[GitHub] rhtyd commented on issue #2492: Fix the name of the column used to hold IPv4 range in 'vlan' table.

2018-03-15 Thread GitBox
rhtyd commented on issue #2492: Fix the name of the column used to hold IPv4 range in 'vlan' table. URL: https://github.com/apache/cloudstack/pull/2492#issuecomment-373585492 Can you check the build failures @rafaelweingartner?

[GitHub] rhtyd closed pull request #2491: Fix "agent-lb" project

2018-03-15 Thread GitBox
rhtyd closed pull request #2491: Fix "agent-lb" project URL: https://github.com/apache/cloudstack/pull/2491 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[cloudstack] branch master updated: CLOUDSTACK-10132: Fix POM of "agent-lb" project (#2491)

2018-03-15 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 8a3943b CLOUDSTACK-10132: Fix POM of "agent-

[GitHub] rhtyd commented on issue #2491: Fix "agent-lb" project

2018-03-15 Thread GitBox
rhtyd commented on issue #2491: Fix "agent-lb" project URL: https://github.com/apache/cloudstack/pull/2491#issuecomment-373584993 Yes, tests lgtm This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] nvazquez opened a new pull request #2493: CLOUDSTACK-10326: Prevent hosts fall into Maintenance when there are running VMs on it

2018-03-15 Thread GitBox
nvazquez opened a new pull request #2493: CLOUDSTACK-10326: Prevent hosts fall into Maintenance when there are running VMs on it URL: https://github.com/apache/cloudstack/pull/2493 JIRA Ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-10326 This issue was discovered, fixed an

[GitHub] rafaelweingartner commented on issue #2491: Fix "agent-lb" project

2018-03-15 Thread GitBox
rafaelweingartner commented on issue #2491: Fix "agent-lb" project URL: https://github.com/apache/cloudstack/pull/2491#issuecomment-373556333 Are these errors something that we need to take a look into? No code has been changed here.

[GitHub] blueorangutan commented on issue #2491: Fix "agent-lb" project

2018-03-15 Thread GitBox
blueorangutan commented on issue #2491: Fix "agent-lb" project URL: https://github.com/apache/cloudstack/pull/2491#issuecomment-37332 Trillian test result (tid-2379) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 20697 seconds Marvin logs

[GitHub] DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-03-15 Thread GitBox
DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-373545553 @fmaximus @rafaelweingartner @marcaurele @rhtyd @ustcweizhou , can we please have further reviews for this? (or mpre discussion)

[GitHub] blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-03-15 Thread GitBox
blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-373544092 Trillian test result (tid-2377) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 27

[GitHub] blueorangutan commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings

2018-03-15 Thread GitBox
blueorangutan commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings URL: https://github.com/apache/cloudstack/pull/2490#issuecomment-373542688 Trillian test result (tid-2378) Environment: kvm-centos7 (x2), Advanced Networking with Mgm

[GitHub] blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-15 Thread GitBox
blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-373530890 Trillian test result (tid-2374) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 3

[GitHub] khos2ow commented on a change in pull request #2489: PULL_REQUEST_TEMPLATE: Add pull request template

2018-03-15 Thread GitBox
khos2ow commented on a change in pull request #2489: PULL_REQUEST_TEMPLATE: Add pull request template URL: https://github.com/apache/cloudstack/pull/2489#discussion_r174936147 ## File path: PULL_REQUEST_TEMPLATE.md ## @@ -0,0 +1,32 @@ +## Description + + + + + +## Types of

[GitHub] rafaelweingartner commented on a change in pull request #2489: PULL_REQUEST_TEMPLATE: Add pull request template

2018-03-15 Thread GitBox
rafaelweingartner commented on a change in pull request #2489: PULL_REQUEST_TEMPLATE: Add pull request template URL: https://github.com/apache/cloudstack/pull/2489#discussion_r174935589 ## File path: PULL_REQUEST_TEMPLATE.md ## @@ -0,0 +1,32 @@ +## Description + + + + + +#

[GitHub] khos2ow commented on a change in pull request #2489: PULL_REQUEST_TEMPLATE: Add pull request template

2018-03-15 Thread GitBox
khos2ow commented on a change in pull request #2489: PULL_REQUEST_TEMPLATE: Add pull request template URL: https://github.com/apache/cloudstack/pull/2489#discussion_r174935002 ## File path: PULL_REQUEST_TEMPLATE.md ## @@ -0,0 +1,32 @@ +## Description + + + + + +## Types of

[GitHub] khos2ow commented on a change in pull request #2489: PULL_REQUEST_TEMPLATE: Add pull request template

2018-03-15 Thread GitBox
khos2ow commented on a change in pull request #2489: PULL_REQUEST_TEMPLATE: Add pull request template URL: https://github.com/apache/cloudstack/pull/2489#discussion_r174934081 ## File path: PULL_REQUEST_TEMPLATE.md ## @@ -0,0 +1,32 @@ +## Description + + + + + +## Types of

[GitHub] rafaelweingartner opened a new pull request #2492: Fix the name of the column used to hold IPv4 range in 'vlan' table.

2018-03-15 Thread GitBox
rafaelweingartner opened a new pull request #2492: Fix the name of the column used to hold IPv4 range in 'vlan' table. URL: https://github.com/apache/cloudstack/pull/2492 The title says everything... This is an automated mess

[GitHub] blueorangutan commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

2018-03-15 Thread GitBox
blueorangutan commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/2387#issuecomment-373480133 Trillian test result (tid-2373) Environment: kvm-centos7 (x2), Advanced Networking with Mg

[GitHub] rhtyd commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

2018-03-15 Thread GitBox
rhtyd commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-373457537 No @DaanHoogland it's the trigger that is sometimes caused by github that kicks these pkging jobs post merge. -

[GitHub] blueorangutan commented on issue #2491: Fix "agent-lb" project

2018-03-15 Thread GitBox
blueorangutan commented on issue #2491: Fix "agent-lb" project URL: https://github.com/apache/cloudstack/pull/2491#issuecomment-373456949 Packaging result: ✔centos6 ✔centos7 ✖debian. JID-1784 This is an automated message from

[GitHub] rhtyd commented on issue #2491: Fix "agent-lb" project

2018-03-15 Thread GitBox
rhtyd commented on issue #2491: Fix "agent-lb" project URL: https://github.com/apache/cloudstack/pull/2491#issuecomment-373457093 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the

[GitHub] blueorangutan commented on issue #2491: Fix "agent-lb" project

2018-03-15 Thread GitBox
blueorangutan commented on issue #2491: Fix "agent-lb" project URL: https://github.com/apache/cloudstack/pull/2491#issuecomment-373457173 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -

[GitHub] blueorangutan commented on issue #2491: Fix "agent-lb" project

2018-03-15 Thread GitBox
blueorangutan commented on issue #2491: Fix "agent-lb" project URL: https://github.com/apache/cloudstack/pull/2491#issuecomment-373444789 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] rhtyd commented on issue #2491: Fix "agent-lb" project

2018-03-15 Thread GitBox
rhtyd commented on issue #2491: Fix "agent-lb" project URL: https://github.com/apache/cloudstack/pull/2491#issuecomment-37348 @blueorangutan package This is an automated message from the Apache Git Service. To respond to

[GitHub] rafaelweingartner commented on issue #2491: Fix "agent-lb" project

2018-03-15 Thread GitBox
rafaelweingartner commented on issue #2491: Fix "agent-lb" project URL: https://github.com/apache/cloudstack/pull/2491#issuecomment-373428991 As soon as travis and Jenkins are green, do we need the integration tests before merging? --

[GitHub] rafaelweingartner commented on issue #2491: Fix "agent-lb" project

2018-03-15 Thread GitBox
rafaelweingartner commented on issue #2491: Fix "agent-lb" project URL: https://github.com/apache/cloudstack/pull/2491#issuecomment-373428991 As soon as travis and Jenkins are green, do we need the integration tests? This is a

[GitHub] nvazquez commented on issue #2489: PULL_REQUEST_TEMPLATE: Add pull request template

2018-03-15 Thread GitBox
nvazquez commented on issue #2489: PULL_REQUEST_TEMPLATE: Add pull request template URL: https://github.com/apache/cloudstack/pull/2489#issuecomment-373425421 Sorry, thought packaging too. Then LGTM as it is This is an automa

[GitHub] rhtyd commented on issue #2489: PULL_REQUEST_TEMPLATE: Add pull request template

2018-03-15 Thread GitBox
rhtyd commented on issue #2489: PULL_REQUEST_TEMPLATE: Add pull request template URL: https://github.com/apache/cloudstack/pull/2489#issuecomment-373422909 Thanks Nicolas, bo pkg can be requested by anyone on apache/cloudstack repo. But only authorized users can run tests. ---

[cloudstack-www] 01/01: Merge branch 'master' into asf-site

2018-03-15 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git commit b2bcb1ad50cdc7d5001e39bf5d33de8ab25c4e11 Merge: 839004f ca509de Author: Daan Hoogland AuthorDate: Thu Mar 15 15:

[cloudstack-www] branch asf-site updated (839004f -> b2bcb1a)

2018-03-15 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git. from 839004f publish site add fd2ec87 Change mailing list search mechanism in CloudStack's web site ad

[cloudstack-www] branch master updated: updated #43 to include compiled content for changes mailist archives

2018-03-15 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git The following commit(s) were added to refs/heads/master by this push: new ca509de updated #43 to include compiled c

[GitHub] nvazquez commented on issue #2408: CLOUDSTACK-10231: Asserted fixes for Direct Download on KVM

2018-03-15 Thread GitBox
nvazquez commented on issue #2408: CLOUDSTACK-10231: Asserted fixes for Direct Download on KVM URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-373400478 @rhtyd done This is an automated message from the Apach

[GitHub] nvazquez commented on issue #2408: asserted fixes for direct downloads

2018-03-15 Thread GitBox
nvazquez commented on issue #2408: asserted fixes for direct downloads URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-373393680 @rhtyd let me squash the entire PR to single Jira ID This is an automated messag

[GitHub] rafaelweingartner commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

2018-03-15 Thread GitBox
rafaelweingartner commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-373391397 Yes. However, that is a consequence of the last merge and is fixed with: #2491 --

[cloudstack-www] 01/01: Merge pull request #43 from rafaelweingartner/mailSearch

2018-03-15 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git commit 5fe416dea2fe2f28db0b4aa20b0ee8feb66dda91 Merge: 09353fb fd2ec87 Author: dahn AuthorDate: Thu Mar 15 14:18:45 2018

[cloudstack-www] branch master updated (09353fb -> 5fe416d)

2018-03-15 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git. from 09353fb s/Berlin/Frankfurt add fd2ec87 Change mailing list search mechanism in CloudStack's web site

[GitHub] DaanHoogland commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

2018-03-15 Thread GitBox
DaanHoogland commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-373391096 debian packaging failed and so did jenkins and travis!

[GitHub] blueorangutan commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings

2018-03-15 Thread GitBox
blueorangutan commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings URL: https://github.com/apache/cloudstack/pull/2490#issuecomment-373390998 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run

[GitHub] DaanHoogland commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings

2018-03-15 Thread GitBox
DaanHoogland commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings URL: https://github.com/apache/cloudstack/pull/2490#issuecomment-373390726 @blueorangutan test This is a

[GitHub] blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-03-15 Thread GitBox
blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-373390643 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-03-15 Thread GitBox
DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-373390590 @blueorangutan test This is an automated message from the Apach

[GitHub] rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-03-15 Thread GitBox
rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-373380723 I believe so, but we still need to find a better way technical and protocol to better manage data model changes in the data

[GitHub] blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-03-15 Thread GitBox
blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-373380619 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1783 This is

[GitHub] blueorangutan commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings

2018-03-15 Thread GitBox
blueorangutan commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings URL: https://github.com/apache/cloudstack/pull/2490#issuecomment-373379532 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1782 ---

[GitHub] ernjvr commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-03-15 Thread GitBox
ernjvr commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-373373896 @DaanHoogland no further comments or objections from anyone. Can the request be merged? --

[GitHub] borisstoyanov commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

2018-03-15 Thread GitBox
borisstoyanov commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-373371916 @blueorangutan test This is an automa

[GitHub] blueorangutan commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

2018-03-15 Thread GitBox
blueorangutan commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-373371964 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke t

[GitHub] DaanHoogland commented on issue #2491: Fix POM of "agent-lb" project

2018-03-15 Thread GitBox
DaanHoogland commented on issue #2491: Fix POM of "agent-lb" project URL: https://github.com/apache/cloudstack/pull/2491#issuecomment-373368975 sounds like a bug in the git-merge-fwd script, @rafaelweingartner . will have a look -

[GitHub] rafaelweingartner opened a new pull request #2491: Fix POM of "agent-lb" project

2018-03-15 Thread GitBox
rafaelweingartner opened a new pull request #2491: Fix POM of "agent-lb" project URL: https://github.com/apache/cloudstack/pull/2491 @DaanHoogland, @rhtyd, and @nvazquez can you take a look here? When PR #2469 got merged forward, the parent pom version was not updated. --

[GitHub] blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-03-15 Thread GitBox
blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-373366996 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] DaanHoogland commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings

2018-03-15 Thread GitBox
DaanHoogland commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings URL: https://github.com/apache/cloudstack/pull/2490#issuecomment-373364042 looks fine @ernjvr let's give it a test sauce @blueorangutan package --

[GitHub] DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-03-15 Thread GitBox
DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-373366839 Discussion seems to go stale, are we now done with all comments @ernjvr ? @blueorangutan package

[GitHub] DaanHoogland commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

2018-03-15 Thread GitBox
DaanHoogland commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-373365586 wow, blueorangutan came back with a stale package result after merge! need more oil in the machine, something got stuc

[GitHub] blueorangutan commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings

2018-03-15 Thread GitBox
blueorangutan commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings URL: https://github.com/apache/cloudstack/pull/2490#issuecomment-373364129 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make

[GitHub] DaanHoogland commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings

2018-03-15 Thread GitBox
DaanHoogland commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings URL: https://github.com/apache/cloudstack/pull/2490#issuecomment-373364042 looks fine @ernjvr let's give it a test souce @blueorangutan package --

[GitHub] ernjvr opened a new pull request #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0.

2018-03-15 Thread GitBox
ernjvr opened a new pull request #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0. URL: https://github.com/apache/cloudstack/pull/2490 Jira ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-10325 Also, add the missing 'VMWare version to OS mappings' SQL in the schema-

[GitHub] blueorangutan commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

2018-03-15 Thread GitBox
blueorangutan commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-373354280 Packaging result: ✔centos6 ✔centos7 ✖debian. JID-1781

[GitHub] blueorangutan commented on issue #2489: PULL_REQUEST_TEMPLATE: Add pull request template

2018-03-15 Thread GitBox
blueorangutan commented on issue #2489: PULL_REQUEST_TEMPLATE: Add pull request template URL: https://github.com/apache/cloudstack/pull/2489#issuecomment-373354279 Packaging result: ✖centos6 ✔centos7 ✖debian. JID-1780 This is

[GitHub] blueorangutan commented on issue #2471: CLOUDSTACK-10311 Agent Log Rotate variable replace bug

2018-03-15 Thread GitBox
blueorangutan commented on issue #2471: CLOUDSTACK-10311 Agent Log Rotate variable replace bug URL: https://github.com/apache/cloudstack/pull/2471#issuecomment-373351125 Packaging result: ✔centos6 ✔centos7 ✖debian. JID-1779 T

[GitHub] blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

2018-03-15 Thread GitBox
blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-373349665 Packaging result: ✔centos6 ✔centos7 ✖debian. JID-1778 ---

[GitHub] rhtyd commented on issue #2408: asserted fixes for direct downloads

2018-03-15 Thread GitBox
rhtyd commented on issue #2408: asserted fixes for direct downloads URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-373348685 @nvazquez can you squash commits based on JIRA id or you would like to squash the entire PR by a single JIRA id? @DaanHoogland I can merge based

[GitHub] borisstoyanov commented on issue #2408: asserted fixes for direct downloads

2018-03-15 Thread GitBox
borisstoyanov commented on issue #2408: asserted fixes for direct downloads URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-373348569 yes @DaanHoogland, this has passed testing and it's good for merge, smoketests are showing good results and it has enough LGTMs. -

[GitHub] blueorangutan commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

2018-03-15 Thread GitBox
blueorangutan commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-373348238 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progres

[GitHub] borisstoyanov commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

2018-03-15 Thread GitBox
borisstoyanov commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-373348135 @blueorangutan package This is an aut

[GitHub] rhtyd opened a new pull request #2489: PULL_REQUEST_TEMPLATE: Add pull request template

2018-03-15 Thread GitBox
rhtyd opened a new pull request #2489: PULL_REQUEST_TEMPLATE: Add pull request template URL: https://github.com/apache/cloudstack/pull/2489 This adds a pull request template. That would look like below: ## Description This adds a pull request for future CloudStack PRs.

[GitHub] blueorangutan commented on issue #2489: PULL_REQUEST_TEMPLATE: Add pull request template

2018-03-15 Thread GitBox
blueorangutan commented on issue #2489: PULL_REQUEST_TEMPLATE: Add pull request template URL: https://github.com/apache/cloudstack/pull/2489#issuecomment-373347233 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] DaanHoogland commented on issue #2408: asserted fixes for direct downloads

2018-03-15 Thread GitBox
DaanHoogland commented on issue #2408: asserted fixes for direct downloads URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-373346742 @borisstoyanov @rhtyd ^^? This is an automated message from the Apache G

[GitHub] DaanHoogland commented on issue #2408: asserted fixes for direct downloads

2018-03-15 Thread GitBox
DaanHoogland commented on issue #2408: asserted fixes for direct downloads URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-373345906 though I only had minimum involvement I hesitate to merge myself. Can we merge? --

[cloudstack] branch master updated (1708838 -> 8ef1317)

2018-03-15 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 1708838 CLOUDSTACK-10268: Fix and enhance package script (#2433) add 19d6578 CLOUDSTACK-10303 : Refactor te

[cloudstack] 01/01: Merge branch '4.11'

2018-03-15 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 8ef131745a5ef0e5e6ddc7e498f3a0208f1bfb71 Merge: 1708838 30175d6 Author: Rohit Yadav AuthorDate: Thu Mar 15 16:46:50 2

[GitHub] rhtyd commented on issue #2471: CLOUDSTACK-10311 Agent Log Rotate variable replace bug

2018-03-15 Thread GitBox
rhtyd commented on issue #2471: CLOUDSTACK-10311 Agent Log Rotate variable replace bug URL: https://github.com/apache/cloudstack/pull/2471#issuecomment-373339530 Can you check the build failures @Slair1 ? (See travis for details, or confirm you're able to build without failures?). @

[GitHub] blueorangutan commented on issue #2471: CLOUDSTACK-10311 Agent Log Rotate variable replace bug

2018-03-15 Thread GitBox
blueorangutan commented on issue #2471: CLOUDSTACK-10311 Agent Log Rotate variable replace bug URL: https://github.com/apache/cloudstack/pull/2471#issuecomment-373339568 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[cloudstack] branch 4.11 updated: CLOUDSTACK-10132: Extend support for management servers LB for agents (#2469)

2018-03-15 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.11 by this push: new 30175d6 CLOUDSTACK-10132: Extend support for man

[GitHub] rhtyd closed pull request #2469: CLOUDSTACK-10132: Extend support for management servers LB for agents

2018-03-15 Thread GitBox
rhtyd closed pull request #2469: CLOUDSTACK-10132: Extend support for management servers LB for agents URL: https://github.com/apache/cloudstack/pull/2469 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of proven

[GitHub] rhtyd commented on issue #2469: CLOUDSTACK-10132: Extend support for management servers LB for agents

2018-03-15 Thread GitBox
rhtyd commented on issue #2469: CLOUDSTACK-10132: Extend support for management servers LB for agents URL: https://github.com/apache/cloudstack/pull/2469#issuecomment-373339040 Thanks, merging this based on test results and two LGTMs. ---

[cloudstack] branch 4.11 updated: CLOUDSTACK-10296: Find time different from last timestamp (#2458)

2018-03-15 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.11 by this push: new ab0bce2 CLOUDSTACK-10296: Find time different fr

[GitHub] blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

2018-03-15 Thread GitBox
blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-373338731 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] rhtyd closed pull request #2458: CLOUDSTACK-10296: Find time different from last timestamp

2018-03-15 Thread GitBox
rhtyd closed pull request #2458: CLOUDSTACK-10296: Find time different from last timestamp URL: https://github.com/apache/cloudstack/pull/2458 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[GitHub] rhtyd commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

2018-03-15 Thread GitBox
rhtyd commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-373338575 Merging this based on test results and review LGTMs. This is

[GitHub] rafaelweingartner commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

2018-03-15 Thread GitBox
rafaelweingartner commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-373338067 Did you pushed your changes to your branch in the remote repository? I am checking your branch,

[GitHub] rhtyd opened a new pull request #2488: smaller systemvm images using sparse disks.

2018-03-15 Thread GitBox
rhtyd opened a new pull request #2488: smaller systemvm images using sparse disks. URL: https://github.com/apache/cloudstack/pull/2488 This is from @PaulAngus 's PR https://github.com/apache/cloudstack/pull/2477 towards 4.11. ---

[cloudstack] branch master updated: CLOUDSTACK-10268: Fix and enhance package script (#2433)

2018-03-15 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 1708838 CLOUDSTACK-10268: Fix and enhance pac

[GitHub] DaanHoogland closed pull request #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-15 Thread GitBox
DaanHoogland closed pull request #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] rhtyd closed pull request #2477: Smaller systemvm images using sparse disks.

2018-03-15 Thread GitBox
rhtyd closed pull request #2477: Smaller systemvm images using sparse disks. URL: https://github.com/apache/cloudstack/pull/2477 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] borisstoyanov commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

2018-03-15 Thread GitBox
borisstoyanov commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-373336567 I'm not sure I'm doing this right.. but git says there's nothing to compare.. ![screen shot 2018-0

[GitHub] rafaelweingartner commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

2018-03-15 Thread GitBox
rafaelweingartner commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-373328490 Thanks! You can open a PR against my branch, then I can merge it here.

[GitHub] blueorangutan commented on issue #2438: [CLOUDSTACK-10307] Remove unused things from HostDaoImpl

2018-03-15 Thread GitBox
blueorangutan commented on issue #2438: [CLOUDSTACK-10307] Remove unused things from HostDaoImpl URL: https://github.com/apache/cloudstack/pull/2438#issuecomment-373321568 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --

[GitHub] borisstoyanov commented on issue #2438: [CLOUDSTACK-10307] Remove unused things from HostDaoImpl

2018-03-15 Thread GitBox
borisstoyanov commented on issue #2438: [CLOUDSTACK-10307] Remove unused things from HostDaoImpl URL: https://github.com/apache/cloudstack/pull/2438#issuecomment-373321486 @blueorangutan test This is an automated message fro

[GitHub] rhtyd closed pull request #2487: Dummy test PR

2018-03-15 Thread GitBox
rhtyd closed pull request #2487: Dummy test PR URL: https://github.com/apache/cloudstack/pull/2487 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL abov

[GitHub] rhtyd commented on issue #2487: Dummy test PR

2018-03-15 Thread GitBox
rhtyd commented on issue #2487: Dummy test PR URL: https://github.com/apache/cloudstack/pull/2487#issuecomment-373320930 Closing this PR, confirmed. Any new PR and its discussions end up on commits ML. This is an automated me

[GitHub] rhtyd opened a new pull request #2487: Dummy test PR

2018-03-15 Thread GitBox
rhtyd opened a new pull request #2487: Dummy test PR URL: https://github.com/apache/cloudstack/pull/2487 This is a PR to see if new PRs with any JIRA id will end up commits ML. Also, how projects can work here. This is an aut

[GitHub] borisstoyanov commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

2018-03-15 Thread GitBox
borisstoyanov commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-373318892 @rafaelweingartner I've created a marvin test but I'm not able to push to your repo. How can I contrib