mike-tutkowski commented on a change in pull request #2776: Issue 2774: Changed
the implementation of isVolumeOnManagedStorage(VolumeInfo) to…
URL: https://github.com/apache/cloudstack/pull/2776#discussion_r207108727
##
File path:
engine/storage/datamotion/src/org/apache/cloudstack
mike-tutkowski commented on issue #2761: Add managed storage pool constraints
to MigrateWithVolume API method
URL: https://github.com/apache/cloudstack/pull/2761#issuecomment-409806548
Once we are good with the standard set of tests, I suggest squashing this
work down to one commit before
mike-tutkowski commented on issue #2761: Add managed storage pool constraints
to MigrateWithVolume API method
URL: https://github.com/apache/cloudstack/pull/2761#issuecomment-409806417
The tests have passed:
test_01_storage_migrate_root_and_data_disks
(TestVMMigrationWithStorage.Tes
rafaelweingartner commented on issue #2761: Add managed storage pool
constraints to MigrateWithVolume API method
URL: https://github.com/apache/cloudstack/pull/2761#issuecomment-409769607
That is a good suggestion. I will implement it.
--
mike-tutkowski commented on issue #2761: Add managed storage pool constraints
to MigrateWithVolume API method
URL: https://github.com/apache/cloudstack/pull/2761#issuecomment-409767259
I have to let this test suite run and come back to it later. Just an FYI,
though: The test that failed be
mike-tutkowski commented on issue #2761: Add managed storage pool constraints
to MigrateWithVolume API method
URL: https://github.com/apache/cloudstack/pull/2761#issuecomment-409761409
No problem. :) I think we are almost there now. I'm going to re-run my tests
in a moment.
--
rafaelweingartner commented on issue #2761: Add managed storage pool
constraints to MigrateWithVolume API method
URL: https://github.com/apache/cloudstack/pull/2761#issuecomment-409761288
Ah yeas, you are right. A terrible miss on my side. I am sorry.
--
mike-tutkowski commented on issue #2761: Add managed storage pool constraints
to MigrateWithVolume API method
URL: https://github.com/apache/cloudstack/pull/2761#issuecomment-409761023
That's not the problem. The issue is iterating over
volumeToStoragePoolObjectMap instead of allVolumes.
rafaelweingartner commented on issue #2761: Add managed storage pool
constraints to MigrateWithVolume API method
URL: https://github.com/apache/cloudstack/pull/2761#issuecomment-409760596
@mike-tutkowski why didn't it work? I checked ant the volume class
implements the hashcode and equals
mike-tutkowski commented on issue #2761: Add managed storage pool constraints
to MigrateWithVolume API method
URL: https://github.com/apache/cloudstack/pull/2761#issuecomment-409757636
This method doesn't work (example: assume volumeToStoragePoolObjectMap comes
in empty):
privat
mike-tutkowski commented on issue #2761: Add managed storage pool constraints
to MigrateWithVolume API method
URL: https://github.com/apache/cloudstack/pull/2761#issuecomment-409712517
@rafaelweingartner This looks good. Let me set up a cloud using this code
and run the test that originall
rafaelweingartner commented on issue #2761: Add managed storage pool
constraints to MigrateWithVolume API method
URL: https://github.com/apache/cloudstack/pull/2761#issuecomment-409683757
Got it! I just changed a bit to avoid those nested IF/ELSE{IF}.
What do you think of the last commit
mike-tutkowski commented on issue #2761: Add managed storage pool constraints
to MigrateWithVolume API method
URL: https://github.com/apache/cloudstack/pull/2761#issuecomment-409676248
You are really close now, @rafaelweingartner. It looks like you missed the
suggestions at the bottom of m
rafaelweingartner commented on issue #2773: CLOUDSTACK-10328: Add Secondary
IPv6 address through API
URL: https://github.com/apache/cloudstack/pull/2773#issuecomment-409664131
@GabrielBrascher is this only to KVM?
This is an
rafaelweingartner commented on a change in pull request #2776: Issue 2774:
Changed the implementation of isVolumeOnManagedStorage(VolumeInfo) to…
URL: https://github.com/apache/cloudstack/pull/2776#discussion_r206971372
##
File path:
engine/storage/datamotion/src/org/apache/cloudst
DaanHoogland commented on a change in pull request #2776: Issue 2774: Changed
the implementation of isVolumeOnManagedStorage(VolumeInfo) to…
URL: https://github.com/apache/cloudstack/pull/2776#discussion_r206955494
##
File path:
engine/storage/datamotion/src/org/apache/cloudstack/s
ernjvr opened a new pull request #2782: add ipaddress input field to 'Add
network to VM' form
URL: https://github.com/apache/cloudstack/pull/2782
## Description
On the 'NICs' tab, when a user clicks the 'Add network to VM' button to add
a network to a VM, the 'Add network to VM' pop
rafaelweingartner commented on a change in pull request #2773:
CLOUDSTACK-10328: Add Secondary IPv6 address through API
URL: https://github.com/apache/cloudstack/pull/2773#discussion_r206869534
##
File path: server/src/main/java/com/cloud/api/query/dao/UserVmJoinDaoImpl.java
##
rafaelweingartner commented on a change in pull request #2773:
CLOUDSTACK-10328: Add Secondary IPv6 address through API
URL: https://github.com/apache/cloudstack/pull/2773#discussion_r206869423
##
File path: server/src/main/java/com/cloud/api/ApiResponseHelper.java
##
@@ -
rafaelweingartner commented on a change in pull request #2773:
CLOUDSTACK-10328: Add Secondary IPv6 address through API
URL: https://github.com/apache/cloudstack/pull/2773#discussion_r206870388
##
File path: server/src/main/java/com/cloud/network/Ipv6AddressManagerImpl.java
###
rafaelweingartner commented on a change in pull request #2773:
CLOUDSTACK-10328: Add Secondary IPv6 address through API
URL: https://github.com/apache/cloudstack/pull/2773#discussion_r206868794
##
File path:
api/src/main/java/org/apache/cloudstack/api/command/user/vm/AddIpToVmNicCm
rafaelweingartner commented on a change in pull request #2773:
CLOUDSTACK-10328: Add Secondary IPv6 address through API
URL: https://github.com/apache/cloudstack/pull/2773#discussion_r206869611
##
File path: server/src/main/java/com/cloud/api/query/dao/UserVmJoinDaoImpl.java
##
rafaelweingartner commented on issue #2761: Add managed storage pool
constraints to MigrateWithVolume API method
URL: https://github.com/apache/cloudstack/pull/2761#issuecomment-409556819
@Mike, I think I understood you and your suggestion
https://github.com/mike-tutkowski/cloudstack/commi
GabrielBrascher commented on issue #2773: CLOUDSTACK-10328: Add Secondary IPv6
address through API
URL: https://github.com/apache/cloudstack/pull/2773#issuecomment-409553727
@borisstoyanov @rafaelweingartner I updated the code enhancing documentation
and unit tests.
@borisstoyanov t
wido commented on issue #2779: Changed to use ifcfg library for cross
compatibility of OS /version
URL: https://github.com/apache/cloudstack/pull/2779#issuecomment-409551742
Thanks @bennysp ! Yes, you can update this one.
Awesome!
rafaelweingartner commented on a change in pull request #2776: Issue 2774:
Changed the implementation of isVolumeOnManagedStorage(VolumeInfo) to…
URL: https://github.com/apache/cloudstack/pull/2776#discussion_r206849541
##
File path:
engine/storage/datamotion/src/org/apache/cloudst
borisstoyanov commented on issue #2779: Changed to use ifcfg library for cross
compatibility of OS /version
URL: https://github.com/apache/cloudstack/pull/2779#issuecomment-409543864
@bennysp I would prefer if we close this and do a separate one, thanks.
---
borisstoyanov commented on issue #2779: Changed to use ifcfg library for cross
compatibility of OS /version
URL: https://github.com/apache/cloudstack/pull/2779#issuecomment-409543502
thanks @bennysp, don't get me wrong, but the reason I'm -1 on adding a new
dependency is because I'm alread
bennysp commented on issue #2779: Changed to use ifcfg library for cross
compatibility of OS /version
URL: https://github.com/apache/cloudstack/pull/2779#issuecomment-409543258
Will do guys! Give me a few. Should I update this PR when ready or create
new?
wido commented on issue #2779: Changed to use ifcfg library for cross
compatibility of OS /version
URL: https://github.com/apache/cloudstack/pull/2779#issuecomment-409542371
I would recommend using "ip"
It has a stable interface when using the "-o" flag.
bennysp commented on issue #2779: Changed to use ifcfg library for cross
compatibility of OS /version
URL: https://github.com/apache/cloudstack/pull/2779#issuecomment-409541592
Sure thing. I can look at that. I was avoiding “reinvent the wheel”, but I
understand the importance of non-depen
rhtyd closed issue #2759: configdrive on Vmware fails with invalid ISO path
info - ssvm dir ConfigDrive changed to configdrive
URL: https://github.com/apache/cloudstack/issues/2759
This is an automated message from the Apach
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
commit 75030e5522ba5894b8528f809aa586d28b801f50
Merge: c8a980b 4f49bf6
Author: Rohit Yadav
AuthorDate: Wed Aug 1 16:37:21 20
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.
from c8a980b Merge branch '4.11'
add 717 vmware: Fixes #2759 config drive iso path for Vmware (#2769)
a
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.11 by this push:
new 4f49bf6 ui: hide hvm tickbox for vmware, otherwi
rhtyd closed pull request #2781: hvm checkbox visibility
URL: https://github.com/apache/cloudstack/pull/2781
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from
borisstoyanov commented on issue #2779: Changed to use ifcfg library for cross
compatibility of OS /version
URL: https://github.com/apache/cloudstack/pull/2779#issuecomment-409535887
Thanks @bennysp, so why don't we refactor the code to use 'ip' instead of
introducing another 3rd party dep
bennysp edited a comment on issue #2779: Changed to use ifcfg library for cross
compatibility of OS /version
URL: https://github.com/apache/cloudstack/pull/2779#issuecomment-409530661
@borisstoyanov the “old way” doesn’t actually parse correctly because of
“ifconfig” format changes happeni
bennysp commented on issue #2779: Changed to use ifcfg library for cross
compatibility of OS /version
URL: https://github.com/apache/cloudstack/pull/2779#issuecomment-409530661
@borisstoyanov the “old way” doesn’t actually parse correctly because of
“ifconfig” format changes happening. So,
bennysp commented on issue #2779: Changed to use ifcfg library for cross
compatibility of OS /version
URL: https://github.com/apache/cloudstack/pull/2779#issuecomment-409527757
@rhtyd I have not tested on Ubuntu.
This is an
bennysp commented on issue #2779: Changed to use ifcfg library for cross
compatibility of OS /version
URL: https://github.com/apache/cloudstack/pull/2779#issuecomment-409527503
@wido from a compiled install, you do ‘pip install ifcfg’. With that said,
this can also be built and the source
DaanHoogland commented on a change in pull request #2776: Issue 2774: Changed
the implementation of isVolumeOnManagedStorage(VolumeInfo) to…
URL: https://github.com/apache/cloudstack/pull/2776#discussion_r206788610
##
File path:
engine/storage/datamotion/src/org/apache/cloudstack/s
blueorangutan commented on issue #2781: hvm checkbox visibility
URL: https://github.com/apache/cloudstack/pull/2781#issuecomment-409483497
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2220
This is an automated message from
blueorangutan commented on issue #2781: hvm checkbox visibility
URL: https://github.com/apache/cloudstack/pull/2781#issuecomment-409475381
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep
you posted as I make progress.
--
borisstoyanov commented on issue #2781: hvm checkbox visibility
URL: https://github.com/apache/cloudstack/pull/2781#issuecomment-409475118
@blueorangutan package
This is an automated message from the Apache Git Service.
To res
45 matches
Mail list logo
