[GitHub] izenk edited a comment on issue #2862: VR stop/start/reboot commands failed

2018-10-16 Thread GitBox
izenk edited a comment on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430510257 @rhtyd KVM with bridge based networking Advanced Zone without security groups During "Start" VR stucks in "Starting" state. If I

[GitHub] izenk edited a comment on issue #2862: VR stop/start/reboot commands failed

2018-10-16 Thread GitBox
izenk edited a comment on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430510257 @rhtyd KVM with bridge based networking Advanced Zone without security groups VPC restart with "Clean up" option does the job

[GitHub] izenk commented on issue #2862: VR stop/start/reboot commands failed

2018-10-16 Thread GitBox
izenk commented on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430510257 @rhtyd KVM with bridge based networking Advanced Zone without security groups

[GitHub] rhtyd commented on issue #2862: VR stop/start/reboot commands failed

2018-10-16 Thread GitBox
rhtyd commented on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430487545 @izenk can you describe your KVM setup, are you using bridge based networking or openvswitch with vlan/vxlan/etc, is it normal adv zone (or with

[GitHub] rhtyd closed pull request #2904: agent: Fixes #2899 on shutdown don't allow server reconnection

2018-10-16 Thread GitBox
rhtyd closed pull request #2904: agent: Fixes #2899 on shutdown don't allow server reconnection URL: https://github.com/apache/cloudstack/pull/2904 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[cloudstack] branch 4.11 updated: agent: on shutdown don't allow server reconnection (#2904)

2018-10-16 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.11 by this push: new 1904a70 agent: on shutdown don't allow server re

[GitHub] blueorangutan commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes

2018-10-16 Thread GitBox
blueorangutan commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes URL: https://github.com/apache/cloudstack/pull/1448#issuecomment-430451894 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] nvazquez commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes

2018-10-16 Thread GitBox
nvazquez commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes URL: https://github.com/apache/cloudstack/pull/1448#issuecomment-430451746 @blueorangutan test This is an automated message from the Apache Git Servic

[GitHub] nvazquez commented on a change in pull request #1448: CLOUDSTACK-9315: Removed unused Classes

2018-10-16 Thread GitBox
nvazquez commented on a change in pull request #1448: CLOUDSTACK-9315: Removed unused Classes URL: https://github.com/apache/cloudstack/pull/1448#discussion_r225752364 ## File path: server/src/main/java/com/cloud/configuration/Config.java ## @@ -1836,9 +1836,9 @@

[GitHub] blueorangutan commented on issue #2869: Fix some Marvin smoke tests

2018-10-16 Thread GitBox
blueorangutan commented on issue #2869: Fix some Marvin smoke tests URL: https://github.com/apache/cloudstack/pull/2869#issuecomment-430417607 Trillian test result (tid-3080) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32549 seconds Marvin

[GitHub] blueorangutan commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes

2018-10-16 Thread GitBox
blueorangutan commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes URL: https://github.com/apache/cloudstack/pull/1448#issuecomment-430366765 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2351 This is an autom

[GitHub] blueorangutan commented on issue #2904: agent: Fixes #2899 on shutdown don't allow server reconnection

2018-10-16 Thread GitBox
blueorangutan commented on issue #2904: agent: Fixes #2899 on shutdown don't allow server reconnection URL: https://github.com/apache/cloudstack/pull/2904#issuecomment-430362361 Trillian test result (tid-3077) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total

[cloudstack] branch master updated: Allow enable the Java remote Debug for CloudStack Agent (#2897)

2018-10-16 Thread rafael
This is an automated email from the ASF dual-hosted git repository. rafael pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 143fe53 Allow enable the Java remote Debug

[GitHub] rafaelweingartner closed pull request #2897: Allow enable the Java remote Debug for CloudStack Agent

2018-10-16 Thread GitBox
rafaelweingartner closed pull request #2897: Allow enable the Java remote Debug for CloudStack Agent URL: https://github.com/apache/cloudstack/pull/2897 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenan

[GitHub] rafaelweingartner commented on issue #2897: Allow enable the Java remote Debug for CloudStack Agent

2018-10-16 Thread GitBox
rafaelweingartner commented on issue #2897: Allow enable the Java remote Debug for CloudStack Agent URL: https://github.com/apache/cloudstack/pull/2897#issuecomment-430356879 The errors do not seem do be related to changes introduced here. --

[GitHub] blueorangutan commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes

2018-10-16 Thread GitBox
blueorangutan commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes URL: https://github.com/apache/cloudstack/pull/1448#issuecomment-430354518 @rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] rafaelweingartner commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes

2018-10-16 Thread GitBox
rafaelweingartner commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes URL: https://github.com/apache/cloudstack/pull/1448#issuecomment-430354007 @blueorangutan package @rhtyd I took the liberty of getting this PR and fixing the conflicts. There were quite a few unused

[GitHub] blueorangutan commented on issue #2897: Allow enable the Java remote Debug for CloudStack Agent

2018-10-16 Thread GitBox
blueorangutan commented on issue #2897: Allow enable the Java remote Debug for CloudStack Agent URL: https://github.com/apache/cloudstack/pull/2897#issuecomment-430334710 Trillian test result (tid-3078) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time t

[GitHub] rhtyd commented on issue #2900: network: Allow ability to disable rolling restart feature

2018-10-16 Thread GitBox
rhtyd commented on issue #2900: network: Allow ability to disable rolling restart feature URL: https://github.com/apache/cloudstack/pull/2900#issuecomment-430315358 Ping @resmo can you review and/or test? This is an automate

[GitHub] blueorangutan commented on issue #2900: network: Allow ability to disable rolling restart feature

2018-10-16 Thread GitBox
blueorangutan commented on issue #2900: network: Allow ability to disable rolling restart feature URL: https://github.com/apache/cloudstack/pull/2900#issuecomment-430307173 Trillian test result (tid-3075) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] rafaelweingartner commented on issue #2658: improve KVM hosts reset (by not rebooting in script)

2018-10-16 Thread GitBox
rafaelweingartner commented on issue #2658: improve KVM hosts reset (by not rebooting in script) URL: https://github.com/apache/cloudstack/pull/2658#issuecomment-430238604 @melnik13 is this PR still valid? This is an automate

[cloudstack] branch master updated (58b4e71 -> 92f8cda)

2018-10-16 Thread rafael
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 58b4e71 params: allow signatureversion and expires without logging add 9003c7b Add checksum sanity validat

[cloudstack] 01/01: Merge forward #2902 (Add checksum sanity validation on template registration)

2018-10-16 Thread rafael
This is an automated email from the ASF dual-hosted git repository. rafael pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 92f8cda64a65d85911a2850b6e7061aaa2505017 Merge: 58b4e71 9003c7b Author: Rafael Weingärtner AuthorDate: Tue Oct 16 10

[cloudstack] branch 4.11 updated: Add checksum sanity validation on template registration (#2902)

2018-10-16 Thread rafael
This is an automated email from the ASF dual-hosted git repository. rafael pushed a commit to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.11 by this push: new 9003c7b Add checksum sanity validation on templ

[GitHub] rafaelweingartner closed pull request #2902: Add checksum sanity validation on template registration

2018-10-16 Thread GitBox
rafaelweingartner closed pull request #2902: Add checksum sanity validation on template registration URL: https://github.com/apache/cloudstack/pull/2902 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenan

[GitHub] blueorangutan commented on issue #2902: Add checksum sanity validation on template registration

2018-10-16 Thread GitBox
blueorangutan commented on issue #2902: Add checksum sanity validation on template registration URL: https://github.com/apache/cloudstack/pull/2902#issuecomment-430230506 Trillian test result (tid-3076) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time t

[GitHub] rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers

2018-10-16 Thread GitBox
rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225526172 ## File path: engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41120to41200.java ##

[GitHub] marcaurele commented on a change in pull request #2578: api: add command to list management servers

2018-10-16 Thread GitBox
marcaurele commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225525504 ## File path: engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41120to41200.java ## @@ -52

[GitHub] rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers

2018-10-16 Thread GitBox
rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225524176 ## File path: engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41120to41200.java ##

[GitHub] rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers

2018-10-16 Thread GitBox
rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225523928 ## File path: engine/schema/src/main/resources/META-INF/db/schema-41120to41200.sql ## @@ -34

[GitHub] marcaurele commented on a change in pull request #2578: api: add command to list management servers

2018-10-16 Thread GitBox
marcaurele commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225522696 ## File path: engine/schema/src/main/resources/META-INF/db/schema-41120to41200.sql ## @@ -34,4 +34,

[GitHub] blueorangutan commented on issue #2869: Fix some Marvin smoke tests

2018-10-16 Thread GitBox
blueorangutan commented on issue #2869: Fix some Marvin smoke tests URL: https://github.com/apache/cloudstack/pull/2869#issuecomment-430216705 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] borisstoyanov commented on issue #2869: Fix some Marvin smoke tests

2018-10-16 Thread GitBox
borisstoyanov commented on issue #2869: Fix some Marvin smoke tests URL: https://github.com/apache/cloudstack/pull/2869#issuecomment-430216626 @blueorangutan test This is an automated message from the Apache Git Service. To re

[GitHub] houthuis opened a new pull request #2793: Destroyvm also removes volumes

2018-10-16 Thread GitBox
houthuis opened a new pull request #2793: Destroyvm also removes volumes URL: https://github.com/apache/cloudstack/pull/2793 ## Description Currently DestroyVMCmd does not have the option to delete any attached volumes (Data Disks), resulting in unused orphan volumes sitting in Cloud

[GitHub] houthuis closed pull request #2793: Destroyvm also removes volumes

2018-10-16 Thread GitBox
houthuis closed pull request #2793: Destroyvm also removes volumes URL: https://github.com/apache/cloudstack/pull/2793 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull requ

[GitHub] rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers

2018-10-16 Thread GitBox
rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225502221 ## File path: engine/schema/src/main/resources/META-INF/db/schema-41120to41200.sql ## @@ -34

[GitHub] rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers

2018-10-16 Thread GitBox
rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225501142 ## File path: framework/cluster/src/main/java/com/cloud/cluster/ClusterFenceManagerImpl.java ###

[GitHub] rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers

2018-10-16 Thread GitBox
rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225501260 ## File path: framework/cluster/pom.xml ## @@ -47,8 +47,7 @@ org.apache.cloudst

[GitHub] rhtyd commented on issue #2897: Allow enable the Java remote Debug for CloudStack Agent

2018-10-16 Thread GitBox
rhtyd commented on issue #2897: Allow enable the Java remote Debug for CloudStack Agent URL: https://github.com/apache/cloudstack/pull/2897#issuecomment-430196587 @rafaelweingartner yes there is an issue with the ubuntu docker container, and a case in one of the unit tests that causes NPE.

[GitHub] blueorangutan commented on issue #2869: Fix some Marvin smoke tests

2018-10-16 Thread GitBox
blueorangutan commented on issue #2869: Fix some Marvin smoke tests URL: https://github.com/apache/cloudstack/pull/2869#issuecomment-430190561 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] borisstoyanov commented on issue #2869: Fix some Marvin smoke tests

2018-10-16 Thread GitBox
borisstoyanov commented on issue #2869: Fix some Marvin smoke tests URL: https://github.com/apache/cloudstack/pull/2869#issuecomment-430190361 @blueorangutan test This is an automated message from the Apache Git Service. To re

[GitHub] rafaelweingartner commented on issue #2897: Allow enable the Java remote Debug for CloudStack Agent

2018-10-16 Thread GitBox
rafaelweingartner commented on issue #2897: Allow enable the Java remote Debug for CloudStack Agent URL: https://github.com/apache/cloudstack/pull/2897#issuecomment-430186861 @rhtyd do you know why the debian package is failing with @blueorangutan ?

[GitHub] blueorangutan commented on issue #2869: Fix some Marvin smoke tests

2018-10-16 Thread GitBox
blueorangutan commented on issue #2869: Fix some Marvin smoke tests URL: https://github.com/apache/cloudstack/pull/2869#issuecomment-430186449 Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2350 This is an automated message

[GitHub] blueorangutan commented on issue #2897: Allow enable the Java remote Debug for CloudStack Agent

2018-10-16 Thread GitBox
blueorangutan commented on issue #2897: Allow enable the Java remote Debug for CloudStack Agent URL: https://github.com/apache/cloudstack/pull/2897#issuecomment-430184115 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests ---

[GitHub] rhtyd commented on issue #2897: Allow enable the Java remote Debug for CloudStack Agent

2018-10-16 Thread GitBox
rhtyd commented on issue #2897: Allow enable the Java remote Debug for CloudStack Agent URL: https://github.com/apache/cloudstack/pull/2897#issuecomment-430183952 @blueorangutan test This is an automated message from the Apac

[GitHub] rhtyd commented on issue #2901: params: allow signatureversion and expires without logging

2018-10-16 Thread GitBox
rhtyd commented on issue #2901: params: allow signatureversion and expires without logging URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-430183776 @pyr we've not tested/merged your PR, we need 2 lgtms just for qualifying, we also need testing. Do you still want the PR --

[GitHub] blueorangutan commented on issue #2904: agent: Fixes #2899 on shutdown don't allow server reconnection

2018-10-16 Thread GitBox
blueorangutan commented on issue #2904: agent: Fixes #2899 on shutdown don't allow server reconnection URL: https://github.com/apache/cloudstack/pull/2904#issuecomment-430183292 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] rhtyd commented on issue #2904: agent: Fixes #2899 on shutdown don't allow server reconnection

2018-10-16 Thread GitBox
rhtyd commented on issue #2904: agent: Fixes #2899 on shutdown don't allow server reconnection URL: https://github.com/apache/cloudstack/pull/2904#issuecomment-430183043 @blueorangutan test This is an automated message from t

[GitHub] rhtyd commented on issue #2862: VR stop/start/reboot commands failed

2018-10-16 Thread GitBox
rhtyd commented on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430183001 Thanks @izenk let me have a look This is an automated message from the Apache Gi

[GitHub] blueorangutan commented on issue #2869: Fix some Marvin smoke tests

2018-10-16 Thread GitBox
blueorangutan commented on issue #2869: Fix some Marvin smoke tests URL: https://github.com/apache/cloudstack/pull/2869#issuecomment-430178246 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] borisstoyanov commented on issue #2869: Fix some Marvin smoke tests

2018-10-16 Thread GitBox
borisstoyanov commented on issue #2869: Fix some Marvin smoke tests URL: https://github.com/apache/cloudstack/pull/2869#issuecomment-430177998 @blueorangutan package This is an automated message from the Apache Git Service. To

[GitHub] blueorangutan commented on issue #2904: agent: Fixes #2899 on shutdown don't allow server reconnection

2018-10-16 Thread GitBox
blueorangutan commented on issue #2904: agent: Fixes #2899 on shutdown don't allow server reconnection URL: https://github.com/apache/cloudstack/pull/2904#issuecomment-430177081 Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2349 --

[GitHub] izenk edited a comment on issue #2862: VR stop/start/reboot commands failed

2018-10-16 Thread GitBox
izenk edited a comment on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430168946 @rhtyd I reproduced the problem. Management log: ~~~ 2018-10-16 11:23:19,102 ERROR [c.c.n.r.VirtualNetworkApplianceManagerImpl

[GitHub] izenk edited a comment on issue #2862: VR stop/start/reboot commands failed

2018-10-16 Thread GitBox
izenk edited a comment on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430168946 @rhtyd I reproduced the problem. Management log: ~~~ 2018-10-16 11:23:19,102 ERROR [c.c.n.r.VirtualNetworkApplianceManagerImpl

[GitHub] izenk commented on issue #2862: VR stop/start/reboot commands failed

2018-10-16 Thread GitBox
izenk commented on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430168946 @rhtyd I reproduced the problem. Management log: ~~~ 2018-10-16 11:23:19,102 ERROR [c.c.n.r.VirtualNetworkApplianceManagerImpl] (Wor

[GitHub] blueorangutan commented on issue #2904: agent: Fixes #2899 on shutdown don't allow server reconnection

2018-10-16 Thread GitBox
blueorangutan commented on issue #2904: agent: Fixes #2899 on shutdown don't allow server reconnection URL: https://github.com/apache/cloudstack/pull/2904#issuecomment-430167981 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] rhtyd commented on issue #2904: agent: Fixes #2899 on shutdown don't allow server reconnection

2018-10-16 Thread GitBox
rhtyd commented on issue #2904: agent: Fixes #2899 on shutdown don't allow server reconnection URL: https://github.com/apache/cloudstack/pull/2904#issuecomment-430167689 @blueorangutan package This is an automated message fro

[GitHub] rhtyd opened a new pull request #2904: agent: Fixes #2899 on shutdown don't allow server reconnection

2018-10-16 Thread GitBox
rhtyd opened a new pull request #2904: agent: Fixes #2899 on shutdown don't allow server reconnection URL: https://github.com/apache/cloudstack/pull/2904 When agent is stopped, don't allow reconnection. Previously this would send a shutdown command to the management server which would pu

[GitHub] marcaurele commented on a change in pull request #2578: api: add command to list management servers

2018-10-16 Thread GitBox
marcaurele commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225434271 ## File path: engine/schema/src/main/resources/META-INF/db/schema-41120to41200.sql ## @@ -34,4 +34,

[GitHub] marcaurele commented on a change in pull request #2578: api: add command to list management servers

2018-10-16 Thread GitBox
marcaurele commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225434354 ## File path: engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41120to41200.java ## @@ -52

[GitHub] marcaurele commented on a change in pull request #2578: api: add command to list management servers

2018-10-16 Thread GitBox
marcaurele commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225425562 ## File path: framework/cluster/pom.xml ## @@ -47,8 +47,7 @@ org.apache.cloudstack

[GitHub] marcaurele commented on a change in pull request #2578: api: add command to list management servers

2018-10-16 Thread GitBox
marcaurele commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225425660 ## File path: framework/cluster/src/main/java/com/cloud/cluster/ClusterManagerListener.java ## @@

[GitHub] marcaurele commented on a change in pull request #2578: api: add command to list management servers

2018-10-16 Thread GitBox
marcaurele commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225425620 ## File path: framework/cluster/src/main/java/com/cloud/cluster/ClusterManager.java ## @@ -16,6 +1

[GitHub] marcaurele commented on a change in pull request #2578: api: add command to list management servers

2018-10-16 Thread GitBox
marcaurele commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225425593 ## File path: framework/cluster/src/main/java/com/cloud/cluster/ClusterFenceManagerImpl.java ## @@

[GitHub] pyr closed pull request #2901: params: allow signatureversion and expires without logging

2018-10-16 Thread GitBox
pyr closed pull request #2901: params: allow signatureversion and expires without logging URL: https://github.com/apache/cloudstack/pull/2901 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As thi

[GitHub] pyr commented on issue #2901: params: allow signatureversion and expires without logging

2018-10-16 Thread GitBox
pyr commented on issue #2901: params: allow signatureversion and expires without logging URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-430123937 Thanks for the review! This is an automated message from the

[cloudstack] branch master updated: params: allow signatureversion and expires without logging

2018-10-16 Thread pyr
This is an automated email from the ASF dual-hosted git repository. pyr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 58b4e71 params: allow signatureversion and exp