[GitHub] blueorangutan commented on issue #1499: Remove unused "umount" method in NfsSecondaryStorageResource

2018-12-14 Thread GitBox
blueorangutan commented on issue #1499: Remove unused "umount" method in NfsSecondaryStorageResource URL: https://github.com/apache/cloudstack/pull/1499#issuecomment-447381007 Trillian test result (tid-3256) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total

[GitHub] nathanejohnson opened a new issue #3096: Need to re-add option to disable automatic snapshot backups to secondary

2018-12-14 Thread GitBox
nathanejohnson opened a new issue #3096: Need to re-add option to disable automatic snapshot backups to secondary URL: https://github.com/apache/cloudstack/issues/3096 # ISSUE TYPE * Bug Report # COMPONENT NAME VOLUME / Snapshot ~~~ ~~~ ###

[GitHub] rafaelweingartner edited a comment on issue #2795: kvm: Properly report available memory to Management Server

2018-12-14 Thread GitBox
rafaelweingartner edited a comment on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-447363980 @wido Jenkins is not being able to build this PR. Can this be a dependency problem? ``` [ERROR] Err

[GitHub] rafaelweingartner commented on issue #2795: kvm: Properly report available memory to Management Server

2018-12-14 Thread GitBox
rafaelweingartner commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-447363980 @wido Jenkins is not being able to build this PR. Can this be a dependency problem? ``` [ERROR] Errors:

[GitHub] bwsw commented on issue #3088: VM restart with 'rebootVirtualMachine' causes SGs broken with KVM

2018-12-14 Thread GitBox
bwsw commented on issue #3088: VM restart with 'rebootVirtualMachine' causes SGs broken with KVM URL: https://github.com/apache/cloudstack/issues/3088#issuecomment-447362415 @rhtyd @RPDiep as it is merged to 4.11.3 suppose we can close. -

[GitHub] bwsw closed issue #3088: VM restart with 'rebootVirtualMachine' causes SGs broken with KVM

2018-12-14 Thread GitBox
bwsw closed issue #3088: VM restart with 'rebootVirtualMachine' causes SGs broken with KVM URL: https://github.com/apache/cloudstack/issues/3088 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] nvazquez commented on a change in pull request #3095: Prevent corner case for infinite PrepareForMaintenance

2018-12-14 Thread GitBox
nvazquez commented on a change in pull request #3095: Prevent corner case for infinite PrepareForMaintenance URL: https://github.com/apache/cloudstack/pull/3095#discussion_r241753226 ## File path: server/src/com/cloud/resource/ResourceManagerImpl.java ## @@ -1350,7 +1364,2

[GitHub] nvazquez commented on a change in pull request #3095: Prevent corner case for infinite PrepareForMaintenance

2018-12-14 Thread GitBox
nvazquez commented on a change in pull request #3095: Prevent corner case for infinite PrepareForMaintenance URL: https://github.com/apache/cloudstack/pull/3095#discussion_r241752783 ## File path: server/src/com/cloud/resource/ResourceManagerImpl.java ## @@ -1350,7 +1364,2

[GitHub] rafaelweingartner commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-12-14 Thread GitBox
rafaelweingartner commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#issuecomment-447322978 Well, I indeed checked everything, and everything seems to be already answered/addressed. There was only

[GitHub] rhtyd commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-12-14 Thread GitBox
rhtyd commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#issuecomment-447321463 @rafaelweingartner go to the files changed tab, there are a few minor comments but nothing I cannot live with. -

[GitHub] rafaelweingartner commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-12-14 Thread GitBox
rafaelweingartner commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#issuecomment-447320029 @rhtyd which ones? This is an automated

[GitHub] rhtyd commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-12-14 Thread GitBox
rhtyd commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#issuecomment-447319083 Few of my comments were not addressed or replied to, but I'll live with the changes. @GabrielBrascher @rafaelweingart

[GitHub] DaanHoogland commented on issue #1499: Remove unused "umount" method in NfsSecondaryStorageResource

2018-12-14 Thread GitBox
DaanHoogland commented on issue #1499: Remove unused "umount" method in NfsSecondaryStorageResource URL: https://github.com/apache/cloudstack/pull/1499#issuecomment-447314143 @blueorangutan test This is an automated message

[GitHub] blueorangutan commented on issue #1499: Remove unused "umount" method in NfsSecondaryStorageResource

2018-12-14 Thread GitBox
blueorangutan commented on issue #1499: Remove unused "umount" method in NfsSecondaryStorageResource URL: https://github.com/apache/cloudstack/pull/1499#issuecomment-447314346 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --

[GitHub] rafaelweingartner commented on issue #1499: Remove unused "umount" method in NfsSecondaryStorageResource

2018-12-14 Thread GitBox
rafaelweingartner commented on issue #1499: Remove unused "umount" method in NfsSecondaryStorageResource URL: https://github.com/apache/cloudstack/pull/1499#issuecomment-447310910 @nvazquez can you review and run tests here?

[GitHub] blueorangutan commented on issue #1499: Remove unused "umount" method in NfsSecondaryStorageResource

2018-12-14 Thread GitBox
blueorangutan commented on issue #1499: Remove unused "umount" method in NfsSecondaryStorageResource URL: https://github.com/apache/cloudstack/pull/1499#issuecomment-447310629 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2491 ---

[GitHub] blueorangutan commented on issue #1499: Remove unused "umount" method in NfsSecondaryStorageResource

2018-12-14 Thread GitBox
blueorangutan commented on issue #1499: Remove unused "umount" method in NfsSecondaryStorageResource URL: https://github.com/apache/cloudstack/pull/1499#issuecomment-447306285 @rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] rafaelweingartner commented on issue #1499: Remove unused "umount" method in NfsSecondaryStorageResource

2018-12-14 Thread GitBox
rafaelweingartner commented on issue #1499: Remove unused "umount" method in NfsSecondaryStorageResource URL: https://github.com/apache/cloudstack/pull/1499#issuecomment-447306208 @blueorangutan package This is an automated

[GitHub] wido opened a new pull request #2795: kvm: Properly report available memory to Management Server

2018-12-14 Thread GitBox
wido opened a new pull request #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795 ## Description The KVM Agent had two mechanisms for reporting its capabilities and memory to the Management Server. On startup it

[GitHub] rafaelweingartner commented on issue #2795: kvm: Properly report available memory to Management Server

2018-12-14 Thread GitBox
rafaelweingartner commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-447304801 forcing Jenkins This is an automated message fr

[GitHub] rafaelweingartner closed pull request #2795: kvm: Properly report available memory to Management Server

2018-12-14 Thread GitBox
rafaelweingartner closed pull request #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of prove

[GitHub] rafaelweingartner commented on a change in pull request #2112: Add Datera CloudStack Storage Plugin 4.10.0.0

2018-12-14 Thread GitBox
rafaelweingartner commented on a change in pull request #2112: Add Datera CloudStack Storage Plugin 4.10.0.0 URL: https://github.com/apache/cloudstack/pull/2112#discussion_r170256535 ## File path: plugins/storage/volume/datera/test/org/apache/cloudstack/storage/datastore/driver/Dat

[GitHub] rafaelweingartner commented on a change in pull request #3078: Add influxdb to statscollector

2018-12-14 Thread GitBox
rafaelweingartner commented on a change in pull request #3078: Add influxdb to statscollector URL: https://github.com/apache/cloudstack/pull/3078#discussion_r241724229 ## File path: server/src/main/java/com/cloud/server/StatsCollector.java ## @@ -692,64 +722,59 @@ public v

[GitHub] rafaelweingartner commented on a change in pull request #3078: Add influxdb to statscollector

2018-12-14 Thread GitBox
rafaelweingartner commented on a change in pull request #3078: Add influxdb to statscollector URL: https://github.com/apache/cloudstack/pull/3078#discussion_r241724176 ## File path: server/src/main/java/com/cloud/server/StatsCollector.java ## @@ -692,64 +722,59 @@ public v

[GitHub] rafaelweingartner commented on a change in pull request #3095: Prevent corner case for infinite PrepareForMaintenance

2018-12-14 Thread GitBox
rafaelweingartner commented on a change in pull request #3095: Prevent corner case for infinite PrepareForMaintenance URL: https://github.com/apache/cloudstack/pull/3095#discussion_r241723002 ## File path: server/src/com/cloud/resource/ResourceManagerImpl.java ## @@ -1350,

[GitHub] rafaelweingartner commented on a change in pull request #3095: Prevent corner case for infinite PrepareForMaintenance

2018-12-14 Thread GitBox
rafaelweingartner commented on a change in pull request #3095: Prevent corner case for infinite PrepareForMaintenance URL: https://github.com/apache/cloudstack/pull/3095#discussion_r241722610 ## File path: server/src/com/cloud/resource/ResourceManagerImpl.java ## @@ -1350,

[GitHub] rafaelweingartner closed pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-12-14 Thread GitBox
rafaelweingartner closed pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake o

[cloudstack] branch master updated: Allow KVM VM live migration with ROOT volume on file storage type (#2997)

2018-12-14 Thread rafael
This is an automated email from the ASF dual-hosted git repository. rafael pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new bf20940 Allow KVM VM live migration with RO

[GitHub] rafaelweingartner commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-12-14 Thread GitBox
rafaelweingartner commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#issuecomment-447291721 Integration tests passed, reviews were made and adjusts executed. Travis problems are not related to this

[GitHub] dhlaluku commented on issue #2848: Vmware offline migration

2018-12-14 Thread GitBox
dhlaluku commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-447256694 @borisstoyanov thanks for investigating this, I will have a look. This is an automated mess