[GitHub] dhlaluku commented on a change in pull request #2848: Vmware offline migration

dhlaluku commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r248172351 ## File path: api/src/main/java/org/apache/cloudstack/api/command/admin/vm/MigrateVMCmd.java ## @@ -119,13 +119,7 @@ pub

[GitHub] bwsw commented on a change in pull request #3036: CLOUDSTACK-3035: Implemented capabilities for snapshots and vm snapshots.

bwsw commented on a change in pull request #3036: CLOUDSTACK-3035: Implemented capabilities for snapshots and vm snapshots. URL: https://github.com/apache/cloudstack/pull/3036#discussion_r248162931 ## File path: server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java

[GitHub] nathanejohnson opened a new pull request #3133: feature: add libvirt / qemu io bursting

nathanejohnson opened a new pull request #3133: feature: add libvirt / qemu io bursting URL: https://github.com/apache/cloudstack/pull/3133 ## Description Adds the ability to set bursting features from libvirt / qemu This allows you to utilize the iops and bytes temporary "bur

[GitHub] dhlaluku commented on issue #3113: kvm: Security Group enhancements and refactor old code

dhlaluku commented on issue #3113: kvm: Security Group enhancements and refactor old code URL: https://github.com/apache/cloudstack/pull/3113#issuecomment-454657332 @blueorangutan test This is an automated message from the Ap

[GitHub] blueorangutan commented on issue #3113: kvm: Security Group enhancements and refactor old code

blueorangutan commented on issue #3113: kvm: Security Group enhancements and refactor old code URL: https://github.com/apache/cloudstack/pull/3113#issuecomment-454657375 @dhlaluku a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -

[GitHub] blueorangutan commented on issue #3125: IP address acquired with associate ip address is marked as source nat

blueorangutan commented on issue #3125: IP address acquired with associate ip address is marked as source nat URL: https://github.com/apache/cloudstack/pull/3125#issuecomment-454657382 @dhlaluku a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --

[GitHub] dhlaluku commented on issue #3125: IP address acquired with associate ip address is marked as source nat

dhlaluku commented on issue #3125: IP address acquired with associate ip address is marked as source nat URL: https://github.com/apache/cloudstack/pull/3125#issuecomment-454657229 @blueorangutan test This is an automated mess

[GitHub] blueorangutan commented on issue #3125: IP address acquired with associate ip address is marked as source nat

blueorangutan commented on issue #3125: IP address acquired with associate ip address is marked as source nat URL: https://github.com/apache/cloudstack/pull/3125#issuecomment-454657035 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2539 ---

[GitHub] blueorangutan commented on issue #3113: kvm: Security Group enhancements and refactor old code

blueorangutan commented on issue #3113: kvm: Security Group enhancements and refactor old code URL: https://github.com/apache/cloudstack/pull/3113#issuecomment-454657034 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2540 T

[GitHub] blueorangutan commented on issue #3113: kvm: Security Group enhancements and refactor old code

blueorangutan commented on issue #3113: kvm: Security Group enhancements and refactor old code URL: https://github.com/apache/cloudstack/pull/3113#issuecomment-454651083 @dhlaluku a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] dhlaluku commented on issue #3113: kvm: Security Group enhancements and refactor old code

dhlaluku commented on issue #3113: kvm: Security Group enhancements and refactor old code URL: https://github.com/apache/cloudstack/pull/3113#issuecomment-454651026 @blueorangutan package This is an automated message from the

[GitHub] blueorangutan commented on issue #3125: IP address acquired with associate ip address is marked as source nat

blueorangutan commented on issue #3125: IP address acquired with associate ip address is marked as source nat URL: https://github.com/apache/cloudstack/pull/3125#issuecomment-454650958 @dhlaluku a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] dhlaluku commented on issue #3125: IP address acquired with associate ip address is marked as source nat

dhlaluku commented on issue #3125: IP address acquired with associate ip address is marked as source nat URL: https://github.com/apache/cloudstack/pull/3125#issuecomment-454650891 @blueorangutan package This is an automated m

[GitHub] rafaelweingartner commented on issue #3069: Update jquery and related libraries

rafaelweingartner commented on issue #3069: Update jquery and related libraries URL: https://github.com/apache/cloudstack/pull/3069#issuecomment-454574485 Can you try accessing the same Cloudstack that you have from a Windows or a Linux PC? -

[GitHub] svenvogel edited a comment on issue #3069: Update jquery and related libraries

svenvogel edited a comment on issue #3069: Update jquery and related libraries URL: https://github.com/apache/cloudstack/pull/3069#issuecomment-454574182 yes i use MACOSX 10.14.2. i tried it with firefox 64.0.2 and chrome 71.0.3578.98. why do you ask? --

[GitHub] svenvogel commented on issue #3069: Update jquery and related libraries

svenvogel commented on issue #3069: Update jquery and related libraries URL: https://github.com/apache/cloudstack/pull/3069#issuecomment-454574182 yes i use macosx. i tried it with firefox 64.0.2 and chrome 71.0.3578.98. why do you ask? -

[GitHub] rafaelweingartner commented on issue #3069: Update jquery and related libraries

rafaelweingartner commented on issue #3069: Update jquery and related libraries URL: https://github.com/apache/cloudstack/pull/3069#issuecomment-454551334 About the second problem, I am not sure what can be causing it. However, about the first one. Are you by any chance using a MAC OS? -

[GitHub] svenvogel edited a comment on issue #3069: Update jquery and related libraries

svenvogel edited a comment on issue #3069: Update jquery and related libraries URL: https://github.com/apache/cloudstack/pull/3069#issuecomment-454541924 @GabrielBrascher @rafaelweingartner Yes. we are run directly on actual master! no cherry pick or our own prs. we have different environme

[GitHub] svenvogel edited a comment on issue #3069: Update jquery and related libraries

svenvogel edited a comment on issue #3069: Update jquery and related libraries URL: https://github.com/apache/cloudstack/pull/3069#issuecomment-454544173 Here the other problem. same on master. Autocomplete does not work when selecting rules for the domain admin ![image](https

[GitHub] svenvogel commented on issue #3069: Update jquery and related libraries

svenvogel commented on issue #3069: Update jquery and related libraries URL: https://github.com/apache/cloudstack/pull/3069#issuecomment-454544173 Here the other problem. same on master. Autocomplete does not work when selecting rules for the domain admin ![image](https://user

[GitHub] nathanejohnson commented on a change in pull request #3122: Add back ability to disable backup of snapshot to secondary

nathanejohnson commented on a change in pull request #3122: Add back ability to disable backup of snapshot to secondary URL: https://github.com/apache/cloudstack/pull/3122#discussion_r248054925 ## File path: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/Snapsho

[GitHub] svenvogel edited a comment on issue #3069: Update jquery and related libraries

svenvogel edited a comment on issue #3069: Update jquery and related libraries URL: https://github.com/apache/cloudstack/pull/3069#issuecomment-454541924 @GabrielBrascher @rafaelweingartner Yes. we are run directly on actual master! no cherry pick or our own prs. we have different enviromen

[GitHub] svenvogel commented on issue #3069: Update jquery and related libraries

svenvogel commented on issue #3069: Update jquery and related libraries URL: https://github.com/apache/cloudstack/pull/3069#issuecomment-454541924 @GabrielBrascher @rafaelweingartner Yes. we are run directly on actual master! no cherry pick or our own prs. we have different enviroments for

[GitHub] wido commented on a change in pull request #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool

wido commented on a change in pull request #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool URL: https://github.com/apache/cloudstack/pull/3077#discussion_r248048840 ## File path: server/src/main/java/com/cloud/network/Ipv6AddressManagerImpl.java ##

[GitHub] blueorangutan commented on issue #3113: kvm: Security Group enhancements and refactor old code

blueorangutan commented on issue #3113: kvm: Security Group enhancements and refactor old code URL: https://github.com/apache/cloudstack/pull/3113#issuecomment-454529289 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] blueorangutan commented on issue #3113: kvm: Security Group enhancements and refactor old code

blueorangutan commented on issue #3113: kvm: Security Group enhancements and refactor old code URL: https://github.com/apache/cloudstack/pull/3113#issuecomment-454529285 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] blueorangutan commented on issue #3113: kvm: Security Group enhancements and refactor old code

blueorangutan commented on issue #3113: kvm: Security Group enhancements and refactor old code URL: https://github.com/apache/cloudstack/pull/3113#issuecomment-454528932 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] blueorangutan commented on issue #3113: kvm: Security Group enhancements and refactor old code

blueorangutan commented on issue #3113: kvm: Security Group enhancements and refactor old code URL: https://github.com/apache/cloudstack/pull/3113#issuecomment-454528930 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] blueorangutan commented on issue #3113: kvm: Security Group enhancements and refactor old code

blueorangutan commented on issue #3113: kvm: Security Group enhancements and refactor old code URL: https://github.com/apache/cloudstack/pull/3113#issuecomment-454528929 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] wido commented on a change in pull request #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool

wido commented on a change in pull request #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool URL: https://github.com/apache/cloudstack/pull/3077#discussion_r248039848 ## File path: server/src/main/java/com/cloud/network/Ipv6AddressManagerImpl.java ##

[GitHub] rafaelweingartner commented on a change in pull request #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool

rafaelweingartner commented on a change in pull request #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool URL: https://github.com/apache/cloudstack/pull/3077#discussion_r248036961 ## File path: server/src/main/java/com/cloud/network/Ipv6AddressManagerImpl.java

[GitHub] GabrielBrascher commented on issue #3113: kvm: Security Group enhancements and refactor old code

GabrielBrascher commented on issue #3113: kvm: Security Group enhancements and refactor old code URL: https://github.com/apache/cloudstack/pull/3113#issuecomment-454521439 @blueorangutan package This is an automated message f

[GitHub] rafaelweingartner commented on a change in pull request #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool

rafaelweingartner commented on a change in pull request #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool URL: https://github.com/apache/cloudstack/pull/3077#discussion_r248032662 ## File path: server/src/main/java/com/cloud/network/Ipv6AddressManagerImpl.java

[GitHub] GabrielBrascher commented on issue #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool

GabrielBrascher commented on issue #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool URL: https://github.com/apache/cloudstack/pull/3077#issuecomment-454519966 @blueorangutan package This is an automated

[GitHub] wido commented on issue #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool

wido commented on issue #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool URL: https://github.com/apache/cloudstack/pull/3077#issuecomment-454518995 I just rebased against master and force pushed with updated comments. -

[GitHub] rafaelweingartner edited a comment on issue #3131: Working with ACL List Rules in VPC networks

rafaelweingartner edited a comment on issue #3131: Working with ACL List Rules in VPC networks URL: https://github.com/apache/cloudstack/pull/3131#issuecomment-454517717 @raiciks this PR is quite odd. The commits are from 2013! Moreover, these features were already addressed. I suspect t

[GitHub] rafaelweingartner edited a comment on issue #3131: Working with ACL List Rules in VPC networks

rafaelweingartner edited a comment on issue #3131: Working with ACL List Rules in VPC networks URL: https://github.com/apache/cloudstack/pull/3131#issuecomment-454517717 @raiciks this PR is quite odd. The commits are from 2013! Moreover, these features were already addressed. I suspect t

[GitHub] rafaelweingartner commented on issue #3131: Working with ACL List Rules in VPC networks

rafaelweingartner commented on issue #3131: Working with ACL List Rules in VPC networks URL: https://github.com/apache/cloudstack/pull/3131#issuecomment-454517717 @raiciks this PR is quite odd. The commits are from 2013! Moreover, these features were already addressed. I suspect this is

[GitHub] rafaelweingartner closed pull request #3131: Working with ACL List Rules in VPC networks

rafaelweingartner closed pull request #3131: Working with ACL List Rules in VPC networks URL: https://github.com/apache/cloudstack/pull/3131 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] wido commented on a change in pull request #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool

wido commented on a change in pull request #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool URL: https://github.com/apache/cloudstack/pull/3077#discussion_r248029601 ## File path: server/src/main/java/com/cloud/network/Ipv6AddressManagerImpl.java ##

[GitHub] wido commented on a change in pull request #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool

wido commented on a change in pull request #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool URL: https://github.com/apache/cloudstack/pull/3077#discussion_r248027952 ## File path: server/src/main/java/com/cloud/network/Ipv6AddressManagerImpl.java ##

[GitHub] wido commented on issue #3113: kvm: Security Group enhancements and refactor old code

wido commented on issue #3113: kvm: Security Group enhancements and refactor old code URL: https://github.com/apache/cloudstack/pull/3113#issuecomment-454515378 @rafaelweingartner I have just rebased against master and force pushed again

[GitHub] rafaelweingartner commented on a change in pull request #3112: network: Offerings do not have to have Security Grouping enabled

rafaelweingartner commented on a change in pull request #3112: network: Offerings do not have to have Security Grouping enabled URL: https://github.com/apache/cloudstack/pull/3112#discussion_r248026733 ## File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/or

[GitHub] marabesi opened a new pull request #3132: changed column fingerprint from varchar(62) to text #3123

marabesi opened a new pull request #3132: changed column fingerprint from varchar(62) to text #3123 URL: https://github.com/apache/cloudstack/pull/3132 ## Description As described in the issue #3123 the certificate endpoint throws an exception when a request is made

[GitHub] rafaelweingartner commented on issue #3069: Update jquery and related libraries

rafaelweingartner commented on issue #3069: Update jquery and related libraries URL: https://github.com/apache/cloudstack/pull/3069#issuecomment-454511597 @svenvogel can you guys try to use master (without your PR) to see if the same problem(dislocated buttons) appear there as well? --

[GitHub] rafaelweingartner commented on issue #3041: Decision making logic of which Secondary storage to be used

rafaelweingartner commented on issue #3041: Decision making logic of which Secondary storage to be used URL: https://github.com/apache/cloudstack/issues/3041#issuecomment-454511285 Any chance on getting this into 4.12.0? Otherwise, I would move it to 5.0.0 -

[GitHub] rafaelweingartner commented on issue #2865: DNS records for additional local IP addresses

rafaelweingartner commented on issue #2865: DNS records for additional local IP addresses URL: https://github.com/apache/cloudstack/issues/2865#issuecomment-454511046 @IngoJochim that is a Great idea. We will try to make it to 5.0.0. Thanks for the proposal.

[GitHub] rafaelweingartner commented on issue #2440: CLOUDSTACK-10260 : Introducing a new API to collect and list CPU Sockets Metrics information for all Hypervisors.

rafaelweingartner commented on issue #2440: CLOUDSTACK-10260 : Introducing a new API to collect and list CPU Sockets Metrics information for all Hypervisors. URL: https://github.com/apache/cloudstack/pull/2440#issuecomment-454510793 I will move this to 5.0.0 due to the lack of activity --

[GitHub] rafaelweingartner commented on issue #2067: CLOUDSTACK-9852: This patch implements the storage lb feature

rafaelweingartner commented on issue #2067: CLOUDSTACK-9852: This patch implements the storage lb feature URL: https://github.com/apache/cloudstack/pull/2067#issuecomment-454510627 I will move this to 5.0.0 due to the lack of activity --

[GitHub] rafaelweingartner commented on issue #1775: CLOUDSTACK-9606: While IP address is released, tag are not deleted.

rafaelweingartner commented on issue #1775: CLOUDSTACK-9606: While IP address is released, tag are not deleted. URL: https://github.com/apache/cloudstack/pull/1775#issuecomment-454510081 I will move this to 5.0.0 due to the lack of activity

[GitHub] rafaelweingartner commented on issue #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with space in its name to existing VMware cluster

rafaelweingartner commented on issue #1891: CLOUDSTACK-9730: [VMware] Unable to add a host with space in its name to existing VMware cluster URL: https://github.com/apache/cloudstack/pull/1891#issuecomment-454509266 Moving to 5.0.0 due to lack of activity --

[GitHub] rafaelweingartner commented on issue #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering

rafaelweingartner commented on issue #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering URL: https://github.com/apache/cloudstack/pull/2231#issuecomment-454509054 @syed I will move this to 5.0.0. The freeze date is coming, and it does not seem that we will be able to add it to 4.12.0.

[GitHub] rafaelweingartner commented on issue #2234: CLOUDSTACK-10041: Support to use ikev1 for site-to-site VPN connections

rafaelweingartner commented on issue #2234: CLOUDSTACK-10041: Support to use ikev1 for site-to-site VPN connections URL: https://github.com/apache/cloudstack/pull/2234#issuecomment-454508639 Moving to 5.0.0 due to lack of activity ---

[GitHub] dhlaluku commented on a change in pull request #3058: CLOUDSTACK-3049: update dynamic role for an account

dhlaluku commented on a change in pull request #3058: CLOUDSTACK-3049: update dynamic role for an account URL: https://github.com/apache/cloudstack/pull/3058#discussion_r248014043 ## File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java ## @@ -1712,25 +172

[GitHub] rafaelweingartner commented on issue #3123: Db exception trying to upload SSL certificate

rafaelweingartner commented on issue #3123: Db exception trying to upload SSL certificate URL: https://github.com/apache/cloudstack/issues/3123#issuecomment-454501529 If you want to target master, it should go in 41120-41200 SQL file

[GitHub] marabesi commented on issue #3123: Db exception trying to upload SSL certificate

marabesi commented on issue #3123: Db exception trying to upload SSL certificate URL: https://github.com/apache/cloudstack/issues/3123#issuecomment-454499192 @rhtyd the file `engine/schema/src/main/resources/META-INF/db/schema-421to430.sql` has the SQL to create the sslcerts table:

[GitHub] GabrielBrascher commented on a change in pull request #3113: kvm: Security Group enhancements and refactor old code

GabrielBrascher commented on a change in pull request #3113: kvm: Security Group enhancements and refactor old code URL: https://github.com/apache/cloudstack/pull/3113#discussion_r248008605 ## File path: scripts/vm/network/security_group.py ## @@ -35,11 +33,6 @@ logpath =

[GitHub] dhlaluku commented on a change in pull request #3058: CLOUDSTACK-3049: update dynamic role for an account

dhlaluku commented on a change in pull request #3058: CLOUDSTACK-3049: update dynamic role for an account URL: https://github.com/apache/cloudstack/pull/3058#discussion_r248004026 ## File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java ## @@ -1687,6 +1692

[GitHub] dhlaluku commented on a change in pull request #3058: CLOUDSTACK-3049: update dynamic role for an account

dhlaluku commented on a change in pull request #3058: CLOUDSTACK-3049: update dynamic role for an account URL: https://github.com/apache/cloudstack/pull/3058#discussion_r248004026 ## File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java ## @@ -1687,6 +1692

[GitHub] GabrielBrascher commented on issue #3091: Address reviewers from abandoned PR #1597.

GabrielBrascher commented on issue #3091: Address reviewers from abandoned PR #1597. URL: https://github.com/apache/cloudstack/pull/3091#issuecomment-454489651 Thanks, @dhlaluku! I appreciate the review and I will ping you when updating the code. --

[GitHub] dhlaluku commented on a change in pull request #3091: Address reviewers from abandoned PR #1597.

dhlaluku commented on a change in pull request #3091: Address reviewers from abandoned PR #1597. URL: https://github.com/apache/cloudstack/pull/3091#discussion_r247995449 ## File path: services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.

[GitHub] rafaelweingartner commented on a change in pull request #3122: Add back ability to disable backup of snapshot to secondary

rafaelweingartner commented on a change in pull request #3122: Add back ability to disable backup of snapshot to secondary URL: https://github.com/apache/cloudstack/pull/3122#discussion_r247993425 ## File path: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/Snap

[GitHub] rafaelweingartner commented on a change in pull request #3122: Add back ability to disable backup of snapshot to secondary

rafaelweingartner commented on a change in pull request #3122: Add back ability to disable backup of snapshot to secondary URL: https://github.com/apache/cloudstack/pull/3122#discussion_r247994142 ## File path: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java

[GitHub] rafaelweingartner commented on a change in pull request #3122: Add back ability to disable backup of snapshot to secondary

rafaelweingartner commented on a change in pull request #3122: Add back ability to disable backup of snapshot to secondary URL: https://github.com/apache/cloudstack/pull/3122#discussion_r247994364 ## File path: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java

[GitHub] dhlaluku commented on a change in pull request #3091: Address reviewers from abandoned PR #1597.

dhlaluku commented on a change in pull request #3091: Address reviewers from abandoned PR #1597. URL: https://github.com/apache/cloudstack/pull/3091#discussion_r247993618 ## File path: services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.

[GitHub] dhlaluku commented on a change in pull request #3091: Address reviewers from abandoned PR #1597.

dhlaluku commented on a change in pull request #3091: Address reviewers from abandoned PR #1597. URL: https://github.com/apache/cloudstack/pull/3091#discussion_r247992136 ## File path: services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.

[GitHub] rafaelweingartner commented on issue #3036: CLOUDSTACK-3035: Implemented capabilities for snapshots and vm snapshots.

rafaelweingartner commented on issue #3036: CLOUDSTACK-3035: Implemented capabilities for snapshots and vm snapshots. URL: https://github.com/apache/cloudstack/pull/3036#issuecomment-454480427 @bwsw are you willing to help us getting this PR into 4.12? -

[GitHub] rafaelweingartner commented on issue #3113: kvm: Security Group enhancements and refactor old code

rafaelweingartner commented on issue #3113: kvm: Security Group enhancements and refactor old code URL: https://github.com/apache/cloudstack/pull/3113#issuecomment-454479597 @wido would you mind rebasing on top of current master? Travis is presenting some odd results, which I think are n

[GitHub] rafaelweingartner commented on a change in pull request #3113: kvm: Security Group enhancements and refactor old code

rafaelweingartner commented on a change in pull request #3113: kvm: Security Group enhancements and refactor old code URL: https://github.com/apache/cloudstack/pull/3113#discussion_r247988655 ## File path: scripts/vm/network/security_group.py ## @@ -35,11 +33,6 @@ logpath

[GitHub] dhlaluku commented on a change in pull request #3091: Address reviewers from abandoned PR #1597.

dhlaluku commented on a change in pull request #3091: Address reviewers from abandoned PR #1597. URL: https://github.com/apache/cloudstack/pull/3091#discussion_r247985322 ## File path: services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.

[GitHub] blueorangutan commented on issue #3125: IP address acquired with associate ip address is marked as source nat

blueorangutan commented on issue #3125: IP address acquired with associate ip address is marked as source nat URL: https://github.com/apache/cloudstack/pull/3125#issuecomment-454445336 Packaging result: ✖centos6 ✖centos7 ✖debian. JID-2538 ---

[GitHub] blueorangutan commented on issue #3125: IP address acquired with associate ip address is marked as source nat

blueorangutan commented on issue #3125: IP address acquired with associate ip address is marked as source nat URL: https://github.com/apache/cloudstack/pull/3125#issuecomment-454443648 @dhlaluku a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] dhlaluku commented on issue #3125: IP address acquired with associate ip address is marked as source nat

dhlaluku commented on issue #3125: IP address acquired with associate ip address is marked as source nat URL: https://github.com/apache/cloudstack/pull/3125#issuecomment-454443359 @blueorangutan package This is an automated m

[GitHub] dhlaluku commented on issue #3125: IP address acquired with associate ip address is marked as source nat

dhlaluku commented on issue #3125: IP address acquired with associate ip address is marked as source nat URL: https://github.com/apache/cloudstack/pull/3125#issuecomment-454442556 @rafaelweingartner I just analyzed the results of the failing tests and it seems they caused by the environmen

[GitHub] rafaelweingartner commented on issue #3125: IP address acquired with associate ip address is marked as source nat

rafaelweingartner commented on issue #3125: IP address acquired with associate ip address is marked as source nat URL: https://github.com/apache/cloudstack/pull/3125#issuecomment-454427833 can you try to rebase on latest master? -

[GitHub] DennisKonrad edited a comment on issue #2820: template downloading fails

DennisKonrad edited a comment on issue #2820: template downloading fails URL: https://github.com/apache/cloudstack/issues/2820#issuecomment-454421565 This issue solved itself for us without us doing something really. We updated maybe or something and after that it just worked. --

[GitHub] DennisKonrad edited a comment on issue #2820: template downloading fails

DennisKonrad edited a comment on issue #2820: template downloading fails URL: https://github.com/apache/cloudstack/issues/2820#issuecomment-454421565 This issue is solved without us doing something really. We updated maybe or something and after that it just worked. -

[GitHub] DennisKonrad commented on issue #2820: template downloading fails

DennisKonrad commented on issue #2820: template downloading fails URL: https://github.com/apache/cloudstack/issues/2820#issuecomment-454421565 This issue is solved without us doing something really. We updated maybe or something and after that it just worked. I'll mark this as solv

[GitHub] dhlaluku commented on issue #3125: IP address acquired with associate ip address is marked as source nat

dhlaluku commented on issue #3125: IP address acquired with associate ip address is marked as source nat URL: https://github.com/apache/cloudstack/pull/3125#issuecomment-454415983 @GabrielBrascher these failures are starting to look suspicious. Any thoughts @borisstoyanov ? --

[GitHub] blueorangutan commented on issue #3125: IP address acquired with associate ip address is marked as source nat

blueorangutan commented on issue #3125: IP address acquired with associate ip address is marked as source nat URL: https://github.com/apache/cloudstack/pull/3125#issuecomment-454374458 Trillian test result (tid-3322) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7

[GitHub] DennisKonrad commented on issue #3089: VMs with invalid IDE configuration when using Solidfire as primary storage

DennisKonrad commented on issue #3089: VMs with invalid IDE configuration when using Solidfire as primary storage URL: https://github.com/apache/cloudstack/issues/3089#issuecomment-454369885 @kiwiflyer Another issue arose with this OS-Type implementation thing. When using "Other PV"

[cloudstack] branch 6d4b980643a8c69cda68e9101ce835aa6f1ce835 deleted (was e56c499)

This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 6d4b980643a8c69cda68e9101ce835aa6f1ce835 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was e56c499 vmware: syncVolumeToRootFolder method to avoid an infite recursive loo

[cloudstack] branch 6d4b980643a8c69cda68e9101ce835aa6f1ce835 created (now e56c499)

This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 6d4b980643a8c69cda68e9101ce835aa6f1ce835 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. at e56c499 vmware: syncVolumeToRootFolder method to avoid an infite recursive loo

[cloudstack] Diff for: [GitHub] rhtyd merged pull request #3099: Add resource UUID instead of resource id in resourcedetails api (#2527)

diff --git a/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java b/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java index 93514700492..f75f711143c 100644 --- a/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java +++ b/server/src/main/java/com/cloud/api/query/Que

[GitHub] rhtyd closed issue #2527: listResourceDetails: ID is not UUID, but DB ID

rhtyd closed issue #2527: listResourceDetails: ID is not UUID, but DB ID URL: https://github.com/apache/cloudstack/issues/2527 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] rhtyd merged pull request #3099: Add resource UUID instead of resource id in resourcedetails api (#2527)

rhtyd merged pull request #3099: Add resource UUID instead of resource id in resourcedetails api (#2527) URL: https://github.com/apache/cloudstack/pull/3099 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, commits@cloudstack.apache.org

[cloudstack] branch master updated: server: use resource UUID instead of resource ID in API response (#2527) (#3099)

This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 1a6eb4b server: use resource UUID instead of

[GitHub] rhtyd commented on a change in pull request #3099: Add resource UUID instead of resource id in resourcedetails api (#2527)

rhtyd commented on a change in pull request #3099: Add resource UUID instead of resource id in resourcedetails api (#2527) URL: https://github.com/apache/cloudstack/pull/3099#discussion_r247799801 ## File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java

[cloudstack] Diff for: [GitHub] rhtyd merged pull request #3129: Fix “test_nic_secondaryip_add_remove” test

diff --git a/server/src/main/java/com/cloud/network/NetworkServiceImpl.java b/server/src/main/java/com/cloud/network/NetworkServiceImpl.java index e9c4554a0b5..10212273e5b 100644 --- a/server/src/main/java/com/cloud/network/NetworkServiceImpl.java +++ b/server/src/main/java/com/cloud/network/Netwo

[cloudstack] branch master updated (df6288f -> 1725130)

This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from df6288f Extend PR#2535 to enable remote debugging for CentOS63 as well (#3128) add 1725130 server: Fix fai

[GitHub] rhtyd merged pull request #3129: Fix “test_nic_secondaryip_add_remove” test

rhtyd merged pull request #3129: Fix “test_nic_secondaryip_add_remove” test URL: https://github.com/apache/cloudstack/pull/3129 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, commits@cloudstack.apache.org --

[GitHub] rhtyd commented on issue #2983: KVM live storage migration intra cluster from NFS source and destination

rhtyd commented on issue #2983: KVM live storage migration intra cluster from NFS source and destination URL: https://github.com/apache/cloudstack/pull/2983#issuecomment-454303526 Test LGTM @GabrielBrascher are you LGTM on this, or still reviewing? --

[GitHub] blueorangutan commented on issue #3125: IP address acquired with associate ip address is marked as source nat

blueorangutan commented on issue #3125: IP address acquired with associate ip address is marked as source nat URL: https://github.com/apache/cloudstack/pull/3125#issuecomment-454303157 @dhlaluku a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --

[GitHub] dhlaluku commented on issue #3125: IP address acquired with associate ip address is marked as source nat

dhlaluku commented on issue #3125: IP address acquired with associate ip address is marked as source nat URL: https://github.com/apache/cloudstack/pull/3125#issuecomment-454303009 @blueorangutan test This is an automated mess

[GitHub] blueorangutan commented on issue #3125: IP address acquired with associate ip address is marked as source nat

blueorangutan commented on issue #3125: IP address acquired with associate ip address is marked as source nat URL: https://github.com/apache/cloudstack/pull/3125#issuecomment-454302592 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2537 ---