[GitHub] [cloudstack] blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-17 Thread GitBox
blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-566469270 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make

[GitHub] [cloudstack] Spaceman1984 commented on issue #3755: Added zone check for attach iso

2019-12-17 Thread GitBox
Spaceman1984 commented on issue #3755: Added zone check for attach iso URL: https://github.com/apache/cloudstack/pull/3755#issuecomment-566468616 Rebased to 4.13 This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358692438 ## File path:

[cloudstack] branch master updated (da62cec -> 2e8c069)

2019-12-17 Thread gabriel
This is an automated email from the ASF dual-hosted git repository. gabriel pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from da62cec README: that time of the year!  (#3769) add 2e8c069 Load Average for KVM (#3738) No new

[GitHub] [cloudstack] GabrielBrascher merged pull request #3738: Load Average for KVM

2019-12-17 Thread GitBox
GabrielBrascher merged pull request #3738: Load Average for KVM URL: https://github.com/apache/cloudstack/pull/3738 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [cloudstack] GabrielBrascher commented on issue #3738: Load Average for KVM

2019-12-17 Thread GitBox
GabrielBrascher commented on issue #3738: Load Average for KVM URL: https://github.com/apache/cloudstack/pull/3738#issuecomment-566461477 Looking good to merge. Merging it considering that all checks have passed, we have 4 LGTMs, a couple of manual tests, and the packaging results are

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-17 Thread GitBox
DaanHoogland commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#discussion_r358684873 ## File path:

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358682235 ## File path:

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358682093 ## File path: core/src/main/java/com/cloud/agent/resource/virtualnetwork/VRScripts.java

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358679982 ## File path:

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358677525 ## File path: api/src/main/java/org/apache/cloudstack/api/response/SeedSystemVMTemplateResponse.java ## @@ -0,0

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358677347 ## File path: api/src/main/java/org/apache/cloudstack/api/response/ActivateSystemVMTemplateResponse.java ## @@

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358677443 ## File path: api/src/main/java/org/apache/cloudstack/api/response/GetSystemVMTemplateDefaultURLResponse.java ##

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358676757 ## File path: ui/config.js ## @@ -17,6 +17,7 @@ // Define custom options configurable by admins for UI

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358676673 ## File path: test/integration/smoke/test_templates.py ## @@ -1354,3 +1353,5 @@ def

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358676582 ## File path: server/src/main/java/com/cloud/storage/mount/NfsMountManager.java ## @@ -0,0 +1,203 @@ +//

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358676303 ## File path: plugins/ca/root-ca/pom.xml ## @@ -43,5 +43,10 @@ cloud-framework-ca

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-17 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358667589 ## File path: core/src/main/java/com/cloud/agent/api/routing/SetMonitorServiceCommand.java

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358665305 ## File path: server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java ## @@ -211,8 +219,14 @@

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358664540 ## File path: server/src/main/java/com/cloud/storage/mount/NfsMountManager.java ## @@ -0,0 +1,203 @@ +//

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358665127 ## File path: server/src/main/java/com/cloud/storage/secondary/NfsMountCapacityChecker.java ## @@ -0,0 +1,69 @@

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358664607 ## File path: server/src/main/java/com/cloud/storage/secondary/CapacityChecker.java ## @@ -0,0 +1,35 @@ +//

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358665974 ## File path: server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java ## @@ -330,8 +345,8 @@

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358666059 ## File path: server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java ## @@ -602,11 +617,13 @@

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358663003 ## File path: server/src/main/java/com/cloud/storage/download/managementserver/system/HttpSystemTemplateDownloader.java

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358663124 ## File path: server/src/main/java/com/cloud/storage/download/managementserver/system/SystemTemplateDownloader.java

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358663237 ## File path: server/src/main/java/com/cloud/storage/download/managementserver/system/SystemTemplateDownloader.java

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358662497 ## File path: engine/storage/src/main/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358661913 ## File path: engine/schema/src/main/java/com/cloud/upgrade/OfficialSystemVMTemplate.java ## @@ -0,0 +1,101 @@

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358661101 ## File path: utils/src/main/java/com/cloud/utils/http/downloader/HttpDirectTemplateDownloader.java ## @@ -0,0

[GitHub] [cloudstack] blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-17 Thread GitBox
blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-566441119 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-476

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358659903 ## File path: utils/src/main/java/com/cloud/utils/http/downloader/HttpDirectTemplateDownloader.java ## @@ -0,0

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358659837 ## File path: utils/src/main/java/com/cloud/utils/http/downloader/DirectTemplateDownloaderImpl.java ## @@ -0,0

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP)

2019-12-17 Thread GitBox
Spaceman1984 commented on a change in pull request #3748: Systemvm template api (WIP) URL: https://github.com/apache/cloudstack/pull/3748#discussion_r358658816 ## File path: ui/scripts/sharedFunctions.js ## @@ -1208,17 +1208,21 @@ cloudStack.validate = {

[GitHub] [cloudstack] borisstoyanov commented on issue #3769: README: that time of the year!

2019-12-17 Thread GitBox
borisstoyanov commented on issue #3769: README: that time of the year! URL: https://github.com/apache/cloudstack/pull/3769#issuecomment-566435272 +1! happy holidays guys, wish you all the best in the new year! This is an

[GitHub] [cloudstack] blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-17 Thread GitBox
blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-566435017 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make

[GitHub] [cloudstack] anuragaw commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-17 Thread GitBox
anuragaw commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-566434701 @blueorangutan package This is an

[GitHub] [cloudstack] DaanHoogland commented on issue #3770: UI: JOB does not complete when you create a template from snapshot

2019-12-17 Thread GitBox
DaanHoogland commented on issue #3770: UI: JOB does not complete when you create a template from snapshot URL: https://github.com/apache/cloudstack/issues/3770#issuecomment-566433570 I think this is a more generic issue where jobs finish but the notification drop-down still shows them as

<    1   2