[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-24 Thread GitBox
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568810848 @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests ---

[GitHub] [cloudstack] andrijapanicsb commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-24 Thread GitBox
andrijapanicsb commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568810820 @blueorangutan test This is an automated message f

[GitHub] [cloudstack] blueorangutan commented on issue #3601: JDK11, Debian 10 support

2019-12-24 Thread GitBox
blueorangutan commented on issue #3601: JDK11, Debian 10 support URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-568810803 Trillian test result (tid-666) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40855 seconds Marvin log

[GitHub] [cloudstack] blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-24 Thread GitBox
blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568801892 @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests -

[GitHub] [cloudstack] andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-24 Thread GitBox
andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568801877 @blueorangutan test centos7 vmware-65u2 This is an automated mes

[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-24 Thread GitBox
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568781422 @anuragaw a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -

[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-24 Thread GitBox
anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568781329 Past failures seem env related.Rekicking tests - @blueorangutan test -

[GitHub] [cloudstack] blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-24 Thread GitBox
blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568775338 @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests -

[GitHub] [cloudstack] andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-24 Thread GitBox
andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568775281 @blueorangutan test centos7 vmware-65u2 This is an automated mes

[GitHub] [cloudstack] svenvogel commented on issue #3776: Fix HA config keys

2019-12-24 Thread GitBox
svenvogel commented on issue #3776: Fix HA config keys URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-568765025 @DaanHoogland for now its ready for 4.14. i think @mdominka dont have time to rebase it. it was his last work. we can move them back later. if its 4.13.1 we nee

[GitHub] [cloudstack] DaanHoogland commented on issue #3764: Refer pod_ip_range_map table instead of host_pod_ref.decription.

2019-12-24 Thread GitBox
DaanHoogland commented on issue #3764: Refer pod_ip_range_map table instead of host_pod_ref.decription. URL: https://github.com/apache/cloudstack/pull/3764#issuecomment-568764685 Hah, IPv6. ok, so there is a good future selling point for this improvement 🥇 @wido can you comment? -

[GitHub] [cloudstack] DaanHoogland commented on issue #3776: Fix HA config keys

2019-12-24 Thread GitBox
DaanHoogland commented on issue #3776: Fix HA config keys URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-568763964 I would prefer just one pr, so for 4.13.1 please rebase upon that branch. This is an automate

[GitHub] [cloudstack] DaanHoogland commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-24 Thread GitBox
DaanHoogland commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568763798 @blueorangutan test This is an automated message fro

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3601: JDK11, Debian 10 support

2019-12-24 Thread GitBox
DaanHoogland commented on a change in pull request #3601: JDK11, Debian 10 support URL: https://github.com/apache/cloudstack/pull/3601#discussion_r361179626 ## File path: server/src/test/java/com/cloud/storage/listener/StoragePoolMonitorTest.java ## @@ -58,17 +60,18 @@ pu

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3601: JDK11, Debian 10 support

2019-12-24 Thread GitBox
DaanHoogland commented on a change in pull request #3601: JDK11, Debian 10 support URL: https://github.com/apache/cloudstack/pull/3601#discussion_r361180628 ## File path: server/src/test/java/com/cloud/user/AccountManagetImplTestBase.java ## @@ -210,6 +211,12 @@ public voi

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3601: JDK11, Debian 10 support

2019-12-24 Thread GitBox
DaanHoogland commented on a change in pull request #3601: JDK11, Debian 10 support URL: https://github.com/apache/cloudstack/pull/3601#discussion_r361180164 ## File path: server/src/test/java/com/cloud/user/AccountManagerImplVolumeDeleteEventTest.java ## @@ -54,18 +57,25

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3601: JDK11, Debian 10 support

2019-12-24 Thread GitBox
DaanHoogland commented on a change in pull request #3601: JDK11, Debian 10 support URL: https://github.com/apache/cloudstack/pull/3601#discussion_r361179176 ## File path: server/src/test/java/com/cloud/snapshot/SnapshotDaoTest.java ## @@ -34,12 +31,16 @@ import com.cloud.

[GitHub] [cloudstack] svenvogel commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag

2019-12-24 Thread GitBox
svenvogel commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-568761697 >@andrijapanicsb yes you can create additional physical network without tags but this PR ensures that there wil

[GitHub] [cloudstack] cl-k-takahashi commented on issue #3764: Refer pod_ip_range_map table instead of host_pod_ref.decription.

2019-12-24 Thread GitBox
cl-k-takahashi commented on issue #3764: Refer pod_ip_range_map table instead of host_pod_ref.decription. URL: https://github.com/apache/cloudstack/pull/3764#issuecomment-568754935 I think you are right, because current code is working well. First, I wanted to make cloudstack support ip

[GitHub] [cloudstack] DaanHoogland commented on issue #3786: [WIP] server: fix checking disk offering access for snapshot volume

2019-12-24 Thread GitBox
DaanHoogland commented on issue #3786: [WIP] server: fix checking disk offering access for snapshot volume URL: https://github.com/apache/cloudstack/pull/3786#issuecomment-568753445 @shwstppr code looks good, but the bug existed IMHO because of the method being 200 lines long and thus ille

[GitHub] [cloudstack] andrijapanicsb commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag

2019-12-24 Thread GitBox
andrijapanicsb commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-568748913 I don't like imposing a limitation (unless its controlled via global setting and defaults to the old behav

[GitHub] [cloudstack] rakgenius edited a comment on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag

2019-12-24 Thread GitBox
rakgenius edited a comment on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-568745769 > @rakgenius @andrijapanicsb i follow your discussion guys 🎅 > > if i understand it correctly the

[GitHub] [cloudstack] rakgenius commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag

2019-12-24 Thread GitBox
rakgenius commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-568745769 r > @rakgenius @andrijapanicsb i follow your discussion guys 🎅 > > if i understand it correctly th

[GitHub] [cloudstack] svenvogel commented on issue #3776: Fix HA config keys

2019-12-24 Thread GitBox
svenvogel commented on issue #3776: Fix HA config keys URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-568736899 @DaanHoogland for me i would be good to get in 4.14 and sure in 4.13.1 too. This is an automated

[GitHub] [cloudstack] svenvogel commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag

2019-12-24 Thread GitBox
svenvogel commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-568736744 @rakgenius @andrijapanicsb i follow your discussion guys 🎅 if i understand it correctly the PR does the

[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-24 Thread GitBox
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568732013 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-508 ---

[GitHub] [cloudstack] blueorangutan commented on issue #3786: [WIP] server: fix checking disk offering access for snapshot volume

2019-12-24 Thread GitBox
blueorangutan commented on issue #3786: [WIP] server: fix checking disk offering access for snapshot volume URL: https://github.com/apache/cloudstack/pull/3786#issuecomment-568731401 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-507 --

[GitHub] [cloudstack] blueorangutan commented on issue #3601: JDK11, Debian 10 support

2019-12-24 Thread GitBox
blueorangutan commented on issue #3601: JDK11, Debian 10 support URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-568730869 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-506 This is an automated message from

[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-24 Thread GitBox
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568727615 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-24 Thread GitBox
anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568727444 @blueorangutan package This is an automated message from

[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-24 Thread GitBox
anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568727222 Failures don't seem related but due to environment failure. Running again. @blueorangutan test ---

[GitHub] [cloudstack] anuragaw removed a comment on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-24 Thread GitBox
anuragaw removed a comment on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568727222 Failures don't seem related but due to environment failure. Running again. @blueorangutan test ---

[GitHub] [cloudstack] blueorangutan commented on issue #3786: [WIP] server: fix checking disk offering access for snapshot volume

2019-12-24 Thread GitBox
blueorangutan commented on issue #3786: [WIP] server: fix checking disk offering access for snapshot volume URL: https://github.com/apache/cloudstack/pull/3786#issuecomment-568726136 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] [cloudstack] shwstppr commented on issue #3786: [WIP] server: fix checking disk offering access for snapshot volume

2019-12-24 Thread GitBox
shwstppr commented on issue #3786: [WIP] server: fix checking disk offering access for snapshot volume URL: https://github.com/apache/cloudstack/pull/3786#issuecomment-568726065 @blueorangutan package This is an automated mes

[GitHub] [cloudstack] shwstppr commented on issue #3783: Create volume or template from snapshot is broken

2019-12-24 Thread GitBox
shwstppr commented on issue #3783: Create volume or template from snapshot is broken URL: https://github.com/apache/cloudstack/issues/3783#issuecomment-568724770 @NuxRo will it be possible for you to test the fix in the reference PR -

[GitHub] [cloudstack] blueorangutan commented on issue #3601: JDK11, Debian 10 support

2019-12-24 Thread GitBox
blueorangutan commented on issue #3601: JDK11, Debian 10 support URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-568724382 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] rhtyd commented on issue #3601: JDK11, Debian 10 support

2019-12-24 Thread GitBox
rhtyd commented on issue #3601: JDK11, Debian 10 support URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-568724227 @blueorangutan package This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] shwstppr opened a new pull request #3786: [WIP] server: fix checking disk offering access for pure snapshot volume

2019-12-24 Thread GitBox
shwstppr opened a new pull request #3786: [WIP] server: fix checking disk offering access for pure snapshot volume URL: https://github.com/apache/cloudstack/pull/3786 Fixes https://github.com/apache/cloudstack/issues/3783 As reported in the issue, creating volumes from pure snapshot fail

[GitHub] [cloudstack] rakgenius commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag

2019-12-24 Thread GitBox
rakgenius commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-568723816 @andrijapanicsb yes you can create additional physical network without tags but this PR ensures that there will

[GitHub] [cloudstack] andrijapanicsb commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag

2019-12-24 Thread GitBox
andrijapanicsb commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-568722806 @rakgenius currently you can still create additional physical network, and then the Guest traffic in this

[GitHub] [cloudstack] blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-24 Thread GitBox
blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-568720714 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-505 --

[GitHub] [cloudstack] rakgenius commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag

2019-12-24 Thread GitBox
rakgenius commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-568719886 @andrijapanicsb in 4.7, we were able to create multiple physical networks without any tag in the same traffic t

[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-24 Thread GitBox
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568719627 Trillian test result (tid-663) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] [cloudstack] blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-24 Thread GitBox
blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-568716833 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] anuragaw commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-24 Thread GitBox
anuragaw commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-568716747 @blueorangutan package This is an autom

[GitHub] [cloudstack] andrijapanicsb commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag

2019-12-24 Thread GitBox
andrijapanicsb commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-568716299 in 4.13 at least (or was it master actually) you can't create Guest network if you have 2 physical network

[GitHub] [cloudstack] blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-24 Thread GitBox
blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-568714265 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] anuragaw commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-24 Thread GitBox
anuragaw commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-568714128 @blueorangutan package This is an autom

[GitHub] [cloudstack] rakgenius commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag

2019-12-24 Thread GitBox
rakgenius commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-568713816 @andrijapanicsb @DaanHoogland Your point sounds valid. I can hide this behind a global setting or completely re

[GitHub] [cloudstack] rakgenius commented on issue #3775: New feature: Acquire specific public IP for network

2019-12-24 Thread GitBox
rakgenius commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-568713208 > @rakgenius I think you have a seat near to Wei's? ;) @DaanHoogland :P I sit next to him :) ---

[GitHub] [cloudstack] rakgenius edited a comment on issue #3775: New feature: Acquire specific public IP for network

2019-12-24 Thread GitBox
rakgenius edited a comment on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-568713208 > @rakgenius I think you have a seat near to Wei's? ;) @DaanHoogland :P I sit next to him :) thanks for merging -

[cloudstack] branch master updated (482e7eb -> 4fa7fad)

2019-12-24 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 482e7eb New feature: Acquire specific public IP for network (#3775) add 8844f59 break session only on illega

[GitHub] [cloudstack] DaanHoogland commented on issue #3715: break session only on illegal origin

2019-12-24 Thread GitBox
DaanHoogland commented on issue #3715: break session only on illegal origin URL: https://github.com/apache/cloudstack/pull/3715#issuecomment-568704302 merged. tested and reviewed. This is an automated message from the Apache G

[cloudstack] branch 4.13 updated: break session only on illegal origin (#3715)

2019-12-24 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.13 by this push: new 8844f59 break session only on illegal origin (#37

[GitHub] [cloudstack] DaanHoogland merged pull request #3715: break session only on illegal origin

2019-12-24 Thread GitBox
DaanHoogland merged pull request #3715: break session only on illegal origin URL: https://github.com/apache/cloudstack/pull/3715 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [cloudstack] DaanHoogland commented on issue #3746: Fix OS category for some OS-es added in 4.13

2019-12-24 Thread GitBox
DaanHoogland commented on issue #3746: Fix OS category for some OS-es added in 4.13 URL: https://github.com/apache/cloudstack/pull/3746#issuecomment-568703874 I'm afraid we'll need a new PR though as this one has been merged, @andrijapanicsb --

[GitHub] [cloudstack] DaanHoogland commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-24 Thread GitBox
DaanHoogland commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568702570 we have more than usual travis failures here @nvazquez . Can you check those? -

[cloudstack] branch master updated (06e1212 -> 482e7eb)

2019-12-24 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 06e1212 Merge release branch 4.13 to master add 482e7eb New feature: Acquire specific public IP for network

[GitHub] [cloudstack] DaanHoogland merged pull request #3775: New feature: Acquire specific public IP for network

2019-12-24 Thread GitBox
DaanHoogland merged pull request #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [cloudstack] DaanHoogland commented on issue #3775: New feature: Acquire specific public IP for network

2019-12-24 Thread GitBox
DaanHoogland commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-568701130 @rakgenius I think you have a seat near to Wei's? ;) This i

[GitHub] [cloudstack] DaanHoogland commented on issue #3776: Fix HA config keys

2019-12-24 Thread GitBox
DaanHoogland commented on issue #3776: Fix HA config keys URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-568700692 @svenvogel @andrijapanicsb do we not want this in for 4.13.1? This is an automated message fr

[GitHub] [cloudstack] DaanHoogland commented on issue #3764: Refer pod_ip_range_map table instead of host_pod_ref.decription.

2019-12-24 Thread GitBox
DaanHoogland commented on issue #3764: Refer pod_ip_range_map table instead of host_pod_ref.decription. URL: https://github.com/apache/cloudstack/pull/3764#issuecomment-568699424 @cl-k-takahashi , I like your code and your thinking. I am worried that we are taking a risk here that is not g

[GitHub] [cloudstack] utchoang opened a new issue #3785: the listProjectInvitations requests "keyword" parameter not to work.

2019-12-24 Thread GitBox
utchoang opened a new issue #3785: the listProjectInvitations requests "keyword" parameter not to work. URL: https://github.com/apache/cloudstack/issues/3785 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ API ~~~ # CLOUDSTACK VERSION ~~~

[GitHub] [cloudstack] andrijapanicsb edited a comment on issue #3746: Fix OS category for some OS-es added in 4.13

2019-12-24 Thread GitBox
andrijapanicsb edited a comment on issue #3746: Fix OS category for some OS-es added in 4.13 URL: https://github.com/apache/cloudstack/pull/3746#issuecomment-568694419 Yes, you can repeat the queries, 2nd run will do no changes - and the rows to be changed are uniquely identified by ID an

[GitHub] [cloudstack] andrijapanicsb edited a comment on issue #3746: Fix OS category for some OS-es added in 4.13

2019-12-24 Thread GitBox
andrijapanicsb edited a comment on issue #3746: Fix OS category for some OS-es added in 4.13 URL: https://github.com/apache/cloudstack/pull/3746#issuecomment-568694419 Yes, you can repeat the queries, 2nd run will do no changes - and the rows to be changed are uniquely identified by ID an

[GitHub] [cloudstack] andrijapanicsb commented on issue #3746: Fix OS category for some OS-es added in 4.13

2019-12-24 Thread GitBox
andrijapanicsb commented on issue #3746: Fix OS category for some OS-es added in 4.13 URL: https://github.com/apache/cloudstack/pull/3746#issuecomment-568694419 Yes, you can repeat the queries, 2nd run will do no changes - and the rows to be changed are uniquely identified by ID and name

[GitHub] [cloudstack] DaanHoogland commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag

2019-12-24 Thread GitBox
DaanHoogland commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-568691387 @rakgenius I can see how you want this. Can you answer @andrijapanicsb on to why enforce this and if you guy

[GitHub] [cloudstack] DaanHoogland commented on issue #3746: Fix OS category for some OS-es added in 4.13

2019-12-24 Thread GitBox
DaanHoogland commented on issue #3746: Fix OS category for some OS-es added in 4.13 URL: https://github.com/apache/cloudstack/pull/3746#issuecomment-568690564 @andrijapanicsb we can, we'll just make sure to test that right? ;) ---

[GitHub] [cloudstack] blueorangutan commented on issue #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support

2019-12-24 Thread GitBox
blueorangutan commented on issue #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support URL: https://github.com/apache/cloudstack/pull/3731#issuecomment-568690300 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-503

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-24 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r361098706 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java ## @@ -201,33