[GitHub] [cloudstack] andrijapanicsb commented on issue #3649: [WIP DO NOT MERGE] Garbage snapshots are left on Primary and Secondary

2020-01-05 Thread GitBox
andrijapanicsb commented on issue #3649: [WIP DO NOT MERGE] Garbage snapshots are left on Primary and Secondary URL: https://github.com/apache/cloudstack/pull/3649#issuecomment-571037576 @DaanHoogland I've raised a blocker issue in regards to the garbage, so it will have to be fixed one wa

[GitHub] [cloudstack] andrijapanicsb commented on issue #2996: [Bug Report] - GRE Isolation Broken in VPC Tier

2020-01-05 Thread GitBox
andrijapanicsb commented on issue #2996: [Bug Report] - GRE Isolation Broken in VPC Tier URL: https://github.com/apache/cloudstack/issues/2996#issuecomment-571036425 Are you saying to let it go, if it doesn't make into 4.14 @bdonnahue? -

[GitHub] [cloudstack] blueorangutan commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR

2020-01-05 Thread GitBox
blueorangutan commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR URL: https://github.com/apache/cloudstack/pull/3477#issuecomment-571034535 @andrijapanicsb a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65,

[GitHub] [cloudstack] andrijapanicsb commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR

2020-01-05 Thread GitBox
andrijapanicsb commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR URL: https://github.com/apache/cloudstack/pull/3477#issuecomment-571034513 @blueorangutan test matrix

[GitHub] [cloudstack] nvazquez commented on a change in pull request #3553: [WIP] [DO NOT MERGE] CloudStack Backup & Recovery Framework

2020-01-05 Thread GitBox
nvazquez commented on a change in pull request #3553: [WIP] [DO NOT MERGE] CloudStack Backup & Recovery Framework URL: https://github.com/apache/cloudstack/pull/3553#discussion_r363162215 ## File path: server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java ##

[GitHub] [cloudstack] nvazquez commented on a change in pull request #3553: [WIP] [DO NOT MERGE] CloudStack Backup & Recovery Framework

2020-01-05 Thread GitBox
nvazquez commented on a change in pull request #3553: [WIP] [DO NOT MERGE] CloudStack Backup & Recovery Framework URL: https://github.com/apache/cloudstack/pull/3553#discussion_r363161806 ## File path: plugins/backup/dummy/src/main/java/org/apache/cloudstack/backup/DummyBackupProvi

[GitHub] [cloudstack] nvazquez commented on a change in pull request #3553: [WIP] [DO NOT MERGE] CloudStack Backup & Recovery Framework

2020-01-05 Thread GitBox
nvazquez commented on a change in pull request #3553: [WIP] [DO NOT MERGE] CloudStack Backup & Recovery Framework URL: https://github.com/apache/cloudstack/pull/3553#discussion_r363161687 ## File path: engine/schema/src/main/java/com/cloud/storage/dao/DiskOfferingDaoImpl.java

[GitHub] [cloudstack] nvazquez commented on a change in pull request #3553: [WIP] [DO NOT MERGE] CloudStack Backup & Recovery Framework

2020-01-05 Thread GitBox
nvazquez commented on a change in pull request #3553: [WIP] [DO NOT MERGE] CloudStack Backup & Recovery Framework URL: https://github.com/apache/cloudstack/pull/3553#discussion_r363161609 ## File path: engine/schema/src/main/java/com/cloud/storage/dao/DiskOfferingDaoImpl.java

[GitHub] [cloudstack] nvazquez commented on a change in pull request #3553: [WIP] [DO NOT MERGE] CloudStack Backup & Recovery Framework

2020-01-05 Thread GitBox
nvazquez commented on a change in pull request #3553: [WIP] [DO NOT MERGE] CloudStack Backup & Recovery Framework URL: https://github.com/apache/cloudstack/pull/3553#discussion_r363160586 ## File path: api/src/main/java/org/apache/cloudstack/api/command/user/backup/CreateBackupCmd.

[GitHub] [cloudstack] pavanaravapalli commented on issue #3638: UEFI Support on CloudStack

2020-01-05 Thread GitBox
pavanaravapalli commented on issue #3638: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#issuecomment-571005896 Hi @andrijapanicsb PR is in good shape can be picked and tested, I am waiting for review comments and Dev Testing find outs from @nvazquez

[GitHub] [cloudstack] blueorangutan commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR

2020-01-05 Thread GitBox
blueorangutan commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR URL: https://github.com/apache/cloudstack/pull/3477#issuecomment-571003211 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-536 ---

[GitHub] [cloudstack] blueorangutan commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR

2020-01-05 Thread GitBox
blueorangutan commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR URL: https://github.com/apache/cloudstack/pull/3477#issuecomment-570999870 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progr

[GitHub] [cloudstack] rhtyd commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR

2020-01-05 Thread GitBox
rhtyd commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR URL: https://github.com/apache/cloudstack/pull/3477#issuecomment-570999757 Trillian test failed, needs re-run @DaanHoogland cc @andrijapanicsb @blueorangutan package -

[GitHub] [cloudstack] blueorangutan commented on issue #3601: JDK11, Debian 10 support

2020-01-05 Thread GitBox
blueorangutan commented on issue #3601: JDK11, Debian 10 support URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-570996180 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-535 This is an automated message from

[GitHub] [cloudstack] blueorangutan commented on issue #3601: JDK11, Debian 10 support

2020-01-05 Thread GitBox
blueorangutan commented on issue #3601: JDK11, Debian 10 support URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-570992727 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] rhtyd commented on issue #3601: JDK11, Debian 10 support

2020-01-05 Thread GitBox
rhtyd commented on issue #3601: JDK11, Debian 10 support URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-570992555 @blueorangutan package This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] blueorangutan commented on issue #3601: JDK11, Debian 10 support

2020-01-05 Thread GitBox
blueorangutan commented on issue #3601: JDK11, Debian 10 support URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-570992095 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-534 This is an automated message from

[GitHub] [cloudstack] nvazquez commented on issue #3065: Direct Download to Ceph Primary storage fails

2020-01-05 Thread GitBox
nvazquez commented on issue #3065: Direct Download to Ceph Primary storage fails URL: https://github.com/apache/cloudstack/issues/3065#issuecomment-570991709 Yes @andrijapanicsb but the improvement will not include managed storage atm. This will need to be moved to the next release/mileston

[GitHub] [cloudstack] blueorangutan commented on issue #3601: JDK11, Debian 10 support

2020-01-05 Thread GitBox
blueorangutan commented on issue #3601: JDK11, Debian 10 support URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-570988268 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] rhtyd commented on issue #3601: JDK11, Debian 10 support

2020-01-05 Thread GitBox
rhtyd commented on issue #3601: JDK11, Debian 10 support URL: https://github.com/apache/cloudstack/pull/3601#issuecomment-570988146 @blueorangutan package This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] bdonnahue commented on issue #2996: [Bug Report] - GRE Isolation Broken in VPC Tier

2020-01-05 Thread GitBox
bdonnahue commented on issue #2996: [Bug Report] - GRE Isolation Broken in VPC Tier URL: https://github.com/apache/cloudstack/issues/2996#issuecomment-570983444 @andrijapanicsb IIRC no one on the list was familiar with the GRE component. I don't think the issue should be closed. Either the

[GitHub] [cloudstack] GabrielBrascher commented on issue #3649: [WIP DO NOT MERGE] Garbage snapshots are left on Primary and Secondary

2020-01-05 Thread GitBox
GabrielBrascher commented on issue #3649: [WIP DO NOT MERGE] Garbage snapshots are left on Primary and Secondary URL: https://github.com/apache/cloudstack/pull/3649#issuecomment-570971213 @DaanHoogland I will bring an update until the end of the week, but probably I will propose a new PR a

[GitHub] [cloudstack] GabrielBrascher commented on issue #3730: [WIP DO NOT MERGE] update VR's scripts from python2 to python3

2020-01-05 Thread GitBox
GabrielBrascher commented on issue #3730: [WIP DO NOT MERGE] update VR's scripts from python2 to python3 URL: https://github.com/apache/cloudstack/pull/3730#issuecomment-570969389 @DaanHoogland it still needs some work and testing, therefore, we can wait a bit for reviewing it. I will b

[GitHub] [cloudstack] andrijapanicsb commented on issue #3536: Extract systemvm.iso using bsdtar

2020-01-05 Thread GitBox
andrijapanicsb commented on issue #3536: Extract systemvm.iso using bsdtar URL: https://github.com/apache/cloudstack/pull/3536#issuecomment-570934138 I've tested master, but this is a change, not bugfix, so I say only master @DaanHoogland? -

[GitHub] [cloudstack] andrijapanicsb commented on issue #3031: VMware basic zone VR fails to start and get private IP

2020-01-05 Thread GitBox
andrijapanicsb commented on issue #3031: VMware basic zone VR fails to start and get private IP URL: https://github.com/apache/cloudstack/issues/3031#issuecomment-570933848 whatever we decide, I'm fine with it. This is an au

[GitHub] [cloudstack] msinhore commented on issue #3698: If a zone has two public IPs range in different VLANs, ACS doesn't create a second northbound NIC if needed

2020-01-05 Thread GitBox
msinhore commented on issue #3698: If a zone has two public IPs range in different VLANs, ACS doesn't create a second northbound NIC if needed URL: https://github.com/apache/cloudstack/issues/3698#issuecomment-570932108 @andrijapanicsb I am closing this issue, as you applied the needed

[GitHub] [cloudstack] msinhore closed issue #3698: If a zone has two public IPs range in different VLANs, ACS doesn't create a second northbound NIC if needed

2020-01-05 Thread GitBox
msinhore closed issue #3698: If a zone has two public IPs range in different VLANs, ACS doesn't create a second northbound NIC if needed URL: https://github.com/apache/cloudstack/issues/3698 This is an automated message from

[GitHub] [cloudstack] DaanHoogland commented on issue #3730: [WIP DO NOT MERGE] update VR's scripts from python2 to python3

2020-01-05 Thread GitBox
DaanHoogland commented on issue #3730: [WIP DO NOT MERGE] update VR's scripts from python2 to python3 URL: https://github.com/apache/cloudstack/pull/3730#issuecomment-570919684 @GabrielBrascher can you give an indication on this. as we are out of time for python2 now? how much more work

[GitHub] [cloudstack] DaanHoogland commented on issue #3728: server: double check host capacity when start/migrate a vm

2020-01-05 Thread GitBox
DaanHoogland commented on issue #3728: server: double check host capacity when start/migrate a vm URL: https://github.com/apache/cloudstack/pull/3728#issuecomment-570919075 @andrijapanicsb this one looks good. Want to have a look? (cc @borisstoyanov ) -

[GitHub] [cloudstack] blueorangutan commented on issue #3758: server: Fix NPE while update displayvm on vm with dynamic service offering

2020-01-05 Thread GitBox
blueorangutan commented on issue #3758: server: Fix NPE while update displayvm on vm with dynamic service offering URL: https://github.com/apache/cloudstack/pull/3758#issuecomment-570919070 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke

[GitHub] [cloudstack] DaanHoogland commented on issue #3758: server: Fix NPE while update displayvm on vm with dynamic service offering

2020-01-05 Thread GitBox
DaanHoogland commented on issue #3758: server: Fix NPE while update displayvm on vm with dynamic service offering URL: https://github.com/apache/cloudstack/pull/3758#issuecomment-570919005 errors seem unrelated, trying insanity @blueorangutan test ---

[GitHub] [cloudstack] DaanHoogland commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR

2020-01-05 Thread GitBox
DaanHoogland commented on issue #3477: RvR: Set up metadata/password/dhcp server on gateway IP instead of guest IP in RVR URL: https://github.com/apache/cloudstack/pull/3477#issuecomment-570918506 build failures again "TASK [Remove previous SSH key from Project if it exists] ". Not sure if

[GitHub] [cloudstack] DaanHoogland commented on issue #3031: VMware basic zone VR fails to start and get private IP

2020-01-05 Thread GitBox
DaanHoogland commented on issue #3031: VMware basic zone VR fails to start and get private IP URL: https://github.com/apache/cloudstack/issues/3031#issuecomment-570917970 @andrijapanicsb basic zones are being phased out in favour of shared networks (with security groups) So I think postpon

[GitHub] [cloudstack] DaanHoogland commented on issue #3383: [WIP DO NOT MERGE] template: copy md5 mismatch

2020-01-05 Thread GitBox
DaanHoogland commented on issue #3383: [WIP DO NOT MERGE] template: copy md5 mismatch URL: https://github.com/apache/cloudstack/pull/3383#issuecomment-570917540 @shwstppr can you cherrypick to 4.14 and force push to your branch please? --

[GitHub] [cloudstack] DaanHoogland commented on issue #3536: Extract systemvm.iso using bsdtar

2020-01-05 Thread GitBox
DaanHoogland commented on issue #3536: Extract systemvm.iso using bsdtar URL: https://github.com/apache/cloudstack/pull/3536#issuecomment-570917077 👍 master or first to 4.13? This is an automated message from the Apache Git Se

[GitHub] [cloudstack] andrijapanicsb commented on issue #3383: [WIP DO NOT MERGE] template: copy md5 mismatch

2020-01-05 Thread GitBox
andrijapanicsb commented on issue #3383: [WIP DO NOT MERGE] template: copy md5 mismatch URL: https://github.com/apache/cloudstack/pull/3383#issuecomment-570900948 Agree @DaanHoogland - let's just enable copying the stuff between zones ---

[GitHub] [cloudstack] shwstppr commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

2020-01-05 Thread GitBox
shwstppr commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-570891450 @poussa I'm not well aware with ACS basic zone networking so will have to test it. But from CKS point of view, whatever networking