[GitHub] [cloudstack] shwstppr commented on a change in pull request #3731: [WIP DO NOT MERGE] Enable Direct Download for System VMs

2020-02-22 Thread GitBox
shwstppr commented on a change in pull request #3731: [WIP DO NOT MERGE] Enable Direct Download for System VMs URL: https://github.com/apache/cloudstack/pull/3731#discussion_r382901352 ## File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java ###

[GitHub] [cloudstack] shwstppr commented on a change in pull request #3731: [WIP DO NOT MERGE] Enable Direct Download for System VMs

2020-02-22 Thread GitBox
shwstppr commented on a change in pull request #3731: [WIP DO NOT MERGE] Enable Direct Download for System VMs URL: https://github.com/apache/cloudstack/pull/3731#discussion_r382901352 ## File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java ###

[GitHub] [cloudstack] shwstppr commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

2020-02-22 Thread GitBox
shwstppr commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-589945721 @blueorangutan matrix This is an automated message from the Apach

[GitHub] [cloudstack] shwstppr opened a new pull request #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

2020-02-22 Thread GitBox
shwstppr opened a new pull request #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service URL: https://github.com/apache/cloudstack/pull/3680 ## Description Specification document https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Kubernetes+Service Kubernete

[GitHub] [cloudstack] shwstppr closed pull request #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

2020-02-22 Thread GitBox
shwstppr closed pull request #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service URL: https://github.com/apache/cloudstack/pull/3680 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [cloudstack] DaanHoogland commented on issue #3905: Fix network rules issue if default egress policy is Allow

2020-02-22 Thread GitBox
DaanHoogland commented on issue #3905: Fix network rules issue if default egress policy is Allow URL: https://github.com/apache/cloudstack/pull/3905#issuecomment-589963166 @andrijapanicsb @borisstoyanov @rhtyd any of you care to @blueorangutan test --

[GitHub] [cloudstack] blueorangutan commented on issue #3905: Fix network rules issue if default egress policy is Allow

2020-02-22 Thread GitBox
blueorangutan commented on issue #3905: Fix network rules issue if default egress policy is Allow URL: https://github.com/apache/cloudstack/pull/3905#issuecomment-589963231 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --

[GitHub] [cloudstack] DaanHoogland commented on issue #3903: VR: Send VM password to all Running VRs in network/vpc

2020-02-22 Thread GitBox
DaanHoogland commented on issue #3903: VR: Send VM password to all Running VRs in network/vpc URL: https://github.com/apache/cloudstack/pull/3903#issuecomment-589963307 @blueorangutan package This is an automated message from

[GitHub] [cloudstack] blueorangutan commented on issue #3903: VR: Send VM password to all Running VRs in network/vpc

2020-02-22 Thread GitBox
blueorangutan commented on issue #3903: VR: Send VM password to all Running VRs in network/vpc URL: https://github.com/apache/cloudstack/pull/3903#issuecomment-589963332 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack] DaanHoogland commented on issue #3894: api: Fix count and item issues returned by list APIs

2020-02-22 Thread GitBox
DaanHoogland commented on issue #3894: api: Fix count and item issues returned by list APIs URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-589963459 @blueorangutan package This is an automated message from t

[GitHub] [cloudstack] blueorangutan commented on issue #3894: api: Fix count and item issues returned by list APIs

2020-02-22 Thread GitBox
blueorangutan commented on issue #3894: api: Fix count and item issues returned by list APIs URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-589963511 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] DaanHoogland commented on issue #3890: With pagesize=10 the count returned in the API response is wrong

2020-02-22 Thread GitBox
DaanHoogland commented on issue #3890: With pagesize=10 the count returned in the API response is wrong URL: https://github.com/apache/cloudstack/issues/3890#issuecomment-589963797 @rhtyd I do not really agree with this being a blocker. It is a blocket to primate only. It has been in for e

[GitHub] [cloudstack] DaanHoogland commented on issue #3899: vpc: add bypassvlanoverlapcheck parameter when create private gateway

2020-02-22 Thread GitBox
DaanHoogland commented on issue #3899: vpc: add bypassvlanoverlapcheck parameter when create private gateway URL: https://github.com/apache/cloudstack/pull/3899#issuecomment-589964859 this is a lot of code change for a little functional change, what I've seen so far looks good, but I do wa

[GitHub] [cloudstack] blueorangutan commented on issue #3903: VR: Send VM password to all Running VRs in network/vpc

2020-02-22 Thread GitBox
blueorangutan commented on issue #3903: VR: Send VM password to all Running VRs in network/vpc URL: https://github.com/apache/cloudstack/pull/3903#issuecomment-589965211 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-935 Th

[GitHub] [cloudstack] blueorangutan commented on issue #3894: api: Fix count and item issues returned by list APIs

2020-02-22 Thread GitBox
blueorangutan commented on issue #3894: api: Fix count and item issues returned by list APIs URL: https://github.com/apache/cloudstack/pull/3894#issuecomment-589965368 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-936 This

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3731: [WIP DO NOT MERGE] Enable Direct Download for System VMs

2020-02-22 Thread GitBox
DaanHoogland commented on a change in pull request #3731: [WIP DO NOT MERGE] Enable Direct Download for System VMs URL: https://github.com/apache/cloudstack/pull/3731#discussion_r382919720 ## File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java ###

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3894: api: Fix count and item issues returned by list APIs

2020-02-22 Thread GitBox
rhtyd commented on a change in pull request #3894: api: Fix count and item issues returned by list APIs URL: https://github.com/apache/cloudstack/pull/3894#discussion_r382920487 ## File path: engine/components-api/src/main/java/com/cloud/agent/AgentManager.java ## @@ -152

[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #3894: api: Fix count and item issues returned by list APIs

2020-02-22 Thread GitBox
Pearl1594 commented on a change in pull request #3894: api: Fix count and item issues returned by list APIs URL: https://github.com/apache/cloudstack/pull/3894#discussion_r382920805 ## File path: engine/components-api/src/main/java/com/cloud/agent/AgentManager.java ## @@

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3894: api: Fix count and item issues returned by list APIs

2020-02-22 Thread GitBox
rhtyd commented on a change in pull request #3894: api: Fix count and item issues returned by list APIs URL: https://github.com/apache/cloudstack/pull/3894#discussion_r382921466 ## File path: engine/components-api/src/main/java/com/cloud/agent/AgentManager.java ## @@ -152

[GitHub] [cloudstack] weizhouapache commented on issue #3899: vpc: add bypassvlanoverlapcheck parameter when create private gateway

2020-02-22 Thread GitBox
weizhouapache commented on issue #3899: vpc: add bypassvlanoverlapcheck parameter when create private gateway URL: https://github.com/apache/cloudstack/pull/3899#issuecomment-589992713 > this is a lot of code change for a little functional change, what I've seen so far looks good, but I do

[GitHub] [cloudstack] shwstppr commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

2020-02-22 Thread GitBox
shwstppr commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-58943 @blueorangutan matrix This is an automated message from the Apach

[GitHub] [cloudstack] shwstppr removed a comment on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

2020-02-22 Thread GitBox
shwstppr removed a comment on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-58943 @blueorangutan matrix This is an automated message from t

[GitHub] [cloudstack] shwstppr removed a comment on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

2020-02-22 Thread GitBox
shwstppr removed a comment on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-589945721 @blueorangutan matrix This is an automated message from t

[GitHub] [cloudstack] shwstppr commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

2020-02-22 Thread GitBox
shwstppr commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-59102 @blueorangutan test matrix This is an automated message from the

[GitHub] [cloudstack] blueorangutan commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

2020-02-22 Thread GitBox
blueorangutan commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-59161 @shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been ki

[GitHub] [cloudstack] blueorangutan commented on issue #3905: Fix network rules issue if default egress policy is Allow

2020-02-22 Thread GitBox
blueorangutan commented on issue #3905: Fix network rules issue if default egress policy is Allow URL: https://github.com/apache/cloudstack/pull/3905#issuecomment-590005263 Trillian test result (tid-1083) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time