[GitHub] [cloudstack] blueorangutan commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier

2020-03-13 Thread GitBox
blueorangutan commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier URL: https://github.com/apache/cloudstack/pull/3587#issuecomment-598998590 Trillian test result (tid-1243) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7

[GitHub] [cloudstack] blueorangutan commented on issue #3839: FEATURE-3823: kvm agent hooks

2020-03-13 Thread GitBox
blueorangutan commented on issue #3839: FEATURE-3823: kvm agent hooks URL: https://github.com/apache/cloudstack/pull/3839#issuecomment-598977985 Trillian test result (tid-1242) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44040 seconds Marv

[GitHub] [cloudstack] blueorangutan commented on issue #3839: FEATURE-3823: kvm agent hooks

2020-03-13 Thread GitBox
blueorangutan commented on issue #3839: FEATURE-3823: kvm agent hooks URL: https://github.com/apache/cloudstack/pull/3839#issuecomment-598964166 @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -

[GitHub] [cloudstack] andrijapanicsb commented on issue #3839: FEATURE-3823: kvm agent hooks

2020-03-13 Thread GitBox
andrijapanicsb commented on issue #3839: FEATURE-3823: kvm agent hooks URL: https://github.com/apache/cloudstack/pull/3839#issuecomment-598964055 @blueorangutan test This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] blueorangutan commented on issue #3839: FEATURE-3823: kvm agent hooks

2020-03-13 Thread GitBox
blueorangutan commented on issue #3839: FEATURE-3823: kvm agent hooks URL: https://github.com/apache/cloudstack/pull/3839#issuecomment-598963097 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1051 This is an automated messag

[GitHub] [cloudstack] blueorangutan commented on issue #3839: FEATURE-3823: kvm agent hooks

2020-03-13 Thread GitBox
blueorangutan commented on issue #3839: FEATURE-3823: kvm agent hooks URL: https://github.com/apache/cloudstack/pull/3839#issuecomment-598956319 @andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack] andrijapanicsb commented on issue #3839: FEATURE-3823: kvm agent hooks

2020-03-13 Thread GitBox
andrijapanicsb commented on issue #3839: FEATURE-3823: kvm agent hooks URL: https://github.com/apache/cloudstack/pull/3839#issuecomment-598956232 @blueorangutan package This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] andrijapanicsb edited a comment on issue #3600: Allow deploy Admin VMs annd VRs in disabled zones/pods/clusters

2020-03-13 Thread GitBox
andrijapanicsb edited a comment on issue #3600: Allow deploy Admin VMs annd VRs in disabled zones/pods/clusters URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-598869031 Last ping @GabrielBrascher :) - any chance to resolve this? Otherwise I shall move it to 4.15?

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3946: server: add global configuration for default router service offering

2020-03-13 Thread GitBox
DaanHoogland commented on a change in pull request #3946: server: add global configuration for default router service offering URL: https://github.com/apache/cloudstack/pull/3946#discussion_r392508300 ## File path: server/src/main/java/org/cloud/network/router/deployment/RouterDepl

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #3946: server: add global configuration for default router service offering

2020-03-13 Thread GitBox
weizhouapache commented on a change in pull request #3946: server: add global configuration for default router service offering URL: https://github.com/apache/cloudstack/pull/3946#discussion_r392476198 ## File path: server/src/main/java/org/cloud/network/router/deployment/RouterDep

[GitHub] [cloudstack] ustcweizhou opened a new pull request #3946: server: add global configuration for default router service offering

2020-03-13 Thread GitBox
ustcweizhou opened a new pull request #3946: server: add global configuration for default router service offering URL: https://github.com/apache/cloudstack/pull/3946 ## Description This adds a global setting router.service.offering, which can be uuid of a system offering. th

[GitHub] [cloudstack] weizhouapache closed pull request #3946: server: add global configuration for default router service offering

2020-03-13 Thread GitBox
weizhouapache closed pull request #3946: server: add global configuration for default router service offering URL: https://github.com/apache/cloudstack/pull/3946 This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] andrijapanicsb merged pull request #3638: UEFI Support on CloudStack

2020-03-13 Thread GitBox
andrijapanicsb merged pull request #3638: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[cloudstack] branch master updated: UEFI Implementation: Enabled UEFI Support for Guest VM's on Hypervisor KVM, VMware. enabled boot modes [Legacy, Secure] support for UEFI boot with known caveats. (#

2020-03-13 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new d4b537e UEFI Implementation: Enabled

[GitHub] [cloudstack] andrijapanicsb commented on issue #3638: UEFI Support on CloudStack

2020-03-13 Thread GitBox
andrijapanicsb commented on issue #3638: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#issuecomment-59044 3 x Approvals, regression tests went fine. Merging This is an automated mess

[GitHub] [cloudstack] blueorangutan commented on issue #3638: UEFI Support on CloudStack

2020-03-13 Thread GitBox
blueorangutan commented on issue #3638: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#issuecomment-598887559 Trillian test result (tid-1241) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33201 seconds Marvin

[GitHub] [cloudstack] andrijapanicsb commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier

2020-03-13 Thread GitBox
andrijapanicsb commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier URL: https://github.com/apache/cloudstack/pull/3587#issuecomment-598876495 Will merge if tests are finished with no errors, despite the freeze date, as everything else is OK atm (

[GitHub] [cloudstack] DaanHoogland commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier

2020-03-13 Thread GitBox
DaanHoogland commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier URL: https://github.com/apache/cloudstack/pull/3587#issuecomment-598872046 nothing outstanding, LGTM*2 and tested. let's merge when the monkey agrees. --

[GitHub] [cloudstack] andrijapanicsb commented on issue #3638: UEFI Support on CloudStack

2020-03-13 Thread GitBox
andrijapanicsb commented on issue #3638: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#issuecomment-598869827 Blue monkey, where are the results on this one??? This is an automated message from

[GitHub] [cloudstack] andrijapanicsb commented on issue #3839: FEATURE-3823: kvm agent hooks

2020-03-13 Thread GitBox
andrijapanicsb commented on issue #3839: FEATURE-3823: kvm agent hooks URL: https://github.com/apache/cloudstack/pull/3839#issuecomment-598869586 Waiting for tests results, and if all good, will merge regardless of the freeze date (as approvals and everything else is good atm)

[GitHub] [cloudstack] andrijapanicsb commented on issue #3600: Allow deploy Admin VMs annd VRs in disabled zones/pods/clusters

2020-03-13 Thread GitBox
andrijapanicsb commented on issue #3600: Allow deploy Admin VMs annd VRs in disabled zones/pods/clusters URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-598869031 Last ping @GabrielBrascher :) - any change to resolve this? Otherwise I shall move it to 4.15? ---

[cloudstack] branch master updated (4ca69ac -> b949280)

2020-03-13 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 4ca69ac Validate disk offering IOPS normal and maximum read/write values (#3681) add b949280 Rename

[GitHub] [cloudstack] andrijapanicsb commented on issue #3960: Rename max.retries setting

2020-03-13 Thread GitBox
andrijapanicsb commented on issue #3960: Rename max.retries setting URL: https://github.com/apache/cloudstack/pull/3960#issuecomment-598868020 2 x LGTMS, test results passing, merging. This is an automated message from the

[GitHub] [cloudstack] andrijapanicsb merged pull request #3960: Rename max.retries setting

2020-03-13 Thread GitBox
andrijapanicsb merged pull request #3960: Rename max.retries setting URL: https://github.com/apache/cloudstack/pull/3960 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [cloudstack] nvazquez commented on issue #3956: maven quality tool plugins

2020-03-13 Thread GitBox
nvazquez commented on issue #3956: maven quality tool plugins URL: https://github.com/apache/cloudstack/pull/3956#issuecomment-598867345 @DaanHoogland I got this error when building (with update dependecies flag) [INFO]

[GitHub] [cloudstack] andrijapanicsb commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat

2020-03-13 Thread GitBox
andrijapanicsb commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-598866950 This one needs more love, and since we are few h away from code freeze, moving it to 4.13.2 milestone

[GitHub] [cloudstack] andrijapanicsb commented on issue #3932: Prevent overflow on StatsCollector.java

2020-03-13 Thread GitBox
andrijapanicsb commented on issue #3932: Prevent overflow on StatsCollector.java URL: https://github.com/apache/cloudstack/pull/3932#issuecomment-598865670 2 x LGTMs, all tests passing (those privategtw tests are "OK", fixed in newer ACS code - this PR is 150+ commits behind master)

[GitHub] [cloudstack] andrijapanicsb merged pull request #3932: Prevent overflow on StatsCollector.java

2020-03-13 Thread GitBox
andrijapanicsb merged pull request #3932: Prevent overflow on StatsCollector.java URL: https://github.com/apache/cloudstack/pull/3932 This is an automated message from the Apache Git Service. To respond to the message, pleas

[cloudstack] branch 4.13 updated: Prevent overflow on StatsCollector + add a few enhancements on code (#3932)

2020-03-13 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a commit to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.13 by this push: new cd6f0cb Prevent overflow on StatsCollecto

[cloudstack] branch master updated (c44539f -> 4ca69ac)

2020-03-13 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from c44539f Make text clear regarding removing data disks. (#3962) add 4ca69ac Validate disk offering IO

[GitHub] [cloudstack] andrijapanicsb commented on issue #3681: Validate disk offering IOPS normal and maximum read/write values

2020-03-13 Thread GitBox
andrijapanicsb commented on issue #3681: Validate disk offering IOPS normal and maximum read/write values URL: https://github.com/apache/cloudstack/pull/3681#issuecomment-598864792 2 x LGTM, tests passing fine. Merging

[GitHub] [cloudstack] andrijapanicsb merged pull request #3681: Validate disk offering IOPS normal and maximum read/write values

2020-03-13 Thread GitBox
andrijapanicsb merged pull request #3681: Validate disk offering IOPS normal and maximum read/write values URL: https://github.com/apache/cloudstack/pull/3681 This is an automated message from the Apache Git Service. To resp

[GitHub] [cloudstack] blueorangutan commented on issue #3960: Rename max.retries setting

2020-03-13 Thread GitBox
blueorangutan commented on issue #3960: Rename max.retries setting URL: https://github.com/apache/cloudstack/pull/3960#issuecomment-598862080 Trillian test result (tid-1240) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35656 seconds Marvin

[GitHub] [cloudstack] andrijapanicsb commented on issue #3960: Rename max.retries setting

2020-03-13 Thread GitBox
andrijapanicsb commented on issue #3960: Rename max.retries setting URL: https://github.com/apache/cloudstack/pull/3960#issuecomment-598860816 Tests are complete from the previous run where shwstppr (author of the failing test) has confirmed it's not realted to this PR. Nevertheless, new

[GitHub] [cloudstack] DaanHoogland opened a new issue #3966: fix logs and modularisation leftovers from #3638

2020-03-13 Thread GitBox
DaanHoogland opened a new issue #3966: fix logs and modularisation leftovers from #3638 URL: https://github.com/apache/cloudstack/issues/3966 @pavanaravapalli creating this issue, please deal with the comments left there. # ISSUE TYPE * Improvement Request * Othe

[GitHub] [cloudstack] pavanaravapalli commented on issue #3638: UEFI Support on CloudStack

2020-03-13 Thread GitBox
pavanaravapalli commented on issue #3638: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#issuecomment-598828278 > @pavanaravapalli I don't think you had anymore functional changes to make so it is fine by me to leave thos fixes for a new PR after this one.

[GitHub] [cloudstack] DaanHoogland commented on issue #3649: Garbage snapshots are left on Primary and Secondary

2020-03-13 Thread GitBox
DaanHoogland commented on issue #3649: Garbage snapshots are left on Primary and Secondary URL: https://github.com/apache/cloudstack/pull/3649#issuecomment-598820496 you have trailing whitespaces in `KVMStorageProcessor` @GabrielBrascher , checkstyle is objecting.

[GitHub] [cloudstack] nvazquez commented on issue #3956: maven quality tool plugins

2020-03-13 Thread GitBox
nvazquez commented on issue #3956: maven quality tool plugins URL: https://github.com/apache/cloudstack/pull/3956#issuecomment-598819004 @DaanHoogland I'm hitting this error when building: [INFO] [IN

[GitHub] [cloudstack] nvazquez removed a comment on issue #3956: maven quality tool plugins

2020-03-13 Thread GitBox
nvazquez removed a comment on issue #3956: maven quality tool plugins URL: https://github.com/apache/cloudstack/pull/3956#issuecomment-598819004 @DaanHoogland I'm hitting this error when building: [INFO] ---

[GitHub] [cloudstack] Slair1 commented on issue #3654: Remote VPN not working if site-to-site VPN exists

2020-03-13 Thread GitBox
Slair1 commented on issue #3654: Remote VPN not working if site-to-site VPN exists URL: https://github.com/apache/cloudstack/issues/3654#issuecomment-598818417 What's the secret to getting virtualbox to boot from the existing qcow2 virtual disk? We just receive "FATAL" Could not read

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3946: server: add global configuration for default router service offering

2020-03-13 Thread GitBox
DaanHoogland commented on a change in pull request #3946: server: add global configuration for default router service offering URL: https://github.com/apache/cloudstack/pull/3946#discussion_r392351506 ## File path: server/src/main/java/org/cloud/network/router/deployment/RouterDepl

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #3946: server: add global configuration for default router service offering

2020-03-13 Thread GitBox
weizhouapache commented on a change in pull request #3946: server: add global configuration for default router service offering URL: https://github.com/apache/cloudstack/pull/3946#discussion_r392347103 ## File path: server/src/main/java/org/cloud/network/router/deployment/RouterDep

[GitHub] [cloudstack] DaanHoogland commented on issue #3956: maven quality tool plugins

2020-03-13 Thread GitBox
DaanHoogland commented on issue #3956: maven quality tool plugins URL: https://github.com/apache/cloudstack/pull/3956#issuecomment-598814046 ping @weizhouapache @kiwiflyer @GabrielBrascher @rhtyd @nathanejohnson @andrijapanic-dont-use-this-one @svenvogel @wido this is ready for review. ---

[GitHub] [cloudstack] DaanHoogland commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier

2020-03-13 Thread GitBox
DaanHoogland commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier URL: https://github.com/apache/cloudstack/pull/3587#issuecomment-598812881 @blueorangutan test This is an automated

[GitHub] [cloudstack] blueorangutan commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier

2020-03-13 Thread GitBox
blueorangutan commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier URL: https://github.com/apache/cloudstack/pull/3587#issuecomment-598813120 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] DaanHoogland commented on issue #3962: Make text clear regarding removing data disks.

2020-03-13 Thread GitBox
DaanHoogland commented on issue #3962: Make text clear regarding removing data disks. URL: https://github.com/apache/cloudstack/pull/3962#issuecomment-598812579 I think this is a fix for a feature not in 4.13, @weizhouapache . cc @PaulAngus ?

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3946: server: add global configuration for default router service offering

2020-03-13 Thread GitBox
DaanHoogland commented on a change in pull request #3946: server: add global configuration for default router service offering URL: https://github.com/apache/cloudstack/pull/3946#discussion_r392342652 ## File path: server/src/main/java/org/cloud/network/router/deployment/RouterDepl

[GitHub] [cloudstack] ustcweizhou opened a new pull request #3965: server: Honor vm.destroy.forcestop when expunge a vm

2020-03-13 Thread GitBox
ustcweizhou opened a new pull request #3965: server: Honor vm.destroy.forcestop when expunge a vm URL: https://github.com/apache/cloudstack/pull/3965 ## Description When expunge a Running vm, vm will be stopped with forcestop=false which does not make sense. we should honor vm.d

[GitHub] [cloudstack] blueorangutan commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier

2020-03-13 Thread GitBox
blueorangutan commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier URL: https://github.com/apache/cloudstack/pull/3587#issuecomment-598808919 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1050 ---

[GitHub] [cloudstack] weizhouapache commented on issue #3962: Make text clear regarding removing data disks.

2020-03-13 Thread GitBox
weizhouapache commented on issue #3962: Make text clear regarding removing data disks. URL: https://github.com/apache/cloudstack/pull/3962#issuecomment-598807592 how about 4.13 ? This is an automated message from the Apac

[GitHub] [cloudstack] weizhouapache commented on issue #3946: server: add global configuration for default router service offering

2020-03-13 Thread GitBox
weizhouapache commented on issue #3946: server: add global configuration for default router service offering URL: https://github.com/apache/cloudstack/pull/3946#issuecomment-598806841 updated based on @harikrishna-patnala 's comment -

[cloudstack] branch master updated (32b509a -> c44539f)

2020-03-13 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 32b509a Handle port forward rule check for vpc and non vpc Isolated net… (#3963) add c44539f Make text clea

[GitHub] [cloudstack] DaanHoogland merged pull request #3962: Make text clear regarding removing data disks.

2020-03-13 Thread GitBox
DaanHoogland merged pull request #3962: Make text clear regarding removing data disks. URL: https://github.com/apache/cloudstack/pull/3962 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] DaanHoogland commented on issue #3962: Make text clear regarding removing data disks.

2020-03-13 Thread GitBox
DaanHoogland commented on issue #3962: Make text clear regarding removing data disks. URL: https://github.com/apache/cloudstack/pull/3962#issuecomment-598805062 packaging works, textual and UI only, merging... This is an auto

[GitHub] [cloudstack] DaanHoogland commented on issue #3638: UEFI Support on CloudStack

2020-03-13 Thread GitBox
DaanHoogland commented on issue #3638: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#issuecomment-598802754 @pavanaravapalli I don't think you had anymore functional changes to make so it is fine by me to leave thos fixes for a new PR after this one. --

[GitHub] [cloudstack] DaanHoogland commented on issue #3638: UEFI Support on CloudStack

2020-03-13 Thread GitBox
DaanHoogland commented on issue #3638: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#issuecomment-598802214 @pavanaravapalli that sounds strange. maybe you can check out again and than cherry-pick your changes and push? git branch -m uefisupport uefisuppo

[GitHub] [cloudstack] pavanaravapalli commented on issue #3638: UEFI Support on CloudStack

2020-03-13 Thread GitBox
pavanaravapalli commented on issue #3638: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#issuecomment-598800479 > > @DaanHoogland > > I will check the changes suggested and update here. > > @pavanaravapalli it would be nice if you can make it today (

[GitHub] [cloudstack] DaanHoogland commented on issue #3638: UEFI Support on CloudStack

2020-03-13 Thread GitBox
DaanHoogland commented on issue #3638: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#issuecomment-598800436 @andrijapanicsb @nathanejohnson had said he would test and than LGTM'd so I'm assuming that is on the basis of his tests (and also I spoke him on othe

[GitHub] [cloudstack] blueorangutan commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier

2020-03-13 Thread GitBox
blueorangutan commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier URL: https://github.com/apache/cloudstack/pull/3587#issuecomment-598798167 @andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] andrijapanicsb commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier

2020-03-13 Thread GitBox
andrijapanicsb commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier URL: https://github.com/apache/cloudstack/pull/3587#issuecomment-598797780 @blueorangutan package This is an autom

[GitHub] [cloudstack] ustcweizhou opened a new pull request #3955: docker: upgrade to ubuntu 18.04 and fix some issues

2020-03-13 Thread GitBox
ustcweizhou opened a new pull request #3955: docker: upgrade to ubuntu 18.04 and fix some issues URL: https://github.com/apache/cloudstack/pull/3955 ## Description upgrade dockerfile to use ubuntu 18.04 instead of ubuntu 16.04 because we use java 11 in 4.14. meanw

[GitHub] [cloudstack] weizhouapache closed pull request #3955: docker: upgrade to ubuntu 18.04 and fix some issues

2020-03-13 Thread GitBox
weizhouapache closed pull request #3955: docker: upgrade to ubuntu 18.04 and fix some issues URL: https://github.com/apache/cloudstack/pull/3955 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [cloudstack] weizhouapache commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier

2020-03-13 Thread GitBox
weizhouapache commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier URL: https://github.com/apache/cloudstack/pull/3587#issuecomment-598792466 @andrijapanicsb tested with isolated networks and vpc with redundant VRs. both work fine. It is ready

[GitHub] [cloudstack] andrijapanicsb commented on issue #3638: UEFI Support on CloudStack

2020-03-13 Thread GitBox
andrijapanicsb commented on issue #3638: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#issuecomment-598779813 I would love to see this in 4.14, and apologies if I missed something - has this been tested by anyone (except the author) @nathanejohnson?

[GitHub] [cloudstack] DaanHoogland commented on issue #3638: UEFI Support on CloudStack

2020-03-13 Thread GitBox
DaanHoogland commented on issue #3638: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#issuecomment-598737109 As this is functionaly ready and approved by parties all over the world I'm moving this back to the 4.14 milestone --

[GitHub] [cloudstack] DaanHoogland commented on issue #3956: maven quality tool plugins

2020-03-13 Thread GitBox
DaanHoogland commented on issue #3956: maven quality tool plugins URL: https://github.com/apache/cloudstack/pull/3956#issuecomment-598724323 @rhtyd @weizhouapache @GabrielBrascher finally apache builds gave a positive again on this maven update. can you approve? cc @svenvogel @PaulAngus

[GitHub] [cloudstack] ArthurHlt commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier

2020-03-13 Thread GitBox
ArthurHlt commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier URL: https://github.com/apache/cloudstack/pull/3587#issuecomment-598722326 @weizhouapache done This is an automated mes

[GitHub] [cloudstack] ArthurHlt edited a comment on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier

2020-03-13 Thread GitBox
ArthurHlt edited a comment on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier URL: https://github.com/apache/cloudstack/pull/3587#issuecomment-598722326 @weizhouapache done ;) This is an aut

[GitHub] [cloudstack] andrijapanicsb commented on issue #3960: Rename max.retries setting

2020-03-13 Thread GitBox
andrijapanicsb commented on issue #3960: Rename max.retries setting URL: https://github.com/apache/cloudstack/pull/3960#issuecomment-598693420 Will probably wait for tests to complete before the code freeze, unless you are 100% sure @shwstppr that we can proceed? --

[GitHub] [cloudstack] andrijapanicsb closed pull request #3961: Reduce nonsence value for capacity.skipcounting.hours

2020-03-13 Thread GitBox
andrijapanicsb closed pull request #3961: Reduce nonsence value for capacity.skipcounting.hours URL: https://github.com/apache/cloudstack/pull/3961 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] andrijapanicsb commented on issue #3961: Reduce nonsence value for capacity.skipcounting.hours

2020-03-13 Thread GitBox
andrijapanicsb commented on issue #3961: Reduce nonsence value for capacity.skipcounting.hours URL: https://github.com/apache/cloudstack/pull/3961#issuecomment-598693021 Closed due to not being able to accomplish the full goal - as discussed in #3942 -

[GitHub] [cloudstack] andrijapanicsb commented on issue #3942: Host reports RAM allocated, when no running VMs

2020-03-13 Thread GitBox
andrijapanicsb commented on issue #3942: Host reports RAM allocated, when no running VMs URL: https://github.com/apache/cloudstack/issues/3942#issuecomment-598692706 My attempt to avoid edge case is useless here, as the implementation of those capacity cheks is such that I can't acomplish

[GitHub] [cloudstack] andrijapanicsb closed issue #3942: Host reports RAM allocated, when no running VMs

2020-03-13 Thread GitBox
andrijapanicsb closed issue #3942: Host reports RAM allocated, when no running VMs URL: https://github.com/apache/cloudstack/issues/3942 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [cloudstack] andrijapanicsb edited a comment on issue #3942: Host reports RAM allocated, when no running VMs

2020-03-13 Thread GitBox
andrijapanicsb edited a comment on issue #3942: Host reports RAM allocated, when no running VMs URL: https://github.com/apache/cloudstack/issues/3942#issuecomment-598692706 My attempt to avoid edge case is useless here, as the implementation of those capacity cheks is such that I can't acc

[GitHub] [cloudstack] andrijapanicsb commented on issue #3937: VR Port Forward rule check on Non-VPC Isolated networks

2020-03-13 Thread GitBox
andrijapanicsb commented on issue #3937: VR Port Forward rule check on Non-VPC Isolated networks URL: https://github.com/apache/cloudstack/pull/3937#issuecomment-598692033 This one was implemented via simpler fix, as discussed on #3952 - via https://github.com/apache/cloudstack/pull/3963

[GitHub] [cloudstack] andrijapanicsb closed pull request #3937: VR Port Forward rule check on Non-VPC Isolated networks

2020-03-13 Thread GitBox
andrijapanicsb closed pull request #3937: VR Port Forward rule check on Non-VPC Isolated networks URL: https://github.com/apache/cloudstack/pull/3937 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [cloudstack] andrijapanicsb commented on issue #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

2020-03-13 Thread GitBox
andrijapanicsb commented on issue #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-598691565 @weizhouapache the PR was made, tested (by you and @Pearl1594 - thanks ) and merged - here https://githu

[GitHub] [cloudstack] DaanHoogland opened a new pull request #3956: maven quality tool plugins

2020-03-13 Thread GitBox
DaanHoogland opened a new pull request #3956: maven quality tool plugins URL: https://github.com/apache/cloudstack/pull/3956 ## Description owasp dependency checker and other tools during the site build phase to be able to add them to apache jenkins. inluding updates and cleanups.

[GitHub] [cloudstack] DaanHoogland closed pull request #3956: maven quality tool plugins

2020-03-13 Thread GitBox
DaanHoogland closed pull request #3956: maven quality tool plugins URL: https://github.com/apache/cloudstack/pull/3956 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [cloudstack] blueorangutan commented on issue #3839: FEATURE-3823: kvm agent hooks

2020-03-13 Thread GitBox
blueorangutan commented on issue #3839: FEATURE-3823: kvm agent hooks URL: https://github.com/apache/cloudstack/pull/3839#issuecomment-598675501 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests ---

[GitHub] [cloudstack] DaanHoogland commented on issue #3839: FEATURE-3823: kvm agent hooks

2020-03-13 Thread GitBox
DaanHoogland commented on issue #3839: FEATURE-3823: kvm agent hooks URL: https://github.com/apache/cloudstack/pull/3839#issuecomment-598675120 @blueorangutan test This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] weizhouapache commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier

2020-03-13 Thread GitBox
weizhouapache commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier URL: https://github.com/apache/cloudstack/pull/3587#issuecomment-598661736 @ArthurHlt can you remove some unused import ? --

[GitHub] [cloudstack] blueorangutan commented on issue #3839: FEATURE-3823: kvm agent hooks

2020-03-13 Thread GitBox
blueorangutan commented on issue #3839: FEATURE-3823: kvm agent hooks URL: https://github.com/apache/cloudstack/pull/3839#issuecomment-598660103 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1048 This is an automated messag

[GitHub] [cloudstack] blueorangutan commented on issue #3649: Garbage snapshots are left on Primary and Secondary

2020-03-13 Thread GitBox
blueorangutan commented on issue #3649: Garbage snapshots are left on Primary and Secondary URL: https://github.com/apache/cloudstack/pull/3649#issuecomment-598660099 Packaging result: ✖centos6 ✖centos7 ✖debian. JID-1049 This

[GitHub] [cloudstack] blueorangutan commented on issue #3638: UEFI Support on CloudStack

2020-03-13 Thread GitBox
blueorangutan commented on issue #3638: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#issuecomment-598649356 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --

[GitHub] [cloudstack] DaanHoogland commented on issue #3638: UEFI Support on CloudStack

2020-03-13 Thread GitBox
DaanHoogland commented on issue #3638: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#issuecomment-598649188 @blueorangutan test This is an automated message from the Apache Git Service. To resp

[GitHub] [cloudstack] blueorangutan commented on issue #3649: Garbage snapshots are left on Primary and Secondary

2020-03-13 Thread GitBox
blueorangutan commented on issue #3649: Garbage snapshots are left on Primary and Secondary URL: https://github.com/apache/cloudstack/pull/3649#issuecomment-598648988 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] [cloudstack] DaanHoogland commented on issue #3649: Garbage snapshots are left on Primary and Secondary

2020-03-13 Thread GitBox
DaanHoogland commented on issue #3649: Garbage snapshots are left on Primary and Secondary URL: https://github.com/apache/cloudstack/pull/3649#issuecomment-598648748 @blueorangutan package This is an automated message from th

[GitHub] [cloudstack] blueorangutan commented on issue #3839: FEATURE-3823: kvm agent hooks

2020-03-13 Thread GitBox
blueorangutan commented on issue #3839: FEATURE-3823: kvm agent hooks URL: https://github.com/apache/cloudstack/pull/3839#issuecomment-598648611 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] DaanHoogland commented on issue #3839: FEATURE-3823: kvm agent hooks

2020-03-13 Thread GitBox
DaanHoogland commented on issue #3839: FEATURE-3823: kvm agent hooks URL: https://github.com/apache/cloudstack/pull/3839#issuecomment-598648306 @blueorangutan package This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack] weizhouapache commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier

2020-03-13 Thread GitBox
weizhouapache commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier URL: https://github.com/apache/cloudstack/pull/3587#issuecomment-598645067 @andrijapanicsb I will test it. This is

[GitHub] [cloudstack] andrijapanicsb commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier

2020-03-13 Thread GitBox
andrijapanicsb commented on issue #3587: vrouter in redundant mode acquire guest ips from first ip of the tier URL: https://github.com/apache/cloudstack/pull/3587#issuecomment-598642986 ping @weizhouapache - any chance to get it in today? ---

[GitHub] [cloudstack] andrijapanicsb commented on issue #3600: Allow deploy Admin VMs annd VRs in disabled zones/pods/clusters

2020-03-13 Thread GitBox
andrijapanicsb commented on issue #3600: Allow deploy Admin VMs annd VRs in disabled zones/pods/clusters URL: https://github.com/apache/cloudstack/pull/3600#issuecomment-598642221 ping @GabrielBrascher freeze incoming in 13-14h :) any update? And there is a conflict. -

[GitHub] [cloudstack] bwsw commented on a change in pull request #3839: FEATURE-3823: kvm agent hooks

2020-03-13 Thread GitBox
bwsw commented on a change in pull request #3839: FEATURE-3823: kvm agent hooks URL: https://github.com/apache/cloudstack/pull/3839#discussion_r392129113 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtStopCommandWrapper.java ###

[GitHub] [cloudstack] blueorangutan commented on issue #3963: Handle port forward rule check for vpc and non vpc Isolated networks

2020-03-13 Thread GitBox
blueorangutan commented on issue #3963: Handle port forward rule check for vpc and non vpc Isolated networks URL: https://github.com/apache/cloudstack/pull/3963#issuecomment-598638667 Trillian test result (tid-1239) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7

[GitHub] [cloudstack] weizhouapache commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat

2020-03-13 Thread GitBox
weizhouapache commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-598637874 > @weizhouapache is this issue/bug visible only when no sourceNat on the network? @andrijapanic

[GitHub] [cloudstack] andrijapanicsb commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat

2020-03-13 Thread GitBox
andrijapanicsb commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-598633981 @weizhouapache is this issue/bug visible only when no sourceNat on the network?

[GitHub] [cloudstack] DaanHoogland opened a new pull request #3956: maven quality tool plugins

2020-03-13 Thread GitBox
DaanHoogland opened a new pull request #3956: maven quality tool plugins URL: https://github.com/apache/cloudstack/pull/3956 ## Description owasp dependency checker and other tools during the site build phase to be able to add them to apache jenkins. inluding updates and cleanups.

[GitHub] [cloudstack] DaanHoogland closed pull request #3956: maven quality tool plugins

2020-03-13 Thread GitBox
DaanHoogland closed pull request #3956: maven quality tool plugins URL: https://github.com/apache/cloudstack/pull/3956 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [cloudstack] andrijapanicsb edited a comment on issue #3031: VMware basic zone VR fails to start and get private IP

2020-03-13 Thread GitBox
andrijapanicsb edited a comment on issue #3031: VMware basic zone VR fails to start and get private IP URL: https://github.com/apache/cloudstack/issues/3031#issuecomment-598623622 @rhtyd @PaulAngus we need this one done before 4.14 is out Any suggestions? /cc @DaanHoogland

  1   2   >