[GitHub] [cloudstack] rhtyd commented on a change in pull request #4071: Dynamic roles improvements

2020-06-09 Thread GitBox
rhtyd commented on a change in pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#discussion_r437203881 ## File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql ## @@ -18,3 +18,81 @@ --; -- Schema upgrade from 4.14.0.0 to 4.15.0.

[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4003: Logging framework to use only log4j

2020-06-09 Thread GitBox
harikrishna-patnala commented on pull request #4003: URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-640763442 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [cloudstack] blueorangutan commented on pull request #4135: Remove use of blacklist/whitelist terms

2020-06-09 Thread GitBox
blueorangutan commented on pull request #4135: URL: https://github.com/apache/cloudstack/pull/4135#issuecomment-640790750 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [cloudstack] vladimirpetrov commented on pull request #4117: [VMware] Explicitly controlling VM hardware version

2020-06-09 Thread GitBox
vladimirpetrov commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-640681675 The following tests have passed successfully: - Datacenter - version not set, Cluster version not set - hardware version reported as the host's - OK - Datacente

[GitHub] [cloudstack] shwstppr commented on pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly

2020-06-09 Thread GitBox
shwstppr commented on pull request #4109: URL: https://github.com/apache/cloudstack/pull/4109#issuecomment-641258592 Packaging OK! This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [cloudstack] blueorangutan commented on pull request #4007: Restarting all networks that needs a restart in a VPC

2020-06-09 Thread GitBox
blueorangutan commented on pull request #4007: URL: https://github.com/apache/cloudstack/pull/4007#issuecomment-640998555 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests Thi

[GitHub] [cloudstack] rhtyd commented on pull request #4131: Health Checkplease don't merge this

2020-06-09 Thread GitBox
rhtyd commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-640998970 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [cloudstack] rhtyd commented on pull request #4104: Debian10 support

2020-06-09 Thread GitBox
rhtyd commented on pull request #4104: URL: https://github.com/apache/cloudstack/pull/4104#issuecomment-640995834 Checked test failures not related to this PR on XenServer, overall all tests have passed. This is an automated

[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8 Support

2020-06-09 Thread GitBox
rhtyd commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-641172607 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [cloudstack] rhtyd commented on pull request #4007: Restarting all networks that needs a restart in a VPC

2020-06-09 Thread GitBox
rhtyd commented on pull request #4007: URL: https://github.com/apache/cloudstack/pull/4007#issuecomment-640998275 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [cloudstack] blueorangutan commented on pull request #4003: Logging framework to use only log4j

2020-06-09 Thread GitBox
blueorangutan commented on pull request #4003: URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-640763889 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [cloudstack] blueorangutan commented on pull request #4130: Fixed null pointer after deleting snapshot, GC and cross cluster vm migration on XCP-NG

2020-06-09 Thread GitBox
blueorangutan commented on pull request #4130: URL: https://github.com/apache/cloudstack/pull/4130#issuecomment-640999655 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests Thi

[GitHub] [cloudstack] shwstppr commented on pull request #4115: cks: fix k8s cluster deployment planner

2020-06-09 Thread GitBox
shwstppr commented on pull request #4115: URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-641113846 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [cloudstack] PaulAngus commented on a change in pull request #4135: Remove use of blacklist/whitelist terms

2020-06-09 Thread GitBox
PaulAngus commented on a change in pull request #4135: URL: https://github.com/apache/cloudstack/pull/4135#discussion_r436992105 ## File path: api/src/main/java/org/apache/cloudstack/query/QueryService.java ## @@ -94,8 +94,8 @@ ConfigKey AllowUserViewDestroyedVM = new Conf

[GitHub] [cloudstack] PaulAngus commented on pull request #4003: Logging framework to use only log4j

2020-06-09 Thread GitBox
PaulAngus commented on pull request #4003: URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-640740145 @DaanHoogland have your comments bee addressed ? if yes @harikrishna-patnala can you repackage and kick the smoke test matrix? --

[GitHub] [cloudstack] Slair1 commented on issue #3138: StrongSwan with several rightsubnet's - ikev1

2020-06-09 Thread GitBox
Slair1 commented on issue #3138: URL: https://github.com/apache/cloudstack/issues/3138#issuecomment-640910495 @ggoodrich-ipp could you upload a PR to address this? We have had this fixed in our environment for a while now.

[GitHub] [cloudstack] rhtyd edited a comment on pull request #4104: Debian10 support

2020-06-09 Thread GitBox
rhtyd edited a comment on pull request #4104: URL: https://github.com/apache/cloudstack/pull/4104#issuecomment-640995834 Checked test failures not related to this PR on XenServer, overall all tests have passed. The cale_vm test case failure is due to license issue (it would pass on xcp-

[GitHub] [cloudstack] rhtyd closed pull request #4071: Dynamic roles improvements

2020-06-09 Thread GitBox
rhtyd closed pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cloudstack] blueorangutan commented on pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly

2020-06-09 Thread GitBox
blueorangutan commented on pull request #4109: URL: https://github.com/apache/cloudstack/pull/4109#issuecomment-641251366 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [cloudstack] rhtyd commented on pull request #4071: Dynamic roles improvements

2020-06-09 Thread GitBox
rhtyd commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-640998000 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [cloudstack] rhtyd closed pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly

2020-06-09 Thread GitBox
rhtyd closed pull request #4109: URL: https://github.com/apache/cloudstack/pull/4109 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] nvazquez commented on pull request #4103: [VMware] Enable unmanaging guest VMs

2020-06-09 Thread GitBox
nvazquez commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-640587965 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [cloudstack] rhtyd commented on pull request #4114: hypervisor: XCP-ng 8.1 support

2020-06-09 Thread GitBox
rhtyd commented on pull request #4114: URL: https://github.com/apache/cloudstack/pull/4114#issuecomment-641171843 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [cloudstack] andrijapanicsb commented on pull request #4077: Disable searching by instance name for customers

2020-06-09 Thread GitBox
andrijapanicsb commented on pull request #4077: URL: https://github.com/apache/cloudstack/pull/4077#issuecomment-641329322 Overall LGTM, but have not tested it. This is an automated message from the Apache Git Service. To res

[GitHub] [cloudstack] blueorangutan commented on pull request #4115: cks: fix k8s cluster deployment planner

2020-06-09 Thread GitBox
blueorangutan commented on pull request #4115: URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-641097828 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [cloudstack] rhtyd closed pull request #4131: Health Checkplease don't merge this

2020-06-09 Thread GitBox
rhtyd closed pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] rhtyd commented on pull request #4130: Fixed null pointer after deleting snapshot, GC and cross cluster vm migration on XCP-NG

2020-06-09 Thread GitBox
rhtyd commented on pull request #4130: URL: https://github.com/apache/cloudstack/pull/4130#issuecomment-640999470 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support

2020-06-09 Thread GitBox
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-641172838 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [cloudstack] blueorangutan commented on pull request #4104: Debian10 support

2020-06-09 Thread GitBox
blueorangutan commented on pull request #4104: URL: https://github.com/apache/cloudstack/pull/4104#issuecomment-640859244 Trillian test result (tid-1638) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 64333 seconds Marvin logs: https://gith

[GitHub] [cloudstack] borisstoyanov commented on pull request #4135: Remove use of blacklist/whitelist terms

2020-06-09 Thread GitBox
borisstoyanov commented on pull request #4135: URL: https://github.com/apache/cloudstack/pull/4135#issuecomment-640790268 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [cloudstack] blueorangutan commented on pull request #4114: hypervisor: XCP-ng 8.1 support

2020-06-09 Thread GitBox
blueorangutan commented on pull request #4114: URL: https://github.com/apache/cloudstack/pull/4114#issuecomment-641172321 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [cloudstack] blueorangutan commented on pull request #3965: server: Honor vm.destroy.forcestop when expunge a vm

2020-06-09 Thread GitBox
blueorangutan commented on pull request #3965: URL: https://github.com/apache/cloudstack/pull/3965#issuecomment-640683826 Trillian test result (tid-1639) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34431 seconds Marvin logs: https://githu

[GitHub] [cloudstack] PaulAngus commented on pull request #4135: Remove use of blacklist/whitelist terms

2020-06-09 Thread GitBox
PaulAngus commented on pull request #4135: URL: https://github.com/apache/cloudstack/pull/4135#issuecomment-640879888 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] rhtyd merged pull request #3965: server: Honor vm.destroy.forcestop when expunge a vm

2020-06-09 Thread GitBox
rhtyd merged pull request #3965: URL: https://github.com/apache/cloudstack/pull/3965 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] blueorangutan commented on pull request #4071: Dynamic roles improvements

2020-06-09 Thread GitBox
blueorangutan commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-641077045 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [cloudstack] rhtyd merged pull request #4104: Debian10 support

2020-06-09 Thread GitBox
rhtyd merged pull request #4104: URL: https://github.com/apache/cloudstack/pull/4104 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] rhtyd commented on pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly

2020-06-09 Thread GitBox
rhtyd commented on pull request #4109: URL: https://github.com/apache/cloudstack/pull/4109#issuecomment-641315181 @blueorangutan test centos7 xenserver-71 This is an automated message from the Apache Git Service. To respond t

[GitHub] [cloudstack] blueorangutan commented on pull request #4131: Health Checkplease don't merge this

2020-06-09 Thread GitBox
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-640788693 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [cloudstack] blueorangutan commented on pull request #4103: [VMware] Enable unmanaging guest VMs

2020-06-09 Thread GitBox
blueorangutan commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-640588541 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [cloudstack] blueorangutan commented on pull request #4132: Fix delete network with no services

2020-06-09 Thread GitBox
blueorangutan commented on pull request #4132: URL: https://github.com/apache/cloudstack/pull/4132#issuecomment-640538716 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [cloudstack] rhtyd commented on pull request #4121: server: fix TransactionLegacy DB connection leaks due to DB switching by B&R thread

2020-06-09 Thread GitBox
rhtyd commented on pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121#issuecomment-641120904 We need another review to get this merged, so we can work towards a 4.14.1.0 release with the two critical issues (a) SG package dependency fix, (b) this issue. Please help rev

[GitHub] [cloudstack] andrijapanicsb opened a new issue #4136: UI doesn't allow login if sessionkey and JSESSIONID cookies are deleted

2020-06-09 Thread GitBox
andrijapanicsb opened a new issue #4136: URL: https://github.com/apache/cloudstack/issues/4136 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ UI (old UI, not Primate) ~~~ # CLOUDSTACK VERSION ~~~ 4.14+ (probably present on

[GitHub] [cloudstack] rhtyd closed issue #3654: Remote VPN not working if site-to-site VPN exists

2020-06-09 Thread GitBox
rhtyd closed issue #3654: URL: https://github.com/apache/cloudstack/issues/3654 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] nvazquez commented on pull request #4132: Fix delete network with no services

2020-06-09 Thread GitBox
nvazquez commented on pull request #4132: URL: https://github.com/apache/cloudstack/pull/4132#issuecomment-640539152 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [cloudstack] weizhouapache commented on pull request #4104: Debian10 support

2020-06-09 Thread GitBox
weizhouapache commented on pull request #4104: URL: https://github.com/apache/cloudstack/pull/4104#issuecomment-640542301 code lgtm did not test it This is an automated message from the Apache Git Service. To respond to th

[cloudstack-documentation] branch vnc-ports-on-vsphere-firewall created (now ae0aa67)

2020-06-09 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch vnc-ports-on-vsphere-firewall in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. at ae0aa67 vnc-ports This branch includes the following new commits:

[cloudstack-documentation] 01/01: vnc-ports

2020-06-09 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a commit to branch vnc-ports-on-vsphere-firewall in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git commit ae0aa67ec631a7accabe4e9c1756fc28137886ef Author: Andrija Panic <45762285+a

[cloudstack-documentation] branch vnc-ports-on-vsphere-firewall updated (ae0aa67 -> 3600f15)

2020-06-09 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch vnc-ports-on-vsphere-firewall in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from ae0aa67 vnc-ports add 3600f15 Update vsphere.rst No new revisi

[cloudstack-documentation] branch vnc-ports-on-vsphere-firewall updated (3600f15 -> 4cabb19)

2020-06-09 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch vnc-ports-on-vsphere-firewall in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from 3600f15 Update vsphere.rst add 4cabb19 Update vsphere.rst No n

[GitHub] [cloudstack] blueorangutan commented on pull request #4007: Restarting all networks that needs a restart in a VPC

2020-06-09 Thread GitBox
blueorangutan commented on pull request #4007: URL: https://github.com/apache/cloudstack/pull/4007#issuecomment-641544436 Trillian test result (tid-1653) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 60402 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #4130: Fixed null pointer after deleting snapshot, GC and cross cluster vm migration on XCP-NG

2020-06-09 Thread GitBox
blueorangutan commented on pull request #4130: URL: https://github.com/apache/cloudstack/pull/4130#issuecomment-641546893 Trillian test result (tid-1654) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 60447 seconds Marvin logs: https://githu

[GitHub] [cloudstack] ggoodrich-ipp opened a new pull request #4137: Adding VPN options for IKE version and IKE split connections.

2020-06-09 Thread GitBox
ggoodrich-ipp opened a new pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137 ## Description IKE version allows selecting ike (autoselect), ikev1, or ikev2. Split connections gives an option of separating the first right subnet from the rest, and kicking out i

[GitHub] [cloudstack] blueorangutan commented on pull request #4003: Logging framework to use only log4j

2020-06-09 Thread GitBox
blueorangutan commented on pull request #4003: URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-641612062 Trillian test result (tid-1657) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 60244 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #4103: [VMware] Enable unmanaging guest VMs

2020-06-09 Thread GitBox
blueorangutan commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-641649675 Trillian test result (tid-1662) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45393 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #4003: Logging framework to use only log4j

2020-06-09 Thread GitBox
blueorangutan commented on pull request #4003: URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-641691692 Trillian test result (tid-1656) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 77155 seconds Marvin logs: https://githu

[GitHub] [cloudstack] rhtyd commented on issue #4136: UI doesn't allow login if sessionkey and JSESSIONID cookies are deleted

2020-06-09 Thread GitBox
rhtyd commented on issue #4136: URL: https://github.com/apache/cloudstack/issues/4136#issuecomment-641710337 The issue happens because from code we're unable to clear HttpOnly cookie[1], this cookie can only be cleared by CloudStack (i.e. the server, not the client) and the fix is to call

[GitHub] [cloudstack] rhtyd commented on issue #4136: UI doesn't allow login if sessionkey and JSESSIONID cookies are deleted

2020-06-09 Thread GitBox
rhtyd commented on issue #4136: URL: https://github.com/apache/cloudstack/issues/4136#issuecomment-641710430 @davidjumani please pick this up. Thanks. This is an automated message from the Apache Git Service. To respond to th

[GitHub] [cloudstack] rhtyd closed issue #3987: Exception in long running Java11/MySQL8 management server

2020-06-09 Thread GitBox
rhtyd closed issue #3987: URL: https://github.com/apache/cloudstack/issues/3987 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] rhtyd commented on issue #3987: Exception in long running Java11/MySQL8 management server

2020-06-09 Thread GitBox
rhtyd commented on issue #3987: URL: https://github.com/apache/cloudstack/issues/3987#issuecomment-641710874 Closing this, we've identified root cause fixed in https://github.com/apache/cloudstack/pull/4121 This is an automa

[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

2020-06-09 Thread GitBox
rhtyd commented on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-641712287 @ggoodrich-ipp please check and fix python/lint issues, see travis failure: https://travis-ci.org/github/apache/cloudstack/jobs/696639652 As PR has UI changes, please mak