rhtyd commented on a change in pull request #4793:
URL: https://github.com/apache/cloudstack/pull/4793#discussion_r600216800
##
File path:
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41500to41510.java
##
@@ -58,6 +66,175 @@ public boolean supportsRollingUpgrade()
blueorangutan commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-805553156
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To res
rhtyd commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-805552594
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
rhtyd commented on pull request #4829:
URL: https://github.com/apache/cloudstack/pull/4829#issuecomment-805552292
Tests LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
rhtyd commented on pull request #4843:
URL: https://github.com/apache/cloudstack/pull/4843#issuecomment-805551712
@DaanHoogland sorry didn't get your comment,, what is cmk to do with the UI
change?
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a change to branch 4.15
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.
from 61de237 ui: Disable login button until redirected (#4857)
add 96dd728 plugins: Add 'break' at RedifshClient r
rhtyd merged pull request #4846:
URL: https://github.com/apache/cloudstack/pull/4846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a change to branch 4.15
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.
from dab7d29 systemvm: Load modules to support NAT traversal in VR (#4777)
add 61de237 ui: Disable login button un
rhtyd commented on a change in pull request #4857:
URL: https://github.com/apache/cloudstack/pull/4857#discussion_r600212638
##
File path: ui/src/views/auth/Login.vue
##
@@ -189,8 +189,8 @@ export default {
}
Login(loginParams)
.then((re
rhtyd merged pull request #4857:
URL: https://github.com/apache/cloudstack/pull/4857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
rhtyd commented on pull request #4854:
URL: https://github.com/apache/cloudstack/pull/4854#issuecomment-805547075
@lujiefsi this PR may be closed in favour of
https://github.com/apache/cloudstack/pull/4859
Generally if a PR exists for older branch, we can review/test merge it and
forwar
blueorangutan commented on pull request #4859:
URL: https://github.com/apache/cloudstack/pull/4859#issuecomment-805546936
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted
as I make progress.
--
This is an automated message from the Apache Git Service.
To respo
rhtyd commented on pull request #4859:
URL: https://github.com/apache/cloudstack/pull/4859#issuecomment-805546679
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
blueorangutan commented on pull request #4773:
URL: https://github.com/apache/cloudstack/pull/4773#issuecomment-805546450
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted
as I make progress.
--
This is an automated message from the Apache Git Service.
To respo
rhtyd commented on pull request #4773:
URL: https://github.com/apache/cloudstack/pull/4773#issuecomment-805546257
@slavkap is the PR work in progress? If not can you change the draft PR to
'ready for review'? Thanks.
@blueorangutan package
--
This is an automated message from the Apac
blueorangutan commented on pull request #4805:
URL: https://github.com/apache/cloudstack/pull/4805#issuecomment-805545953
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To res
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a change to branch 4.15
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.
from 40d93af vpc: dnsmasq is not started if use.external.dns is true
(#4806)
add dab7d29 systemvm: Load modules t
rhtyd merged pull request #4777:
URL: https://github.com/apache/cloudstack/pull/4777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
rhtyd commented on pull request #4805:
URL: https://github.com/apache/cloudstack/pull/4805#issuecomment-805545379
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a change to branch 4.15
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.
from bd79e1a ui: Consider overprovisioning factor when displaying
allocated progress bar (#4850)
add 40d93af vpc:
rhtyd merged pull request #4806:
URL: https://github.com/apache/cloudstack/pull/4806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
blueorangutan commented on pull request #4847:
URL: https://github.com/apache/cloudstack/pull/4847#issuecomment-805522302
Packaging result: :heavy_check_mark: centos7 :heavy_multiplication_x:
centos8 :heavy_check_mark: debian. SL-JID 218
--
This is an automated message from the Apache Gi
shwstppr opened a new pull request #4860:
URL: https://github.com/apache/cloudstack/pull/4860
### Description
Minor fix to not show domain's DB ID in the error message that gets
displayed in the UI.
### Types of changes
- [ ] Breaking change (fix or
harikrishna-patnala commented on pull request #4819:
URL: https://github.com/apache/cloudstack/pull/4819#issuecomment-805507248
-1 from my side for now unless if there are plans to deprecate
"getVMpassword" API and not to save VM password in database.
--
This is an automated message from
harikrishna-patnala commented on pull request #4819:
URL: https://github.com/apache/cloudstack/pull/4819#issuecomment-805506386
@GutoVeronezi There is a reason why we are generating a new password upon
reset ssh key.
We save the encrypted password (using ssh public key) of VM in the dat
shwstppr commented on pull request #4794:
URL: https://github.com/apache/cloudstack/pull/4794#issuecomment-805483687
> as stated in [#4794
(comment)](https://github.com/apache/cloudstack/pull/4794#issuecomment-797386465),
clgtm but i'm going to 👎 this anyway. both templates and volumes mus
shwstppr commented on pull request #4840:
URL: https://github.com/apache/cloudstack/pull/4840#issuecomment-805482095
@DaanHoogland
> > > > This PR removes the rule(s) validation with api names while
importing a role. This will be in sync with the current create role permission
beha
davidjumani commented on a change in pull request #4857:
URL: https://github.com/apache/cloudstack/pull/4857#discussion_r600155644
##
File path: ui/src/views/auth/Login.vue
##
@@ -189,8 +189,8 @@ export default {
}
Login(loginParams)
.th
blueorangutan commented on pull request #4329:
URL: https://github.com/apache/cloudstack/pull/4329#issuecomment-805456838
Trillian test result (tid-236)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45659 seconds
Marvin logs:
https://githu
blueorangutan commented on pull request #4200:
URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-805455688
Trillian test result (tid-239)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39786 seconds
Marvin logs:
https://github
blueorangutan commented on pull request #4793:
URL: https://github.com/apache/cloudstack/pull/4793#issuecomment-805403712
Trillian test result (tid-226)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44682 seconds
Marvin logs:
https://github
blueorangutan commented on pull request #4748:
URL: https://github.com/apache/cloudstack/pull/4748#issuecomment-805403552
Trillian test result (tid-234)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38991 seconds
Marvin logs:
https://github
blueorangutan commented on pull request #4840:
URL: https://github.com/apache/cloudstack/pull/4840#issuecomment-80544
Trillian test result (tid-233)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39249 seconds
Marvin logs:
https://github
blueorangutan commented on pull request #4829:
URL: https://github.com/apache/cloudstack/pull/4829#issuecomment-805397987
Trillian test result (tid-229)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42211 seconds
Marvin logs:
https://github
utchoang commented on a change in pull request #4857:
URL: https://github.com/apache/cloudstack/pull/4857#discussion_r600074511
##
File path: ui/src/views/auth/Login.vue
##
@@ -189,8 +189,8 @@ export default {
}
Login(loginParams)
.then(
blueorangutan commented on pull request #4329:
URL: https://github.com/apache/cloudstack/pull/4329#issuecomment-805396454
Trillian test result (tid-237)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37846 seconds
Marvin logs:
https://github
utchoang commented on a change in pull request #4857:
URL: https://github.com/apache/cloudstack/pull/4857#discussion_r600074511
##
File path: ui/src/views/auth/Login.vue
##
@@ -189,8 +189,8 @@ export default {
}
Login(loginParams)
.then(
blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-805358891
Trillian test result (tid-231)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35496 seconds
Marvin logs:
https://github
blueorangutan commented on pull request #4717:
URL: https://github.com/apache/cloudstack/pull/4717#issuecomment-805352608
Trillian test result (tid-232)
Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34736 seconds
Marvin logs:
https://github
blueorangutan commented on pull request #4829:
URL: https://github.com/apache/cloudstack/pull/4829#issuecomment-805346873
Trillian test result (tid-228)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35299 seconds
Marvin logs:
https://github
blueorangutan commented on pull request #4793:
URL: https://github.com/apache/cloudstack/pull/4793#issuecomment-805324516
Trillian test result (tid-224)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36554 seconds
Marvin logs:
https://githu
blueorangutan commented on pull request #4793:
URL: https://github.com/apache/cloudstack/pull/4793#issuecomment-805323929
Trillian test result (tid-225)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35727 seconds
Marvin logs:
https://github
blueorangutan commented on pull request #4829:
URL: https://github.com/apache/cloudstack/pull/4829#issuecomment-805317921
Trillian test result (tid-227)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33443 seconds
Marvin logs:
https://githu
DaanHoogland commented on issue #4733:
URL: https://github.com/apache/cloudstack/issues/4733#issuecomment-805287633
@mhoffmann21 both dutch and german use comma for decimal separation and
english uses point. This is the issue as confirmed by @MoeRT09/ I'm not sure if
this should be solved
blueorangutan commented on pull request #4777:
URL: https://github.com/apache/cloudstack/pull/4777#issuecomment-805238669
Trillian test result (tid-223)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35441 seconds
Marvin logs:
https://github
MoeRT09 commented on issue #4733:
URL: https://github.com/apache/cloudstack/issues/4733#issuecomment-805192813
@DaanHoogland It is definitely related to the system locale. Changing it to
en_US.UTF-8 fixes this issue. So probably the problem is caused by the number
format.
On Ubunt
blueorangutan commented on pull request #4710:
URL: https://github.com/apache/cloudstack/pull/4710#issuecomment-805155307
Trillian test result (tid-218)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 51077 seconds
Marvin logs:
https://github
weizhouapache commented on pull request #4847:
URL: https://github.com/apache/cloudstack/pull/4847#issuecomment-805126392
> > I think the change in this line also needed.
> >
https://github.com/apache/cloudstack/blob/master/systemvm/debian/etc/iptables/iptables-dhcpsrvr#L40
>
> In
weizhouapache commented on a change in pull request #4847:
URL: https://github.com/apache/cloudstack/pull/4847#discussion_r599824466
##
File path: systemvm/debian/opt/cloud/bin/cs/CsApp.py
##
@@ -61,12 +61,12 @@ def setup(self):
self.fw.append([
"", "fro
blueorangutan commented on pull request #4847:
URL: https://github.com/apache/cloudstack/pull/4847#issuecomment-805092154
@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has
been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
Spaceman1984 commented on pull request #4847:
URL: https://github.com/apache/cloudstack/pull/4847#issuecomment-805091835
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
blueorangutan commented on pull request #4847:
URL: https://github.com/apache/cloudstack/pull/4847#issuecomment-805090519
Packaging result: :heavy_check_mark: centos7 :heavy_multiplication_x:
centos8 :heavy_check_mark: debian. SL-JID 216
--
This is an automated message from the Apache Gi
lujiefsi edited a comment on pull request #4854:
URL: https://github.com/apache/cloudstack/pull/4854#issuecomment-805083336
> @lujiefsi can you change base branch to 4.15 as it's marked bug fix
done see https://github.com/apache/cloudstack/pull/4859
--
This is an automated message
lujiefsi commented on pull request #4854:
URL: https://github.com/apache/cloudstack/pull/4854#issuecomment-805083336
> @lujiefsi can you change base branch to 4.15 as it's marked bug fix
done see https://github.com/apache/cloudstack/pull/4859/files
--
This is an automated message f
blueorangutan commented on pull request #4710:
URL: https://github.com/apache/cloudstack/pull/4710#issuecomment-805079813
Trillian test result (tid-220)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36258 seconds
Marvin logs:
https://githu
blueorangutan commented on pull request #4847:
URL: https://github.com/apache/cloudstack/pull/4847#issuecomment-805077692
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
--
This is an automated message from the Apache Git Service.
T
Spaceman1984 commented on pull request #4847:
URL: https://github.com/apache/cloudstack/pull/4847#issuecomment-805077093
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
Spaceman1984 commented on pull request #4847:
URL: https://github.com/apache/cloudstack/pull/4847#issuecomment-805073077
> I think the change in this line also needed.
>
https://github.com/apache/cloudstack/blob/master/systemvm/debian/etc/iptables/iptables-dhcpsrvr#L40
In my testi
Spaceman1984 commented on a change in pull request #4847:
URL: https://github.com/apache/cloudstack/pull/4847#discussion_r599765300
##
File path: systemvm/debian/opt/cloud/bin/cs/CsApp.py
##
@@ -61,12 +61,12 @@ def setup(self):
self.fw.append([
"", "fron
lujiefsi opened a new pull request #4859:
URL: https://github.com/apache/cloudstack/pull/4859
### Description
This PR...
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionalit
weizhouapache commented on issue #4858:
URL: https://github.com/apache/cloudstack/issues/4858#issuecomment-805048815
> @weizhouapache you are right. Appending the `autoconnect=true` parameter
to the URL of the iframe fixes it.
good to know !
--
This is an automated message from th
MoeRT09 commented on issue #4858:
URL: https://github.com/apache/cloudstack/issues/4858#issuecomment-805041899
@weizhouapache you are right. Appending the `autoconnect=true` parameter to
the URL of the iframe fixes it.
--
This is an automated message from the Apache Git Service.
To respo
lujiefsi commented on pull request #4854:
URL: https://github.com/apache/cloudstack/pull/4854#issuecomment-805037552
> @lujiefsi can you change base branch to 4.15 as it's marked bug fix
YES, i will!
--
This is an automated message from the Apache Git Service.
To respond to the mes
lujiefsi commented on pull request #4854:
URL: https://github.com/apache/cloudstack/pull/4854#issuecomment-805036943
> @lujiefsi why do you think this "solves" CLOUDSTACK-10434? I can not find
that, it redirects me to
[CLOUDSTACK-10431](https://issues.apache.org/jira/projects/CLOUDSTACK/is
weizhouapache commented on issue #4858:
URL: https://github.com/apache/cloudstack/issues/4858#issuecomment-805030916
@MoeRT09 this should be fixed by #4833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
blueorangutan commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-805029529
Trillian test result (tid-212)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50793 seconds
Marvin logs:
https://github
blueorangutan commented on pull request #4215:
URL: https://github.com/apache/cloudstack/pull/4215#issuecomment-805013350
Trillian Build Failed (tid-238)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
MoeRT09 opened a new issue #4858:
URL: https://github.com/apache/cloudstack/issues/4858
# ISSUE TYPE
* Bug Report
# COMPONENT NAME
~~~
UI
~~~
# CLOUDSTACK VERSION
~~~
4.15.0.0
~~~
# CONFIGURATION
N/A
blueorangutan commented on pull request #4840:
URL: https://github.com/apache/cloudstack/pull/4840#issuecomment-805002839
Trillian test result (tid-198)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 116011 seconds
Marvin logs:
https://githu
GabrielBrascher edited a comment on pull request #4200:
URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-804999576
Thanks for fixing the conflicts @ravening.
## Here are my two cents:
From what I understood, the main discussion has been due to confusion around
GabrielBrascher commented on pull request #4200:
URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-804999576
Thanks for fixing the conflicts @ravening.
## Here are my two cents:
From what I understood, the main discussion has been due to confusion around
the sco
mhoffmann21 commented on issue #4733:
URL: https://github.com/apache/cloudstack/issues/4733#issuecomment-804986118
@DaanHoogland 1,5 like in dutch or german.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
DaanHoogland commented on issue #4733:
URL: https://github.com/apache/cloudstack/issues/4733#issuecomment-804980939
@mhoffmann21 just a hunch but that looks like a localisation issue: 1,5 in
dutch or german vs 1.5 in english???
--
This is an automated message from the Apache Git Service.
mhoffmann21 commented on issue #4733:
URL: https://github.com/apache/cloudstack/issues/4733#issuecomment-804967083
@DaanHoogland hey, sorry for the late answer.
There are no other messages in the log after the click on the host tab and
the described WARN message...yeah of course the typi
blueorangutan commented on pull request #4215:
URL: https://github.com/apache/cloudstack/pull/4215#issuecomment-804965721
Packaging result: :heavy_check_mark: centos7 :heavy_multiplication_x:
centos8 :heavy_check_mark: debian. SL-JID 215
--
This is an automated message from the Apache Gi
blueorangutan commented on pull request #4200:
URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-804960153
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8
:heavy_check_mark: debian. SL-JID 214
--
This is an automated message from the Apache Git Serv
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.
from 4e90a8c Qemu 2.10 requires `-U` flag to read volume metadata (#4567)
add 5895435 tests: Extend wait time aft
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
commit 64f792bd7c3a2017d760b0d47b9a403cb88bab99
Merge: 4e90a8c bd79e1a
Author: Daan Hoogland
AuthorDate: Tue Mar 23 15:36:30
DaanHoogland commented on pull request #4840:
URL: https://github.com/apache/cloudstack/pull/4840#issuecomment-804938239
> > > This PR removes the rule(s) validation with api names while importing
a role. This will be in sync with the current create role permission behavior.
> >
> >
blueorangutan commented on pull request #4329:
URL: https://github.com/apache/cloudstack/pull/4329#issuecomment-804936657
Trillian Build Failed (tid-235)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
blueorangutan commented on pull request #4748:
URL: https://github.com/apache/cloudstack/pull/4748#issuecomment-804933059
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To
Pearl1594 commented on pull request #4748:
URL: https://github.com/apache/cloudstack/pull/4748#issuecomment-804932429
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
blueorangutan commented on pull request #4329:
URL: https://github.com/apache/cloudstack/pull/4329#issuecomment-804924285
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8
:heavy_check_mark: debian. SL-JID 212
--
This is an automated message from the Apache Git Serv
blueorangutan commented on pull request #4748:
URL: https://github.com/apache/cloudstack/pull/4748#issuecomment-804924283
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8
:heavy_check_mark: debian. SL-JID 213
--
This is an automated message from the Apache Git Serv
blueorangutan commented on pull request #4840:
URL: https://github.com/apache/cloudstack/pull/4840#issuecomment-804923836
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To res
rhtyd commented on pull request #4840:
URL: https://github.com/apache/cloudstack/pull/4840#issuecomment-804923037
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a change to branch 4.15
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.
from eaefc2a ui: Fix the styles action button (#4856)
add bd79e1a ui: Consider overprovisioning factor when displa
rhtyd merged pull request #4850:
URL: https://github.com/apache/cloudstack/pull/4850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
rhtyd commented on pull request #4850:
URL: https://github.com/apache/cloudstack/pull/4850#issuecomment-804922136
Thanks all I'll merge based on your remarks and testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
rhtyd commented on a change in pull request #4857:
URL: https://github.com/apache/cloudstack/pull/4857#discussion_r599588789
##
File path: ui/src/views/auth/Login.vue
##
@@ -189,8 +189,8 @@ export default {
}
Login(loginParams)
.then((re
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a change to branch 4.15
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.
from a53ecac ui: Fill out the search filter form field after performing a
filter (#4855)
add eaefc2a ui: Fix the
rhtyd merged pull request #4856:
URL: https://github.com/apache/cloudstack/pull/4856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
rhtyd commented on pull request #4856:
URL: https://github.com/apache/cloudstack/pull/4856#issuecomment-804920722
Did a quick test - lgtm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a change to branch 4.15
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.
from 83b568e ui: fix add cluster form for vmware (#4841)
add a53ecac ui: Fill out the search filter form field aft
rhtyd merged pull request #4855:
URL: https://github.com/apache/cloudstack/pull/4855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
rhtyd commented on pull request #4854:
URL: https://github.com/apache/cloudstack/pull/4854#issuecomment-804919248
@lujiefsi can you change base branch to 4.15 as it's marked bug fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
sureshanaparti commented on a change in pull request #4230:
URL: https://github.com/apache/cloudstack/pull/4230#discussion_r599585486
##
File path:
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##
@@ -835,6 +845,161 @@ public Configuration updateCo
GabrielBrascher commented on pull request #4846:
URL: https://github.com/apache/cloudstack/pull/4846#issuecomment-804915820
Thanks for the review @rhtyd! I have tested it, and it looks good.
Here follows details of the test process comparing **4.15.0.0** with this
implementation (**4
sureshanaparti commented on a change in pull request #4230:
URL: https://github.com/apache/cloudstack/pull/4230#discussion_r599579603
##
File path:
api/src/main/java/org/apache/cloudstack/api/command/admin/config/ResetCfgCmd.java
##
@@ -0,0 +1,164 @@
+// Licensed to the Apache
sureshanaparti commented on a change in pull request #4230:
URL: https://github.com/apache/cloudstack/pull/4230#discussion_r599576544
##
File path:
api/src/main/java/org/apache/cloudstack/api/command/admin/config/ResetCfgCmd.java
##
@@ -0,0 +1,164 @@
+// Licensed to the Apache
1 - 100 of 172 matches
Mail list logo
