[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4790: Externalize secondary storage capacity threshold

2021-05-25 Thread GitBox
sureshanaparti commented on a change in pull request #4790: URL: https://github.com/apache/cloudstack/pull/4790#discussion_r639445764 ## File path: server/src/main/java/com/cloud/server/StatsCollector.java ## @@ -1599,10 +1621,21 @@ public String getConfigComponentName() {

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4790: Externalize secondary storage capacity threshold

2021-05-25 Thread GitBox
sureshanaparti commented on a change in pull request #4790: URL: https://github.com/apache/cloudstack/pull/4790#discussion_r639448021 ## File path: server/src/main/java/com/cloud/server/StatsCollector.java ## @@ -219,6 +224,8 @@ public String toString() { private static fi

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4790: Externalize secondary storage capacity threshold

2021-05-25 Thread GitBox
sureshanaparti commented on a change in pull request #4790: URL: https://github.com/apache/cloudstack/pull/4790#discussion_r639445764 ## File path: server/src/main/java/com/cloud/server/StatsCollector.java ## @@ -1599,10 +1621,21 @@ public String getConfigComponentName() {

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4790: Externalize secondary storage capacity threshold

2021-05-25 Thread GitBox
sureshanaparti commented on a change in pull request #4790: URL: https://github.com/apache/cloudstack/pull/4790#discussion_r639439274 ## File path: server/src/main/java/com/cloud/server/StatsCollector.java ## @@ -204,6 +206,9 @@ public String toString() { private static fi

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4790: Externalize secondary storage capacity threshold

2021-05-25 Thread GitBox
sureshanaparti commented on a change in pull request #4790: URL: https://github.com/apache/cloudstack/pull/4790#discussion_r639439450 ## File path: server/src/main/java/com/cloud/server/StatsCollector.java ## @@ -204,6 +206,9 @@ public String toString() { private static fi

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4790: Externalize secondary storage capacity threshold

2021-05-25 Thread GitBox
sureshanaparti commented on a change in pull request #4790: URL: https://github.com/apache/cloudstack/pull/4790#discussion_r639439274 ## File path: server/src/main/java/com/cloud/server/StatsCollector.java ## @@ -204,6 +206,9 @@ public String toString() { private static fi

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4790: Externalize secondary storage capacity threshold

2021-05-25 Thread GitBox
sureshanaparti commented on a change in pull request #4790: URL: https://github.com/apache/cloudstack/pull/4790#discussion_r639438086 ## File path: server/src/main/java/com/cloud/server/StatsCollector.java ## @@ -219,6 +224,8 @@ public String toString() { private static fi

[GitHub] [cloudstack] blueorangutan commented on pull request #5024: Health Check PR: 4.15

2021-05-25 Thread GitBox
blueorangutan commented on pull request #5024: URL: https://github.com/apache/cloudstack/pull/5024#issuecomment-848494570 Trillian test result (tid-733) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 58864 seconds Marvin logs: https://github

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4790: Externalize secondary storage capacity threshold

2021-05-25 Thread GitBox
sureshanaparti commented on a change in pull request #4790: URL: https://github.com/apache/cloudstack/pull/4790#discussion_r639417891 ## File path: server/src/main/java/com/cloud/server/StatsCollector.java ## @@ -1367,10 +1372,28 @@ public boolean imageStoreHasEnoughCapacity(Da

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive word

2021-05-25 Thread GitBox
blueorangutan removed a comment on pull request #4922: URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-848470360 @sureshanaparti unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, centos8, ubuntu18, ubuntu20`. Supported hypervisors are: `kvm-

[GitHub] [cloudstack] sureshanaparti removed a comment on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive wor

2021-05-25 Thread GitBox
sureshanaparti removed a comment on pull request #4922: URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-848470092 @blueorangutan test centos7 xs71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms

2021-05-25 Thread GitBox
sureshanaparti commented on pull request #4922: URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-848470092 @blueorangutan test centos7 xs71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms

2021-05-25 Thread GitBox
sureshanaparti commented on pull request #4922: URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-848470934 @blueorangutan test centos7 xenserver-71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4922: URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-848471371 @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests -- This is an automated message from the Apache Git Servi

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4922: URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-848470360 @sureshanaparti unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, centos8, ubuntu18, ubuntu20`. Supported hypervisors are: `kvm-centos6,

[GitHub] [cloudstack] blueorangutan commented on pull request #4819: Remove meaningless password regeneration on resetSSHKeyForVirtualMachine

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4819: URL: https://github.com/apache/cloudstack/pull/4819#issuecomment-848448771 Trillian test result (tid-741) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47651 seconds Marvin logs: https://github

[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4643: URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-848439881 Trillian test result (tid-737) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49630 seconds Marvin logs: https://github

[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4643: URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-848395303 Trillian test result (tid-736) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41906 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #4819: Remove meaningless password regeneration on resetSSHKeyForVirtualMachine

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4819: URL: https://github.com/apache/cloudstack/pull/4819#issuecomment-848375770 Trillian test result (tid-731) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48575 seconds Marvin logs: https://github

[GitHub] [cloudstack] blueorangutan commented on pull request #5024: Health Check PR: 4.15

2021-05-25 Thread GitBox
blueorangutan commented on pull request #5024: URL: https://github.com/apache/cloudstack/pull/5024#issuecomment-848369074 Trillian test result (tid-732) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38131 seconds Marvin logs: https://githu

[GitHub] [cloudstack] GutoVeronezi commented on pull request #4954: Unify SMTP mail sending

2021-05-25 Thread GitBox
GutoVeronezi commented on pull request #4954: URL: https://github.com/apache/cloudstack/pull/4954#issuecomment-848284090 @rhtyd As mentioned before, I set SMTP global settings to project, alert and quota and enabled StartTLS (global setting); Then I allowed `Less secure app access`

[GitHub] [cloudstack] rhtyd commented on pull request #5038: systemvmtemplate: update to Debian 10.9

2021-05-25 Thread GitBox
rhtyd commented on pull request #5038: URL: https://github.com/apache/cloudstack/pull/5038#issuecomment-848271018 Not necesary if we install the latest ca-certificates, we don't want to install anything with an invalid certificate. -- This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] GutoVeronezi commented on pull request #4586: Externalize kvm agent storage reboot configuration

2021-05-25 Thread GitBox
GutoVeronezi commented on pull request #4586: URL: https://github.com/apache/cloudstack/pull/4586#issuecomment-848223941 @DaanHoogland @GabrielBrascher rename done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack] weizhouapache commented on pull request #5038: systemvmtemplate: update to Debian 10.9

2021-05-25 Thread GitBox
weizhouapache commented on pull request #5038: URL: https://github.com/apache/cloudstack/pull/5038#issuecomment-848212886 @rhtyd by the way, would it be better to add "--no-check-certificate " to all "wget" command ? -- This is an automated message from the Apache Git Service. To res

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4886: server: list routers by healthchecksfailed

2021-05-25 Thread GitBox
weizhouapache commented on a change in pull request #4886: URL: https://github.com/apache/cloudstack/pull/4886#discussion_r639132477 ## File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java ## @@ -1341,6 +1342,27 @@ sb.and("networkId", sb.entity

[GitHub] [cloudstack] blueorangutan commented on pull request #4577: [HEALTH] 4.16/master Health Check please don't merge this

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4577: URL: https://github.com/apache/cloudstack/pull/4577#issuecomment-848204583 Trillian test result (tid-727) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 50852 seconds Marvin logs: https://github

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4586: Externalize kvm agent storage reboot configuration

2021-05-25 Thread GitBox
GabrielBrascher commented on a change in pull request #4586: URL: https://github.com/apache/cloudstack/pull/4586#discussion_r639113071 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHAMonitor.java ## @@ -32,17 +33,23 @@ import java.ut

[GitHub] [cloudstack] GabrielBrascher commented on pull request #4708: kvm: Handle storage issue on NFS/KVM in multiple ways

2021-05-25 Thread GitBox
GabrielBrascher commented on pull request #4708: URL: https://github.com/apache/cloudstack/pull/4708#issuecomment-848184689 @ustcweizhou thanks for the PR. From what I understood (really quick glance of eyes) this avoid also situations of HA monitor a removed NFS storage. Am I right?

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4922: URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-848144168 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To res

[GitHub] [cloudstack] rhtyd commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appro

2021-05-25 Thread GitBox
rhtyd commented on pull request #4922: URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-848142637 @blueorangutan test centos7 vmware-67u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4922: URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-848069731 Trillian test result (tid-729) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35083 seconds Marvin logs: https://github

[GitHub] [cloudstack] GutoVeronezi commented on pull request #4960: Improve logs on RemoteAccessVpnManagerImpl

2021-05-25 Thread GitBox
GutoVeronezi commented on pull request #4960: URL: https://github.com/apache/cloudstack/pull/4960#issuecomment-848054939 @rhtyd As we discussed in [PR 4966](https://github.com/apache/cloudstack/pull/4966), these PRs have different contexts and different changes; Joining each PR in a single

[GitHub] [cloudstack] blueorangutan commented on pull request #4577: [HEALTH] 4.16/master Health Check please don't merge this

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4577: URL: https://github.com/apache/cloudstack/pull/4577#issuecomment-848048464 Trillian Build Failed (tid-725) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [cloudstack] blueorangutan commented on pull request #5037: Updated PowerFlex/ScaleIO gateway client with some improvements.

2021-05-25 Thread GitBox
blueorangutan commented on pull request #5037: URL: https://github.com/apache/cloudstack/pull/5037#issuecomment-848043591 @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Servic

[GitHub] [cloudstack] sureshanaparti commented on pull request #5037: Updated PowerFlex/ScaleIO gateway client with some improvements.

2021-05-25 Thread GitBox
sureshanaparti commented on pull request #5037: URL: https://github.com/apache/cloudstack/pull/5037#issuecomment-848043198 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] rhtyd opened a new pull request #5038: systemvmtemplate: update to Debian 10.9

2021-05-25 Thread GitBox
rhtyd opened a new pull request #5038: URL: https://github.com/apache/cloudstack/pull/5038 Updates systemvmtemplate build scripts to use latest 10.9 iso. Fix url to get `vhd-util`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [cloudstack] rhtyd commented on pull request #4977: Enable creation of vms with solidfire root volumes on vmware67

2021-05-25 Thread GitBox
rhtyd commented on pull request #4977: URL: https://github.com/apache/cloudstack/pull/4977#issuecomment-847995156 Thanks for replying @skattoju4, based on your remark and private email from @pdion891 moving this to next 4.15.2.0 milestone. Happy to help in any way to get this moving, thank

[GitHub] [cloudstack] blueorangutan commented on pull request #5024: Health Check PR: 4.15

2021-05-25 Thread GitBox
blueorangutan commented on pull request #5024: URL: https://github.com/apache/cloudstack/pull/5024#issuecomment-847941731 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To res

[GitHub] [cloudstack] blueorangutan commented on pull request #4819: Remove meaningless password regeneration on resetSSHKeyForVirtualMachine

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4819: URL: https://github.com/apache/cloudstack/pull/4819#issuecomment-847941705 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To res

[GitHub] [cloudstack] rhtyd commented on pull request #4819: Remove meaningless password regeneration on resetSSHKeyForVirtualMachine

2021-05-25 Thread GitBox
rhtyd commented on pull request #4819: URL: https://github.com/apache/cloudstack/pull/4819#issuecomment-847941339 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [cloudstack] rhtyd commented on pull request #5024: Health Check PR: 4.15

2021-05-25 Thread GitBox
rhtyd commented on pull request #5024: URL: https://github.com/apache/cloudstack/pull/5024#issuecomment-84794 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[cloudstack] branch master updated: fix: create template with Marvin (#4631)

2021-05-25 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new a0d9ace fix: create template with Marvin (#4

[GitHub] [cloudstack] rhtyd merged pull request #4631: fix: create template with Marvin

2021-05-25 Thread GitBox
rhtyd merged pull request #4631: URL: https://github.com/apache/cloudstack/pull/4631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [cloudstack] blueorangutan commented on pull request #4708: kvm: Handle storage issue on NFS/KVM in multiple ways

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4708: URL: https://github.com/apache/cloudstack/pull/4708#issuecomment-847929682 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 91 -- This is an automated message from the Apache Git Servi

[GitHub] [cloudstack] blueorangutan commented on pull request #4886: server: list routers by healthchecksfailed

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4886: URL: https://github.com/apache/cloudstack/pull/4886#issuecomment-847929515 Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_multiplication_x: debian. SL-JID 90 -- This is an automated message from th

[GitHub] [cloudstack] blueorangutan commented on pull request #4954: Unify SMTP mail sending

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4954: URL: https://github.com/apache/cloudstack/pull/4954#issuecomment-847929513 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 89 -- This is an automated message from the Apache Git Servi

[GitHub] [cloudstack] blueorangutan commented on pull request #4790: Externalize secondary storage capacity threshold

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4790: URL: https://github.com/apache/cloudstack/pull/4790#issuecomment-847929440 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 88 -- This is an automated message from the Apache Git Servi

[GitHub] [cloudstack] GabrielBrascher commented on pull request #4570: Externalize KVM Agent's option to change migration thread timeout

2021-05-25 Thread GitBox
GabrielBrascher commented on pull request #4570: URL: https://github.com/apache/cloudstack/pull/4570#issuecomment-847919516 @rhtyd @GutoVeronezi my 2 cents here is: I think that PR #4586 has nothing to do with #4570. The first one externalizes the KVM agent **storage reboot configura

[GitHub] [cloudstack] blueorangutan commented on pull request #4819: Remove meaningless password regeneration on resetSSHKeyForVirtualMachine

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4819: URL: https://github.com/apache/cloudstack/pull/4819#issuecomment-847909875 Trillian Build Failed (tid-740) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [cloudstack] blueorangutan commented on pull request #5024: Health Check PR: 4.15

2021-05-25 Thread GitBox
blueorangutan commented on pull request #5024: URL: https://github.com/apache/cloudstack/pull/5024#issuecomment-847903985 Trillian Build Failed (tid-734) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [cloudstack] slavkap commented on a change in pull request #4631: fix: create template with Marvin

2021-05-25 Thread GitBox
slavkap commented on a change in pull request #4631: URL: https://github.com/apache/cloudstack/pull/4631#discussion_r638817965 ## File path: tools/marvin/marvin/lib/base.py ## @@ -1521,12 +1513,12 @@ def _set_command(cls, apiclient, cmd, services, random_name=True):

[GitHub] [cloudstack] blueorangutan commented on pull request #4708: kvm: Handle storage issue on NFS/KVM in multiple ways

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4708: URL: https://github.com/apache/cloudstack/pull/4708#issuecomment-847894380 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] rhtyd commented on pull request #4708: kvm: Handle storage issue on NFS/KVM in multiple ways

2021-05-25 Thread GitBox
rhtyd commented on pull request #4708: URL: https://github.com/apache/cloudstack/pull/4708#issuecomment-847893967 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [cloudstack] blueorangutan commented on pull request #4886: server: list routers by healthchecksfailed

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4886: URL: https://github.com/apache/cloudstack/pull/4886#issuecomment-847893564 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] ustcweizhou opened a new pull request #4886: server: list routers by healthchecksfailed

2021-05-25 Thread GitBox
ustcweizhou opened a new pull request #4886: URL: https://github.com/apache/cloudstack/pull/4886 ### Description ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to ch

[GitHub] [cloudstack] rhtyd commented on pull request #4886: server: list routers by healthchecksfailed

2021-05-25 Thread GitBox
rhtyd commented on pull request #4886: URL: https://github.com/apache/cloudstack/pull/4886#issuecomment-847892771 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [cloudstack] rhtyd closed pull request #4886: server: list routers by healthchecksfailed

2021-05-25 Thread GitBox
rhtyd closed pull request #4886: URL: https://github.com/apache/cloudstack/pull/4886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [cloudstack] rhtyd commented on pull request #4890: Universal sshkey and password manager script

2021-05-25 Thread GitBox
rhtyd commented on pull request #4890: URL: https://github.com/apache/cloudstack/pull/4890#issuecomment-847892427 Thanks, we need some manual test/confirmation and a doc PR to https://github.com/apache/cloudstack-documentation explaining how to use this. -- This is an automated message f

[GitHub] [cloudstack] rhtyd commented on pull request #4699: Add new registers in guest_os

2021-05-25 Thread GitBox
rhtyd commented on pull request #4699: URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-847890849 @harikrishna-patnala can you review this PR - is this good to go or needs to wait for your design proposal/changes? -- This is an automated message from the Apache Git Servic

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4631: fix: create template with Marvin

2021-05-25 Thread GitBox
rhtyd commented on a change in pull request #4631: URL: https://github.com/apache/cloudstack/pull/4631#discussion_r638810660 ## File path: tools/marvin/marvin/lib/base.py ## @@ -1521,12 +1513,12 @@ def _set_command(cls, apiclient, cmd, services, random_name=True):

[GitHub] [cloudstack] rhtyd commented on pull request #4960: Improve logs on RemoteAccessVpnManagerImpl

2021-05-25 Thread GitBox
rhtyd commented on pull request #4960: URL: https://github.com/apache/cloudstack/pull/4960#issuecomment-847888111 @GutoVeronezi could you club all your "Improve logs on..." PRs - would be easier to get them tested, reviewed merged. -- This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] blueorangutan commented on pull request #4819: Remove meaningless password regeneration on resetSSHKeyForVirtualMachine

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4819: URL: https://github.com/apache/cloudstack/pull/4819#issuecomment-847887961 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To res

[GitHub] [cloudstack] blueorangutan commented on pull request #4790: Externalize secondary storage capacity threshold

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4790: URL: https://github.com/apache/cloudstack/pull/4790#issuecomment-847887937 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] blueorangutan commented on pull request #4954: Unify SMTP mail sending

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4954: URL: https://github.com/apache/cloudstack/pull/4954#issuecomment-847887994 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] rhtyd commented on pull request #4790: Externalize secondary storage capacity threshold

2021-05-25 Thread GitBox
rhtyd commented on pull request #4790: URL: https://github.com/apache/cloudstack/pull/4790#issuecomment-847887582 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [cloudstack] rhtyd commented on pull request #4819: Remove meaningless password regeneration on resetSSHKeyForVirtualMachine

2021-05-25 Thread GitBox
rhtyd commented on pull request #4819: URL: https://github.com/apache/cloudstack/pull/4819#issuecomment-847887467 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] rhtyd commented on pull request #4954: Unify SMTP mail sending

2021-05-25 Thread GitBox
rhtyd commented on pull request #4954: URL: https://github.com/apache/cloudstack/pull/4954#issuecomment-847887105 @GutoVeronezi do you have test results from testing the changes? For example setup the smtp settings and see if it actually works, share tests with screenshots etc. @blueora

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4966: Refactor few process of VirtualMachineManagerImpl and improve logs

2021-05-25 Thread GitBox
blueorangutan removed a comment on pull request #4966: URL: https://github.com/apache/cloudstack/pull/4966#issuecomment-838940854 Trillian test result (tid-639) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 100678 seconds Marvin logs: https

[GitHub] [cloudstack] blueorangutan commented on pull request #4852: Allow host cert renewals even if client auth strictness is false

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4852: URL: https://github.com/apache/cloudstack/pull/4852#issuecomment-847881850 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To res

[GitHub] [cloudstack] rhtyd commented on pull request #4852: Allow host cert renewals even if client auth strictness is false

2021-05-25 Thread GitBox
rhtyd commented on pull request #4852: URL: https://github.com/apache/cloudstack/pull/4852#issuecomment-847880990 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] rhtyd commented on pull request #4570: Externalize KVM Agent's option to change migration thread timeout

2021-05-25 Thread GitBox
rhtyd commented on pull request #4570: URL: https://github.com/apache/cloudstack/pull/4570#issuecomment-847880011 @GutoVeronezi just another example where related PRs should be clubbed together, commits can be separate to allow reviewing of them individually. -- This is an automated mess

[GitHub] [cloudstack] blueorangutan commented on pull request #4852: Allow host cert renewals even if client auth strictness is false

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4852: URL: https://github.com/apache/cloudstack/pull/4852#issuecomment-847876733 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 87 -- This is an automated message from the Apache Git Servi

[GitHub] [cloudstack] sureshanaparti commented on pull request #4703: Improve logs on ProcessRunner

2021-05-25 Thread GitBox
sureshanaparti commented on pull request #4703: URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-847868501 > doesn't look like more is needed to me. @sureshanaparti, @borisstoyanov , @vladimirpetrov do you agree those test results look good? @DaanHoogland @GutoVeronez

[GitHub] [cloudstack] sureshanaparti commented on issue #4897: Eliminate *_details table inconsistency

2021-05-25 Thread GitBox
sureshanaparti commented on issue #4897: URL: https://github.com/apache/cloudstack/issues/4897#issuecomment-847866161 > Following details table allow NULL values, > > ``` > cloud.account_details > cloud.cluster_details > cloud.data_center_details > cloud.domain_details

[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4643: URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-847863275 @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an

[GitHub] [cloudstack] DaanHoogland commented on pull request #4643: VM dynamic scaling option granularity

2021-05-25 Thread GitBox
DaanHoogland commented on pull request #4643: URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-847862309 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack] blueorangutan commented on pull request #5024: Health Check PR: 4.15

2021-05-25 Thread GitBox
blueorangutan commented on pull request #5024: URL: https://github.com/apache/cloudstack/pull/5024#issuecomment-847860337 @rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automa

[GitHub] [cloudstack] rhtyd commented on pull request #5024: Health Check PR: 4.15

2021-05-25 Thread GitBox
rhtyd commented on pull request #5024: URL: https://github.com/apache/cloudstack/pull/5024#issuecomment-847859799 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [cloudstack] blueorangutan commented on pull request #4852: Allow host cert renewals even if client auth strictness is false

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4852: URL: https://github.com/apache/cloudstack/pull/4852#issuecomment-847857119 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] rhtyd commented on pull request #4852: Allow host cert renewals even if client auth strictness is false

2021-05-25 Thread GitBox
rhtyd commented on pull request #4852: URL: https://github.com/apache/cloudstack/pull/4852#issuecomment-847856105 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #5017: Usage: usage generated for destroyed VMs with no backups

2021-05-25 Thread GitBox
Pearl1594 commented on a change in pull request #5017: URL: https://github.com/apache/cloudstack/pull/5017#discussion_r638761289 ## File path: engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java ## @@ -613,7 +613,7 @@ boolean ifStateUnchanged(State oldState, Sta

[GitHub] [cloudstack] blueorangutan commented on pull request #5024: Health Check PR: 4.15

2021-05-25 Thread GitBox
blueorangutan commented on pull request #5024: URL: https://github.com/apache/cloudstack/pull/5024#issuecomment-847842959 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 86 -- This is an automated message from the Apache Git Servi

[GitHub] [cloudstack] skattoju4 commented on pull request #4977: Enable creation of vms with solidfire root volumes on vmware67

2021-05-25 Thread GitBox
skattoju4 commented on pull request #4977: URL: https://github.com/apache/cloudstack/pull/4977#issuecomment-847842516 > Hi @skattoju4 @pdion891 @swill any update please? We need you to communicate, it's been two weeks and we want to cut RC1 next week. Thanks. @rhtyd lets push this on

[GitHub] [cloudstack] blueorangutan commented on pull request #5024: Health Check PR: 4.15

2021-05-25 Thread GitBox
blueorangutan commented on pull request #5024: URL: https://github.com/apache/cloudstack/pull/5024#issuecomment-847826434 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] rhtyd commented on pull request #5024: Health Check PR: 4.15

2021-05-25 Thread GitBox
rhtyd commented on pull request #5024: URL: https://github.com/apache/cloudstack/pull/5024#issuecomment-847825620 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [cloudstack] rhtyd closed pull request #5024: Health Check PR: 4.15

2021-05-25 Thread GitBox
rhtyd closed pull request #5024: URL: https://github.com/apache/cloudstack/pull/5024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [cloudstack] rhtyd commented on pull request #5017: Usage: usage generated for destroyed VMs with no backups

2021-05-25 Thread GitBox
rhtyd commented on pull request #5017: URL: https://github.com/apache/cloudstack/pull/5017#issuecomment-847824952 @olivierlemasle can the acceptable solution be as simple as leave it as is because backups are first class citizen? As per your bug report, at least 1 backup is created/exists

[GitHub] [cloudstack] rhtyd commented on a change in pull request #5017: Usage: usage generated for destroyed VMs with no backups

2021-05-25 Thread GitBox
rhtyd commented on a change in pull request #5017: URL: https://github.com/apache/cloudstack/pull/5017#discussion_r638735679 ## File path: server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java ## @@ -1030,10 +1031,12 @@ protected void runInContext() {

[GitHub] [cloudstack] rhtyd commented on a change in pull request #5017: Usage: usage generated for destroyed VMs with no backups

2021-05-25 Thread GitBox
rhtyd commented on a change in pull request #5017: URL: https://github.com/apache/cloudstack/pull/5017#discussion_r638734452 ## File path: engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java ## @@ -613,7 +613,7 @@ boolean ifStateUnchanged(State oldState, State n

[GitHub] [cloudstack] rhtyd commented on a change in pull request #5017: Usage: usage generated for destroyed VMs with no backups

2021-05-25 Thread GitBox
rhtyd commented on a change in pull request #5017: URL: https://github.com/apache/cloudstack/pull/5017#discussion_r638734452 ## File path: engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java ## @@ -613,7 +613,7 @@ boolean ifStateUnchanged(State oldState, State n

[GitHub] [cloudstack] blueorangutan commented on pull request #4819: Remove meaningless password regeneration on resetSSHKeyForVirtualMachine

2021-05-25 Thread GitBox
blueorangutan commented on pull request #4819: URL: https://github.com/apache/cloudstack/pull/4819#issuecomment-847759447 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 85 -- This is an automated message from the Apache Git Servi

[GitHub] [cloudstack] blueorangutan commented on pull request #5037: Updated PowerFlex/ScaleIO gateway client with some improvements.

2021-05-25 Thread GitBox
blueorangutan commented on pull request #5037: URL: https://github.com/apache/cloudstack/pull/5037#issuecomment-847748924 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 84 -- This is an automated message from the Apache Git Servi

[GitHub] [cloudstack] DaanHoogland commented on pull request #4703: Improve logs on ProcessRunner

2021-05-25 Thread GitBox
DaanHoogland commented on pull request #4703: URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-847738713 doesn't look like more is needed to me. @sureshanaparti, @borisstoyanov , @vladimirpetrov do you agree those test results look good? -- This is an automated message f

[GitHub] [cloudstack] blueorangutan commented on pull request #5037: Updated PowerFlex/ScaleIO gateway client with some improvements.

2021-05-25 Thread GitBox
blueorangutan commented on pull request #5037: URL: https://github.com/apache/cloudstack/pull/5037#issuecomment-847729699 @sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] sureshanaparti commented on pull request #5037: Updated PowerFlex/ScaleIO gateway client with some improvements.

2021-05-25 Thread GitBox
sureshanaparti commented on pull request #5037: URL: https://github.com/apache/cloudstack/pull/5037#issuecomment-847729375 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] sureshanaparti opened a new pull request #5037: Updated PowerFlex/ScaleIO gateway client with some improvements.

2021-05-25 Thread GitBox
sureshanaparti opened a new pull request #5037: URL: https://github.com/apache/cloudstack/pull/5037 ### Description This PR updates the PowerFlex/ScaleIO gateway client with the following improvements. - Added connection manager to the gateway client. - Updated storage pool clie

[cloudstack] branch master updated: Externalize OOBM background task's interval (#4881)

2021-05-25 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 06744c1 Externalize OOBM background task's in

[GitHub] [cloudstack] DaanHoogland merged pull request #4881: Externalize OOBM background task's interval

2021-05-25 Thread GitBox
DaanHoogland merged pull request #4881: URL: https://github.com/apache/cloudstack/pull/4881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [cloudstack] DaanHoogland commented on pull request #4881: Externalize OOBM background task's interval

2021-05-25 Thread GitBox
DaanHoogland commented on pull request #4881: URL: https://github.com/apache/cloudstack/pull/4881#issuecomment-847720545 @GutoVeronezi not from me. taking @rhtyd 's silence as a concurrance. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [cloudstack] DaanHoogland commented on issue #4897: Eliminate *_details table inconsistency

2021-05-25 Thread GitBox
DaanHoogland commented on issue #4897: URL: https://github.com/apache/cloudstack/issues/4897#issuecomment-847711791 I don't know if there is any requirement for a detail in the system. In cases where details might be copied we will certainly have to allign tables (i.e. template > vm_insta

  1   2   >