[GitHub] [cloudstack] blueorangutan commented on pull request #5136: apiserver : Ensure required parameters are not empty

2021-06-21 Thread GitBox
blueorangutan commented on pull request #5136: URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-865651724 @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5008: Decouple service (compute) offering and disk offering

2021-06-21 Thread GitBox
DaanHoogland commented on a change in pull request #5008: URL: https://github.com/apache/cloudstack/pull/5008#discussion_r655927095 ## File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java ## @@ -3851,8 +3851,9 @@ public void checkIfCanUpgra

[GitHub] [cloudstack] davidjumani commented on pull request #5136: apiserver : Ensure required parameters are not empty

2021-06-21 Thread GitBox
davidjumani commented on pull request #5136: URL: https://github.com/apache/cloudstack/pull/5136#issuecomment-865650926 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] DaanHoogland commented on pull request #5125: volume: Fix deletion of Uploaded volumes

2021-06-21 Thread GitBox
DaanHoogland commented on pull request #5125: URL: https://github.com/apache/cloudstack/pull/5125#issuecomment-865647484 @Pearl1594 your code is very popular (5x :heavy_check_mark: ) but I see some errors in the trillian output. Can you investigate, please? -- This is an automated messag

[GitHub] [cloudstack] DaanHoogland commented on pull request #5132: Change logrotate interval to hourly

2021-06-21 Thread GitBox
DaanHoogland commented on pull request #5132: URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-865646427 @weizhouapache @ravening will we wait with merging for a similar solution for vpcrouter.sh? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] utchoang commented on pull request #4885: UI: Add multiple management server support

2021-06-21 Thread GitBox
utchoang commented on pull request #4885: URL: https://github.com/apache/cloudstack/pull/4885#issuecomment-865644147 @weizhouapache Yes. Two PRs same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [cloudstack] DaanHoogland commented on pull request #4780: Add SharedMountPoint to KVMs supported storage pool types

2021-06-21 Thread GitBox
DaanHoogland commented on pull request #4780: URL: https://github.com/apache/cloudstack/pull/4780#issuecomment-865643341 @GutoVeronezi no, just a test run that shows no regressions. I just started it. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] DaanHoogland commented on pull request #4699: Add new registers in guest_os

2021-06-21 Thread GitBox
DaanHoogland commented on pull request #4699: URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-865642636 @harikrishna-patnala I'm sure @GutoVeronezi doesn't have your document. Can you share it or share the jist of it here? Is it a conflict that would stop us from goi

[GitHub] [cloudstack] davidjumani edited a comment on pull request #5135: api: Add validation for empty vm group name

2021-06-21 Thread GitBox
davidjumani edited a comment on pull request #5135: URL: https://github.com/apache/cloudstack/pull/5135#issuecomment-865629562 `validations = {ApiArgValidator.NotNullOrEmpty}` could be a generic solution in the `Parameter` annotation @shwstppr -- This is an automated message from the Apa

[GitHub] [cloudstack] blueorangutan commented on pull request #4378: server: Optional destination host when migrate a vm

2021-06-21 Thread GitBox
blueorangutan commented on pull request #4378: URL: https://github.com/apache/cloudstack/pull/4378#issuecomment-865639752 @shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an aut

[GitHub] [cloudstack] shwstppr commented on pull request #4378: server: Optional destination host when migrate a vm

2021-06-21 Thread GitBox
shwstppr commented on pull request #4378: URL: https://github.com/apache/cloudstack/pull/4378#issuecomment-865639383 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [cloudstack] weizhouapache commented on pull request #4885: UI: Add multiple management server support

2021-06-21 Thread GitBox
weizhouapache commented on pull request #4885: URL: https://github.com/apache/cloudstack/pull/4885#issuecomment-865637334 I have tested https://github.com/apache/cloudstack-primate/pull/898, which worked. I used nginx or pfsense/haproxy to solve CORS issue. @utchoang are these tw

[GitHub] [cloudstack] davidjumani opened a new pull request #5136: apiserver : Ensure required parameters are not empty

2021-06-21 Thread GitBox
davidjumani opened a new pull request #5136: URL: https://github.com/apache/cloudstack/pull/5136 ### Description Addon to https://github.com/apache/cloudstack/pull/5135 Ensures that any required parameter is not empty / null ### Types of changes - [ ] Breaking change

[GitHub] [cloudstack] wido edited a comment on pull request #4885: UI: Add multiple management server support

2021-06-21 Thread GitBox
wido edited a comment on pull request #4885: URL: https://github.com/apache/cloudstack/pull/4885#issuecomment-865632294 > @davidjumani In the previous discussion at [apache/cloudstack-primate#898](https://github.com/apache/cloudstack-primate/pull/898) there was a discussion about the CORS

[GitHub] [cloudstack] wido commented on pull request #4885: UI: Add multiple management server support

2021-06-21 Thread GitBox
wido commented on pull request #4885: URL: https://github.com/apache/cloudstack/pull/4885#issuecomment-865632294 > @davidjumani In the previous discussion at [apache/cloudstack-primate#898](https://github.com/apache/cloudstack-primate/pull/898) there was a discussion about the CORS issue,

[GitHub] [cloudstack] davidjumani edited a comment on pull request #5135: api: Add validation for empty vm group name

2021-06-21 Thread GitBox
davidjumani edited a comment on pull request #5135: URL: https://github.com/apache/cloudstack/pull/5135#issuecomment-865629562 `validations = {ApiArgValidator.NotNullOrEmpty}` could be a generic solution in the `Parameter` annotation @shwstppr `validateNonEmptyString` be called when any

[GitHub] [cloudstack] davidjumani commented on pull request #5135: api: Add validation for empty vm group name

2021-06-21 Thread GitBox
davidjumani commented on pull request #5135: URL: https://github.com/apache/cloudstack/pull/5135#issuecomment-865629562 `validations = {ApiArgValidator.NotNullOrEmpty}` could be a generic solution in the `Parameter` annotation @shwstppr -- This is an automated message from the Apache Gi

[GitHub] [cloudstack] shwstppr edited a comment on pull request #5135: api: Add validation for empty vm group name

2021-06-21 Thread GitBox
shwstppr edited a comment on pull request #5135: URL: https://github.com/apache/cloudstack/pull/5135#issuecomment-865619844 @Pearl1594 this problem can be with other APIs as well. ``` (localcloud) SBCM5> > create domain name= { "domain": { "haschild": false, "id"

[GitHub] [cloudstack] shwstppr commented on pull request #5135: api: Add validation for empty vm group name

2021-06-21 Thread GitBox
shwstppr commented on pull request #5135: URL: https://github.com/apache/cloudstack/pull/5135#issuecomment-865619844 @Pearl1594 this problem can be with other APIs as well. ``` (localcloud) SBCM5> > create volume name= diskofferingid=b91448e2-4070-4b4a-8757-e7a5c12f9101 zoneid=e5dff2

[GitHub] [cloudstack] blueorangutan commented on pull request #4885: UI: Add multiple management server support

2021-06-21 Thread GitBox
blueorangutan commented on pull request #4885: URL: https://github.com/apache/cloudstack/pull/4885#issuecomment-865618218 UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4885 (SL-JID-273) -- This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack] blueorangutan commented on pull request #4885: UI: Add multiple management server support

2021-06-21 Thread GitBox
blueorangutan commented on pull request #4885: URL: https://github.com/apache/cloudstack/pull/4885#issuecomment-865616326 @utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] utchoang commented on pull request #4885: UI: Add multiple management server support

2021-06-21 Thread GitBox
utchoang commented on pull request #4885: URL: https://github.com/apache/cloudstack/pull/4885#issuecomment-865616146 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [cloudstack] utchoang commented on pull request #4885: UI: Add multiple management server support

2021-06-21 Thread GitBox
utchoang commented on pull request #4885: URL: https://github.com/apache/cloudstack/pull/4885#issuecomment-865614966 @davidjumani In the previous discussion at https://github.com/apache/cloudstack-primate/pull/898 there was a discussion about the CORS issue, and I think it will be solved b

[GitHub] [cloudstack] blueorangutan commented on pull request #5135: api: Add validation for empty vm group name

2021-06-21 Thread GitBox
blueorangutan commented on pull request #5135: URL: https://github.com/apache/cloudstack/pull/5135#issuecomment-865600131 @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] Pearl1594 commented on pull request #5135: api: Add validation for empty vm group name

2021-06-21 Thread GitBox
Pearl1594 commented on pull request #5135: URL: https://github.com/apache/cloudstack/pull/5135#issuecomment-865599215 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [cloudstack] blueorangutan commented on pull request #5135: api: Add validation for empty vm group name

2021-06-21 Thread GitBox
blueorangutan commented on pull request #5135: URL: https://github.com/apache/cloudstack/pull/5135#issuecomment-865594438 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 318 -- This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] blueorangutan commented on pull request #5135: api: Add validation for empty vm group name

2021-06-21 Thread GitBox
blueorangutan commented on pull request #5135: URL: https://github.com/apache/cloudstack/pull/5135#issuecomment-865556335 @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] slavkap commented on pull request #4878: Support vm dynamic scaling with kvm

2021-06-21 Thread GitBox
slavkap commented on pull request #4878: URL: https://github.com/apache/cloudstack/pull/4878#issuecomment-86942 @GutoVeronezi, I've tested this with few use cases, and it works as expected. However, I've hit one problem, but not sure if it has to be fixed in this PR: - Create uncons

[GitHub] [cloudstack] Pearl1594 commented on pull request #5135: api: Add validation for empty vm group name

2021-06-21 Thread GitBox
Pearl1594 commented on pull request #5135: URL: https://github.com/apache/cloudstack/pull/5135#issuecomment-865554622 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [cloudstack] Pearl1594 opened a new pull request #5135: api: Add validation for empty vm group name

2021-06-21 Thread GitBox
Pearl1594 opened a new pull request #5135: URL: https://github.com/apache/cloudstack/pull/5135 ### Description This PR prevents creation of an instance group with an empty name ### Types of changes - [ ] Breaking change (fix or feature that would caus

[GitHub] [cloudstack] davidjumani commented on pull request #4885: UI: Add multiple management server support

2021-06-21 Thread GitBox
davidjumani commented on pull request #4885: URL: https://github.com/apache/cloudstack/pull/4885#issuecomment-865543697 @utchoang Did you face any CORS issue ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [cloudstack] davidjumani commented on a change in pull request #4885: UI: Add multiple management server support

2021-06-21 Thread GitBox
davidjumani commented on a change in pull request #4885: URL: https://github.com/apache/cloudstack/pull/4885#discussion_r655869685 ## File path: ui/src/components/header/UserMenu.vue ## @@ -20,6 +20,15 @@ + +

[GitHub] [cloudstack] davidjumani edited a comment on pull request #5060: ui: Adding option to choose between name and displayname

2021-06-21 Thread GitBox
davidjumani edited a comment on pull request #5060: URL: https://github.com/apache/cloudstack/pull/5060#issuecomment-865520284 @DaanHoogland @rhtyd Would it be better to have an option to let the user select which columns to display ? And any idea where to place it ? General idea :

[GitHub] [cloudstack] davidjumani commented on pull request #5060: ui: Adding option to choose between name and displayname

2021-06-21 Thread GitBox
davidjumani commented on pull request #5060: URL: https://github.com/apache/cloudstack/pull/5060#issuecomment-865520284 @DaanHoogland @rhtyd Would it be better to have an option to let the user select which columns to be displayed ? And any idea where to place it ? General idea :

[GitHub] [cloudstack] davidjumani edited a comment on issue #5126: UI: Quick view option is not available for newly create resources

2021-06-21 Thread GitBox
davidjumani edited a comment on issue #5126: URL: https://github.com/apache/cloudstack/issues/5126#issuecomment-865518192 @utchoang Destroy a systemvm and hit refresh until a new one comes up, and it'll not have a quickview option even when running -- This is an automated message from th

[GitHub] [cloudstack] davidjumani edited a comment on issue #5126: UI: Quick view option is not available for newly create resources

2021-06-21 Thread GitBox
davidjumani edited a comment on issue #5126: URL: https://github.com/apache/cloudstack/issues/5126#issuecomment-865518192 @utchoang Destroy a systemvm and hit refresh until a new one comes up, and it'll not have a quickview option even when up -- This is an automated message from the Apa

[GitHub] [cloudstack] davidjumani commented on issue #5126: UI: Quick view option is not available for newly create resources

2021-06-21 Thread GitBox
davidjumani commented on issue #5126: URL: https://github.com/apache/cloudstack/issues/5126#issuecomment-865518192 @utchoang Try to deploy a zone and open the systemvms tab, at that point when the VM is starting it'll have no quickview, and after refreshing a couple of times the vms will c

[GitHub] [cloudstack] div8cn opened a new issue #5134: Opening web console after enable ssl is very slow

2021-06-21 Thread GitBox
div8cn opened a new issue #5134: URL: https://github.com/apache/cloudstack/issues/5134 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ CPVM noVNC ~~~ # CLOUDSTACK VERSION ~~~ 4.15.0.0 ~~~ # CONFIGURATION

[GitHub] [cloudstack] blueorangutan commented on pull request #5002: db: Cleanup obsolete tables

2021-06-21 Thread GitBox
blueorangutan commented on pull request #5002: URL: https://github.com/apache/cloudstack/pull/5002#issuecomment-865444317 Trillian test result (tid-1028) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 50231 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #5130: Fix of delete of Ceph's snapshots from secondary storage

2021-06-21 Thread GitBox
blueorangutan commented on pull request #5130: URL: https://github.com/apache/cloudstack/pull/5130#issuecomment-865422503 Trillian test result (tid-1027) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 53251 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #4575: Enhance log messages with host name

2021-06-21 Thread GitBox
blueorangutan commented on pull request #4575: URL: https://github.com/apache/cloudstack/pull/4575#issuecomment-865416113 Trillian test result (tid-1023) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 56119 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #4959: Improve logs on ConsoleProxyManagerImpl and refactor a few process

2021-06-21 Thread GitBox
blueorangutan commented on pull request #4959: URL: https://github.com/apache/cloudstack/pull/4959#issuecomment-865407384 Trillian test result (tid-1026) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 51638 seconds Marvin logs: https://githu

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #5043: Allow updating the storage/host tags of service offerings

2021-06-21 Thread GitBox
GabrielBrascher commented on a change in pull request #5043: URL: https://github.com/apache/cloudstack/pull/5043#discussion_r655695768 ## File path: api/src/main/java/org/apache/cloudstack/api/command/admin/offering/UpdateServiceOfferingCmd.java ## @@ -71,6 +73,20 @@

[GitHub] [cloudstack] blueorangutan commented on pull request #4878: Support vm dynamic scaling with kvm

2021-06-21 Thread GitBox
blueorangutan commented on pull request #4878: URL: https://github.com/apache/cloudstack/pull/4878#issuecomment-865331519 Trillian test result (tid-1024) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45222 seconds Marvin logs: https://githu

[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #4978: KVM High Availability regardless of storage

2021-06-21 Thread GitBox
GutoVeronezi commented on a change in pull request #4978: URL: https://github.com/apache/cloudstack/pull/4978#discussion_r655691011 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/ha/KVMInvestigator.java ## @@ -101,24 +115,29 @@ public Status isAgentAlive(Host ag

[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #4978: KVM High Availability regardless of storage

2021-06-21 Thread GitBox
GutoVeronezi commented on a change in pull request #4978: URL: https://github.com/apache/cloudstack/pull/4978#discussion_r655691011 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/ha/KVMInvestigator.java ## @@ -101,24 +115,29 @@ public Status isAgentAlive(Host ag

[GitHub] [cloudstack] blueorangutan commented on pull request #4978: KVM High Availability regardless of storage

2021-06-21 Thread GitBox
blueorangutan commented on pull request #4978: URL: https://github.com/apache/cloudstack/pull/4978#issuecomment-865323546 Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_multiplication_x: debian. SL-JID 315 -- This is an automated message from t

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4978: KVM High Availability regardless of storage

2021-06-21 Thread GitBox
GabrielBrascher commented on a change in pull request #4978: URL: https://github.com/apache/cloudstack/pull/4978#discussion_r655677278 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/ha/KVMInvestigator.java ## @@ -101,24 +115,29 @@ public Status isAgentAlive(Host

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4978: KVM High Availability regardless of storage

2021-06-21 Thread GitBox
GabrielBrascher commented on a change in pull request #4978: URL: https://github.com/apache/cloudstack/pull/4978#discussion_r655677278 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/ha/KVMInvestigator.java ## @@ -101,24 +115,29 @@ public Status isAgentAlive(Host

[GitHub] [cloudstack] blueorangutan commented on pull request #4978: KVM High Availability regardless of storage

2021-06-21 Thread GitBox
blueorangutan commented on pull request #4978: URL: https://github.com/apache/cloudstack/pull/4978#issuecomment-865317286 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service

[GitHub] [cloudstack] GabrielBrascher commented on pull request #4978: KVM High Availability regardless of storage

2021-06-21 Thread GitBox
GabrielBrascher commented on pull request #4978: URL: https://github.com/apache/cloudstack/pull/4978#issuecomment-865316576 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] GabrielBrascher commented on issue #5124: KVM disk-only based snapshot of volumes instead of taking VM's full snapshot and extracting disks

2021-06-21 Thread GitBox
GabrielBrascher commented on issue #5124: URL: https://github.com/apache/cloudstack/issues/5124#issuecomment-865313161 @GutoVeronezi thanks for sharing this design; looks good. This execution flow should be improved indeed. I can't wait to see the implementation. -- This is an automat

[GitHub] [cloudstack] blueorangutan commented on pull request #5132: Change logrotate interval to hourly

2021-06-21 Thread GitBox
blueorangutan commented on pull request #5132: URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-865235351 Trillian test result (tid-1025) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33895 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #5004: Follow consistent vo table name convention

2021-06-21 Thread GitBox
blueorangutan commented on pull request #5004: URL: https://github.com/apache/cloudstack/pull/5004#issuecomment-865213640 Trillian test result (tid-1022) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38051 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #5008: Decouple service (compute) offering and disk offering

2021-06-21 Thread GitBox
blueorangutan commented on pull request #5008: URL: https://github.com/apache/cloudstack/pull/5008#issuecomment-865183023 Trillian test result (tid-1021) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 70477 seconds Marvin logs: https://githu

[GitHub] [cloudstack] GutoVeronezi commented on pull request #4878: Support vm dynamic scaling with kvm

2021-06-21 Thread GitBox
GutoVeronezi commented on pull request #4878: URL: https://github.com/apache/cloudstack/pull/4878#issuecomment-865058066 @GabrielBrascher could you review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack] GutoVeronezi commented on pull request #4790: Externalize secondary storage capacity threshold

2021-06-21 Thread GitBox
GutoVeronezi commented on pull request #4790: URL: https://github.com/apache/cloudstack/pull/4790#issuecomment-865054458 @sureshanaparti @DaanHoogland @GabrielBrascher is there anything else to do? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [cloudstack] GutoVeronezi commented on pull request #4780: Add SharedMountPoint to KVMs supported storage pool types

2021-06-21 Thread GitBox
GutoVeronezi commented on pull request #4780: URL: https://github.com/apache/cloudstack/pull/4780#issuecomment-865052606 @DaanHoogland @GabrielBrascher is there anything else to do? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5008: Decouple service (compute) offering and disk offering

2021-06-21 Thread GitBox
sureshanaparti commented on a change in pull request #5008: URL: https://github.com/apache/cloudstack/pull/5008#discussion_r655398004 ## File path: server/src/main/java/com/cloud/server/ConfigurationServerImpl.java ## @@ -926,16 +926,21 @@ private DiskOfferingVO createDefaultDi

[GitHub] [cloudstack] GutoVeronezi commented on pull request #4699: Add new registers in guest_os

2021-06-21 Thread GitBox
GutoVeronezi commented on pull request #4699: URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-865052134 @harikrishna-patnala any update about @rhtyd's comment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5008: Decouple service (compute) offering and disk offering

2021-06-21 Thread GitBox
sureshanaparti commented on a change in pull request #5008: URL: https://github.com/apache/cloudstack/pull/5008#discussion_r655389615 ## File path: engine/schema/src/main/java/com/cloud/service/ServiceOfferingVO.java ## @@ -103,11 +146,16 @@ public ServiceOfferingVO(String name

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5008: Decouple service (compute) offering and disk offering

2021-06-21 Thread GitBox
sureshanaparti commented on a change in pull request #5008: URL: https://github.com/apache/cloudstack/pull/5008#discussion_r655386222 ## File path: api/src/main/java/org/apache/cloudstack/api/response/DiskOfferingResponse.java ## @@ -155,6 +155,10 @@ @Param(description =

[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5030: refactor: migrate vm with storage

2021-06-21 Thread GitBox
GutoVeronezi commented on a change in pull request #5030: URL: https://github.com/apache/cloudstack/pull/5030#discussion_r655372731 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -575,6 +575,13 @@ private static final ConfigKey VmDestroyForces

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5008: Decouple service (compute) offering and disk offering

2021-06-21 Thread GitBox
sureshanaparti commented on a change in pull request #5008: URL: https://github.com/apache/cloudstack/pull/5008#discussion_r655374654 ## File path: api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java ## @@ -239,6 +239,10 @@ description = "

[GitHub] [cloudstack] weizhouapache commented on pull request #5132: Change logrotate interval to hourly

2021-06-21 Thread GitBox
weizhouapache commented on pull request #5132: URL: https://github.com/apache/cloudstack/pull/5132#issuecomment-864989204 @ravening could you fix vpcrouter as well ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4378: server: Optional destination host when migrate a vm

2021-06-21 Thread GitBox
weizhouapache commented on a change in pull request #4378: URL: https://github.com/apache/cloudstack/pull/4378#discussion_r655318680 ## File path: ui/src/views/compute/MigrateWizard.vue ## @@ -168,6 +170,12 @@ export default { this.hosts.sort((a, b) => { ret

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #5130: Fix of delete of Ceph's snapshots from secondary storage

2021-06-21 Thread GitBox
GabrielBrascher commented on a change in pull request #5130: URL: https://github.com/apache/cloudstack/pull/5130#discussion_r655317878 ## File path: engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/CephSnapshotStrategy.java ## @@ -64,10 +64,6 @@ pub

[GitHub] [cloudstack] blueorangutan commented on pull request #4378: server: Optional destination host when migrate a vm

2021-06-21 Thread GitBox
blueorangutan commented on pull request #4378: URL: https://github.com/apache/cloudstack/pull/4378#issuecomment-864964761 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 314 -- This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] shwstppr commented on a change in pull request #4378: server: Optional destination host when migrate a vm

2021-06-21 Thread GitBox
shwstppr commented on a change in pull request #4378: URL: https://github.com/apache/cloudstack/pull/4378#discussion_r655297475 ## File path: ui/src/views/compute/MigrateWizard.vue ## @@ -168,6 +170,12 @@ export default { this.hosts.sort((a, b) => { return b

[GitHub] [cloudstack] blueorangutan commented on pull request #4378: server: Optional destination host when migrate a vm

2021-06-21 Thread GitBox
blueorangutan commented on pull request #4378: URL: https://github.com/apache/cloudstack/pull/4378#issuecomment-864956342 UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4378 (SL-JID-270) -- This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack] blueorangutan commented on pull request #4378: server: Optional destination host when migrate a vm

2021-06-21 Thread GitBox
blueorangutan commented on pull request #4378: URL: https://github.com/apache/cloudstack/pull/4378#issuecomment-864952180 @weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] weizhouapache commented on pull request #4378: server: Optional destination host when migrate a vm

2021-06-21 Thread GitBox
weizhouapache commented on pull request #4378: URL: https://github.com/apache/cloudstack/pull/4378#issuecomment-864952004 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] blueorangutan commented on pull request #4378: server: Optional destination host when migrate a vm

2021-06-21 Thread GitBox
blueorangutan commented on pull request #4378: URL: https://github.com/apache/cloudstack/pull/4378#issuecomment-864948905 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] shwstppr commented on pull request #4378: server: Optional destination host when migrate a vm

2021-06-21 Thread GitBox
shwstppr commented on pull request #4378: URL: https://github.com/apache/cloudstack/pull/4378#issuecomment-864948548 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] weizhouapache commented on pull request #4378: server: Optional destination host when migrate a vm

2021-06-21 Thread GitBox
weizhouapache commented on pull request #4378: URL: https://github.com/apache/cloudstack/pull/4378#issuecomment-864944437 @shwstppr @rhtyd updated this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack] blueorangutan commented on pull request #5008: Decouple service offering disk offering

2021-06-21 Thread GitBox
blueorangutan commented on pull request #5008: URL: https://github.com/apache/cloudstack/pull/5008#issuecomment-864938606 Trillian test result (tid-1019) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 50472 seconds Marvin logs: https://gith

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5130: Fix of delete of Ceph's snapshots from secondary storage

2021-06-21 Thread GitBox
sureshanaparti commented on a change in pull request #5130: URL: https://github.com/apache/cloudstack/pull/5130#discussion_r655267427 ## File path: engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/CephSnapshotStrategy.java ## @@ -64,10 +64,6 @@ publ

[GitHub] [cloudstack] blueorangutan commented on pull request #5008: Decouple service offering disk offering

2021-06-21 Thread GitBox
blueorangutan commented on pull request #5008: URL: https://github.com/apache/cloudstack/pull/5008#issuecomment-864926232 Trillian test result (tid-1020) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48456 seconds Marvin logs: https://githu

[cloudstack] branch decoupleServiceOfferingDiskOffering updated (841a011 -> fc32515)

2021-06-21 Thread harikrishna
This is an automated email from the ASF dual-hosted git repository. harikrishna pushed a change to branch decoupleServiceOfferingDiskOffering in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 841a011 Fix delete compute offering add 66f2045 Fix VM deployment from c

[GitHub] [cloudstack] blueorangutan commented on pull request #5002: db: Cleanup obsolete tables

2021-06-21 Thread GitBox
blueorangutan commented on pull request #5002: URL: https://github.com/apache/cloudstack/pull/5002#issuecomment-864919256 @davidjumani a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] davidjumani edited a comment on pull request #5002: db: Cleanup obsolete tables

2021-06-21 Thread GitBox
davidjumani edited a comment on pull request #5002: URL: https://github.com/apache/cloudstack/pull/5002#issuecomment-864918892 @blueorangutan test centos7 vmware-65u2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [cloudstack] davidjumani commented on pull request #5002: db: Cleanup obsolete tables

2021-06-21 Thread GitBox
davidjumani commented on pull request #5002: URL: https://github.com/apache/cloudstack/pull/5002#issuecomment-864918892 @blueorangutan test centos7 vmware65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [cloudstack] blueorangutan commented on pull request #5002: db: Cleanup obsolete tables

2021-06-21 Thread GitBox
blueorangutan commented on pull request #5002: URL: https://github.com/apache/cloudstack/pull/5002#issuecomment-864918650 @davidjumani unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, centos8, ubuntu18, ubuntu20`. Supported hypervisors are: `kvm-centos6, kv

[GitHub] [cloudstack] davidjumani commented on pull request #5002: db: Cleanup obsolete tables

2021-06-21 Thread GitBox
davidjumani commented on pull request #5002: URL: https://github.com/apache/cloudstack/pull/5002#issuecomment-864918218 @blueorangutan test centos7 vmware65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [cloudstack] blueorangutan commented on pull request #5002: db: Cleanup obsolete tables

2021-06-21 Thread GitBox
blueorangutan commented on pull request #5002: URL: https://github.com/apache/cloudstack/pull/5002#issuecomment-864896771 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 313 -- This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] weizhouapache commented on pull request #5130: Fix of delete of Ceph's snapshots from secondary storage

2021-06-21 Thread GitBox
weizhouapache commented on pull request #5130: URL: https://github.com/apache/cloudstack/pull/5130#issuecomment-864896395 > enough but I'll rerun the smoke tests anyway to make sure these last three failures are spurious. @DaanHoogland we had the failures in many smoke tests, wh

[GitHub] [cloudstack] blueorangutan commented on pull request #5002: db: Cleanup obsolete tables

2021-06-21 Thread GitBox
blueorangutan commented on pull request #5002: URL: https://github.com/apache/cloudstack/pull/5002#issuecomment-864879206 @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] davidjumani commented on pull request #5002: db: Cleanup obsolete tables

2021-06-21 Thread GitBox
davidjumani commented on pull request #5002: URL: https://github.com/apache/cloudstack/pull/5002#issuecomment-864878671 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #5002: db: Cleanup obsolete tables

2021-06-21 Thread GitBox
blueorangutan commented on pull request #5002: URL: https://github.com/apache/cloudstack/pull/5002#issuecomment-864875014 Packaging result: :heavy_multiplication_x: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 312 -- This is an automated message from the Apache Gi

[GitHub] [cloudstack] blueorangutan commented on pull request #5067: Keep volume policies after migrating it to another primary storage

2021-06-21 Thread GitBox
blueorangutan commented on pull request #5067: URL: https://github.com/apache/cloudstack/pull/5067#issuecomment-864871437 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 311 -- This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] slavkap commented on pull request #3724: Storage-based Snapshots for KVM VMs

2021-06-21 Thread GitBox
slavkap commented on pull request #3724: URL: https://github.com/apache/cloudstack/pull/3724#issuecomment-864857010 Thanks, @DaanHoogland. I will add these checks depending on OS and qemu version -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [cloudstack] slavkap commented on pull request #5130: Fix of delete of Ceph's snapshots from secondary storage

2021-06-21 Thread GitBox
slavkap commented on pull request #5130: URL: https://github.com/apache/cloudstack/pull/5130#issuecomment-864853357 Thank you all for the reviews! OK @DaanHoogland, all tests have failed with this - Failed to SSH into VM (which I guess it's not related to) -- This is an automated message

[GitHub] [cloudstack] DaanHoogland commented on pull request #3724: Storage-based Snapshots for KVM VMs

2021-06-21 Thread GitBox
DaanHoogland commented on pull request #3724: URL: https://github.com/apache/cloudstack/pull/3724#issuecomment-864851177 It's allright to test for requirements and execute based on availability, so by no means remove them, @slavkap . My biggest worry is the big interval of functionality

[GitHub] [cloudstack] blueorangutan commented on pull request #5002: db: Cleanup obsolete tables

2021-06-21 Thread GitBox
blueorangutan commented on pull request #5002: URL: https://github.com/apache/cloudstack/pull/5002#issuecomment-864850327 @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] davidjumani commented on pull request #5002: db: Cleanup obsolete tables

2021-06-21 Thread GitBox
davidjumani commented on pull request #5002: URL: https://github.com/apache/cloudstack/pull/5002#issuecomment-864849790 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] DaanHoogland commented on pull request #5130: Fix of delete of Ceph's snapshots from secondary storage

2021-06-21 Thread GitBox
DaanHoogland commented on pull request #5130: URL: https://github.com/apache/cloudstack/pull/5130#issuecomment-864849090 enough :+1: but I'll rerun the smoke tests anyway to make sure these last three failures are spurious. -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] blueorangutan commented on pull request #5106: tests: Fix test failures for Local storage and Basic zones

2021-06-21 Thread GitBox
blueorangutan commented on pull request #5106: URL: https://github.com/apache/cloudstack/pull/5106#issuecomment-864844823 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 310 -- This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5067: Keep volume policies after migrating it to another primary storage

2021-06-21 Thread GitBox
blueorangutan removed a comment on pull request #5067: URL: https://github.com/apache/cloudstack/pull/5067#issuecomment-864065498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [cloudstack] DaanHoogland commented on pull request #5030: refactor: migrate vm with storage

2021-06-21 Thread GitBox
DaanHoogland commented on pull request #5030: URL: https://github.com/apache/cloudstack/pull/5030#issuecomment-864839484 @GutoVeronezi I resolved some of your comments on outdated code. Are all your questions/comments addressed (i.e. lgty?) -- This is an automated message from the Apache

[GitHub] [cloudstack] slavkap commented on pull request #3724: Storage-based Snapshots for KVM VMs

2021-06-21 Thread GitBox
slavkap commented on pull request #3724: URL: https://github.com/apache/cloudstack/pull/3724#issuecomment-864827359 Thank you, @DaanHoogland. Then it's normal mine Marvin's tests to fail. Do I have to remove the tests from this PR or skip them? -- This is an automated message from the Ap

  1   2   >