[GitHub] [cloudstack] blueorangutan commented on pull request #5075: ui: vmware vm import-unmanage

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5075: URL: https://github.com/apache/cloudstack/pull/5075#issuecomment-875340001 @shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] shwstppr commented on pull request #5075: ui: vmware vm import-unmanage

2021-07-06 Thread GitBox
shwstppr commented on pull request #5075: URL: https://github.com/apache/cloudstack/pull/5075#issuecomment-875339384 Last commit unrelated to import wizard/form. A change in UI component was causing some fields not visible in AddNetworkOffering form. Fixed now. @blueorangutan ui --

[GitHub] [cloudstack] abdelouahabb opened a new issue #5189: Kubuntu returns Neon which causes error

2021-07-06 Thread GitBox
abdelouahabb opened a new issue #5189: URL: https://github.com/apache/cloudstack/issues/5189 In the file `/usr/lib/python3/dist-packages/cloudutils/syscfg.py` there is only Ubuntu, but in Kubuntu, it gives Neon if you run `/usr/bin/lsb_release -i Distributor ID: Neon `

[GitHub] [cloudstack] abdelouahabb opened a new issue #5188: Broken link in the 4.15.1 docs

2021-07-06 Thread GitBox
abdelouahabb opened a new issue #5188: URL: https://github.com/apache/cloudstack/issues/5188 Please update the main docs : `deb http://server.url/cloudstack/repo/binary ./` `wget -q -O - http://server.url/cloudstack/repo/binary/KEY.gpg | sudo apt-key add -` Url : http:

[GitHub] [cloudstack] blueorangutan commented on pull request #5184: server: fix network access for addNicToVirtualMachine API

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5184: URL: https://github.com/apache/cloudstack/pull/5184#issuecomment-875151460 Trillian test result (tid-1210) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33430 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #5186: Remove condition that are prevent resizing for root volumes (vmware)

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5186: URL: https://github.com/apache/cloudstack/pull/5186#issuecomment-875097262 @shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] shwstppr commented on pull request #5186: Remove condition that are prevent resizing for root volumes (vmware)

2021-07-06 Thread GitBox
shwstppr commented on pull request #5186: URL: https://github.com/apache/cloudstack/pull/5186#issuecomment-875096896 @blueorangutan test centos7 vmware-65u2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [cloudstack] blueorangutan commented on pull request #5186: Remove condition that are prevent resizing for root volumes (vmware)

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5186: URL: https://github.com/apache/cloudstack/pull/5186#issuecomment-875096338 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 482 -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] blueorangutan commented on pull request #5139: marvin: make deployDataCenter.py script compatible with python 2 and 3

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5139: URL: https://github.com/apache/cloudstack/pull/5139#issuecomment-875093028 Trillian test result (tid-1207) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34453 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #5186: Remove condition that are prevent resizing for root volumes (vmware)

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5186: URL: https://github.com/apache/cloudstack/pull/5186#issuecomment-875081938 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] shwstppr commented on pull request #5186: Remove condition that are prevent resizing for root volumes (vmware)

2021-07-06 Thread GitBox
shwstppr commented on pull request #5186: URL: https://github.com/apache/cloudstack/pull/5186#issuecomment-875081576 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] mib1185 commented on pull request #5186: Remove condition that are prevent resizing for root volumes (vmware)

2021-07-06 Thread GitBox
mib1185 commented on pull request #5186: URL: https://github.com/apache/cloudstack/pull/5186#issuecomment-875030476 @blueorangutan test centos7 vmware-65u2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack] blueorangutan commented on pull request #5184: server: fix network access for addNicToVirtualMachine API

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5184: URL: https://github.com/apache/cloudstack/pull/5184#issuecomment-874776599 @shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] shwstppr commented on pull request #5184: server: fix network access for addNicToVirtualMachine API

2021-07-06 Thread GitBox
shwstppr commented on pull request #5184: URL: https://github.com/apache/cloudstack/pull/5184#issuecomment-874775989 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [cloudstack] blueorangutan commented on pull request #5184: server: fix network access for addNicToVirtualMachine API

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5184: URL: https://github.com/apache/cloudstack/pull/5184#issuecomment-874763959 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 481 -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] blueorangutan commented on pull request #4640: Added disk provisioning type support for VMWare

2021-07-06 Thread GitBox
blueorangutan commented on pull request #4640: URL: https://github.com/apache/cloudstack/pull/4640#issuecomment-874757742 @Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] Spaceman1984 commented on pull request #4640: Added disk provisioning type support for VMWare

2021-07-06 Thread GitBox
Spaceman1984 commented on pull request #4640: URL: https://github.com/apache/cloudstack/pull/4640#issuecomment-874757108 @blueorangutan test centos7 vmware-67u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack] Spaceman1984 opened a new pull request #5187: Added ability to create schemas only when using cloudstack-setup-data…

2021-07-06 Thread GitBox
Spaceman1984 opened a new pull request #5187: URL: https://github.com/apache/cloudstack/pull/5187 …bases ### Description This PR adds the ability to run the cloudstack-setup-databases script without having to know the root user credentials. The cloud and cloud_usage dat

[GitHub] [cloudstack] blueorangutan commented on pull request #5184: server: fix network access for addNicToVirtualMachine API

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5184: URL: https://github.com/apache/cloudstack/pull/5184#issuecomment-874744389 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] shwstppr commented on pull request #5184: server: fix network access for addNicToVirtualMachine API

2021-07-06 Thread GitBox
shwstppr commented on pull request #5184: URL: https://github.com/apache/cloudstack/pull/5184#issuecomment-874743736 @weizhouapache done @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5184: server: fix network access for addNicToVirtualMachine API

2021-07-06 Thread GitBox
blueorangutan removed a comment on pull request #5184: URL: https://github.com/apache/cloudstack/pull/5184#issuecomment-874690113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [cloudstack] shwstppr removed a comment on pull request #5184: server: fix network access for addNicToVirtualMachine API

2021-07-06 Thread GitBox
shwstppr removed a comment on pull request #5184: URL: https://github.com/apache/cloudstack/pull/5184#issuecomment-874716456 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cloudstack] shwstppr removed a comment on pull request #5184: server: fix network access for addNicToVirtualMachine API

2021-07-06 Thread GitBox
shwstppr removed a comment on pull request #5184: URL: https://github.com/apache/cloudstack/pull/5184#issuecomment-874689866 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack] weizhouapache commented on pull request #5184: server: fix network access for addNicToVirtualMachine API

2021-07-06 Thread GitBox
weizhouapache commented on pull request #5184: URL: https://github.com/apache/cloudstack/pull/5184#issuecomment-874727171 @shwstppr re-target to 4.15 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack] shwstppr closed pull request #5184: server: fix network access for addNicToVirtualMachine API

2021-07-06 Thread GitBox
shwstppr closed pull request #5184: URL: https://github.com/apache/cloudstack/pull/5184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [cloudstack] blueorangutan commented on pull request #5184: server: fix network access for addNicToVirtualMachine API

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5184: URL: https://github.com/apache/cloudstack/pull/5184#issuecomment-874716953 @shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] shwstppr commented on pull request #5184: server: fix network access for addNicToVirtualMachine API

2021-07-06 Thread GitBox
shwstppr commented on pull request #5184: URL: https://github.com/apache/cloudstack/pull/5184#issuecomment-874716456 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [cloudstack] blueorangutan commented on pull request #5184: server: fix network access for addNicToVirtualMachine API

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5184: URL: https://github.com/apache/cloudstack/pull/5184#issuecomment-874704693 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 480 -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] Pearl1594 commented on pull request #5139: marvin: make deployDataCenter.py script compatible with python 2 and 3

2021-07-06 Thread GitBox
Pearl1594 commented on pull request #5139: URL: https://github.com/apache/cloudstack/pull/5139#issuecomment-874678981 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [cloudstack] DK101010 opened a new pull request #5186: Remove condition that are prevent resizing for root volumes (vmware)

2021-07-06 Thread GitBox
DK101010 opened a new pull request #5186: URL: https://github.com/apache/cloudstack/pull/5186 ### Description Remove condition that are prevent resizing for root volumes (vmware). ### Types of changes - [ ] Breaking change (fix or feature that would c

[GitHub] [cloudstack] blueorangutan commented on pull request #5139: marvin: make deployDataCenter.py script compatible with python 2 and 3

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5139: URL: https://github.com/apache/cloudstack/pull/5139#issuecomment-874678061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] blueorangutan commented on pull request #4640: Added disk provisioning type support for VMWare

2021-07-06 Thread GitBox
blueorangutan commented on pull request #4640: URL: https://github.com/apache/cloudstack/pull/4640#issuecomment-874677735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] Spaceman1984 commented on pull request #4640: Added disk provisioning type support for VMWare

2021-07-06 Thread GitBox
Spaceman1984 commented on pull request #4640: URL: https://github.com/apache/cloudstack/pull/4640#issuecomment-874677576 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [cloudstack] shwstppr commented on pull request #5184: server: fix network access for addNicToVirtualMachine API

2021-07-06 Thread GitBox
shwstppr commented on pull request #5184: URL: https://github.com/apache/cloudstack/pull/5184#issuecomment-874689866 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] blueorangutan commented on pull request #5184: server: fix network access for addNicToVirtualMachine API

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5184: URL: https://github.com/apache/cloudstack/pull/5184#issuecomment-874690113 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] rhtyd commented on pull request #4699: Add new registers in guest_os

2021-07-06 Thread GitBox
rhtyd commented on pull request #4699: URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-874531147 I think this is okay, however, it may be better to start doing these changes via an internal Java API/manager/service. The logic would still be the same but it may be easier to

[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5145: URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-874492954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)

2021-07-06 Thread GitBox
sureshanaparti commented on a change in pull request #5165: URL: https://github.com/apache/cloudstack/pull/5165#discussion_r664263489 ## File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java ## @@ -881,8 +881,9 @@ protected boolean checkWork

[GitHub] [cloudstack] sureshanaparti commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form

2021-07-06 Thread GitBox
sureshanaparti commented on pull request #5145: URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-874492468 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [cloudstack] shwstppr commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form

2021-07-06 Thread GitBox
shwstppr commented on pull request #5145: URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-874494439 @sureshanaparti this is still wip -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [cloudstack] shwstppr commented on pull request #5170: vmware: fix migrate vm with volume

2021-07-06 Thread GitBox
shwstppr commented on pull request #5170: URL: https://github.com/apache/cloudstack/pull/5170#issuecomment-874266966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4640: Added disk provisioning type support for VMWare

2021-07-06 Thread GitBox
sureshanaparti commented on a change in pull request #4640: URL: https://github.com/apache/cloudstack/pull/4640#discussion_r664228043 ## File path: engine/storage/volume/src/main/java/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java ## @@ -100,9 +110,4

[GitHub] [cloudstack] shwstppr closed pull request #5170: vmware: fix migrate vm with volume

2021-07-06 Thread GitBox
shwstppr closed pull request #5170: URL: https://github.com/apache/cloudstack/pull/5170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [cloudstack] Pearl1594 commented on pull request #5034: UI: bulk action support for various resources

2021-07-06 Thread GitBox
Pearl1594 commented on pull request #5034: URL: https://github.com/apache/cloudstack/pull/5034#issuecomment-874555828 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [cloudstack] staySober commented on issue #5185: ”cpu.overprovisioning.factor“ Configuration not in effect

2021-07-06 Thread GitBox
staySober commented on issue #5185: URL: https://github.com/apache/cloudstack/issues/5185#issuecomment-874592266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [cloudstack] lujiefsi commented on a change in pull request #5066: CLOUDSTACK-10436:remind users to use correct permission for tmp dir and fixed an NPE

2021-07-06 Thread GitBox
lujiefsi commented on a change in pull request #5066: URL: https://github.com/apache/cloudstack/pull/5066#discussion_r664186558 ## File path: core/src/main/java/com/cloud/storage/JavaStorageLayer.java ## @@ -178,18 +183,25 @@ public long getSize(String path) { } @Ov

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5163: add entity-type to message when no UUID is found for a DB ID

2021-07-06 Thread GitBox
sureshanaparti commented on a change in pull request #5163: URL: https://github.com/apache/cloudstack/pull/5163#discussion_r664264653 ## File path: server/src/main/java/com/cloud/uuididentity/UUIDManagerImpl.java ## @@ -119,7 +119,9 @@ public boolean IsUuidFormat(String uuid) {

[GitHub] [cloudstack] blueorangutan commented on pull request #5034: UI: bulk action support for various resources

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5034: URL: https://github.com/apache/cloudstack/pull/5034#issuecomment-874556087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] staySober closed issue #5185: ”cpu.overprovisioning.factor“ Configuration not in effect

2021-07-06 Thread GitBox
staySober closed issue #5185: URL: https://github.com/apache/cloudstack/issues/5185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [cloudstack] slavkap commented on issue #5185: ”cpu.overprovisioning.factor“ Configuration not in effect

2021-07-06 Thread GitBox
slavkap commented on issue #5185: URL: https://github.com/apache/cloudstack/issues/5185#issuecomment-874585712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4640: Added disk provisioning type support for VMWare

2021-07-06 Thread GitBox
harikrishna-patnala commented on a change in pull request #4640: URL: https://github.com/apache/cloudstack/pull/4640#discussion_r664236652 ## File path: engine/storage/volume/src/main/java/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java ## @@ -100,9 +

[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5122: URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-873915002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5075: ui: vmware vm import-unmanage

2021-07-06 Thread GitBox
blueorangutan removed a comment on pull request #5075: URL: https://github.com/apache/cloudstack/pull/5075#issuecomment-873894042 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [cloudstack] Pearl1594 commented on pull request #5157: [WIP] Support to upload resource icons

2021-07-06 Thread GitBox
Pearl1594 commented on pull request #5157: URL: https://github.com/apache/cloudstack/pull/5157#issuecomment-874058019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [cloudstack] blueorangutan commented on pull request #5183: expunge vm: Allow expunging a VM in destroyed state

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5183: URL: https://github.com/apache/cloudstack/pull/5183#issuecomment-874081410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5163: add entity-type to message when no UUID is found for a DB ID

2021-07-06 Thread GitBox
GutoVeronezi commented on a change in pull request #5163: URL: https://github.com/apache/cloudstack/pull/5163#discussion_r663913413 ## File path: server/src/main/java/com/cloud/uuididentity/UUIDManagerImpl.java ## @@ -119,7 +119,9 @@ public boolean IsUuidFormat(String uuid) {

[GitHub] [cloudstack] Pearl1594 commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)

2021-07-06 Thread GitBox
Pearl1594 commented on pull request #5165: URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-874127139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [cloudstack] blueorangutan commented on pull request #5182: ui: Fix traversal to domain details via domain router-link of a resource

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5182: URL: https://github.com/apache/cloudstack/pull/5182#issuecomment-874075575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] blueorangutan commented on pull request #5170: vmware: fix migrate vm with volume

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5170: URL: https://github.com/apache/cloudstack/pull/5170#issuecomment-873935658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] Pearl1594 commented on pull request #5182: ui: Fix traversal to domain details via domain router-link of a resource

2021-07-06 Thread GitBox
Pearl1594 commented on pull request #5182: URL: https://github.com/apache/cloudstack/pull/5182#issuecomment-874075103 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [cloudstack] blueorangutan commented on pull request #5075: ui: vmware vm import-unmanage

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5075: URL: https://github.com/apache/cloudstack/pull/5075#issuecomment-873894042 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] blueorangutan commented on pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5165: URL: https://github.com/apache/cloudstack/pull/5165#issuecomment-874127271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] rhtyd commented on pull request #5102: [HEALTH] Default branch 'main' (renamed from 'master') Health Checks - Please don't merge this

2021-07-06 Thread GitBox
rhtyd commented on pull request #5102: URL: https://github.com/apache/cloudstack/pull/5102#issuecomment-873894873 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4257: remove the unnecessary check for tags when migrating volumes

2021-07-06 Thread GitBox
RodrigoDLopez commented on pull request #4257: URL: https://github.com/apache/cloudstack/pull/4257#issuecomment-874073693 ping @rhtyd @GabrielBrascher @sureshanaparti @DaanHoogland @weizhouapache Any update on this one? -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] GutoVeronezi commented on pull request #4790: Externalize secondary storage capacity threshold

2021-07-06 Thread GitBox
GutoVeronezi commented on pull request #4790: URL: https://github.com/apache/cloudstack/pull/4790#issuecomment-874068353 @sureshanaparti @DaanHoogland @GabrielBrascher is there anything else to do? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [cloudstack] shwstppr removed a comment on pull request #5075: ui: vmware vm import-unmanage

2021-07-06 Thread GitBox
shwstppr removed a comment on pull request #5075: URL: https://github.com/apache/cloudstack/pull/5075#issuecomment-873871805 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack] apurv-1 closed pull request #5090: UI: Keyboard shortcuts

2021-07-06 Thread GitBox
apurv-1 closed pull request #5090: URL: https://github.com/apache/cloudstack/pull/5090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5170: vmware: fix migrate vm with volume

2021-07-06 Thread GitBox
GutoVeronezi commented on a change in pull request #5170: URL: https://github.com/apache/cloudstack/pull/5170#discussion_r663893353 ## File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java ## @@ -7445,7 +7443,7 @@ private

[GitHub] [cloudstack] GutoVeronezi commented on pull request #4959: Improve logs on ConsoleProxyManagerImpl and refactor a few process

2021-07-06 Thread GitBox
GutoVeronezi commented on pull request #4959: URL: https://github.com/apache/cloudstack/pull/4959#issuecomment-874067819 @DaanHoogland @GabrielBrascher is there anything else to do? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [cloudstack] Spaceman1984 closed pull request #4640: Added disk provisioning type support for VMWare

2021-07-06 Thread GitBox
Spaceman1984 closed pull request #4640: URL: https://github.com/apache/cloudstack/pull/4640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [cloudstack] blueorangutan commented on pull request #5102: [HEALTH] Default branch 'main' (renamed from 'master') Health Checks - Please don't merge this

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5102: URL: https://github.com/apache/cloudstack/pull/5102#issuecomment-873889629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] Pearl1594 commented on pull request #5183: expunge vm: Allow expunging a VM in destroyed state

2021-07-06 Thread GitBox
Pearl1594 commented on pull request #5183: URL: https://github.com/apache/cloudstack/pull/5183#issuecomment-874081059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)

2021-07-06 Thread GitBox
Pearl1594 commented on a change in pull request #5165: URL: https://github.com/apache/cloudstack/pull/5165#discussion_r663944636 ## File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java ## @@ -881,8 +881,9 @@ protected boolean checkWorkItems

[GitHub] [cloudstack] blueorangutan commented on pull request #5157: [WIP] Support to upload resource icons

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5157: URL: https://github.com/apache/cloudstack/pull/5157#issuecomment-874058334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] shwstppr commented on a change in pull request #5170: vmware: fix migrate vm with volume

2021-07-06 Thread GitBox
shwstppr commented on a change in pull request #5170: URL: https://github.com/apache/cloudstack/pull/5170#discussion_r663905949 ## File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java ## @@ -7337,20 +7337,20 @@ private An

[GitHub] [cloudstack] shwstppr commented on pull request #5075: ui: vmware vm import-unmanage

2021-07-06 Thread GitBox
shwstppr commented on pull request #5075: URL: https://github.com/apache/cloudstack/pull/5075#issuecomment-873968261 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5165: Prevent starting a VM in destroyed state (or any state but Stopped)

2021-07-06 Thread GitBox
GutoVeronezi commented on a change in pull request #5165: URL: https://github.com/apache/cloudstack/pull/5165#discussion_r663903003 ## File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java ## @@ -881,8 +881,9 @@ protected boolean checkWorkIt

[GitHub] [cloudstack] borisstoyanov commented on pull request #5122: UI: Keyboard label shortcut

2021-07-06 Thread GitBox
borisstoyanov commented on pull request #5122: URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-873914868 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] staySober closed issue #5185: ”cpu.overprovisioning.factor“ Configuration not in effect

2021-07-06 Thread GitBox
staySober closed issue #5185: URL: https://github.com/apache/cloudstack/issues/5185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [cloudstack] staySober commented on issue #5185: ”cpu.overprovisioning.factor“ Configuration not in effect

2021-07-06 Thread GitBox
staySober commented on issue #5185: URL: https://github.com/apache/cloudstack/issues/5185#issuecomment-874627099 @slavkap Oh, My problem. I forget check the cluster setting. now It work correctly. Thanks for your help me. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] slavkap commented on issue #5185: ”cpu.overprovisioning.factor“ Configuration not in effect

2021-07-06 Thread GitBox
slavkap commented on issue #5185: URL: https://github.com/apache/cloudstack/issues/5185#issuecomment-874621885 Hmm not sure what steps you've taken. To take effect on old hosts, you have to update the `cpu.overprovisioning.factor` in the cluster's settings. If you changed it from the `Glob

[GitHub] [cloudstack] staySober commented on issue #5185: ”cpu.overprovisioning.factor“ Configuration not in effect

2021-07-06 Thread GitBox
staySober commented on issue #5185: URL: https://github.com/apache/cloudstack/issues/5185#issuecomment-874592266 @slavkap but when I deploy a VM, I saw the log as follow ![image](https://user-images.githubusercontent.com/20500978/124573563-3e738080-de7c-11eb-8e9a-71b40c8c1910.png) I

[GitHub] [cloudstack] slavkap commented on issue #5185: ”cpu.overprovisioning.factor“ Configuration not in effect

2021-07-06 Thread GitBox
slavkap commented on issue #5185: URL: https://github.com/apache/cloudstack/issues/5185#issuecomment-874585712 @staySober, I've tested this, and `cpu.overprovisioning.factor` is set correctly. This is just a warning that the configuration wasn't found in `Config.java` because it's deprecat

[GitHub] [cloudstack] blueorangutan commented on pull request #5034: UI: bulk action support for various resources

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5034: URL: https://github.com/apache/cloudstack/pull/5034#issuecomment-874559075 UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5034 (SL-JID-325) -- This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack] blueorangutan commented on pull request #5034: UI: bulk action support for various resources

2021-07-06 Thread GitBox
blueorangutan commented on pull request #5034: URL: https://github.com/apache/cloudstack/pull/5034#issuecomment-874556087 @Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] Pearl1594 commented on pull request #5034: UI: bulk action support for various resources

2021-07-06 Thread GitBox
Pearl1594 commented on pull request #5034: URL: https://github.com/apache/cloudstack/pull/5034#issuecomment-874555828 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [cloudstack] staySober opened a new issue #5185: ”cpu.overprovisioning.factor“ Configuration not in effect

2021-07-06 Thread GitBox
staySober opened a new issue #5185: URL: https://github.com/apache/cloudstack/issues/5185 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ cloudstack-managemnt server ~~~ # CLOUDSTACK VERSION ~~~ 4.15.1-SNAPSHOT ~~~

[GitHub] [cloudstack] rhtyd commented on pull request #4699: Add new registers in guest_os

2021-07-06 Thread GitBox
rhtyd commented on pull request #4699: URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-874531147 I think this is okay, however, it may be better to start doing these changes via an internal Java API/manager/service. The logic would still be the same but it may be easier to