[GitHub] [cloudstack] blueorangutan commented on pull request #5658: remove VmWorkJob after adding a nic to a vm

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5658: URL: https://github.com/apache/cloudstack/pull/5658#issuecomment-958689968 @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Servic

[GitHub] [cloudstack] sureshanaparti commented on pull request #5658: remove VmWorkJob after adding a nic to a vm

2021-11-02 Thread GitBox
sureshanaparti commented on pull request #5658: URL: https://github.com/apache/cloudstack/pull/5658#issuecomment-958689901 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #5658: remove VmWorkJob after adding a nic to a vm

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5658: URL: https://github.com/apache/cloudstack/pull/5658#issuecomment-958689764 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1668 -- This is an automated message from

[GitHub] [cloudstack] blueorangutan commented on pull request #5659: api,server,engine/schema: admin listvm api clusterid

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5659: URL: https://github.com/apache/cloudstack/pull/5659#issuecomment-958688640 Trillian test result (tid-2522) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34091 seconds Marvin logs: https://gith

[GitHub] [cloudstack] blueorangutan commented on pull request #5659: api,server,engine/schema: admin listvm api clusterid

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5659: URL: https://github.com/apache/cloudstack/pull/5659#issuecomment-958688199 Trillian test result (tid-2524) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34132 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #5659: api,server,engine/schema: admin listvm api clusterid

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5659: URL: https://github.com/apache/cloudstack/pull/5659#issuecomment-958686319 Trillian test result (tid-2523) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33529 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #5658: remove VmWorkJob after adding a nic to a vm

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5658: URL: https://github.com/apache/cloudstack/pull/5658#issuecomment-958673827 @sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] sureshanaparti commented on pull request #5658: remove VmWorkJob after adding a nic to a vm

2021-11-02 Thread GitBox
sureshanaparti commented on pull request #5658: URL: https://github.com/apache/cloudstack/pull/5658#issuecomment-958673502 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] rhtyd commented on a change in pull request #5658: remove VmWorkJob after adding a nic to a vm

2021-11-02 Thread GitBox
rhtyd commented on a change in pull request #5658: URL: https://github.com/apache/cloudstack/pull/5658#discussion_r741621686 ## File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java ## @@ -4026,25 +4027,39 @@ public NicProfile addVmToNetwork

[GitHub] [cloudstack] rhtyd commented on pull request #5658: remove VmWorkJob after adding a nic to a vm

2021-11-02 Thread GitBox
rhtyd commented on pull request #5658: URL: https://github.com/apache/cloudstack/pull/5658#issuecomment-958655666 PR doesn't seem ready cc @DaanHoogland @weizhouapache @nvazquez @sureshanaparti -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [cloudstack] blueorangutan commented on pull request #5201: [HEALTH] 4.16 Health Checks - Please don't merge

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5201: URL: https://github.com/apache/cloudstack/pull/5201#issuecomment-958633565 Trillian test result (tid-2517) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35810 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #5201: [HEALTH] 4.16 Health Checks - Please don't merge

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5201: URL: https://github.com/apache/cloudstack/pull/5201#issuecomment-958621740 Trillian test result (tid-2518) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34448 seconds Marvin logs: https://githu

[GitHub] [cloudstack] div8cn commented on issue #5651: Repeated deletion to add the same network to the vm error

2021-11-02 Thread GitBox
div8cn commented on issue #5651: URL: https://github.com/apache/cloudstack/issues/5651#issuecomment-958614956 Sorry, I manually merged this PR into 4.15, so I tested this BUG This problem does not exist in 4.15, thank you @weizhouapache @DaanHoogland -- This is an automated mes

[GitHub] [cloudstack] blueorangutan commented on pull request #5201: [HEALTH] 4.16 Health Checks - Please don't merge

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5201: URL: https://github.com/apache/cloudstack/pull/5201#issuecomment-958610564 Trillian test result (tid-2516) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32558 seconds Marvin logs: https://gith

[GitHub] [cloudstack] utchoang commented on pull request #5653: UI - Deploy VM with params from the template, iso, network pages

2021-11-02 Thread GitBox
utchoang commented on pull request #5653: URL: https://github.com/apache/cloudstack/pull/5653#issuecomment-958595716 @rhtyd Will now pass the template id, network id on the URL, and will auto-select it on the form. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [cloudstack] msinhore commented on issue #5631: Instance isn't detroyed by root and domain admin after be destroyed by a regular user account

2021-11-02 Thread GitBox
msinhore commented on issue #5631: URL: https://github.com/apache/cloudstack/issues/5631#issuecomment-958233714 Tried with 4.16 and the purge works. I'm going to close this issue since it was fixed in 4.16. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [cloudstack] msinhore closed issue #5631: Instance isn't detroyed by root and domain admin after be destroyed by a regular user account

2021-11-02 Thread GitBox
msinhore closed issue #5631: URL: https://github.com/apache/cloudstack/issues/5631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [cloudstack] weizhouapache merged pull request #5645: Marvin: change some vlans in test_data.py

2021-11-02 Thread GitBox
weizhouapache merged pull request #5645: URL: https://github.com/apache/cloudstack/pull/5645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [cloudstack] sureshanaparti closed pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR

2021-11-02 Thread GitBox
sureshanaparti closed pull request #5648: URL: https://github.com/apache/cloudstack/pull/5648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: comm

[GitHub] [cloudstack] sureshanaparti commented on pull request #5649: Handle NullPointerException when sending email alerts

2021-11-02 Thread GitBox
sureshanaparti commented on pull request #5649: URL: https://github.com/apache/cloudstack/pull/5649#issuecomment-957198331 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] blueorangutan commented on pull request #5647: assume a property is one when it isn't a number

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5647: URL: https://github.com/apache/cloudstack/pull/5647#issuecomment-957227271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] DaanHoogland commented on issue #5651: Repeated deletion to add the same network to the vm error

2021-11-02 Thread GitBox
DaanHoogland commented on issue #5651: URL: https://github.com/apache/cloudstack/issues/5651#issuecomment-957252137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [cloudstack] rhtyd commented on pull request #5645: Marvin: change some vlans in test_data.py

2021-11-02 Thread GitBox
rhtyd commented on pull request #5645: URL: https://github.com/apache/cloudstack/pull/5645#issuecomment-957064064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [cloudstack] rhtyd merged pull request #5642: upgrade/systemvm: add template zone entries

2021-11-02 Thread GitBox
rhtyd merged pull request #5642: URL: https://github.com/apache/cloudstack/pull/5642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [cloudstack] rhtyd commented on pull request #5201: [HEALTH] 4.16 Health Checks - Please don't merge

2021-11-02 Thread GitBox
rhtyd commented on pull request #5201: URL: https://github.com/apache/cloudstack/pull/5201#issuecomment-957963237 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [cloudstack] rhtyd commented on pull request #5658: remove VmWorkJob after adding a nic to a vm

2021-11-02 Thread GitBox
rhtyd commented on pull request #5658: URL: https://github.com/apache/cloudstack/pull/5658#issuecomment-957963799 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cloudstack] blueorangutan commented on pull request #5657: engine/schema: fix build error in #5642

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5657: URL: https://github.com/apache/cloudstack/pull/5657#issuecomment-957446703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] rp- commented on pull request #4994: Linstor volume plugin

2021-11-02 Thread GitBox
rp- commented on pull request #4994: URL: https://github.com/apache/cloudstack/pull/4994#issuecomment-957147583 @nvazquez I'm on it via a different communication channel But I suspect a configuration problem, I'll report back here what solved the case. -- This is an automated mess

[GitHub] [cloudstack] utchoang commented on pull request #5653: UI - Deploy VM with params from the template, iso, network pages

2021-11-02 Thread GitBox
utchoang commented on pull request #5653: URL: https://github.com/apache/cloudstack/pull/5653#issuecomment-957143825 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [cloudstack] DaanHoogland commented on pull request #5647: assume a property is one when it isn't a number

2021-11-02 Thread GitBox
DaanHoogland commented on pull request #5647: URL: https://github.com/apache/cloudstack/pull/5647#issuecomment-957226469 @blueorangutan test centos7 vmware-70u1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack] blueorangutan commented on pull request #5658: remove VmWorkJob after adding a nic to a vm

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5658: URL: https://github.com/apache/cloudstack/pull/5658#issuecomment-957964675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] shwstppr commented on a change in pull request #5642: upgrade/systemvm: add template zone entries

2021-11-02 Thread GitBox
shwstppr commented on a change in pull request #5642: URL: https://github.com/apache/cloudstack/pull/5642#discussion_r740711242 ## File path: engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java ## @@ -458,10 +466,32 @@ private Long createTemplateOb

[GitHub] [cloudstack] blueorangutan commented on pull request #5201: [HEALTH] 4.16 Health Checks - Please don't merge

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5201: URL: https://github.com/apache/cloudstack/pull/5201#issuecomment-957815321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] rhtyd closed issue #5641: cks: cluster deployment fails for an upgraded env with auto-registered system vm template

2021-11-02 Thread GitBox
rhtyd closed issue #5641: URL: https://github.com/apache/cloudstack/issues/5641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5650: Remove restriction, in VMWare, to resize only SCSI disks

2021-11-02 Thread GitBox
sureshanaparti commented on a change in pull request #5650: URL: https://github.com/apache/cloudstack/pull/5650#discussion_r740809019 ## File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java ## @@ -928,34 +926,33 @@ privat

[GitHub] [cloudstack] davidjumani commented on pull request #5645: Marvin: change some vlans in test_data.py

2021-11-02 Thread GitBox
davidjumani commented on pull request #5645: URL: https://github.com/apache/cloudstack/pull/5645#issuecomment-957070641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [cloudstack] joseflauzino commented on a change in pull request #5633: Fix metrics stats for VMs not running

2021-11-02 Thread GitBox
joseflauzino commented on a change in pull request #5633: URL: https://github.com/apache/cloudstack/pull/5633#discussion_r741161031 ## File path: server/src/main/java/com/cloud/server/StatsCollector.java ## @@ -1485,6 +1487,32 @@ private void storeVirtualMachineStatsInMemory(V

[GitHub] [cloudstack] nvazquez commented on pull request #5645: Marvin: change some vlans in test_data.py

2021-11-02 Thread GitBox
nvazquez commented on pull request #5645: URL: https://github.com/apache/cloudstack/pull/5645#issuecomment-957029641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR

2021-11-02 Thread GitBox
DaanHoogland commented on a change in pull request #5648: URL: https://github.com/apache/cloudstack/pull/5648#discussion_r740842173 ## File path: server/src/main/java/com/cloud/network/Ipv6AddressManagerImpl.java ## @@ -195,13 +195,23 @@ protected boolean isIp6Taken(Network net

[GitHub] [cloudstack] rhtyd commented on a change in pull request #5628: UI: Add footer text option for login screen

2021-11-02 Thread GitBox
rhtyd commented on a change in pull request #5628: URL: https://github.com/apache/cloudstack/pull/5628#discussion_r740981286 ## File path: ui/public/config.json ## @@ -56,5 +56,6 @@ "plugins": [], "basicZoneEnabled": true, "multipleServer": false, - "docHelpMappings":

[GitHub] [cloudstack] nvazquez commented on pull request #4994: Linstor volume plugin

2021-11-02 Thread GitBox
nvazquez commented on pull request #4994: URL: https://github.com/apache/cloudstack/pull/4994#issuecomment-957031297 Hi @rp- @Philipp-Reisner can you please advise on the reported issue? Could be a configuration issue or a bug in CloudStack that needs fixing? -- This is an automated mess

[GitHub] [cloudstack] shwstppr commented on pull request #5650: Remove restriction, in VMWare, to resize only SCSI disks

2021-11-02 Thread GitBox
shwstppr commented on pull request #5650: URL: https://github.com/apache/cloudstack/pull/5650#issuecomment-957094138 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] blueorangutan commented on pull request #5653: UI - Deploy VM with params from the template, iso, network pages

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5653: URL: https://github.com/apache/cloudstack/pull/5653#issuecomment-957144143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] DaanHoogland commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils

2021-11-02 Thread GitBox
DaanHoogland commented on pull request #5386: URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-957229022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] weizhouapache commented on pull request #5594: IPv6 with static routing

2021-11-02 Thread GitBox
weizhouapache commented on pull request #5594: URL: https://github.com/apache/cloudstack/pull/5594#issuecomment-957315498 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cloudstack] blueorangutan commented on pull request #5649: Handle NullPointerException when sending email alerts

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5649: URL: https://github.com/apache/cloudstack/pull/5649#issuecomment-957125305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] weizhouapache merged pull request #5657: engine/schema: fix build error in #5642

2021-11-02 Thread GitBox
weizhouapache merged pull request #5657: URL: https://github.com/apache/cloudstack/pull/5657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR

2021-11-02 Thread GitBox
weizhouapache commented on a change in pull request #5648: URL: https://github.com/apache/cloudstack/pull/5648#discussion_r741107965 ## File path: server/src/main/java/com/cloud/network/Ipv6AddressManagerImpl.java ## @@ -195,13 +195,23 @@ protected boolean isIp6Taken(Network ne

[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5145: URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-957076612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] shwstppr commented on pull request #5659: api,server,engine/schema: admin listvm api clusterid

2021-11-02 Thread GitBox
shwstppr commented on pull request #5659: URL: https://github.com/apache/cloudstack/pull/5659#issuecomment-958096097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5659: api,server,engine/schema: admin listvm api clusterid

2021-11-02 Thread GitBox
weizhouapache commented on a change in pull request #5659: URL: https://github.com/apache/cloudstack/pull/5659#discussion_r741406481 ## File path: api/src/main/java/org/apache/cloudstack/api/command/admin/vm/ListVMsCmdByAdmin.java ## @@ -16,6 +16,7 @@ // under the License. p

[GitHub] [cloudstack] ravening commented on a change in pull request #5649: Handle NullPointerException when sending email alerts

2021-11-02 Thread GitBox
ravening commented on a change in pull request #5649: URL: https://github.com/apache/cloudstack/pull/5649#discussion_r741130770 ## File path: framework/quota/src/main/java/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java ## @@ -325,14 +326,20 @@ public void sentSuccessfu

[GitHub] [cloudstack] nvazquez merged pull request #5646: usage: updateNewMaxId after sanity check

2021-11-02 Thread GitBox
nvazquez merged pull request #5646: URL: https://github.com/apache/cloudstack/pull/5646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [cloudstack] utchoang commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form

2021-11-02 Thread GitBox
utchoang commented on pull request #5145: URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-957075907 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [cloudstack] weizhouapache commented on issue #5651: Repeated deletion to add the same network to the vm error

2021-11-02 Thread GitBox
weizhouapache commented on issue #5651: URL: https://github.com/apache/cloudstack/issues/5651#issuecomment-957232622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #5650: Remove restriction, in VMWare, to resize only SCSI disks

2021-11-02 Thread GitBox
harikrishna-patnala commented on a change in pull request #5650: URL: https://github.com/apache/cloudstack/pull/5650#discussion_r740718564 ## File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java ## @@ -928,34 +926,33 @@ p

[GitHub] [cloudstack] blueorangutan commented on pull request #5650: Remove restriction, in VMWare, to resize only SCSI disks

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5650: URL: https://github.com/apache/cloudstack/pull/5650#issuecomment-957125306 Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1657 -- This is an automated message

[GitHub] [cloudstack] shwstppr commented on pull request #5649: Handle NullPointerException when sending email alerts

2021-11-02 Thread GitBox
shwstppr commented on pull request #5649: URL: https://github.com/apache/cloudstack/pull/5649#issuecomment-957094580 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] blueorangutan commented on pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5648: URL: https://github.com/apache/cloudstack/pull/5648#issuecomment-957001906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] shwstppr commented on a change in pull request #5659: api,server,engine/schema: admin listvm api clusterid

2021-11-02 Thread GitBox
shwstppr commented on a change in pull request #5659: URL: https://github.com/apache/cloudstack/pull/5659#discussion_r741411748 ## File path: api/src/main/java/org/apache/cloudstack/api/command/admin/vm/ListVMsCmdByAdmin.java ## @@ -16,6 +16,7 @@ // under the License. packag

[GitHub] [cloudstack] weizhouapache commented on pull request #5657: engine/schema: fix build error in #5642

2021-11-02 Thread GitBox
weizhouapache commented on pull request #5657: URL: https://github.com/apache/cloudstack/pull/5657#issuecomment-957445847 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cloudstack] blueorangutan commented on pull request #5659: api,server,engine/schema: admin listvm api clusterid

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5659: URL: https://github.com/apache/cloudstack/pull/5659#issuecomment-958096780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5642: upgrade/systemvm: add template zone entries

2021-11-02 Thread GitBox
sureshanaparti commented on a change in pull request #5642: URL: https://github.com/apache/cloudstack/pull/5642#discussion_r740800832 ## File path: engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java ## @@ -458,10 +466,32 @@ private Long createTemp

[GitHub] [cloudstack] blueorangutan commented on pull request #5594: IPv6 with static routing

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5594: URL: https://github.com/apache/cloudstack/pull/5594#issuecomment-957316308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5386: URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-957229394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5633: Fix metrics stats for VMs not running

2021-11-02 Thread GitBox
sureshanaparti commented on a change in pull request #5633: URL: https://github.com/apache/cloudstack/pull/5633#discussion_r740997586 ## File path: server/src/main/java/com/cloud/server/StatsCollector.java ## @@ -1485,6 +1487,32 @@ private void storeVirtualMachineStatsInMemory

[GitHub] [cloudstack] blueorangutan commented on pull request #5645: Marvin: change some vlans in test_data.py

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5645: URL: https://github.com/apache/cloudstack/pull/5645#issuecomment-957065101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] DaanHoogland commented on pull request #5297: KVM disk-only based snapshot of volumes instead of taking VM's full snapshot and extracting disks

2021-11-02 Thread GitBox
DaanHoogland commented on pull request #5297: URL: https://github.com/apache/cloudstack/pull/5297#issuecomment-957230976 @GutoVeronezi we are releasing 4.16 now and this is waiting to be merged after that as far as I can tell -- This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack] shwstppr commented on pull request #5201: [HEALTH] 4.16 Health Checks - Please don't merge

2021-11-02 Thread GitBox
shwstppr commented on pull request #5201: URL: https://github.com/apache/cloudstack/pull/5201#issuecomment-957813015 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] rhtyd commented on pull request #5653: UI - Deploy VM with params from the template, iso, network pages

2021-11-02 Thread GitBox
rhtyd commented on pull request #5653: URL: https://github.com/apache/cloudstack/pull/5653#issuecomment-957373465 I think the specific parameter should be passed to the url and be picked up by the form. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [cloudstack] DaanHoogland commented on pull request #5658: remove VmWorkJob after adding a nic to a vm

2021-11-02 Thread GitBox
DaanHoogland commented on pull request #5658: URL: https://github.com/apache/cloudstack/pull/5658#issuecomment-957825980 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] blueorangutan commented on pull request #5646: usage: updateNewMaxId after sanity check

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5646: URL: https://github.com/apache/cloudstack/pull/5646#issuecomment-956573623 Trillian test result (tid-2501) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31146 seconds Marvin logs: https://githu

[GitHub] [cloudstack] rhtyd commented on pull request #4994: Linstor volume plugin

2021-11-02 Thread GitBox
rhtyd commented on pull request #4994: URL: https://github.com/apache/cloudstack/pull/4994#issuecomment-956571240 @rp- @Philipp-Reisner can you check a potential Linstor regression - https://markmail.org/message/tc4qkm2izzcjqahn I'll tag/cc you in the email thread too. -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #5642: upgrade/systemvm: add template zone entries

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5642: URL: https://github.com/apache/cloudstack/pull/5642#issuecomment-956561220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] blueorangutan commented on pull request #5633: Fix metrics stats for VMs not running

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5633: URL: https://github.com/apache/cloudstack/pull/5633#issuecomment-956682299 Trillian test result (tid-2502) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31865 seconds Marvin logs: https://githu

[GitHub] [cloudstack] soptecsn commented on pull request #4994: Linstor volume plugin

2021-11-02 Thread GitBox
soptecsn commented on pull request #4994: URL: https://github.com/apache/cloudstack/pull/4994#issuecomment-956585899 We are trying to deploy linstor driver for primary storage and it is not wokring. We have configured 3 linstor nodes with ZFS, ACS 4.16 First we get an error that lins

[GitHub] [cloudstack] blueorangutan commented on pull request #5659: api,server,engine/schema: admin listvm api clusterid

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5659: URL: https://github.com/apache/cloudstack/pull/5659#issuecomment-958146957 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1665 -- This is an automated message from

[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5386: URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-958140432 Trillian test result (tid-2513) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32871 seconds Marvin logs: https://gith

[GitHub] [cloudstack] blueorangutan commented on pull request #5659: api,server,engine/schema: admin listvm api clusterid

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5659: URL: https://github.com/apache/cloudstack/pull/5659#issuecomment-958133131 @shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an aut

[GitHub] [cloudstack] shwstppr commented on pull request #5659: api,server,engine/schema: admin listvm api clusterid

2021-11-02 Thread GitBox
shwstppr commented on pull request #5659: URL: https://github.com/apache/cloudstack/pull/5659#issuecomment-958132726 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [cloudstack] blueorangutan commented on pull request #5659: api,server,engine/schema: admin listvm api clusterid

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5659: URL: https://github.com/apache/cloudstack/pull/5659#issuecomment-958131127 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1664 -- This is an automated message from

[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5386: URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-958126423 Trillian test result (tid-2514) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31474 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #5659: api,server,engine/schema: admin listvm api clusterid

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5659: URL: https://github.com/apache/cloudstack/pull/5659#issuecomment-958113685 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] shwstppr commented on pull request #5659: api,server,engine/schema: admin listvm api clusterid

2021-11-02 Thread GitBox
shwstppr commented on pull request #5659: URL: https://github.com/apache/cloudstack/pull/5659#issuecomment-958112975 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] shwstppr commented on a change in pull request #5659: api,server,engine/schema: admin listvm api clusterid

2021-11-02 Thread GitBox
shwstppr commented on a change in pull request #5659: URL: https://github.com/apache/cloudstack/pull/5659#discussion_r741411748 ## File path: api/src/main/java/org/apache/cloudstack/api/command/admin/vm/ListVMsCmdByAdmin.java ## @@ -16,6 +16,7 @@ // under the License. packag

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5659: api,server,engine/schema: admin listvm api clusterid

2021-11-02 Thread GitBox
weizhouapache commented on a change in pull request #5659: URL: https://github.com/apache/cloudstack/pull/5659#discussion_r741406481 ## File path: api/src/main/java/org/apache/cloudstack/api/command/admin/vm/ListVMsCmdByAdmin.java ## @@ -16,6 +16,7 @@ // under the License. p

[GitHub] [cloudstack] blueorangutan commented on pull request #5659: api,server,engine/schema: admin listvm api clusterid

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5659: URL: https://github.com/apache/cloudstack/pull/5659#issuecomment-958096780 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] shwstppr commented on pull request #5659: api,server,engine/schema: admin listvm api clusterid

2021-11-02 Thread GitBox
shwstppr commented on pull request #5659: URL: https://github.com/apache/cloudstack/pull/5659#issuecomment-958096097 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] shwstppr opened a new pull request #5659: api,server,engine/schema: admin listvm api clusterid

2021-11-02 Thread GitBox
shwstppr opened a new pull request #5659: URL: https://github.com/apache/cloudstack/pull/5659 ### Description Add clusterid parameter in listVirtualMachines API for admin Import-Export Instances UI relies on cluster filtering for managed instances. Without clusterid param supp

[GitHub] [cloudstack] blueorangutan commented on pull request #5647: assume a property is one when it isn't a number

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5647: URL: https://github.com/apache/cloudstack/pull/5647#issuecomment-958055274 Trillian test result (tid-2510) Environment: vmware-70u1 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34952 seconds Marvin logs: https://githu

[GitHub] [cloudstack] weizhouapache merged pull request #5645: Marvin: change some vlans in test_data.py

2021-11-02 Thread GitBox
weizhouapache merged pull request #5645: URL: https://github.com/apache/cloudstack/pull/5645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [cloudstack] sureshanaparti closed pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR

2021-11-02 Thread GitBox
sureshanaparti closed pull request #5648: URL: https://github.com/apache/cloudstack/pull/5648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: comm

[GitHub] [cloudstack] blueorangutan commented on pull request #5647: assume a property is one when it isn't a number

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5647: URL: https://github.com/apache/cloudstack/pull/5647#issuecomment-957227271 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-70u1) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] sureshanaparti commented on pull request #5649: Handle NullPointerException when sending email alerts

2021-11-02 Thread GitBox
sureshanaparti commented on pull request #5649: URL: https://github.com/apache/cloudstack/pull/5649#issuecomment-957198331 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] rhtyd commented on pull request #5645: Marvin: change some vlans in test_data.py

2021-11-02 Thread GitBox
rhtyd commented on pull request #5645: URL: https://github.com/apache/cloudstack/pull/5645#issuecomment-957064064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [cloudstack] DaanHoogland commented on issue #5651: Repeated deletion to add the same network to the vm error

2021-11-02 Thread GitBox
DaanHoogland commented on issue #5651: URL: https://github.com/apache/cloudstack/issues/5651#issuecomment-957252137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [cloudstack] shwstppr commented on pull request #5649: Handle NullPointerException when sending email alerts

2021-11-02 Thread GitBox
shwstppr commented on pull request #5649: URL: https://github.com/apache/cloudstack/pull/5649#issuecomment-957094580 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] rhtyd commented on pull request #5658: remove VmWorkJob after adding a nic to a vm

2021-11-02 Thread GitBox
rhtyd commented on pull request #5658: URL: https://github.com/apache/cloudstack/pull/5658#issuecomment-957963799 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cloudstack] rhtyd commented on pull request #5201: [HEALTH] 4.16 Health Checks - Please don't merge

2021-11-02 Thread GitBox
rhtyd commented on pull request #5201: URL: https://github.com/apache/cloudstack/pull/5201#issuecomment-957963237 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [cloudstack] blueorangutan commented on pull request #5657: engine/schema: fix build error in #5642

2021-11-02 Thread GitBox
blueorangutan commented on pull request #5657: URL: https://github.com/apache/cloudstack/pull/5657#issuecomment-957446703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

  1   2   3   >