[GitHub] [cloudstack] blueorangutan commented on pull request #6207: api: add vpcname to networkacl response

2022-04-05 Thread GitBox
blueorangutan commented on PR #6207: URL: https://github.com/apache/cloudstack/pull/6207#issuecomment-1089814116 Trillian test result (tid-3824) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 30951 seconds Marvin logs: https://github.com/blue

[cloudstack] branch main updated: api: add vpcname to networkacl response (#6207)

2022-04-05 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new ca8782b703 api: add vpcname to networkacl respons

[GitHub] [cloudstack] rohityadavcloud merged pull request #6207: api: add vpcname to networkacl response

2022-04-05 Thread GitBox
rohityadavcloud merged PR #6207: URL: https://github.com/apache/cloudstack/pull/6207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6207: api: add vpcname to networkacl response

2022-04-05 Thread GitBox
rohityadavcloud commented on PR #6207: URL: https://github.com/apache/cloudstack/pull/6207#issuecomment-1089778180 This is additive API response change, Travis alone lgtm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [cloudstack] acs-robot commented on pull request #6207: api: add vpcname to networkacl response

2022-04-05 Thread GitBox
acs-robot commented on PR #6207: URL: https://github.com/apache/cloudstack/pull/6207#issuecomment-1089777004 This is additive API response change, Travis alone lgtm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[cloudstack] branch main updated: api: Update account type when updating account role (#6156)

2022-04-05 Thread nvazquez
This is an automated email from the ASF dual-hosted git repository. nvazquez pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 9cc8da2a30 api: Update account type when updat

[GitHub] [cloudstack] nvazquez merged pull request #6156: api: Update account type when updating account role

2022-04-05 Thread GitBox
nvazquez merged PR #6156: URL: https://github.com/apache/cloudstack/pull/6156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@clouds

[GitHub] [cloudstack] nvazquez closed issue #6155: updateAccount don't change "type" column in DB

2022-04-05 Thread GitBox
nvazquez closed issue #6155: updateAccount don't change "type" column in DB URL: https://github.com/apache/cloudstack/issues/6155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [cloudstack] nvazquez commented on issue #6127: SSO fails with error "Expired session, missing signature, or missing apiKey"

2022-04-05 Thread GitBox
nvazquez commented on issue #6127: URL: https://github.com/apache/cloudstack/issues/6127#issuecomment-1089738014 Thanks @kohrar can you please test a combination of PRs #6193 and #6197? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] blueorangutan commented on pull request #6187: api: Prevent modifying acl rules order for default ACLs

2022-04-05 Thread GitBox
blueorangutan commented on PR #6187: URL: https://github.com/apache/cloudstack/pull/6187#issuecomment-1089736387 Trillian Build Failed (tid-3828) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[cloudstack] 01/01: Merge branch '4.16'

2022-04-05 Thread nvazquez
This is an automated email from the ASF dual-hosted git repository. nvazquez pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 306baea228dcc20a4e45cf110378ef0e64f1ae71 Merge: e4b6992def c61ea9f96d Author: nvazquez AuthorDate: Wed Apr 6 00:19:1

[cloudstack] branch main updated (e4b6992def -> 306baea228)

2022-04-05 Thread nvazquez
This is an automated email from the ASF dual-hosted git repository. nvazquez pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from e4b6992def server: fix list reserved/free public ips in project (#6198) add 47454eca7d VR: add '-m ' for tcp

[GitHub] [cloudstack] blueorangutan commented on pull request #6187: api: Prevent modifying acl rules order for default ACLs

2022-04-05 Thread GitBox
blueorangutan commented on PR #6187: URL: https://github.com/apache/cloudstack/pull/6187#issuecomment-1089735069 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] nvazquez commented on pull request #6187: api: Prevent modifying acl rules order for default ACLs

2022-04-05 Thread GitBox
nvazquez commented on PR #6187: URL: https://github.com/apache/cloudstack/pull/6187#issuecomment-1089734362 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[cloudstack] branch main updated: server: fix list reserved/free public ips in project (#6198)

2022-04-05 Thread nvazquez
This is an automated email from the ASF dual-hosted git repository. nvazquez pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new e4b6992def server: fix list reserved/free publ

[GitHub] [cloudstack] nvazquez merged pull request #6198: server: fix list reserved/free public ips in project

2022-04-05 Thread GitBox
nvazquez merged PR #6198: URL: https://github.com/apache/cloudstack/pull/6198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@clouds

[cloudstack] branch 4.16 updated: VR: Do not add iptables rules for the revoked ip addresses (#6189)

2022-04-05 Thread nvazquez
This is an automated email from the ASF dual-hosted git repository. nvazquez pushed a commit to branch 4.16 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.16 by this push: new c61ea9f96d VR: Do not add iptables rules for t

[GitHub] [cloudstack] nvazquez merged pull request #6189: VR: Do not add iptables rules for the revoked ip addresses

2022-04-05 Thread GitBox
nvazquez merged PR #6189: URL: https://github.com/apache/cloudstack/pull/6189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@clouds

[cloudstack] branch 4.16 updated: VR: add '-m ' for tcp or udp protocol (#6188)

2022-04-05 Thread nvazquez
This is an automated email from the ASF dual-hosted git repository. nvazquez pushed a commit to branch 4.16 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.16 by this push: new 47454eca7d VR: add '-m ' for tcp or udp protoc

[GitHub] [cloudstack] nvazquez merged pull request #6188: VR: add '-m ' for tcp or udp protocol

2022-04-05 Thread GitBox
nvazquez merged PR #6188: URL: https://github.com/apache/cloudstack/pull/6188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@clouds

[GitHub] [cloudstack] nvazquez commented on issue #6209: Revert volume to snapshot fails after volume migration

2022-04-05 Thread GitBox
nvazquez commented on issue #6209: URL: https://github.com/apache/cloudstack/issues/6209#issuecomment-1089725273 Thanks @slavkap I've updated the description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [cloudstack] blueorangutan commented on pull request #6104: Direct download certificates additions and improvements

2022-04-05 Thread GitBox
blueorangutan commented on PR #6104: URL: https://github.com/apache/cloudstack/pull/6104#issuecomment-1089723403 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] nvazquez commented on pull request #6104: Direct download certificates additions and improvements

2022-04-05 Thread GitBox
nvazquez commented on PR #6104: URL: https://github.com/apache/cloudstack/pull/6104#issuecomment-1089722382 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [cloudstack] blueorangutan commented on pull request #6104: Direct download certificates additions and improvements

2022-04-05 Thread GitBox
blueorangutan commented on PR #6104: URL: https://github.com/apache/cloudstack/pull/6104#issuecomment-1089721755 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3083 -- This is an automated message from the Apache

[GitHub] [cloudstack] blueorangutan commented on pull request #5984: Persistence of VM stats

2022-04-05 Thread GitBox
blueorangutan commented on PR #5984: URL: https://github.com/apache/cloudstack/pull/5984#issuecomment-1089698995 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] nvazquez commented on pull request #5984: Persistence of VM stats

2022-04-05 Thread GitBox
nvazquez commented on PR #5984: URL: https://github.com/apache/cloudstack/pull/5984#issuecomment-1089698268 Thanks @GutoVeronezi, sure @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [cloudstack] blueorangutan commented on pull request #6104: Direct download certificates additions and improvements

2022-04-05 Thread GitBox
blueorangutan commented on PR #6104: URL: https://github.com/apache/cloudstack/pull/6104#issuecomment-1089684457 @nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- T

[GitHub] [cloudstack] nvazquez commented on pull request #6104: Direct download certificates additions and improvements

2022-04-05 Thread GitBox
nvazquez commented on PR #6104: URL: https://github.com/apache/cloudstack/pull/6104#issuecomment-1089683700 Thanks @weizhouapache - fixing the APINAME has fixed the issue of the ID on cmk, have fixed your comments and retested @blueorangutan package -- This is an automated message from

[GitHub] [cloudstack] nvazquez commented on pull request #5848: Feat/add vdisk UUID to list volume

2022-04-05 Thread GitBox
nvazquez commented on PR #5848: URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1089671830 Hi @DK101010 the packaging is failing due to the merge conflicts Auto-merging vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java Auto-merging

[GitHub] [cloudstack] blueorangutan commented on pull request #6190: Added new field to updateBackupOffering API.

2022-04-05 Thread GitBox
blueorangutan commented on PR #6190: URL: https://github.com/apache/cloudstack/pull/6190#issuecomment-1089669576 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] nvazquez commented on pull request #6190: Added new field to updateBackupOffering API.

2022-04-05 Thread GitBox
nvazquez commented on PR #6190: URL: https://github.com/apache/cloudstack/pull/6190#issuecomment-1089667950 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [cloudstack] blueorangutan commented on pull request #6190: Added new field to updateBackupOffering API.

2022-04-05 Thread GitBox
blueorangutan commented on PR #6190: URL: https://github.com/apache/cloudstack/pull/6190#issuecomment-1089647822 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3082 -- This is an automated message from the Apache

[GitHub] [cloudstack] nvazquez commented on a diff in pull request #6104: Direct download certificates additions and improvements

2022-04-05 Thread GitBox
nvazquez commented on code in PR #6104: URL: https://github.com/apache/cloudstack/pull/6104#discussion_r843383888 ## api/src/main/java/org/apache/cloudstack/api/command/admin/direct/download/RevokeTemplateDirectDownloadCertificateCmd.java: ## @@ -54,35 +57,54 @@ private sta

[GitHub] [cloudstack] blueorangutan commented on pull request #6190: Added new field to updateBackupOffering API.

2022-04-05 Thread GitBox
blueorangutan commented on PR #6190: URL: https://github.com/apache/cloudstack/pull/6190#issuecomment-1089614523 @nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- T

[GitHub] [cloudstack] nvazquez commented on pull request #6190: Added new field to updateBackupOffering API.

2022-04-05 Thread GitBox
nvazquez commented on PR #6190: URL: https://github.com/apache/cloudstack/pull/6190#issuecomment-1089614289 Sure @DaanHoogland @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs

2022-04-05 Thread GitBox
blueorangutan commented on PR #5938: URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1089355712 Trillian test result (tid-3819) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38186 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] blueorangutan commented on pull request #6153: VR: add rules for traffic between static nat and private gateway static routes

2022-04-05 Thread GitBox
blueorangutan commented on PR #6153: URL: https://github.com/apache/cloudstack/pull/6153#issuecomment-1089309990 Trillian test result (tid-3821) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31224 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] slavkap commented on issue #6209: Revert volume to snapshot fails after volume migration

2022-04-05 Thread GitBox
slavkap commented on issue #6209: URL: https://github.com/apache/cloudstack/issues/6209#issuecomment-1089306858 @nvazquez, this can also be hit when migrating a volume to another storage. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs

2022-04-05 Thread GitBox
blueorangutan commented on PR #5938: URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1089284770 Trillian test result (tid-3820) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35151 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] nvazquez commented on issue #6209: Revert volume to snapshot fails after volume migration

2022-04-05 Thread GitBox
nvazquez commented on issue #6209: URL: https://github.com/apache/cloudstack/issues/6209#issuecomment-1089265571 @slavkap @weizhouapache this might be related to #5433 and should find a solution for both issues -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] nvazquez opened a new issue, #6209: Revert volume to snapshot fails after volume migration

2022-04-05 Thread GitBox
nvazquez opened a new issue, #6209: URL: https://github.com/apache/cloudstack/issues/6209 # ISSUE TYPE * Bug Report * Improvement Request * Enhancement Request # COMPONENT NAME ~~~ Storage ~~~ # CLOUDSTACK VERSION ~~~ 4.16.1 and main ~~~

[GitHub] [cloudstack] blueorangutan commented on pull request #6207: api: add vpcname to networkacl response

2022-04-05 Thread GitBox
blueorangutan commented on PR #6207: URL: https://github.com/apache/cloudstack/pull/6207#issuecomment-1089251341 @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] weizhouapache commented on pull request #6207: api: add vpcname to networkacl response

2022-04-05 Thread GitBox
weizhouapache commented on PR #6207: URL: https://github.com/apache/cloudstack/pull/6207#issuecomment-1089250862 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [cloudstack] ravening commented on pull request #6164: Mount disabled storage pool on host reboot

2022-04-05 Thread GitBox
ravening commented on PR #6164: URL: https://github.com/apache/cloudstack/pull/6164#issuecomment-1089244417 @wido @nvazquez Yes we always wanted the disabled pools to be mounted by default even after the node reboot. I didnt want to change the existing behaviour as it might break the functi

[GitHub] [cloudstack] blueorangutan commented on pull request #5938: VR: remove old json config when start vmware/xenserver VPC VRs

2022-04-05 Thread GitBox
blueorangutan commented on PR #5938: URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1089227309 Trillian test result (tid-3818) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32051 seconds Marvin logs: https://github.com/blu

[cloudstack] branch main updated: .asf.yaml: introduce new .asf.yaml file

2022-04-05 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new a66dee4374 .asf.yaml: introduce new .asf.yaml fil

[GitHub] [cloudstack] kohrar commented on issue #6127: SSO fails with error "Expired session, missing signature, or missing apiKey"

2022-04-05 Thread GitBox
kohrar commented on issue #6127: URL: https://github.com/apache/cloudstack/issues/6127#issuecomment-1089163094 Thanks @utchoang. I checked out your PR #6197 against the latest commit on the main branch as of this writing and it seems to fix the SSO option being disabled on a logout and also

[GitHub] [cloudstack] acs-robot commented on pull request #6208: [IGNORE ME] Test PR - ignore this pull request

2022-04-05 Thread GitBox
acs-robot commented on PR #6208: URL: https://github.com/apache/cloudstack/pull/6208#issuecomment-1089162268 not implemented yet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6208: [IGNORE ME] Test PR - ignore this pull request

2022-04-05 Thread GitBox
rohityadavcloud commented on PR #6208: URL: https://github.com/apache/cloudstack/pull/6208#issuecomment-1089162106 /coverage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [cloudstack] acs-robot commented on pull request #6208: [IGNORE ME] Test PR - ignore this pull request

2022-04-05 Thread GitBox
acs-robot commented on PR #6208: URL: https://github.com/apache/cloudstack/pull/6208#issuecomment-1089161852 ¯\_(ツ)_/¯ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6208: [IGNORE ME] Test PR - ignore this pull request

2022-04-05 Thread GitBox
rohityadavcloud commented on PR #6208: URL: https://github.com/apache/cloudstack/pull/6208#issuecomment-1089161625 /shrug -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6208: [IGNORE ME] Test PR - ignore this pull request

2022-04-05 Thread GitBox
rohityadavcloud commented on PR #6208: URL: https://github.com/apache/cloudstack/pull/6208#issuecomment-1089160491 /help -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] acs-robot commented on pull request #6208: [IGNORE ME] Test PR - ignore this pull request

2022-04-05 Thread GitBox
acs-robot commented on PR #6208: URL: https://github.com/apache/cloudstack/pull/6208#issuecomment-1089160254 ![aa](https://user-images.githubusercontent.com/103067153/161824889-d2b9d65d-28b0-4f11-939d-eb312e09c0c3.jpg) #watching -- This is an automated message from the Apache Git Servi

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6208: [IGNORE ME] Test PR - ignore this pull request

2022-04-05 Thread GitBox
rohityadavcloud commented on PR #6208: URL: https://github.com/apache/cloudstack/pull/6208#issuecomment-1089159462 /meow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] acs-robot commented on pull request #6208: [IGNORE ME] Test PR - ignore this pull request

2022-04-05 Thread GitBox
acs-robot commented on PR #6208: URL: https://github.com/apache/cloudstack/pull/6208#issuecomment-1089158668 error - can't add label - I don't have access to this repo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [cloudstack] acs-robot commented on pull request #6208: [IGNORE ME] Test PR - ignore this pull request

2022-04-05 Thread GitBox
acs-robot commented on PR #6208: URL: https://github.com/apache/cloudstack/pull/6208#issuecomment-1089157895 Hi @rohityadavcloud - this is new CI/CD bot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack] rohityadavcloud opened a new pull request, #6208: [IGNORE ME] Test PR - ignore this pull request

2022-04-05 Thread GitBox
rohityadavcloud opened a new pull request, #6208: URL: https://github.com/apache/cloudstack/pull/6208 ### Description This PR... ### Types of changes - [ ] Breaking change (fix or feature that would cause existing funct

[GitHub] [cloudstack] blueorangutan commented on pull request #6207: api: add vpcname to networkacl response

2022-04-05 Thread GitBox
blueorangutan commented on PR #6207: URL: https://github.com/apache/cloudstack/pull/6207#issuecomment-1089139316 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3081 -- This is an automated message from the Apache

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6104: Direct download certificates additions and improvements

2022-04-05 Thread GitBox
weizhouapache commented on code in PR #6104: URL: https://github.com/apache/cloudstack/pull/6104#discussion_r843120355 ## api/src/main/java/org/apache/cloudstack/api/command/admin/direct/download/RevokeTemplateDirectDownloadCertificateCmd.java: ## @@ -54,35 +57,54 @@ privat

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6104: Direct download certificates additions and improvements

2022-04-05 Thread GitBox
weizhouapache commented on code in PR #6104: URL: https://github.com/apache/cloudstack/pull/6104#discussion_r843113878 ## api/src/main/java/org/apache/cloudstack/api/command/admin/direct/download/RevokeTemplateDirectDownloadCertificateCmd.java: ## @@ -54,35 +57,54 @@ privat

[GitHub] [cloudstack] GutoVeronezi commented on pull request #5984: Persistence of VM stats

2022-04-05 Thread GitBox
GutoVeronezi commented on PR #5984: URL: https://github.com/apache/cloudstack/pull/5984#issuecomment-1089105927 I re-ran the manual tests (one of the results below). The feature seems working fine to me. --- Test with 15 seconds of interval and 1 minute of retention, with 2 MGM

[GitHub] [cloudstack] blueorangutan commented on pull request #6207: api: add vpcname to networkacl response

2022-04-05 Thread GitBox
blueorangutan commented on PR #6207: URL: https://github.com/apache/cloudstack/pull/6207#issuecomment-1089096990 @shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- T

[GitHub] [cloudstack] shwstppr commented on pull request #6207: api: add vpcname to networkacl response

2022-04-05 Thread GitBox
shwstppr commented on PR #6207: URL: https://github.com/apache/cloudstack/pull/6207#issuecomment-1089095753 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [cloudstack] blueorangutan commented on pull request #6104: Direct download certificates additions and improvements

2022-04-05 Thread GitBox
blueorangutan commented on PR #6104: URL: https://github.com/apache/cloudstack/pull/6104#issuecomment-1089094174 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3080 -- This is an automated message from the Apache

[GitHub] [cloudstack] blueorangutan commented on pull request #6104: Direct download certificates additions and improvements

2022-04-05 Thread GitBox
blueorangutan commented on PR #6104: URL: https://github.com/apache/cloudstack/pull/6104#issuecomment-1089039295 @nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- T

[GitHub] [cloudstack] nvazquez commented on pull request #6104: Direct download certificates additions and improvements

2022-04-05 Thread GitBox
nvazquez commented on PR #6104: URL: https://github.com/apache/cloudstack/pull/6104#issuecomment-1089038070 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [cloudstack] nvazquez commented on pull request #5297: KVM disk-only based snapshot of volumes instead of taking VM's full snapshot and extracting disks

2022-04-05 Thread GitBox
nvazquez commented on PR #5297: URL: https://github.com/apache/cloudstack/pull/5297#issuecomment-1089020371 Thanks @slavkap - confirming the case is also present on 4.17 and not related to this PR - as you mention it an edge case involving the migration of the volume, can be fixed separatel

[GitHub] [cloudstack] blueorangutan commented on pull request #6104: Direct download certificates additions and improvements

2022-04-05 Thread GitBox
blueorangutan commented on PR #6104: URL: https://github.com/apache/cloudstack/pull/6104#issuecomment-1089008997 Trillian test result (tid-3817) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34966 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] nvazquez commented on a diff in pull request #6104: Direct download certificates additions and improvements

2022-04-05 Thread GitBox
nvazquez commented on code in PR #6104: URL: https://github.com/apache/cloudstack/pull/6104#discussion_r843020060 ## api/src/main/java/org/apache/cloudstack/api/command/admin/direct/download/RevokeTemplateDirectDownloadCertificateCmd.java: ## @@ -28,39 +28,40 @@ import org.apac

[GitHub] [cloudstack] slavkap commented on pull request #5297: KVM disk-only based snapshot of volumes instead of taking VM's full snapshot and extracting disks

2022-04-05 Thread GitBox
slavkap commented on PR #5297: URL: https://github.com/apache/cloudstack/pull/5297#issuecomment-1088968824 @nvazquez, with this scenario, the same issue appears in 4.16.1.0. It is not related to this PR. When you migrate a VM with its volumes, new volumes are created, and after the migratio

[GitHub] [cloudstack] nvazquez commented on pull request #6164: Mount disabled storage pool on host reboot

2022-04-05 Thread GitBox
nvazquez commented on PR #6164: URL: https://github.com/apache/cloudstack/pull/6164#issuecomment-1088866312 Hi @wido thanks for your input - @ravening @weizhouapache what's your opinion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [cloudstack] nvazquez commented on pull request #5297: KVM disk-only based snapshot of volumes instead of taking VM's full snapshot and extracting disks

2022-04-05 Thread GitBox
nvazquez commented on PR #5297: URL: https://github.com/apache/cloudstack/pull/5297#issuecomment-1088819124 Actually continued testing and cannot revert volume to snapshot @GutoVeronezi can you please check: 2022-04-05 14:52:25,411 ERROR [c.c.a.ApiAsyncJobDispatcher] (API-Job-Exe

[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume

2022-04-05 Thread GitBox
blueorangutan commented on PR #5848: URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1088787695 Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 3079 -- This is an automated

[GitHub] [cloudstack] blueorangutan commented on pull request #6187: api: Prevent modifying acl rules order for default ACLs

2022-04-05 Thread GitBox
blueorangutan commented on PR #6187: URL: https://github.com/apache/cloudstack/pull/6187#issuecomment-1088787694 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3078 -- This is an automated message from the Apache

[GitHub] [cloudstack] weizhouapache commented on pull request #5848: Feat/add vdisk UUID to list volume

2022-04-05 Thread GitBox
weizhouapache commented on PR #5848: URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1088762461 @DK101010 can you fix the merge conflict ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume

2022-04-05 Thread GitBox
blueorangutan commented on PR #5848: URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1088762011 @weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] weizhouapache commented on pull request #5848: Feat/add vdisk UUID to list volume

2022-04-05 Thread GitBox
weizhouapache commented on PR #5848: URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1088761524 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [cloudstack] nvazquez commented on a diff in pull request #5797: [WIP] Improve global settings UI to be more intuitive/logical

2022-04-05 Thread GitBox
nvazquez commented on code in PR #5797: URL: https://github.com/apache/cloudstack/pull/5797#discussion_r842784512 ## api/src/main/java/org/apache/cloudstack/api/command/admin/config/ListCfgGroupsByCmd.java: ## @@ -0,0 +1,80 @@ +// Licensed to the Apache Software Foundation (ASF)

[cloudstack] branch main updated (1c8d8cdef2 -> 7e6d1f1f85)

2022-04-05 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 1c8d8cdef2 ui: Fix label for LUN number (#6204) add 7e6d1f1f85 ui: fix acl rules listing (#6206) No new revisio

[GitHub] [cloudstack] rohityadavcloud merged pull request #6206: ui: fix acl rules listing

2022-04-05 Thread GitBox
rohityadavcloud merged PR #6206: URL: https://github.com/apache/cloudstack/pull/6206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [cloudstack] blueorangutan commented on pull request #6187: api: Prevent modifying acl rules order for default ACLs

2022-04-05 Thread GitBox
blueorangutan commented on PR #6187: URL: https://github.com/apache/cloudstack/pull/6187#issuecomment-1088753397 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress. -- This is an a

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6187: api: Prevent modifying acl rules order for default ACLs

2022-04-05 Thread GitBox
rohityadavcloud commented on PR #6187: URL: https://github.com/apache/cloudstack/pull/6187#issuecomment-1088752083 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] DK101010 commented on pull request #5848: Feat/add vdisk UUID to list volume

2022-04-05 Thread GitBox
DK101010 commented on PR #5848: URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1088656507 > @DK101010 `external_uuid` is not nice but ok to me. can you add more information in the description of api response below ? for example, `On vmware, ` > > `@Param(des

[GitHub] [cloudstack] DK101010 commented on a diff in pull request #5848: Feat/add vdisk UUID to list volume

2022-04-05 Thread GitBox
DK101010 commented on code in PR #5848: URL: https://github.com/apache/cloudstack/pull/5848#discussion_r842737377 ## engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql: ## @@ -220,6 +220,19 @@ CREATE VIEW `cloud`.`service_offering_view` AS GROUP BY

[GitHub] [cloudstack] weizhouapache opened a new pull request, #6207: api: add vpcname to networkacl response

2022-04-05 Thread GitBox
weizhouapache opened a new pull request, #6207: URL: https://github.com/apache/cloudstack/pull/6207 ### Description This PR fixes the vpc uuid in info card of network acls prior to this PR: ![2022-04-05_14-40](https://user-images.githubusercontent.com/57355700/161754224-6e36

[GitHub] [cloudstack] tajisoft commented on pull request #6195: [WIP] ui: update ja_JP locale

2022-04-05 Thread GitBox
tajisoft commented on PR #6195: URL: https://github.com/apache/cloudstack/pull/6195#issuecomment-1088640287 @rohityadavcloud I got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] wido commented on pull request #6164: Mount disabled storage pool on host reboot

2022-04-05 Thread GitBox
wido commented on PR #6164: URL: https://github.com/apache/cloudstack/pull/6164#issuecomment-1088634309 I noticed this PR a bit late. Great PR and good catch, however (There is always a however!) The API: https://cloudstack.apache.org/api/apidocs-4.16/apis/updateStoragePool.html

[GitHub] [cloudstack] blueorangutan commented on pull request #6206: ui: fix acl rules listing

2022-04-05 Thread GitBox
blueorangutan commented on PR #6206: URL: https://github.com/apache/cloudstack/pull/6206#issuecomment-1088620672 UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6206 (SL-JID-1342) -- This is an automated message from the Apache Git Service. To respond

[GitHub] [cloudstack] blueorangutan commented on pull request #6188: VR: add '-m ' for tcp or udp protocol

2022-04-05 Thread GitBox
blueorangutan commented on PR #6188: URL: https://github.com/apache/cloudstack/pull/6188#issuecomment-1088616375 Trillian test result (tid-3822) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 378 seconds Marvin logs: https://github.com/blueor

[GitHub] [cloudstack] blueorangutan commented on pull request #6206: ui: fix acl rules listing

2022-04-05 Thread GitBox
blueorangutan commented on PR #6206: URL: https://github.com/apache/cloudstack/pull/6206#issuecomment-1088615758 @shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] shwstppr commented on pull request #6206: ui: fix acl rules listing

2022-04-05 Thread GitBox
shwstppr commented on PR #6206: URL: https://github.com/apache/cloudstack/pull/6206#issuecomment-1088615455 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [cloudstack] shwstppr opened a new pull request, #6206: ui: fix acl rules listing

2022-04-05 Thread GitBox
shwstppr opened a new pull request, #6206: URL: https://github.com/apache/cloudstack/pull/6206 ### Description When a rule in the list has start-end port, UI listing was failing. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functio

[GitHub] [cloudstack] blueorangutan commented on pull request #6188: VR: add '-m ' for tcp or udp protocol

2022-04-05 Thread GitBox
blueorangutan commented on PR #6188: URL: https://github.com/apache/cloudstack/pull/6188#issuecomment-1088612588 Trillian test result (tid-3815) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32060 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] blueorangutan commented on pull request #6198: server: fix list reserved/free public ips in project

2022-04-05 Thread GitBox
blueorangutan commented on PR #6198: URL: https://github.com/apache/cloudstack/pull/6198#issuecomment-1088606014 Trillian test result (tid-3814) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31800 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] blueorangutan commented on pull request #5786: network: ipv6 static routes

2022-04-05 Thread GitBox
blueorangutan commented on PR #5786: URL: https://github.com/apache/cloudstack/pull/5786#issuecomment-1088592259 @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] weizhouapache commented on pull request #5786: network: ipv6 static routes

2022-04-05 Thread GitBox
weizhouapache commented on PR #5786: URL: https://github.com/apache/cloudstack/pull/5786#issuecomment-1088591369 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [cloudstack] blueorangutan commented on pull request #6188: VR: add '-m ' for tcp or udp protocol

2022-04-05 Thread GitBox
blueorangutan commented on PR #6188: URL: https://github.com/apache/cloudstack/pull/6188#issuecomment-1088591302 @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] weizhouapache commented on pull request #6188: VR: add '-m ' for tcp or udp protocol

2022-04-05 Thread GitBox
weizhouapache commented on PR #6188: URL: https://github.com/apache/cloudstack/pull/6188#issuecomment-1088590544 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [cloudstack] blueorangutan commented on pull request #6153: VR: add rules for traffic between static nat and private gateway static routes

2022-04-05 Thread GitBox
blueorangutan commented on PR #6153: URL: https://github.com/apache/cloudstack/pull/6153#issuecomment-1088590272 @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] weizhouapache commented on pull request #6153: VR: add rules for traffic between static nat and private gateway static routes

2022-04-05 Thread GitBox
weizhouapache commented on PR #6153: URL: https://github.com/apache/cloudstack/pull/6153#issuecomment-1088589921 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

  1   2   >