[GitHub] [cloudstack] DK101010 commented on a diff in pull request #5848: Feat/add vdisk UUID to list volume

2022-04-07 Thread GitBox
DK101010 commented on code in PR #5848: URL: https://github.com/apache/cloudstack/pull/5848#discussion_r845782422 ## engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql: ## @@ -272,6 +291,7 @@ CREATE VIEW `cloud`.`volume_view` AS disk_offering.display_t

[GitHub] [cloudstack] blueorangutan commented on pull request #5786: network: ipv6 static routes

2022-04-07 Thread GitBox
blueorangutan commented on PR #5786: URL: https://github.com/apache/cloudstack/pull/5786#issuecomment-1092493375 @shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- T

[GitHub] [cloudstack] shwstppr commented on pull request #5786: network: ipv6 static routes

2022-04-07 Thread GitBox
shwstppr commented on PR #5786: URL: https://github.com/apache/cloudstack/pull/5786#issuecomment-1092493153 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [cloudstack] github-actions[bot] commented on pull request #6007: StorPool storage plugin

2022-04-07 Thread GitBox
github-actions[bot] commented on PR #6007: URL: https://github.com/apache/cloudstack/pull/6007#issuecomment-1092493039 Hi @shwstppr, your pull request has merge conflicts. Can you fix the conflicts and sync your branch with the base branch? -- This is an automated message from the Apache

[GitHub] [cloudstack] github-actions[bot] commented on pull request #5297: KVM disk-only based snapshot of volumes instead of taking VM's full snapshot and extracting disks

2022-04-07 Thread GitBox
github-actions[bot] commented on PR #5297: URL: https://github.com/apache/cloudstack/pull/5297#issuecomment-1092493023 Hi @shwstppr, your pull request has merge conflicts. Can you fix the conflicts and sync your branch with the base branch? -- This is an automated message from the Apache

[GitHub] [cloudstack] github-actions[bot] commented on pull request #5216: Support for new Feature: Clone a Virtual Machine (#4818)

2022-04-07 Thread GitBox
github-actions[bot] commented on PR #5216: URL: https://github.com/apache/cloudstack/pull/5216#issuecomment-1092493005 Hi @shwstppr, your pull request has merge conflicts. Can you fix the conflicts and sync your branch with the base branch? -- This is an automated message from the Apache

[GitHub] [cloudstack] blueorangutan commented on pull request #5811: [HEALTH] 4.17 Health Check please don't merge this

2022-04-07 Thread GitBox
blueorangutan commented on PR #5811: URL: https://github.com/apache/cloudstack/pull/5811#issuecomment-1092381750 @nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automated mes

[GitHub] [cloudstack] nvazquez commented on pull request #5811: [HEALTH] 4.17 Health Check please don't merge this

2022-04-07 Thread GitBox
nvazquez commented on PR #5811: URL: https://github.com/apache/cloudstack/pull/5811#issuecomment-1092381483 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #5811: [HEALTH] 4.17 Health Check please don't merge this

2022-04-07 Thread GitBox
blueorangutan commented on PR #5811: URL: https://github.com/apache/cloudstack/pull/5811#issuecomment-1092371704 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3097 -- This is an automated message from the Apache

[GitHub] [cloudstack] blueorangutan commented on pull request #5811: [HEALTH] 4.17 Health Check please don't merge this

2022-04-07 Thread GitBox
blueorangutan commented on PR #5811: URL: https://github.com/apache/cloudstack/pull/5811#issuecomment-1092353593 @nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- T

[GitHub] [cloudstack] nvazquez commented on pull request #5811: [HEALTH] 4.17 Health Check please don't merge this

2022-04-07 Thread GitBox
nvazquez commented on PR #5811: URL: https://github.com/apache/cloudstack/pull/5811#issuecomment-1092353276 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [cloudstack] kohrar commented on pull request #6149: Update SAML2 auth sessionkey cookie path

2022-04-07 Thread GitBox
kohrar commented on PR #6149: URL: https://github.com/apache/cloudstack/pull/6149#issuecomment-1092343238 I would think so. The UI issue is a separate issue. The original issue was that the session key cookie was set with a different path by the browser, resulting in the valid session key b

[GitHub] [cloudstack] nvazquez commented on pull request #5297: KVM disk-only based snapshot of volumes instead of taking VM's full snapshot and extracting disks

2022-04-07 Thread GitBox
nvazquez commented on PR #5297: URL: https://github.com/apache/cloudstack/pull/5297#issuecomment-1092336117 @GutoVeronezi can you fix the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack] nvazquez commented on pull request #6007: StorPool storage plugin

2022-04-07 Thread GitBox
nvazquez commented on PR #6007: URL: https://github.com/apache/cloudstack/pull/6007#issuecomment-1092334895 @slavkap can you fix the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] nvazquez commented on pull request #6149: Update SAML2 auth sessionkey cookie path

2022-04-07 Thread GitBox
nvazquez commented on PR #6149: URL: https://github.com/apache/cloudstack/pull/6149#issuecomment-1092333650 Hi @kohrar is this PR still valid after the UI fixes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack] nvazquez commented on pull request #6142: UI: Remove unused dependencies and fix travis build

2022-04-07 Thread GitBox
nvazquez commented on PR #6142: URL: https://github.com/apache/cloudstack/pull/6142#issuecomment-1092331866 Moving this to the next milestone to prevent any regressions near the 4.17 freeze date -- This is an automated message from the Apache Git Service. To respond to the message, please

[cloudstack] branch main updated: Storage-based Snapshots for KVM VMs (#3724)

2022-04-07 Thread nvazquez
This is an automated email from the ASF dual-hosted git repository. nvazquez pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 2b075ed39e2 Storage-based Snapshots for KVM VM

[GitHub] [cloudstack] nvazquez closed issue #5836: Improve kvm vm snapshot

2022-04-07 Thread GitBox
nvazquez closed issue #5836: Improve kvm vm snapshot URL: https://github.com/apache/cloudstack/issues/5836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [cloudstack] nvazquez merged pull request #3724: Storage-based Snapshots for KVM VMs

2022-04-07 Thread GitBox
nvazquez merged PR #3724: URL: https://github.com/apache/cloudstack/pull/3724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@clouds

[GitHub] [cloudstack] nvazquez commented on pull request #3724: Storage-based Snapshots for KVM VMs

2022-04-07 Thread GitBox
nvazquez commented on PR #3724: URL: https://github.com/apache/cloudstack/pull/3724#issuecomment-1092330638 Merging based on approvals and tests results -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[cloudstack] branch main updated: api: Prevent modifying acl rules order for default ACLs (#6187)

2022-04-07 Thread nvazquez
This is an automated email from the ASF dual-hosted git repository. nvazquez pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new c1c381fcd16 api: Prevent modifying acl rules o

[GitHub] [cloudstack] nvazquez merged pull request #6187: api: Prevent modifying acl rules order for default ACLs

2022-04-07 Thread GitBox
nvazquez merged PR #6187: URL: https://github.com/apache/cloudstack/pull/6187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@clouds

[GitHub] [cloudstack] nvazquez commented on pull request #6197: UI: fixes login button not work and Single Sign-On tab disabled after logout

2022-04-07 Thread GitBox
nvazquez commented on PR #6197: URL: https://github.com/apache/cloudstack/pull/6197#issuecomment-1092326182 Ping for review @rohityadavcloud @Pearl1594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[cloudstack] branch main updated: upgrade: update minreq.sysvmtemplate.version to the latest template version (#6227)

2022-04-07 Thread nvazquez
This is an automated email from the ASF dual-hosted git repository. nvazquez pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new daa7bdb0461 upgrade: update minreq.sysvmtempla

[GitHub] [cloudstack] nvazquez merged pull request #6227: upgrade: update minreq.sysvmtemplate.version to the latest template version

2022-04-07 Thread GitBox
nvazquez merged PR #6227: URL: https://github.com/apache/cloudstack/pull/6227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@clouds

[GitHub] [cloudstack] blueorangutan commented on pull request #6227: upgrade: update minreq.sysvmtemplate.version to the latest template version

2022-04-07 Thread GitBox
blueorangutan commented on PR #6227: URL: https://github.com/apache/cloudstack/pull/6227#issuecomment-1092294820 Trillian test result (tid-3840) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33094 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] blueorangutan commented on pull request #6226: Display proper gateway length in health check result

2022-04-07 Thread GitBox
blueorangutan commented on PR #6226: URL: https://github.com/apache/cloudstack/pull/6226#issuecomment-1092268422 Trillian test result (tid-3838) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33710 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] rwdj commented on issue #6232: HTTP ERROR 503 Service Unavailable /client

2022-04-07 Thread GitBox
rwdj commented on issue #6232: URL: https://github.com/apache/cloudstack/issues/6232#issuecomment-1092241473 As noted, I have seen #3843 and #4027. They didn't help, unfortunately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [cloudstack] boring-cyborg[bot] commented on issue #6232: HTTP ERROR 503 Service Unavailable /client

2022-04-07 Thread GitBox
boring-cyborg[bot] commented on issue #6232: URL: https://github.com/apache/cloudstack/issues/6232#issuecomment-1092228675 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [cloudstack] rwdj opened a new issue, #6232: HTTP ERROR 503 Service Unavailable /client

2022-04-07 Thread GitBox
rwdj opened a new issue, #6232: URL: https://github.com/apache/cloudstack/issues/6232 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ UI ~~~ # CLOUDSTACK VERSION ~~~ cloudstack-management 4.16.1.0-1.el8 mysql 8.0.26 mysql-connector-java 8.0.28

[GitHub] [cloudstack] rohityadavcloud closed pull request #6229: dummy commit

2022-04-07 Thread GitBox
rohityadavcloud closed pull request #6229: dummy commit URL: https://github.com/apache/cloudstack/pull/6229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [cloudstack] synergiator opened a new issue, #6231: Provide project UUID in the user UI if not an admin

2022-04-07 Thread GitBox
synergiator opened a new issue, #6231: URL: https://github.com/apache/cloudstack/issues/6231 # ISSUE TYPE * Enhancement Request # COMPONENT NAME UI # CLOUDSTACK VERSION GA # CONFIGURATION http://qa.cloudstack.cloud:8080 # SU

[GitHub] [cloudstack] kohrar commented on issue #6127: SSO fails with error "Expired session, missing signature, or missing apiKey"

2022-04-07 Thread GitBox
kohrar commented on issue #6127: URL: https://github.com/apache/cloudstack/issues/6127#issuecomment-1092060945 > Thanks @kohrar can you please test a combination of PRs #6193 and #6197? A did a quick test and I had no additional issues with #6193. I didn't test it originally since I d

[GitHub] [cloudstack] blueorangutan commented on pull request #5786: network: ipv6 static routes

2022-04-07 Thread GitBox
blueorangutan commented on PR #5786: URL: https://github.com/apache/cloudstack/pull/5786#issuecomment-1092042367 Trillian test result (tid-3831) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 105960 seconds Marvin logs: https://github.com/blu

[GitHub] [cloudstack] rohityadavcloud opened a new pull request, #6230: .github: build jacoco quality build with parallel threads

2022-04-07 Thread GitBox
rohityadavcloud opened a new pull request, #6230: URL: https://github.com/apache/cloudstack/pull/6230 Aims to speed up github action workflow, reduce build time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[cloudstack] branch main updated (5630ca4411 -> 6bf812cdc9)

2022-04-07 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 5630ca4411 .github: update action tag as per https://issues.apache.org/jira/browse/INFRA-23109 add 6bf812cdc9 .

[cloudstack] branch main updated: .github: update action tag as per https://issues.apache.org/jira/browse/INFRA-23109

2022-04-07 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 5630ca4411 .github: update action tag as per htt

[GitHub] [cloudstack] blueorangutan commented on pull request #6228: Support JaCoCo and other quality checks

2022-04-07 Thread GitBox
blueorangutan commented on PR #6228: URL: https://github.com/apache/cloudstack/pull/6228#issuecomment-109198 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3096 -- This is an automated message from the Apache

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6194: Use MegaLinter for better performances

2022-04-07 Thread GitBox
rohityadavcloud commented on PR #6194: URL: https://github.com/apache/cloudstack/pull/6194#issuecomment-1091878570 Thanks @nvuillam I like your PR but looks like ASF by default doesn't allow all actions to be used in the repo. Maybe you can discuss with them, or I can revisit in near future

[GitHub] [cloudstack] rohityadavcloud commented on pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-04-07 Thread GitBox
rohityadavcloud commented on PR #5769: URL: https://github.com/apache/cloudstack/pull/5769#issuecomment-1091876754 🤦 it should be @weizhouapache and not me - but glad the integration is working cc @nvazquez -- This is an automated message from the Apache Git Service. To respond to the me

[cloudstack] branch main updated (676fe31ca9 -> 1cdacccdc0)

2022-04-07 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 676fe31ca9 UI: Fixes removing undesired API parameters on form submit (#6196) add 1cdacccdc0 maven: support JaC

[GitHub] [cloudstack] rohityadavcloud merged pull request #6228: Support JaCoCo and other quality checks

2022-04-07 Thread GitBox
rohityadavcloud merged PR #6228: URL: https://github.com/apache/cloudstack/pull/6228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [cloudstack] blueorangutan commented on pull request #6228: Support JaCoCo and other quality checks

2022-04-07 Thread GitBox
blueorangutan commented on PR #6228: URL: https://github.com/apache/cloudstack/pull/6228#issuecomment-1091861080 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6228: Support JaCoCo and other quality checks

2022-04-07 Thread GitBox
rohityadavcloud commented on PR #6228: URL: https://github.com/apache/cloudstack/pull/6228#issuecomment-1091859722 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [cloudstack] github-actions[bot] commented on pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-04-07 Thread GitBox
github-actions[bot] commented on PR #5769: URL: https://github.com/apache/cloudstack/pull/5769#issuecomment-1091858582 Hi @rohityadavcloud, your pull request has merge conflicts. Can you fix the conflicts and sync your branch with the base branch? -- This is an automated message from the

[GitHub] [cloudstack] shwstppr commented on pull request #5786: network: ipv6 static routes

2022-04-07 Thread GitBox
shwstppr commented on PR #5786: URL: https://github.com/apache/cloudstack/pull/5786#issuecomment-1091822080 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6228: Support JaCoCo and other quality checks

2022-04-07 Thread GitBox
rohityadavcloud commented on PR #6228: URL: https://github.com/apache/cloudstack/pull/6228#issuecomment-1091807254 Sadly the quality/coverage doesn't allow threaded build with -T flag, and it takes 40+mins alone to build it :( which makes using github actions not scalable for PRs: https:

[GitHub] [cloudstack] nvuillam commented on pull request #6194: Use MegaLinter for better performances

2022-04-07 Thread GitBox
nvuillam commented on PR #6194: URL: https://github.com/apache/cloudstack/pull/6194#issuecomment-1091785451 No problem, it was mainly to check performances :) Have a good day :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[cloudstack] branch main updated: UI: Fixes removing undesired API parameters on form submit (#6196)

2022-04-07 Thread nvazquez
This is an automated email from the ASF dual-hosted git repository. nvazquez pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 676fe31ca9 UI: Fixes removing undesired API pa

[GitHub] [cloudstack] nvazquez closed issue #6184: ui: latest ui sends undesired api parameters on form submit

2022-04-07 Thread GitBox
nvazquez closed issue #6184: ui: latest ui sends undesired api parameters on form submit URL: https://github.com/apache/cloudstack/issues/6184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [cloudstack] nvazquez merged pull request #6196: UI: Fixes removing undesired API parameters on form submit

2022-04-07 Thread GitBox
nvazquez merged PR #6196: URL: https://github.com/apache/cloudstack/pull/6196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@clouds

[GitHub] [cloudstack] nvazquez commented on a diff in pull request #5848: Feat/add vdisk UUID to list volume

2022-04-07 Thread GitBox
nvazquez commented on code in PR #5848: URL: https://github.com/apache/cloudstack/pull/5848#discussion_r845170582 ## engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql: ## @@ -272,6 +291,7 @@ CREATE VIEW `cloud`.`volume_view` AS disk_offering.display_t

[GitHub] [cloudstack] blueorangutan commented on pull request #6196: UI: Fixes removing undesired API parameters on form submit

2022-04-07 Thread GitBox
blueorangutan commented on PR #6196: URL: https://github.com/apache/cloudstack/pull/6196#issuecomment-1091771524 UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6196 (SL-JID-1349) -- This is an automated message from the Apache Git Service. To respond

[GitHub] [cloudstack] blueorangutan commented on pull request #6196: UI: Fixes removing undesired API parameters on form submit

2022-04-07 Thread GitBox
blueorangutan commented on PR #6196: URL: https://github.com/apache/cloudstack/pull/6196#issuecomment-1091766070 @nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] nvazquez commented on pull request #6196: UI: Fixes removing undesired API parameters on form submit

2022-04-07 Thread GitBox
nvazquez commented on PR #6196: URL: https://github.com/apache/cloudstack/pull/6196#issuecomment-1091762255 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume

2022-04-07 Thread GitBox
blueorangutan commented on PR #5848: URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1091762200 Trillian Build Failed (tid-3839) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cloudstack] blueorangutan commented on pull request #6227: upgrade: update minreq.sysvmtemplate.version to the latest template version

2022-04-07 Thread GitBox
blueorangutan commented on PR #6227: URL: https://github.com/apache/cloudstack/pull/6227#issuecomment-1091758189 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] nvazquez commented on pull request #6227: upgrade: update minreq.sysvmtemplate.version to the latest template version

2022-04-07 Thread GitBox
nvazquez commented on PR #6227: URL: https://github.com/apache/cloudstack/pull/6227#issuecomment-1091757388 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [cloudstack] blueorangutan commented on pull request #6227: upgrade: update minreq.sysvmtemplate.version to the latest template version

2022-04-07 Thread GitBox
blueorangutan commented on PR #6227: URL: https://github.com/apache/cloudstack/pull/6227#issuecomment-1091753032 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3095 -- This is an automated message from the Apache

[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume

2022-04-07 Thread GitBox
blueorangutan commented on PR #5848: URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1091740433 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] nvazquez commented on pull request #5848: Feat/add vdisk UUID to list volume

2022-04-07 Thread GitBox
nvazquez commented on PR #5848: URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1091739130 @blueorangutan test centos7 vmware-67u3 keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack] blueorangutan commented on pull request #6227: upgrade: update minreq.sysvmtemplate.version to the latest template version

2022-04-07 Thread GitBox
blueorangutan commented on PR #6227: URL: https://github.com/apache/cloudstack/pull/6227#issuecomment-1091710514 @nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- T

[GitHub] [cloudstack] nvazquez commented on pull request #6227: upgrade: update minreq.sysvmtemplate.version to the latest template version

2022-04-07 Thread GitBox
nvazquez commented on PR #6227: URL: https://github.com/apache/cloudstack/pull/6227#issuecomment-1091710154 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [cloudstack] nvazquez closed pull request #6194: Use MegaLinter for better performances

2022-04-07 Thread GitBox
nvazquez closed pull request #6194: Use MegaLinter for better performances URL: https://github.com/apache/cloudstack/pull/6194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [cloudstack] nvazquez commented on pull request #6194: Use MegaLinter for better performances

2022-04-07 Thread GitBox
nvazquez commented on PR #6194: URL: https://github.com/apache/cloudstack/pull/6194#issuecomment-1091709307 Thanks for your feedback @jbampton @weizhouapache - I agree as well to keep only Github supported linter @nvuillam I think we can close the PR for now while only actions made by Gi

[cloudstack] branch main updated: Allow storage.overprovisioning.factor to be <1 which allows underprovisioning of storage pools (#6218)

2022-04-07 Thread nvazquez
This is an automated email from the ASF dual-hosted git repository. nvazquez pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 68fa9a1061 Allow storage.overprovisioning.fact

[GitHub] [cloudstack] nvazquez merged pull request #6218: Allow storage.overprovisioning.factor to be <1

2022-04-07 Thread GitBox
nvazquez merged PR #6218: URL: https://github.com/apache/cloudstack/pull/6218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@clouds

[GitHub] [cloudstack] blueorangutan commented on pull request #6226: Display proper gateway length in health check result

2022-04-07 Thread GitBox
blueorangutan commented on PR #6226: URL: https://github.com/apache/cloudstack/pull/6226#issuecomment-1091687047 @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [cloudstack] Pearl1594 commented on pull request #6226: Display proper gateway length in health check result

2022-04-07 Thread GitBox
Pearl1594 commented on PR #6226: URL: https://github.com/apache/cloudstack/pull/6226#issuecomment-1091685338 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [cloudstack] DaanHoogland commented on pull request #6228: Support JaCoCo and other quality checks

2022-04-07 Thread GitBox
DaanHoogland commented on PR #6228: URL: https://github.com/apache/cloudstack/pull/6228#issuecomment-1091675920 > @DaanHoogland I need some input on how the Jenkins pr-analysis job is tied to PRs. It doesn't show up now :( in the list of PR checks - [ci-builds.apache.org/job/Cloudstack/job/

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6228: Support JaCoCo and other quality checks

2022-04-07 Thread GitBox
rohityadavcloud commented on PR #6228: URL: https://github.com/apache/cloudstack/pull/6228#issuecomment-1091669482 @DaanHoogland I need some input on how the Jenkins pr-analysis job is tied to PRs. It doesn't show up now :( in the list of PR checks - https://ci-builds.apache.org/job/Cloudst

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6228: Support JaCoCo and other quality checks

2022-04-07 Thread GitBox
rohityadavcloud commented on code in PR #6228: URL: https://github.com/apache/cloudstack/pull/6228#discussion_r845046737 ## pom.xml: ## @@ -1152,7 +1152,6 @@ ${cs.surefire-plugin.version} false -

[GitHub] [cloudstack] blueorangutan commented on pull request #6226: Display proper gateway length in health check result

2022-04-07 Thread GitBox
blueorangutan commented on PR #6226: URL: https://github.com/apache/cloudstack/pull/6226#issuecomment-1091613664 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3094 -- This is an automated message from the Apache

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6226: Display proper gateway length in health check result

2022-04-07 Thread GitBox
rohityadavcloud commented on PR #6226: URL: https://github.com/apache/cloudstack/pull/6226#issuecomment-1091562409 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [cloudstack] blueorangutan commented on pull request #6226: Display proper gateway length in health check result

2022-04-07 Thread GitBox
blueorangutan commented on PR #6226: URL: https://github.com/apache/cloudstack/pull/6226#issuecomment-1091563679 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6228: Support JaCoCo and other quality checks

2022-04-07 Thread GitBox
rohityadavcloud commented on code in PR #6228: URL: https://github.com/apache/cloudstack/pull/6228#discussion_r844977182 ## .github/workflows/pull-request-checks.yml: ## @@ -15,17 +15,45 @@ # specific language governing permissions and limitations # under the License. -name:

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6228: Support JaCoCo and other quality checks

2022-04-07 Thread GitBox
DaanHoogland commented on code in PR #6228: URL: https://github.com/apache/cloudstack/pull/6228#discussion_r844975016 ## .github/workflows/pull-request-checks.yml: ## @@ -15,17 +15,45 @@ # specific language governing permissions and limitations # under the License. -name: Li

[GitHub] [cloudstack] rohityadavcloud opened a new pull request, #6228: Support JaCoCo and other quality checks

2022-04-07 Thread GitBox
rohityadavcloud opened a new pull request, #6228: URL: https://github.com/apache/cloudstack/pull/6228 This enables JaCoCo and other quality/history checks for the ASF Jenkins job. Also adds a workflow to generate coverage report for the PR. -- This is an automated message from the Apache

[GitHub] [cloudstack] Pearl1594 opened a new pull request, #6227: upgrade: update minreq.sysvmtemplate.version to the latest template version

2022-04-07 Thread GitBox
Pearl1594 opened a new pull request, #6227: URL: https://github.com/apache/cloudstack/pull/6227 ### Description This PR fixes the value set for `minreq.sysvmtemplate.version` when upgrading to 4.17. Because of the value being hard-coded to 4.16.0 at https://github.com/apache/clo

[GitHub] [cloudstack] ravening opened a new pull request, #6226: Display proper gateway length in health check result

2022-04-07 Thread GitBox
ravening opened a new pull request, #6226: URL: https://github.com/apache/cloudstack/pull/6226 ### Description The output always returns 1 since all gateways are present in one line but the actual output should be the number of gateways present in that line

[GitHub] [cloudstack] DaanHoogland commented on pull request #3951: Network orchestrator refactor

2022-04-07 Thread GitBox
DaanHoogland commented on PR #3951: URL: https://github.com/apache/cloudstack/pull/3951#issuecomment-1091283030 retry sometime later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [cloudstack] DaanHoogland closed pull request #3951: Network orchestrator refactor

2022-04-07 Thread GitBox
DaanHoogland closed pull request #3951: Network orchestrator refactor URL: https://github.com/apache/cloudstack/pull/3951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [cloudstack] DaanHoogland closed pull request #3933: Ip manager refactor

2022-04-07 Thread GitBox
DaanHoogland closed pull request #3933: Ip manager refactor URL: https://github.com/apache/cloudstack/pull/3933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [cloudstack] DaanHoogland commented on pull request #3933: Ip manager refactor

2022-04-07 Thread GitBox
DaanHoogland commented on PR #3933: URL: https://github.com/apache/cloudstack/pull/3933#issuecomment-1091282319 retry sometime later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[cloudstack] branch main updated: .github: fix workflow settings and allow branch pushes to main by committers (#6225)

2022-04-07 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 2b1c4fbe6e .github: fix workflow settings and all

[GitHub] [cloudstack] rohityadavcloud merged pull request #6225: .github: fix workflow settings and allow branch pushes to main by com…

2022-04-07 Thread GitBox
rohityadavcloud merged PR #6225: URL: https://github.com/apache/cloudstack/pull/6225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6225: .github: fix workflow settings and allow branch pushes to main by com…

2022-04-07 Thread GitBox
rohityadavcloud commented on PR #6225: URL: https://github.com/apache/cloudstack/pull/6225#issuecomment-1091213498 In the last run [1], it appears the workflow has worked but failed to ping the PR author (the variable wasn't expanded as documented in one of the wikis/blogs). This attempts t

[GitHub] [cloudstack] rohityadavcloud opened a new pull request, #6225: .github: fix workflow settings and allow branch pushes to main by com…

2022-04-07 Thread GitBox
rohityadavcloud opened a new pull request, #6225: URL: https://github.com/apache/cloudstack/pull/6225 …mitters This fixes the comment message for merge conflict checker and resets the github branch protection for main in case of need by the RM. ### Types of changes - [

[GitHub] [cloudstack] blueorangutan commented on pull request #5831: SystemVM optimizations

2022-04-07 Thread GitBox
blueorangutan commented on PR #5831: URL: https://github.com/apache/cloudstack/pull/5831#issuecomment-1091164906 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3093 -- This is an automated message from the Apache

[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource

2022-04-07 Thread GitBox
blueorangutan commented on PR #6202: URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1091150917 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3092 -- This is an automated message from the Apache