[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6442: Possibility to choose the source NAT IP address on a isolated network or VPC

2023-05-02 Thread via GitHub
DaanHoogland commented on code in PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#discussion_r1183301894 ## api/src/main/java/org/apache/cloudstack/api/response/IPAddressResponse.java: ## @@ -159,10 +159,9 @@ public class IPAddressResponse extends BaseResponseWith

[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6442: Possibility to choose the source NAT IP address on a isolated network or VPC

2023-05-02 Thread via GitHub
harikrishna-patnala commented on code in PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#discussion_r1183283308 ## .github/workflows/ci.yml: ## @@ -79,7 +79,8 @@ jobs: smoke/test_metrics_api smoke/test_migration

[GitHub] [cloudstack] blueorangutan commented on pull request #7397: Feature: VM Scheduler

2023-05-02 Thread via GitHub
blueorangutan commented on PR #7397: URL: https://github.com/apache/cloudstack/pull/7397#issuecomment-1532307191 Trillian test result (tid-6495) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39459 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] GaOrtiga commented on a diff in pull request #7153: Introducing concept of domain VPCs

2023-05-02 Thread via GitHub
GaOrtiga commented on code in PR #7153: URL: https://github.com/apache/cloudstack/pull/7153#discussion_r1183062659 ## server/src/main/java/com/cloud/network/IpAddressManagerImpl.java: ## @@ -1476,7 +1476,8 @@ public IPAddressVO associateIPToGuestNetwork(long ipId, long networkI

[cloudstack-www] branch docusaurus-staging updated (0e9a504b -> b1a44b2d)

2023-05-02 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from 0e9a504b fixes add b1a44b2d use-cases pages No new revisions were added by this update. Summ

[cloudstack-www] branch docusaurus-staging updated (4ef206e0 -> 0e9a504b)

2023-05-02 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from 4ef206e0 fix tagline add 0e9a504b fixes No new revisions were added by this update. Summary

[GitHub] [cloudstack] JoaoJandre opened a new pull request, #7489: Flexible tags for hosts and storage pools

2023-05-02 Thread via GitHub
JoaoJandre opened a new pull request, #7489: URL: https://github.com/apache/cloudstack/pull/7489 ### Description Currently when setting tags for a resource, a host for example, offerings with those tags will be directed towards that resource. However, offerings without any tags may a

[GitHub] [cloudstack] blueorangutan commented on pull request #6442: Possibility to choose the source NAT IP address on a isolated network or VPC

2023-05-02 Thread via GitHub
blueorangutan commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1531724410 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6013 -- This is an automated

[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7323: Changed all references from VM to Instance to maintain a naming pattern.

2023-05-02 Thread via GitHub
harikrishna-patnala commented on PR #7323: URL: https://github.com/apache/cloudstack/pull/7323#issuecomment-1531692628 > @msinhore I think we should make this VM Instances and not just Instances. It will be confusing. agree with @DaanHoogland it will be more readable for all types of

[cloudstack-www] branch docusaurus-staging updated (eaa331b8 -> 4ef206e0)

2023-05-02 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from eaa331b8 address review comments from Ivet add 4ef206e0 fix tagline No new revisions were add

[cloudstack-www] branch docusaurus-staging updated (aa945f9f -> eaa331b8)

2023-05-02 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from aa945f9f add jamie and test blog add eaa331b8 address review comments from Ivet No new revisi

[GitHub] [cloudstack] github-actions[bot] commented on pull request #7484: HAproxy based load balancer Customisation

2023-05-02 Thread via GitHub
github-actions[bot] commented on PR #7484: URL: https://github.com/apache/cloudstack/pull/7484#issuecomment-1531643871 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

[GitHub] [cloudstack] github-actions[bot] commented on pull request #7323: Changed all references from VM to Instance to maintain a naming pattern.

2023-05-02 Thread via GitHub
github-actions[bot] commented on PR #7323: URL: https://github.com/apache/cloudstack/pull/7323#issuecomment-1531637311 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

[cloudstack-www] branch docusaurus-staging updated (b956a228 -> aa945f9f)

2023-05-02 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from b956a228 add jamie add aa945f9f add jamie and test blog No new revisions were added by this u

[cloudstack-www] branch docusaurus-staging updated (82b15215 -> b956a228)

2023-05-02 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from 82b15215 blog fix add b956a228 add jamie No new revisions were added by this update. Summary

[cloudstack-www] branch docusaurus-staging updated (2cdb3a4e -> 82b15215)

2023-05-02 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from 2cdb3a4e make landing page same as old site add 82b15215 blog fix No new revisions were added

[GitHub] [cloudstack] blueorangutan commented on pull request #7397: Feature: VM Scheduler

2023-05-02 Thread via GitHub
blueorangutan commented on PR #7397: URL: https://github.com/apache/cloudstack/pull/7397#issuecomment-1531431896 @vishesh92 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [cloudstack] vishesh92 commented on pull request #7397: Feature: VM Scheduler

2023-05-02 Thread via GitHub
vishesh92 commented on PR #7397: URL: https://github.com/apache/cloudstack/pull/7397#issuecomment-1531429596 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [cloudstack] blueorangutan commented on pull request #6442: Possibility to choose the source NAT IP address on a isolated network or VPC

2023-05-02 Thread via GitHub
blueorangutan commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1531427705 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6012 -- This is an automated

[GitHub] [cloudstack] blueorangutan commented on pull request #7397: Feature: VM Scheduler

2023-05-02 Thread via GitHub
blueorangutan commented on PR #7397: URL: https://github.com/apache/cloudstack/pull/7397#issuecomment-1531421443 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6011 -- This is an automated

[cloudstack-documentation] branch main updated: Added details to the stickiness policy under load balacing

2023-05-02 Thread harikrishna
This is an automated email from the ASF dual-hosted git repository. harikrishna pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git The following commit(s) were added to refs/heads/main by this push: new 7d95054 Added details to the

[GitHub] [cloudstack] weizhouapache commented on issue #7431: Kubernetes external ip for a loadbalancer service is in peding state

2023-05-02 Thread via GitHub
weizhouapache commented on issue #7431: URL: https://github.com/apache/cloudstack/issues/7431#issuecomment-1531340534 @Noelantogerorge yes, understood. can you create a github issue for it ? it looks like a small change can you also share what you have done to make it work ? -- T

[GitHub] [cloudstack] blueorangutan commented on pull request #6442: Possibility to choose the source NAT IP address on a isolated network or VPC

2023-05-02 Thread via GitHub
blueorangutan commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1531337035 Trillian Build Failed (tid-6494) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cloudstack] blueorangutan commented on pull request #7397: Feature: VM Scheduler

2023-05-02 Thread via GitHub
blueorangutan commented on PR #7397: URL: https://github.com/apache/cloudstack/pull/7397#issuecomment-1531326453 @vishesh92 a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. --

[GitHub] [cloudstack] vishesh92 commented on pull request #7397: Feature: VM Scheduler

2023-05-02 Thread via GitHub
vishesh92 commented on PR #7397: URL: https://github.com/apache/cloudstack/pull/7397#issuecomment-1531325266 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [cloudstack] Noelantogerorge commented on issue #7431: Kubernetes external ip for a loadbalancer service is in peding state

2023-05-02 Thread via GitHub
Noelantogerorge commented on issue #7431: URL: https://github.com/apache/cloudstack/issues/7431#issuecomment-1531324120 @weizhouapache Ya, When ever I create a cluster there is no metric API available with it. With metric API we could get the pod and node utilization also it helps to

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7434: Few UI fixes and details improvements

2023-05-02 Thread via GitHub
rohityadavcloud commented on PR #7434: URL: https://github.com/apache/cloudstack/pull/7434#issuecomment-1531318702 LGTM, merging based on @borisstoyanov 's testing. Thanks @harikrishna-patnala -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [cloudstack] rohityadavcloud merged pull request #7434: Few UI fixes and details improvements

2023-05-02 Thread via GitHub
rohityadavcloud merged PR #7434: URL: https://github.com/apache/cloudstack/pull/7434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[cloudstack] branch main updated: Few UI fixes and details improvements (#7434)

2023-05-02 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new b280370a983 Few UI fixes and details improvements

[GitHub] [cloudstack] weizhouapache commented on issue #7431: Kubernetes external ip for a loadbalancer service is in peding state

2023-05-02 Thread via GitHub
weizhouapache commented on issue #7431: URL: https://github.com/apache/cloudstack/issues/7431#issuecomment-1531296208 @Noelantogerorge can you explain a bit more of your requirement ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [cloudstack] kiranchavala commented on issue #7483: VPC ACL Issue

2023-05-02 Thread via GitHub
kiranchavala commented on issue #7483: URL: https://github.com/apache/cloudstack/issues/7483#issuecomment-1531254330 This is a good improvement request to add source and destination CIDRs to Network ACL items -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [cloudstack] nikam14 opened a new pull request, #7488: [Enhancement] removed commented code in DhcpProtocolParserServer.java

2023-05-02 Thread via GitHub
nikam14 opened a new pull request, #7488: URL: https://github.com/apache/cloudstack/pull/7488 ### Description This PR... removed commented code. ### Types of changes - [ ] Breaking change (fix or feature that would cause

[cloudstack-www] branch docusaurus-staging updated (af41f838 -> 2cdb3a4e)

2023-05-02 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from af41f838 remove homepage features add 2cdb3a4e make landing page same as old site No new revi

[GitHub] [cloudstack] boring-cyborg[bot] commented on issue #7487: [Enhancement] unused code in file PropertiesStorage.java

2023-05-02 Thread via GitHub
boring-cyborg[bot] commented on issue #7487: URL: https://github.com/apache/cloudstack/issues/7487#issuecomment-1531225290 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [cloudstack] nikam14 opened a new issue, #7487: [Enhancement] unused code in file PropertiesStorage.java

2023-05-02 Thread via GitHub
nikam14 opened a new issue, #7487: URL: https://github.com/apache/cloudstack/issues/7487 # ISSUE TYPE * Improvement Request * Enhancement Request # SUMMARY location: agent/src/main/java/com/cloud/agent/dao/impl/PropertiesStorage.java line

[GitHub] [cloudstack] blueorangutan commented on pull request #6442: Possibility to choose the source NAT IP address on a isolated network or VPC

2023-05-02 Thread via GitHub
blueorangutan commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1531208194 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6010 -- This is an automated

[GitHub] [cloudstack] nikam14 opened a new pull request, #7486: [MINOR][Enhancement] improved concatenation way in PropertiesStorage.java

2023-05-02 Thread via GitHub
nikam14 opened a new pull request, #7486: URL: https://github.com/apache/cloudstack/pull/7486 ### Description This PR... changed the '+' operator for concatenation to .concat method for concatenation because '+' operator takes more time then .concat method. [Optimisation].

[GitHub] [cloudstack] Noelantogerorge commented on issue #7431: Kubernetes external ip for a loadbalancer service is in peding state

2023-05-02 Thread via GitHub
Noelantogerorge commented on issue #7431: URL: https://github.com/apache/cloudstack/issues/7431#issuecomment-1531192722 @weizhouapache Is it possible for you to add metric api to kubernetes cluster.. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [cloudstack] Noelantogerorge commented on issue #7431: Kubernetes external ip for a loadbalancer service is in peding state

2023-05-02 Thread via GitHub
Noelantogerorge commented on issue #7431: URL: https://github.com/apache/cloudstack/issues/7431#issuecomment-1531173452 @weizhouapache I created 2 cluster 1 with shared network and other with isolated network. So my app servers and its associated pods works in isolated network with

[cloudstack-www] branch docusaurus-staging updated (6f34312f -> af41f838)

2023-05-02 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from 6f34312f remove users logos add af41f838 remove homepage features No new revisions were added

[cloudstack-www] branch docusaurus-staging updated (ca16c42d -> 6f34312f)

2023-05-02 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from ca16c42d disable dark theme add 6f34312f remove users logos No new revisions were added by th

[GitHub] [cloudstack] toneskoturw commented on issue #7481: NoVNC cannot be accessed through a browser

2023-05-02 Thread via GitHub
toneskoturw commented on issue #7481: URL: https://github.com/apache/cloudstack/issues/7481#issuecomment-1531076701 When I upgraded to 4.18, I encountered the same problem as you. I manually shutdown the ConsoleProxy VM, and the VM automatically restarted, problem solved. (restarting the CP

[cloudstack-www] branch docusaurus-staging updated (e4d03e43 -> ca16c42d)

2023-05-02 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from e4d03e43 update: fix suresh's feedback use banner as old website add ca16c42d disable dark the

[cloudstack-www] branch docusaurus-staging updated (7883e3e4 -> e4d03e43)

2023-05-02 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from 7883e3e4 move to developers resources page add e4d03e43 update: fix suresh's feedback use bann

[cloudstack-www] branch docusaurus-staging updated (a8d06a23 -> 7883e3e4)

2023-05-02 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from a8d06a23 move blog item, Suresh's comment from ML add 7883e3e4 move to developers resources pa

[cloudstack-www] branch docusaurus-staging updated (74790dc8 -> a8d06a23)

2023-05-02 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from 74790dc8 landing pages from ivet's ideas add a8d06a23 move blog item, Suresh's comment from ML

[cloudstack-www] branch docusaurus-staging updated (586fbc24 -> 74790dc8)

2023-05-02 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from 586fbc24 fix xcp-ng add 74790dc8 landing pages from ivet's ideas No new revisions were added

[GitHub] [cloudstack] weizhouapache commented on issue #7483: VPC ACL Issue

2023-05-02 Thread via GitHub
weizhouapache commented on issue #7483: URL: https://github.com/apache/cloudstack/issues/7483#issuecomment-1531030770 Currently network ACLs apply on VPC tiers only. it might be a change (API, UI, service layer) to support ACL on public IPs. as I said on mailing list, Each ACL rule ca

[GitHub] [cloudstack] rajujith commented on issue #7483: VPC ACL Issue

2023-05-02 Thread via GitHub
rajujith commented on issue #7483: URL: https://github.com/apache/cloudstack/issues/7483#issuecomment-1531004270 @assistanz247 by the current design the network ACL in a VPC is applicable at the tier side hence the public port is not filtered by the ACL. It is allowing the traffic since th