[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7345: [HEALTH] 4.18 LTS Health Check, please don't merge this!

2023-08-25 Thread via GitHub
sonarcloud[bot] commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1694194367 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Q

[GitHub] [cloudstack] meisammaleki opened a new issue, #7914: (HTTP 530, error code 4250) Failed to get listusersresponse on Cloudstack 4.17.2

2023-08-25 Thread via GitHub
meisammaleki opened a new issue, #7914: URL: https://github.com/apache/cloudstack/issues/7914 # ISSUE TYPE Bug Report # COMPONENT NAME API # CLOUDSTACK VERSION 4.17.2 # CONFIGURATION # OS / ENVIRONMENT Centos 7 # SUMMARY I

[cloudstack] 01/01: don't merge

2023-08-25 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.18-dummy in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 801c4bfdf33416e7e25beddc4042e4f82c6b46da Author: Daan Hoogland AuthorDate: Thu Mar 16 09:21:39 2023 +0100 don

[cloudstack] branch 4.18-dummy updated (932cc5b0c5b -> 801c4bfdf33)

2023-08-25 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.18-dummy in repository https://gitbox.apache.org/repos/asf/cloudstack.git omit 932cc5b0c5b don't merge add f5a1f4130d5 server: fix global setting system.vm.public.ip.reservation.mode.st

[GitHub] [cloudstack] blueorangutan commented on pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-25 Thread via GitHub
blueorangutan commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1694155208 [SF] Trillian test result (tid-7561) Environment: xcpng82 (x2), Advanced Networking with Mgmt server 7 Total time taken: 62521 seconds Marvin logs: https://github.com/blu

[GitHub] [cloudstack] blueorangutan commented on pull request #7345: [HEALTH] 4.18 LTS Health Check, please don't merge this!

2023-08-25 Thread via GitHub
blueorangutan commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1694145184 [SF] Trillian test result (tid-7553) Environment: xcpng82 (x2), Advanced Networking with Mgmt server 7 Total time taken: 63849 seconds Marvin logs: https://github.com/blu

[GitHub] [cloudstack] blueorangutan commented on pull request #7345: [HEALTH] 4.18 LTS Health Check, please don't merge this!

2023-08-25 Thread via GitHub
blueorangutan commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1694141652 [LL]Trillian test result (tid-6712) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 51909 seconds Marvin logs: https://github.com

[GitHub] [cloudstack] blueorangutan commented on pull request #6812: Normalize encryption on global configurations values

2023-08-25 Thread via GitHub
blueorangutan commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1694123262 [LL]Trillian test result (tid-6709) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 47870 seconds Marvin logs: https://github.com

[GitHub] [cloudstack] blueorangutan commented on pull request #7912: utils: build both SHADED and original jars

2023-08-25 Thread via GitHub
blueorangutan commented on PR #7912: URL: https://github.com/apache/cloudstack/pull/7912#issuecomment-1694087974 [SF] Trillian test result (tid-7559) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 51885 seconds Marvin logs: https://github.

[GitHub] [cloudstack] blueorangutan commented on pull request #6812: Normalize encryption on global configurations values

2023-08-25 Thread via GitHub
blueorangutan commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1694061040 [LL]Trillian test result (tid-6710) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40177 seconds Marvin logs: https://github.com/

[GitHub] [cloudstack] blueorangutan commented on pull request #6812: Normalize encryption on global configurations values

2023-08-25 Thread via GitHub
blueorangutan commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1694059330 [LL]Trillian test result (tid-6708) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40092 seconds Marvin logs: https://github.com

[GitHub] [cloudstack] blueorangutan commented on pull request #7874: systemvm: update size and state of systemvm template during registration

2023-08-25 Thread via GitHub
blueorangutan commented on PR #7874: URL: https://github.com/apache/cloudstack/pull/7874#issuecomment-1694030371 [SF] Trillian test result (tid-7562) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38997 seconds Marvin logs: https://github.com

[GitHub] [cloudstack] blueorangutan commented on pull request #7345: [HEALTH] 4.18 LTS Health Check, please don't merge this!

2023-08-25 Thread via GitHub
blueorangutan commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1694029730 [LL]Trillian test result (tid-6711) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 37407 seconds Marvin logs: https://github.com

[GitHub] [cloudstack] blueorangutan commented on pull request #7912: utils: build both SHADED and original jars

2023-08-25 Thread via GitHub
blueorangutan commented on PR #7912: URL: https://github.com/apache/cloudstack/pull/7912#issuecomment-1693989542 [SF] Trillian test result (tid-7556) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 43123 seconds Marvin logs: https://github.co

[GitHub] [cloudstack] blueorangutan commented on pull request #7913: server: throw new exception when rootdisksize is required but not set

2023-08-25 Thread via GitHub
blueorangutan commented on PR #7913: URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1693978042 [SF] Trillian test result (tid-7558) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41943 seconds Marvin logs: https://github.com

[GitHub] [cloudstack] blueorangutan commented on pull request #7912: utils: build both SHADED and original jars

2023-08-25 Thread via GitHub
blueorangutan commented on PR #7912: URL: https://github.com/apache/cloudstack/pull/7912#issuecomment-1693968301 [SF] Trillian test result (tid-7557) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41146 seconds Marvin logs: https://github.com

[GitHub] [cloudstack] blueorangutan commented on pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!

2023-08-25 Thread via GitHub
blueorangutan commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1693953989 [LL]Trillian test result (tid-6706) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 52127 seconds Marvin logs: https://github.com

[GitHub] [cloudstack] blueorangutan commented on pull request #7912: utils: build both SHADED and original jars

2023-08-25 Thread via GitHub
blueorangutan commented on PR #7912: URL: https://github.com/apache/cloudstack/pull/7912#issuecomment-1693930831 [SF] Trillian test result (tid-7555) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38981 seconds Marvin logs: https://github.co

[GitHub] [cloudstack] blueorangutan commented on pull request #7909: server: fix global setting system.vm.public.ip.reservation.mode.strictness is not really dynamic

2023-08-25 Thread via GitHub
blueorangutan commented on PR #7909: URL: https://github.com/apache/cloudstack/pull/7909#issuecomment-1693884562 [SF] Trillian test result (tid-7551) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40678 seconds Marvin logs: https://github.com

[GitHub] [cloudstack] gpordeus commented on pull request #7615: server: Fix NPE when migrating volume without template

2023-08-25 Thread via GitHub
gpordeus commented on PR #7615: URL: https://github.com/apache/cloudstack/pull/7615#issuecomment-1693829103 > @gpordeus I can reproduce the issue @vladimirpetrov faced in his testing > > image of vm B does not have backing file either, but it works (the disk size is much bigger than v

[GitHub] [cloudstack] blueorangutan commented on pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!

2023-08-25 Thread via GitHub
blueorangutan commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1693716648 [LL]Trillian test result (tid-6705) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38415 seconds Marvin logs: https://github.com

[GitHub] [cloudstack] blueorangutan commented on pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!

2023-08-25 Thread via GitHub
blueorangutan commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1693702081 [LL]Trillian test result (tid-6707) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 37670 seconds Marvin logs: https://github.com/

[GitHub] [cloudstack] weizhouapache commented on pull request #6812: Normalize encryption on global configurations values

2023-08-25 Thread via GitHub
weizhouapache commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1693689311 > > > @BryanMLima @weizhouapache @soreana , what else is needed on this? > > > > > > I think it is better to keep this PR for the next release (4.18.2 or even 4.19) as

[GitHub] [cloudstack] soreana commented on pull request #6812: Normalize encryption on global configurations values

2023-08-25 Thread via GitHub
soreana commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1693500859 > > @BryanMLima @weizhouapache @soreana , what else is needed on this? > > I think it is better to keep this PR for the next release (4.18.2 or even 4.19) as to not delay the `4.

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-25 Thread via GitHub
DaanHoogland commented on code in PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#discussion_r1305769377 ## plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/XenServerGuru.java: ## @@ -96,14 +95,7 @@ public VirtualMachineTO implement(VirtualMachinePr

[cloudstack] branch 4.18 updated (57d4d0d94a7 -> 0dd6bb7c67b)

2023-08-25 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 57d4d0d94a7 UI: Infer template settings in the deploy VM wizard (#7867) add 0dd6bb7c67b systemvm: update size and

[GitHub] [cloudstack] DaanHoogland merged pull request #7874: systemvm: update size and state of systemvm template during registration

2023-08-25 Thread via GitHub
DaanHoogland merged PR #7874: URL: https://github.com/apache/cloudstack/pull/7874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[GitHub] [cloudstack] DaanHoogland closed issue #7910: GUI - search instance always give the first VM name and GUI is very slow

2023-08-25 Thread via GitHub
DaanHoogland closed issue #7910: GUI - search instance always give the first VM name and GUI is very slow URL: https://github.com/apache/cloudstack/issues/7910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[cloudstack] branch main updated (24ae5aa5fad -> f563c165cb3)

2023-08-25 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 24ae5aa5fad Merge branch '4.18' add 57d4d0d94a7 UI: Infer template settings in the deploy VM wizard (#7867)

[cloudstack] 01/01: Merge release branch 4.18 to main

2023-08-25 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit f563c165cb397aec3a813f15987e173ee3b7447d Merge: 24ae5aa5fad 57d4d0d94a7 Author: Daan Hoogland AuthorDate: Fri Aug 25 16:

[GitHub] [cloudstack] DaanHoogland merged pull request #7867: UI: Infer template settings in the deploy VM wizard

2023-08-25 Thread via GitHub
DaanHoogland merged PR #7867: URL: https://github.com/apache/cloudstack/pull/7867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[cloudstack] branch 4.18 updated: UI: Infer template settings in the deploy VM wizard (#7867)

2023-08-25 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.18 by this push: new 57d4d0d94a7 UI: Infer template settings in the dep

[GitHub] [cloudstack] DaanHoogland commented on pull request #7874: systemvm: update size and state of systemvm template during registration

2023-08-25 Thread via GitHub
DaanHoogland commented on PR #7874: URL: https://github.com/apache/cloudstack/pull/7874#issuecomment-1693461618 verified both conditions in a test env. template size is set during zone creation only one entry is added per template/store (i didn't know this was a thing) ready to m

[GitHub] [cloudstack] soreana commented on pull request #6812: Normalize encryption on global configurations values

2023-08-25 Thread via GitHub
soreana commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1693418068 > > LGTM, tested the PR manually, here are the steps and results: > > > > 1. Created an account and domain in my test environment, and set the following configurations: > >

[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19

2023-08-25 Thread via GitHub
github-actions[bot] commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1693368489 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

[GitHub] [cloudstack] weizhouapache commented on pull request #7874: systemvm: update size and state of systemvm template during registration

2023-08-25 Thread via GitHub
weizhouapache commented on PR #7874: URL: https://github.com/apache/cloudstack/pull/7874#issuecomment-1693327030 @rohityadavcloud @DaanHoogland this fixes two current issues when setup a cloudstack zone (1) system vm template size is NULL until ssvm is Up (2) there are duplicated re

[GitHub] [cloudstack] weizhouapache commented on pull request #7912: utils: build both SHADED and original jars

2023-08-25 Thread via GitHub
weizhouapache commented on PR #7912: URL: https://github.com/apache/cloudstack/pull/7912#issuecomment-1693318156 > Hi @weizhouapache thanks for the PR - can you explain, the advantage of this, for systemvms aren't we copying all dependency jars? @rohityadavcloud the jars in system

[GitHub] [cloudstack] weizhouapache commented on pull request #7912: utils: build both SHADED and original jars

2023-08-25 Thread via GitHub
weizhouapache commented on PR #7912: URL: https://github.com/apache/cloudstack/pull/7912#issuecomment-1693312393 > ok so this depends on #7131 to make any sense, but it removes the need of a new command line for the encryption tools 👍 yes, moreover, no need to install `log4j-core`

[GitHub] [cloudstack] DaanHoogland commented on pull request #7912: utils: build both SHADED and original jars

2023-08-25 Thread via GitHub
DaanHoogland commented on PR #7912: URL: https://github.com/apache/cloudstack/pull/7912#issuecomment-1693306171 ok so this depends on #7131 to make any sense, but it removes the need of a new command line for the encryption tools :+1: -- This is an automated message from the Apache

[GitHub] [cloudstack] weizhouapache commented on pull request #7912: utils: build both SHADED and original jars

2023-08-25 Thread via GitHub
weizhouapache commented on PR #7912: URL: https://github.com/apache/cloudstack/pull/7912#issuecomment-1693290343 @rohityadavcloud @DaanHoogland - Without this PR (main) During build, it creates `cloud-utils-4.19.0.0-SNAPSHOT.jar` which contains some dependencies, see below

[cloudstack] branch main updated (3b05797344c -> 24ae5aa5fad)

2023-08-25 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 3b05797344c Merge remote-tracking branch 'origin/4.18' add e964395bd45 vmware: improve solidfire storage plugin i

[cloudstack] 01/01: Merge branch '4.18'

2023-08-25 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 24ae5aa5fad92006db02f3ae5ee08beda0c96d09 Merge: 3b05797344c 93bd5b7a692 Author: Daan Hoogland AuthorDate: Fri Aug 25 14:

[GitHub] [cloudstack] blueorangutan commented on pull request #7874: systemvm: update size and state of systemvm template during registration

2023-08-25 Thread via GitHub
blueorangutan commented on PR #7874: URL: https://github.com/apache/cloudstack/pull/7874#issuecomment-1693261931 @weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] weizhouapache commented on pull request #7874: systemvm: update size and state of systemvm template during registration

2023-08-25 Thread via GitHub
weizhouapache commented on PR #7874: URL: https://github.com/apache/cloudstack/pull/7874#issuecomment-1693260815 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [cloudstack] blueorangutan commented on pull request #6812: Normalize encryption on global configurations values

2023-08-25 Thread via GitHub
blueorangutan commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1693256434 Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6162 -- This is an auto

[GitHub] [cloudstack] weizhouapache closed issue #7840: UI bug: internal "refresh" of the UI can cause a wrong VM to be deleted

2023-08-25 Thread via GitHub
weizhouapache closed issue #7840: UI bug: internal "refresh" of the UI can cause a wrong VM to be deleted URL: https://github.com/apache/cloudstack/issues/7840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[cloudstack] branch 4.18 updated (6f7725ab353 -> 93bd5b7a692)

2023-08-25 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a change to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 6f7725ab353 ui: Fix refresh and re-route behaviour (#7846) add 93bd5b7a692 ui: speed up compute instance listi

[GitHub] [cloudstack] weizhouapache merged pull request #7911: ui: speed up compute instance listing

2023-08-25 Thread via GitHub
weizhouapache merged PR #7911: URL: https://github.com/apache/cloudstack/pull/7911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@c

[GitHub] [cloudstack] blueorangutan commented on pull request #7911: ui: speed up compute instance listing

2023-08-25 Thread via GitHub
blueorangutan commented on PR #7911: URL: https://github.com/apache/cloudstack/pull/7911#issuecomment-1693241891 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7911 (QA-JID-170) -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7911: ui: speed up compute instance listing

2023-08-25 Thread via GitHub
weizhouapache commented on code in PR #7911: URL: https://github.com/apache/cloudstack/pull/7911#discussion_r1305561778 ## ui/src/config/section/compute.js: ## @@ -32,9 +32,9 @@ export default { permission: ['listVirtualMachinesMetrics'], resourceType: 'UserVm',

[GitHub] [cloudstack] weizhouapache commented on pull request #7895: Flexible URI for connection with DB

2023-08-25 Thread via GitHub
weizhouapache commented on PR #7895: URL: https://github.com/apache/cloudstack/pull/7895#issuecomment-1693230781 > @JoaoJandre You can generate the uri by settings in db properties > > * driver > * replicas > * failover mode (new) > * url params > > what else are missin

[cloudstack] branch 4.18 updated: ui: Fix refresh and re-route behaviour (#7846)

2023-08-25 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.18 by this push: new 6f7725ab353 ui: Fix refresh and re-route behaviour

[GitHub] [cloudstack] DaanHoogland merged pull request #7846: ui: Fix refresh and re-route behaviour

2023-08-25 Thread via GitHub
DaanHoogland merged PR #7846: URL: https://github.com/apache/cloudstack/pull/7846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[GitHub] [cloudstack] DaanHoogland commented on pull request #7846: ui: Fix refresh and re-route behaviour

2023-08-25 Thread via GitHub
DaanHoogland commented on PR #7846: URL: https://github.com/apache/cloudstack/pull/7846#issuecomment-1693230097 ok, merging. @GutoVeronezi if you find anything please open a new issue on that? thanks -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [cloudstack] blueorangutan commented on pull request #7911: ui: speed up compute instance listing

2023-08-25 Thread via GitHub
blueorangutan commented on PR #7911: URL: https://github.com/apache/cloudstack/pull/7911#issuecomment-1693228892 @rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7911: ui: speed up compute instance listing

2023-08-25 Thread via GitHub
rohityadavcloud commented on PR #7911: URL: https://github.com/apache/cloudstack/pull/7911#issuecomment-1693228144 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7911: ui: speed up compute instance listing

2023-08-25 Thread via GitHub
rohityadavcloud commented on code in PR #7911: URL: https://github.com/apache/cloudstack/pull/7911#discussion_r1305552693 ## ui/src/config/section/compute.js: ## @@ -32,9 +32,9 @@ export default { permission: ['listVirtualMachinesMetrics'], resourceType: 'UserVm',

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7911: ui: speed up compute instance listing

2023-08-25 Thread via GitHub
rohityadavcloud commented on code in PR #7911: URL: https://github.com/apache/cloudstack/pull/7911#discussion_r1305544503 ## ui/src/views/AutogenView.vue: ## @@ -858,6 +858,10 @@ export default { delete params.showunique } + if (['listVirtualMachinesMetric

[GitHub] [cloudstack] codecov[bot] commented on pull request #7911: ui: speed up compute instance listing

2023-08-25 Thread via GitHub
codecov[bot] commented on PR #7911: URL: https://github.com/apache/cloudstack/pull/7911#issuecomment-1693219500 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7911?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7911: ui: speed up compute instance listing

2023-08-25 Thread via GitHub
rohityadavcloud commented on code in PR #7911: URL: https://github.com/apache/cloudstack/pull/7911#discussion_r1305544503 ## ui/src/views/AutogenView.vue: ## @@ -858,6 +858,10 @@ export default { delete params.showunique } + if (['listVirtualMachinesMetric

[GitHub] [cloudstack] weizhouapache closed pull request #7906: try different reverts to get main back on track

2023-08-25 Thread via GitHub
weizhouapache closed pull request #7906: try different reverts to get main back on track URL: https://github.com/apache/cloudstack/pull/7906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7911: ui: speed up compute instance listing

2023-08-25 Thread via GitHub
rohityadavcloud commented on code in PR #7911: URL: https://github.com/apache/cloudstack/pull/7911#discussion_r1305543548 ## ui/src/config/section/compute.js: ## @@ -32,9 +32,9 @@ export default { permission: ['listVirtualMachinesMetrics'], resourceType: 'UserVm',

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7911: ui: speed up compute instance listing

2023-08-25 Thread via GitHub
rohityadavcloud commented on code in PR #7911: URL: https://github.com/apache/cloudstack/pull/7911#discussion_r1305542663 ## ui/src/config/section/compute.js: ## @@ -32,9 +32,9 @@ export default { permission: ['listVirtualMachinesMetrics'], resourceType: 'UserVm',

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7911: ui: speed up compute instance listing

2023-08-25 Thread via GitHub
rohityadavcloud commented on code in PR #7911: URL: https://github.com/apache/cloudstack/pull/7911#discussion_r1305542372 ## ui/src/views/AutogenView.vue: ## @@ -858,6 +858,11 @@ export default { delete params.showunique } + if (['listVirtualMachinesMetric

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7912: utils: build both SHADED and original jars

2023-08-25 Thread via GitHub
rohityadavcloud commented on PR #7912: URL: https://github.com/apache/cloudstack/pull/7912#issuecomment-1693214193 Hi @weizhouapache thanks for the PR - can you explain, the advantage of this, for systemvms aren't we copying all dependency jars? -- This is an automated message from the Ap

[GitHub] [cloudstack] blueorangutan commented on pull request #6812: Normalize encryption on global configurations values

2023-08-25 Thread via GitHub
blueorangutan commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1693208808 @weizhouapache a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7911: ui: speed up compute instance listing

2023-08-25 Thread via GitHub
weizhouapache commented on code in PR #7911: URL: https://github.com/apache/cloudstack/pull/7911#discussion_r1305533586 ## ui/src/config/section/compute.js: ## @@ -32,9 +32,9 @@ export default { permission: ['listVirtualMachinesMetrics'], resourceType: 'UserVm',

[GitHub] [cloudstack] andrijapanicsb commented on pull request #7846: ui: Fix refresh and re-route behaviour

2023-08-25 Thread via GitHub
andrijapanicsb commented on PR #7846: URL: https://github.com/apache/cloudstack/pull/7846#issuecomment-1693193186 Wait for it... give me 1h -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [cloudstack] blueorangutan commented on pull request #6812: Normalize encryption on global configurations values

2023-08-25 Thread via GitHub
blueorangutan commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1693188152 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6894 -- This is an auto

[GitHub] [cloudstack] weizhouapache commented on pull request #7846: ui: Fix refresh and re-route behaviour

2023-08-25 Thread via GitHub
weizhouapache commented on PR #7846: URL: https://github.com/apache/cloudstack/pull/7846#issuecomment-1693170329 > I think this is no issue in this code. can we merge @weizhouapache @rohityadavcloud ? @DaanHoogland thanks for testing I am ok with merging . -- This is an auto

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7846: ui: Fix refresh and re-route behaviour

2023-08-25 Thread via GitHub
rohityadavcloud commented on PR #7846: URL: https://github.com/apache/cloudstack/pull/7846#issuecomment-1693165796 @DaanHoogland I've asked @andrijapanicsb to confirm testing, perhaps @GutoVeronezi was testing as well - appreciate all the QA, feedback we can get on this. Thanks. -- This

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7846: ui: Fix refresh and re-route behaviour

2023-08-25 Thread via GitHub
rohityadavcloud commented on PR #7846: URL: https://github.com/apache/cloudstack/pull/7846#issuecomment-1693164977 @DaanHoogland that could a notification regression or somehow things got opened in a new tab / refreshed, I've noticed that too (but not related to changes in autogenview)

[GitHub] [cloudstack] DaanHoogland commented on pull request #7846: ui: Fix refresh and re-route behaviour

2023-08-25 Thread via GitHub
DaanHoogland commented on PR #7846: URL: https://github.com/apache/cloudstack/pull/7846#issuecomment-1693163880 I think this is no issue in this code. can we merge @weizhouapache @rohityadavcloud ? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-25 Thread via GitHub
blueorangutan commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1693157345 @weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + xcpng82) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To resp

[GitHub] [cloudstack] weizhouapache commented on pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-25 Thread via GitHub
weizhouapache commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1693156823 @blueorangutan test centos7 xcpng82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [cloudstack] DaanHoogland commented on pull request #7846: ui: Fix refresh and re-route behaviour

2023-08-25 Thread via GitHub
DaanHoogland commented on PR #7846: URL: https://github.com/apache/cloudstack/pull/7846#issuecomment-1693156277 all seems fine but one strange thing I noticed is that an "Add VPC" notification remained "in progress" ![image](https://github.com/apache/cloudstack/assets/2486961/193847c8-97

[GitHub] [cloudstack] blueorangutan commented on pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-25 Thread via GitHub
blueorangutan commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1693153127 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6893 -- This is an auto

[GitHub] [cloudstack] blueorangutan commented on pull request #6812: Normalize encryption on global configurations values

2023-08-25 Thread via GitHub
blueorangutan commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1693128774 @weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

[GitHub] [cloudstack] weizhouapache commented on pull request #6812: Normalize encryption on global configurations values

2023-08-25 Thread via GitHub
weizhouapache commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1693128221 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19

2023-08-25 Thread via GitHub
blueorangutan commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1693113063 [SF] Trillian test result (tid-7547) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48855 seconds Marvin logs: https://github.com

[GitHub] [cloudstack] weizhouapache commented on pull request #7912: utils: build both SHADED and original jars

2023-08-25 Thread via GitHub
weizhouapache commented on PR #7912: URL: https://github.com/apache/cloudstack/pull/7912#issuecomment-1693104149 @blueorangutan test ubuntu22 kvm-ubuntu22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack] weizhouapache commented on pull request #7913: server: throw new exception when rootdisksize is required but not set

2023-08-25 Thread via GitHub
weizhouapache commented on PR #7913: URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1693103466 > @weizhouapache #7115 is this not a UI bug ? @harikrishna-patnala yes, we 'd better enforce user to input the rootdisksize (in the scenario) on UI I think the new e

[GitHub] [cloudstack] weizhouapache commented on pull request #7912: utils: build both SHADED and original jars

2023-08-25 Thread via GitHub
weizhouapache commented on PR #7912: URL: https://github.com/apache/cloudstack/pull/7912#issuecomment-1693100239 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cloudstack] weizhouapache commented on pull request #7877: server: try with all supported hypervisors (ordered, no duplications) when deploy a virtual router

2023-08-25 Thread via GitHub
weizhouapache commented on PR #7877: URL: https://github.com/apache/cloudstack/pull/7877#issuecomment-1693097833 > I verified with a VR as well, and in the end all start on the available host irrespective of hypervisor type. merging thanks @DaanHoogland ! -- This is an automated me

[GitHub] [cloudstack] weizhouapache closed issue #7433: Virtual Router fails to deploy with multi-hypervisor zone

2023-08-25 Thread via GitHub
weizhouapache closed issue #7433: Virtual Router fails to deploy with multi-hypervisor zone URL: https://github.com/apache/cloudstack/issues/7433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[cloudstack] branch 4.18 updated (8dc5fdd067d -> b19db10ea68)

2023-08-25 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 8dc5fdd067d server: fix cannot get systemvm ips in dedicated ranges (#7144) add b19db10ea68 server: try with all

[GitHub] [cloudstack] DaanHoogland merged pull request #7877: server: try with all supported hypervisors (ordered, no duplications) when deploy a virtual router

2023-08-25 Thread via GitHub
DaanHoogland merged PR #7877: URL: https://github.com/apache/cloudstack/pull/7877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[GitHub] [cloudstack] DaanHoogland commented on pull request #7877: server: try with all supported hypervisors (ordered, no duplications) when deploy a virtual router

2023-08-25 Thread via GitHub
DaanHoogland commented on PR #7877: URL: https://github.com/apache/cloudstack/pull/7877#issuecomment-1693094863 I verified with a VR as well, and in the end all start on the available host irrespective of hypervisor type. merging -- This is an automated message from the Apache Git Service

[GitHub] [cloudstack] weizhouapache commented on pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-25 Thread via GitHub
weizhouapache commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1693089989 > @DaanHoogland @shwstppr this PR breaks the smoke tests on xcpng82, but xenserver-71 works fine. I have no idea what caused it. I'd like to close this PR and suggest @shwstppr @

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7345: [HEALTH] 4.18 LTS Health Check, please don't merge this!

2023-08-25 Thread via GitHub
sonarcloud[bot] commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1693089865 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Q

[GitHub] [cloudstack] blueorangutan commented on pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-25 Thread via GitHub
blueorangutan commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1693085746 @weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

[GitHub] [cloudstack] weizhouapache commented on pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-25 Thread via GitHub
weizhouapache commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1693083158 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[cloudstack] branch 4.18 updated: server: fix cannot get systemvm ips in dedicated ranges (#7144)

2023-08-25 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.18 by this push: new 8dc5fdd067d server: fix cannot get systemvm ips

[GitHub] [cloudstack] weizhouapache merged pull request #7144: server: fix cannot get systemvm ips in dedicated ranges

2023-08-25 Thread via GitHub
weizhouapache merged PR #7144: URL: https://github.com/apache/cloudstack/pull/7144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@c

[GitHub] [cloudstack] weizhouapache commented on pull request #7144: server: fix cannot get systemvm ips in dedicated ranges

2023-08-25 Thread via GitHub
weizhouapache commented on PR #7144: URL: https://github.com/apache/cloudstack/pull/7144#issuecomment-1693074227 Thanks @DaanHoogland for verification merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[cloudstack] branch 4.18 updated: server: fix global setting system.vm.public.ip.reservation.mode.strictness is not really dynamic (#7909)

2023-08-25 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.18 by this push: new f5a1f4130d5 server: fix global setting system.

[GitHub] [cloudstack] weizhouapache merged pull request #7909: server: fix global setting system.vm.public.ip.reservation.mode.strictness is not really dynamic

2023-08-25 Thread via GitHub
weizhouapache merged PR #7909: URL: https://github.com/apache/cloudstack/pull/7909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@c

[GitHub] [cloudstack] weizhouapache commented on pull request #7909: server: fix global setting system.vm.public.ip.reservation.mode.strictness is not really dynamic

2023-08-25 Thread via GitHub
weizhouapache commented on PR #7909: URL: https://github.com/apache/cloudstack/pull/7909#issuecomment-1693072660 > @weizhouapache does it make sense to merge this change with #7144 ? @DaanHoogland it is already in :facepalm: I totally forgot it ... -- This is an automated me

[GitHub] [cloudstack] blueorangutan commented on pull request #7913: server: throw new exception when rootdisksize is required but not set

2023-08-25 Thread via GitHub
blueorangutan commented on PR #7913: URL: https://github.com/apache/cloudstack/pull/7913#issuecomment-1693062193 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6892 -- This is an auto

[GitHub] [cloudstack] DaanHoogland commented on pull request #7144: server: fix cannot get systemvm ips in dedicated ranges

2023-08-25 Thread via GitHub
DaanHoogland commented on PR #7144: URL: https://github.com/apache/cloudstack/pull/7144#issuecomment-1693044657 verified: after setting `system.vm.public.reservation.mode.strictness` to `true` and `use.system.public.ips` to `false` on 4.18.0 SVMs won't come up. After upgrading to this PR th

  1   2   >