[GitHub] [cloudstack] blueorangutan commented on pull request #8002: fix: cleanup directory if empty after removal of snapshot

2023-09-26 Thread via GitHub
blueorangutan commented on PR #8002: URL: https://github.com/apache/cloudstack/pull/8002#issuecomment-1736742945 [SF] Trillian test result (tid-7723) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 52298 seconds Marvin logs: https://github.com

[GitHub] [cloudstack] blueorangutan commented on pull request #7991: Fix style for LibvirtComputingResource variable names and its dependencies

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7991: URL: https://github.com/apache/cloudstack/pull/7991#issuecomment-1736679683 [SF] Trillian test result (tid-7721) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 52642 seconds Marvin logs: https://github.com

[GitHub] [cloudstack] blueorangutan commented on pull request #7979: LibvirtServerDiscoverer should only process added hosts relevant to hypervisor type

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7979: URL: https://github.com/apache/cloudstack/pull/7979#issuecomment-1736662684 [SF] Trillian test result (tid-7722) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 52373 seconds Marvin logs: https://github.com

[GitHub] [cloudstack] vishesh92 commented on a diff in pull request #8002: fix: cleanup directory if empty after removal of snapshot

2023-09-26 Thread via GitHub
vishesh92 commented on code in PR #8002: URL: https://github.com/apache/cloudstack/pull/8002#discussion_r1338029412 ## services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java: ## @@ -2050,6 +2050,13 @@ protected Ans

[GitHub] [cloudstack] blueorangutan commented on pull request #6812: Normalize encryption on global configurations values

2023-09-26 Thread via GitHub
blueorangutan commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1736633785 [SF] Trillian test result (tid-7715) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 74644 seconds Marvin logs: https://github.co

[GitHub] [cloudstack] blueorangutan commented on pull request #7858: Keep deleted projects name

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7858: URL: https://github.com/apache/cloudstack/pull/7858#issuecomment-1736578255 [SF] Trillian test result (tid-7718) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 69367 seconds Marvin logs: https://github.co

[GitHub] [cloudstack] blueorangutan commented on pull request #7987: KVM Agent config to reserve dom0 CPUs

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7987: URL: https://github.com/apache/cloudstack/pull/7987#issuecomment-1736530312 [SF] Trillian test result (tid-7720) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 56336 seconds Marvin logs: https://github.com

[GitHub] [cloudstack] blueorangutan commented on pull request #6812: Normalize encryption on global configurations values

2023-09-26 Thread via GitHub
blueorangutan commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1736407579 [SF] Trillian test result (tid-7716) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 56022 seconds Marvin logs: https://github.com

[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #8002: fix: cleanup directory if empty after removal of snapshot

2023-09-26 Thread via GitHub
harikrishna-patnala commented on code in PR #8002: URL: https://github.com/apache/cloudstack/pull/8002#discussion_r1337850036 ## services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java: ## @@ -2050,6 +2050,13 @@ pro

[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7984: removal of unused interface

2023-09-26 Thread via GitHub
harikrishna-patnala commented on PR #7984: URL: https://github.com/apache/cloudstack/pull/7984#issuecomment-1736392605 > > I see no usages for DirectoryService also in the same directory. can we delete that as well. > > no, `org.apache.directory.server.core.api.DirectoryService` is us

[GitHub] [cloudstack] blueorangutan commented on pull request #7949: WIP - Storage mgmt

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7949: URL: https://github.com/apache/cloudstack/pull/7949#issuecomment-1736357453 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7117 -- This is an auto

[GitHub] [cloudstack] blueorangutan commented on pull request #6812: Normalize encryption on global configurations values

2023-09-26 Thread via GitHub
blueorangutan commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1736349723 [SF] Trillian test result (tid-7714) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 52619 seconds Marvin logs: https://github.co

[GitHub] [cloudstack] hsato03 commented on a diff in pull request #7974: Fix templates and ISOs listing pagination

2023-09-26 Thread via GitHub
hsato03 commented on code in PR #7974: URL: https://github.com/apache/cloudstack/pull/7974#discussion_r1337812593 ## server/src/main/java/com/cloud/api/query/QueryManagerImpl.java: ## @@ -3782,11 +3781,62 @@ else if (!template.isPublicTemplate() && caller.getType() != Account.T

[GitHub] [cloudstack] hsato03 commented on pull request #7868: Removed state for removed accounts

2023-09-26 Thread via GitHub
hsato03 commented on PR #7868: URL: https://github.com/apache/cloudstack/pull/7868#issuecomment-1736336948 Hi @soreana, Any updates on this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [cloudstack] hsato03 commented on pull request #7859: server: set Default NIC when VM has no default NIC

2023-09-26 Thread via GitHub
hsato03 commented on PR #7859: URL: https://github.com/apache/cloudstack/pull/7859#issuecomment-1736312854 Hello, @DaanHoogland. Could you reproduce the tests? Let me know your opinion about the discussion I proposed. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [cloudstack] blueorangutan commented on pull request #7949: WIP - Storage mgmt

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7949: URL: https://github.com/apache/cloudstack/pull/7949#issuecomment-1736299950 @vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] vishesh92 commented on pull request #7949: WIP - Storage mgmt

2023-09-26 Thread via GitHub
vishesh92 commented on PR #7949: URL: https://github.com/apache/cloudstack/pull/7949#issuecomment-1736298974 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [cloudstack] blueorangutan commented on pull request #7858: Keep deleted projects name

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7858: URL: https://github.com/apache/cloudstack/pull/7858#issuecomment-1736262947 [SF] Trillian test result (tid-7719) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48098 seconds Marvin logs: https://github.com

[GitHub] [cloudstack] blueorangutan commented on pull request #7949: WIP - Storage mgmt

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7949: URL: https://github.com/apache/cloudstack/pull/7949#issuecomment-1736257120 Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-

[GitHub] [cloudstack] blueorangutan commented on pull request #7949: WIP - Storage mgmt

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7949: URL: https://github.com/apache/cloudstack/pull/7949#issuecomment-1736240024 @vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] vishesh92 commented on pull request #7949: WIP - Storage mgmt

2023-09-26 Thread via GitHub
vishesh92 commented on PR #7949: URL: https://github.com/apache/cloudstack/pull/7949#issuecomment-1736237401 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [cloudstack] blueorangutan commented on pull request #7949: WIP - Storage mgmt

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7949: URL: https://github.com/apache/cloudstack/pull/7949#issuecomment-1736224249 Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-

[GitHub] [cloudstack] blueorangutan commented on pull request #7919: NSX integration

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7919: URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1736224246 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7114 -- This is an auto

[GitHub] [cloudstack] blueorangutan commented on pull request #7949: WIP - Storage mgmt

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7949: URL: https://github.com/apache/cloudstack/pull/7949#issuecomment-1736200906 @vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] vishesh92 commented on pull request #7949: WIP - Storage mgmt

2023-09-26 Thread via GitHub
vishesh92 commented on PR #7949: URL: https://github.com/apache/cloudstack/pull/7949#issuecomment-1736198614 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [cloudstack] blueorangutan commented on pull request #7919: NSX integration

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7919: URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1736143955 @Pearl1594 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] Pearl1594 commented on pull request #7919: NSX integration

2023-09-26 Thread via GitHub
Pearl1594 commented on PR #7919: URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1736141768 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[cloudstack] branch nsx-integration updated (3132bfdffae -> c65076bd622)

2023-09-26 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch nsx-integration in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 3132bfdffae update offering add c65076bd622 update offering No new revisions were added by this

[GitHub] [cloudstack] JoaoJandre commented on a diff in pull request #7938: Add Service Offering to listSystemVMs and fix link from VR to its offering

2023-09-26 Thread via GitHub
JoaoJandre commented on code in PR #7938: URL: https://github.com/apache/cloudstack/pull/7938#discussion_r1337647860 ## api/src/main/java/org/apache/cloudstack/api/response/SystemVmResponse.java: ## @@ -178,6 +178,14 @@ public class SystemVmResponse extends BaseResponseWithAnno

[GitHub] [cloudstack] blueorangutan commented on pull request #7858: Keep deleted projects name

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7858: URL: https://github.com/apache/cloudstack/pull/7858#issuecomment-1736009594 [SF] Trillian test result (tid-7717) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38058 seconds Marvin logs: https://github.co

[GitHub] [cloudstack] codecov[bot] commented on pull request #8007: Added JoaoJandre to .asf.yaml

2023-09-26 Thread via GitHub
codecov[bot] commented on PR #8007: URL: https://github.com/apache/cloudstack/pull/8007#issuecomment-1735999665 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8007?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

[cloudstack] branch main updated (d58d60cd6ce -> 5da176a7b31)

2023-09-26 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from d58d60cd6ce Add GaOrtiga to .asf.yaml as collaborator (#8005) add 5da176a7b31 Add SadiJr to .asf.yaml as colla

[GitHub] [cloudstack] weizhouapache merged pull request #8006: Added SadiJr to .asf.yaml collaborators

2023-09-26 Thread via GitHub
weizhouapache merged PR #8006: URL: https://github.com/apache/cloudstack/pull/8006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@c

[GitHub] [cloudstack] weizhouapache commented on pull request #7982: VR: remove apache2 config for removed VPC tiers

2023-09-26 Thread via GitHub
weizhouapache commented on PR #7982: URL: https://github.com/apache/cloudstack/pull/7982#issuecomment-1735955306 > LGTM, Tested the issue manually for both default vpc and redundant vpc offering > > Followed the steps, and only the config files for the active tiers are present >

[GitHub] [cloudstack] JoaoJandre opened a new pull request, #8007: Added JoaoJandre to .asf.yaml

2023-09-26 Thread via GitHub
JoaoJandre opened a new pull request, #8007: URL: https://github.com/apache/cloudstack/pull/8007 ### Description Added myself (`JoaoJandre`) as a collaborator to be able to report issue with tags, and be assigned to issues and PRs. ### Types of changes - [ ] Breaking cha

[GitHub] [cloudstack] SadiJr opened a new pull request, #8006: Added SadiJr to .asf.yaml collaborators

2023-09-26 Thread via GitHub
SadiJr opened a new pull request, #8006: URL: https://github.com/apache/cloudstack/pull/8006 ### Description Added myself (`SadiJr`) as a collaborator in `.asf.yaml` to be able to report issue with tags, and be assigned to issues and PRs. ### Types of changes - [ ] Break

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7990: registry of message busses

2023-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #7990: URL: https://github.com/apache/cloudstack/pull/7990#issuecomment-1735755210 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] blueorangutan commented on pull request #7990: registry of message busses

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7990: URL: https://github.com/apache/cloudstack/pull/7990#issuecomment-1735732852 Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6186 -- This is an auto

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7919: NSX integration

2023-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #7919: URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1735715168 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] blueorangutan commented on pull request #8004: Fix the poll for the API ReadyForShutdown even after logout

2023-09-26 Thread via GitHub
blueorangutan commented on PR #8004: URL: https://github.com/apache/cloudstack/pull/8004#issuecomment-1735713056 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7113 -- This is an auto

[GitHub] [cloudstack] blueorangutan commented on pull request #8002: fix: cleanup directory if empty after removal of snapshot

2023-09-26 Thread via GitHub
blueorangutan commented on PR #8002: URL: https://github.com/apache/cloudstack/pull/8002#issuecomment-1735711140 @vishesh92 a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To resp

[GitHub] [cloudstack] vishesh92 commented on pull request #8002: fix: cleanup directory if empty after removal of snapshot

2023-09-26 Thread via GitHub
vishesh92 commented on PR #8002: URL: https://github.com/apache/cloudstack/pull/8002#issuecomment-1735708145 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [cloudstack] blueorangutan commented on pull request #7919: NSX integration

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7919: URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1735695657 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7112 -- This is an auto

[GitHub] [cloudstack] blueorangutan commented on pull request #8002: fix: cleanup directory if empty after removal of snapshot

2023-09-26 Thread via GitHub
blueorangutan commented on PR #8002: URL: https://github.com/apache/cloudstack/pull/8002#issuecomment-1735692205 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7110 -- This is an auto

[GitHub] [cloudstack] blueorangutan commented on pull request #7963: Trigger out of band VM state update via libvirt event when VM stops

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7963: URL: https://github.com/apache/cloudstack/pull/7963#issuecomment-1735659269 Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6185 -- This is an auto

[cloudstack] 05/08: publish to list

2023-09-26 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 6778-if-kafka-is-turned-on-internal-subs-dont-work in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 9673099d042f3b29fd1519eba9b6f28d8e61b637 Author: Daan Hoogland AuthorDate

[cloudstack] 06/08: cleanup

2023-09-26 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 6778-if-kafka-is-turned-on-internal-subs-dont-work in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 8942f9ddeb39f1ded9426f1c08c5d9877853ad66 Author: Daan Hoogland AuthorDate

[cloudstack] branch 6778-if-kafka-is-turned-on-internal-subs-dont-work updated (a265f48deb5 -> ebc78e30cf5)

2023-09-26 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 6778-if-kafka-is-turned-on-internal-subs-dont-work in repository https://gitbox.apache.org/repos/asf/cloudstack.git omit a265f48deb5 bean-def omit 29208135620 events via the distributor

[cloudstack] 04/08: spring-reg

2023-09-26 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 6778-if-kafka-is-turned-on-internal-subs-dont-work in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit e18bbfd6ad7e9cc33232e585f5c5c460e23960d4 Author: Daan Hoogland AuthorDate

[cloudstack] 03/08: extra logging

2023-09-26 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 6778-if-kafka-is-turned-on-internal-subs-dont-work in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 167c91f997ad14e82d3716451e210c3d122021c1 Author: Daan Hoogland AuthorDate

[cloudstack] 07/08: events via the distributor

2023-09-26 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 6778-if-kafka-is-turned-on-internal-subs-dont-work in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 9b78fe8ecf0db14ec2c2359a18ff26ffe3dee045 Author: Daan Hoogland AuthorDate

[cloudstack] 01/08: registry of message busses

2023-09-26 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 6778-if-kafka-is-turned-on-internal-subs-dont-work in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit da668f3d7c3e7a1a7ed2635fb40c1b42aede018e Author: Daan Hoogland AuthorDate

[cloudstack] 08/08: bean-def

2023-09-26 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 6778-if-kafka-is-turned-on-internal-subs-dont-work in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit ebc78e30cf566196d22a8ce61bdb9229ccafc5d1 Author: Daan Hoogland AuthorDate

[cloudstack] 02/08: rats

2023-09-26 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 6778-if-kafka-is-turned-on-internal-subs-dont-work in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 3c399f6c34311731a45325ffb5b7df001f425755 Author: dahn AuthorDate: Thu Sep

[GitHub] [cloudstack] blueorangutan commented on pull request #8004: Fix the poll for the API ReadyForShutdown even after logout

2023-09-26 Thread via GitHub
blueorangutan commented on PR #8004: URL: https://github.com/apache/cloudstack/pull/8004#issuecomment-1735591221 @DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

[GitHub] [cloudstack] DaanHoogland commented on pull request #8004: Fix the poll for the API ReadyForShutdown even after logout

2023-09-26 Thread via GitHub
DaanHoogland commented on PR #8004: URL: https://github.com/apache/cloudstack/pull/8004#issuecomment-1735590295 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[cloudstack] branch main updated (d73cfbd6b76 -> d58d60cd6ce)

2023-09-26 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from d73cfbd6b76 add BryanMLima as a collaborator (#8003) add d58d60cd6ce Add GaOrtiga to .asf.yaml as collaborator (#

[GitHub] [cloudstack] DaanHoogland merged pull request #8005: Added GaOrtiga to .asf.yaml collaborators

2023-09-26 Thread via GitHub
DaanHoogland merged PR #8005: URL: https://github.com/apache/cloudstack/pull/8005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[cloudstack] branch main updated: add BryanMLima as a collaborator (#8003)

2023-09-26 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new d73cfbd6b76 add BryanMLima as a collaborator (#800

[GitHub] [cloudstack] DaanHoogland merged pull request #8003: Added BryanMLima to .asf.yaml

2023-09-26 Thread via GitHub
DaanHoogland merged PR #8003: URL: https://github.com/apache/cloudstack/pull/8003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[GitHub] [cloudstack] DaanHoogland commented on pull request #7984: removal of unused interface

2023-09-26 Thread via GitHub
DaanHoogland commented on PR #7984: URL: https://github.com/apache/cloudstack/pull/7984#issuecomment-1735577182 > I see no usages for DirectoryService also in the same directory. can we delete that as well. no, `org.apache.directory.server.core.api.DirectoryService` is used (in test

[GitHub] [cloudstack] blueorangutan commented on pull request #7979: LibvirtServerDiscoverer should only process added hosts relevant to hypervisor type

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7979: URL: https://github.com/apache/cloudstack/pull/7979#issuecomment-1735569822 @DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] blueorangutan commented on pull request #7991: Fix style for LibvirtComputingResource variable names and its dependencies

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7991: URL: https://github.com/apache/cloudstack/pull/7991#issuecomment-1735569694 @DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] blueorangutan commented on pull request #7919: NSX integration

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7919: URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1735569757 @Pearl1594 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[cloudstack] branch 6778-if-kafka-is-turned-on-internal-subs-dont-work updated (29208135620 -> a265f48deb5)

2023-09-26 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 6778-if-kafka-is-turned-on-internal-subs-dont-work in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 29208135620 events via the distributor add a265f48deb5 bean-def N

[GitHub] [cloudstack] DaanHoogland commented on pull request #7991: Fix style for LibvirtComputingResource variable names and its dependencies

2023-09-26 Thread via GitHub
DaanHoogland commented on PR #7991: URL: https://github.com/apache/cloudstack/pull/7991#issuecomment-1735567161 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [cloudstack] Pearl1594 commented on pull request #7919: NSX integration

2023-09-26 Thread via GitHub
Pearl1594 commented on PR #7919: URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1735566203 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [cloudstack] DaanHoogland commented on pull request #7979: LibvirtServerDiscoverer should only process added hosts relevant to hypervisor type

2023-09-26 Thread via GitHub
DaanHoogland commented on PR #7979: URL: https://github.com/apache/cloudstack/pull/7979#issuecomment-1735565509 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[cloudstack] branch nsx-integration updated (0f65118039d -> 3132bfdffae)

2023-09-26 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch nsx-integration in repository https://gitbox.apache.org/repos/asf/cloudstack.git omit 0f65118039d update offering add 3132bfdffae update offering This update added new revisions aft

[GitHub] [cloudstack] blueorangutan commented on pull request #7919: NSX integration

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7919: URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1735558877 @Pearl1594 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] blueorangutan commented on pull request #8002: fix: cleanup directory if empty after removal of snapshot

2023-09-26 Thread via GitHub
blueorangutan commented on PR #8002: URL: https://github.com/apache/cloudstack/pull/8002#issuecomment-1735558822 @vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] vishesh92 commented on pull request #8002: fix: cleanup directory if empty after removal of snapshot

2023-09-26 Thread via GitHub
vishesh92 commented on PR #8002: URL: https://github.com/apache/cloudstack/pull/8002#issuecomment-1735558156 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [cloudstack] Pearl1594 commented on pull request #7919: NSX integration

2023-09-26 Thread via GitHub
Pearl1594 commented on PR #7919: URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-173645 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[cloudstack] branch nsx-integration updated (33a29dce036 -> 0f65118039d)

2023-09-26 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch nsx-integration in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 33a29dce036 add route advertisement add 0f65118039d update offering No new revisions were added

[cloudstack] branch 4.18 updated: VR: remove apache2 config for removed VPC tiers (#7982)

2023-09-26 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.18 by this push: new 10d7e6cf6ff VR: remove apache2 config for removed

[GitHub] [cloudstack] DaanHoogland merged pull request #7982: VR: remove apache2 config for removed VPC tiers

2023-09-26 Thread via GitHub
DaanHoogland merged PR #7982: URL: https://github.com/apache/cloudstack/pull/7982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[GitHub] [cloudstack] blueorangutan commented on pull request #8002: fix: cleanup directory if empty after removal of snapshot

2023-09-26 Thread via GitHub
blueorangutan commented on PR #8002: URL: https://github.com/apache/cloudstack/pull/8002#issuecomment-1735520527 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7109 -- This is an auto

[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #8002: fix: cleanup directory if empty after removal of snapshot

2023-09-26 Thread via GitHub
GutoVeronezi commented on code in PR #8002: URL: https://github.com/apache/cloudstack/pull/8002#discussion_r1337171922 ## services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java: ## @@ -2050,6 +2050,14 @@ protected

[GitHub] [cloudstack] codecov[bot] commented on pull request #8004: Fix the poll for the API ReadyForShutdown even after logout

2023-09-26 Thread via GitHub
codecov[bot] commented on PR #8004: URL: https://github.com/apache/cloudstack/pull/8004#issuecomment-1735470069 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8004?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

[GitHub] [cloudstack] GaOrtiga opened a new pull request, #8005: Added GaOrtiga to .asf.yaml collaborators

2023-09-26 Thread via GitHub
GaOrtiga opened a new pull request, #8005: URL: https://github.com/apache/cloudstack/pull/8005 ### Description Added GaOrtiga(me) as a collaborator in `.asf.yaml` ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change

[GitHub] [cloudstack] harikrishna-patnala opened a new pull request, #8004: Fix the poll for the API ReadyForShutdown even after logout

2023-09-26 Thread via GitHub
harikrishna-patnala opened a new pull request, #8004: URL: https://github.com/apache/cloudstack/pull/8004 ### Description This PR fixes the issue of continuous poll of ReadyForShutdown API even after logout. This poll is causing issues after logout with unnecessary login error me

[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #8002: fix: cleanup directory if empty after removal of snapshot

2023-09-26 Thread via GitHub
GutoVeronezi commented on code in PR #8002: URL: https://github.com/apache/cloudstack/pull/8002#discussion_r1337129420 ## services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java: ## @@ -2050,6 +2050,15 @@ protected

[GitHub] [cloudstack] blueorangutan commented on pull request #8002: fix: cleanup directory if empty after removal of snapshot

2023-09-26 Thread via GitHub
blueorangutan commented on PR #8002: URL: https://github.com/apache/cloudstack/pull/8002#issuecomment-1735430760 @vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] vishesh92 commented on pull request #8002: fix: cleanup directory if empty after removal of snapshot

2023-09-26 Thread via GitHub
vishesh92 commented on PR #8002: URL: https://github.com/apache/cloudstack/pull/8002#issuecomment-1735429812 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [cloudstack] blueorangutan commented on pull request #7990: registry of message busses

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7990: URL: https://github.com/apache/cloudstack/pull/7990#issuecomment-1735419614 Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6184 -- This is an auto

[GitHub] [cloudstack] BryanMLima opened a new pull request, #8003: Added collaborator to .asf.yaml

2023-09-26 Thread via GitHub
BryanMLima opened a new pull request, #8003: URL: https://github.com/apache/cloudstack/pull/8003 ### Description Added myself as a collaborator to be able to report issue with tags, and be assigned to issues and PRs. ### Types of changes - [ ] Breaking change (fix or fea

[GitHub] [cloudstack] weizhouapache commented on pull request #7989: Improve the description of config password.policy.minimum.digits

2023-09-26 Thread via GitHub
weizhouapache commented on PR #7989: URL: https://github.com/apache/cloudstack/pull/7989#issuecomment-1735378955 code lgtm @winterhazel could you like to improve description of special characters as well ? -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [cloudstack] GutoVeronezi commented on pull request #7972: Fix 2FA becoming enabled when the user inputs the wrong code during setup

2023-09-26 Thread via GitHub
GutoVeronezi commented on PR #7972: URL: https://github.com/apache/cloudstack/pull/7972#issuecomment-1735357534 Thanks for the fix, @winterhazel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[cloudstack] branch contributers deleted (was 3e196c18245)

2023-09-26 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch contributers in repository https://gitbox.apache.org/repos/asf/cloudstack.git was 3e196c18245 style The revisions that were on this branch are still contained in other references; therefore,

[cloudstack] branch main updated: contributor-howto (#7995)

2023-09-26 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new b34da2658fc contributor-howto (#7995) b34da2658fc

[GitHub] [cloudstack] DaanHoogland merged pull request #7995: contributor-howto

2023-09-26 Thread via GitHub
DaanHoogland merged PR #7995: URL: https://github.com/apache/cloudstack/pull/7995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[cloudstack] branch main updated: Remove powermock from pom.xml (#8000)

2023-09-26 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 84e770bf958 Remove powermock from pom.xml (#8000)

[GitHub] [cloudstack] DaanHoogland merged pull request #8000: Remove powermock from pom.xml

2023-09-26 Thread via GitHub
DaanHoogland merged PR #8000: URL: https://github.com/apache/cloudstack/pull/8000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[GitHub] [cloudstack] DaanHoogland commented on pull request #8000: Remove powermock from pom.xml

2023-09-26 Thread via GitHub
DaanHoogland commented on PR #8000: URL: https://github.com/apache/cloudstack/pull/8000#issuecomment-1735351449 just test and pom changes => merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack] weizhouapache commented on pull request #7985: ui: allow copying password from notification

2023-09-26 Thread via GitHub
weizhouapache commented on PR #7985: URL: https://github.com/apache/cloudstack/pull/7985#issuecomment-1735350910 code lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [cloudstack] blueorangutan commented on pull request #7985: ui: allow copying password from notification

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7985: URL: https://github.com/apache/cloudstack/pull/7985#issuecomment-1735345437 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7107 -- This is an auto

[GitHub] [cloudstack] blueorangutan commented on pull request #7979: LibvirtServerDiscoverer should only process added hosts relevant to hypervisor type

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7979: URL: https://github.com/apache/cloudstack/pull/7979#issuecomment-1735345432 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7105 -- This is an auto

[GitHub] [cloudstack] blueorangutan commented on pull request #7989: Improve the description of config password.policy.minimum.digits

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7989: URL: https://github.com/apache/cloudstack/pull/7989#issuecomment-1735345434 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7108 -- This is an auto

[GitHub] [cloudstack] blueorangutan commented on pull request #7991: Fix style for LibvirtComputingResource variable names and its dependencies

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7991: URL: https://github.com/apache/cloudstack/pull/7991#issuecomment-1735345435 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7106 -- This is an auto

[GitHub] [cloudstack] blueorangutan commented on pull request #7963: Trigger out of band VM state update via libvirt event when VM stops

2023-09-26 Thread via GitHub
blueorangutan commented on PR #7963: URL: https://github.com/apache/cloudstack/pull/7963#issuecomment-1735343040 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7104 -- This is an auto

  1   2   >