Re: [PR] vm-import: fix stopped managed vms listing in unmanaged instances [cloudstack]

2023-10-09 Thread via GitHub
shwstppr commented on PR #7606: URL: https://github.com/apache/cloudstack/pull/7606#issuecomment-1754535891 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Snapshot removal and storage cleanup logs [cloudstack]

2023-10-09 Thread via GitHub
DaanHoogland commented on code in PR #8031: URL: https://github.com/apache/cloudstack/pull/8031#discussion_r1351627754 ## server/src/main/java/com/cloud/storage/StorageManagerImpl.java: ## @@ -1456,7 +1471,7 @@ public void cleanupStorage(boolean recurring) {

Re: [PR] Snapshot removal and storage cleanup logs [cloudstack]

2023-10-09 Thread via GitHub
DaanHoogland commented on code in PR #8031: URL: https://github.com/apache/cloudstack/pull/8031#discussion_r1351625216 ## server/src/main/java/com/cloud/storage/StorageManagerImpl.java: ## @@ -1397,17 +1412,17 @@ public void cleanupStorage(boolean recurring) {

Re: [PR] Snapshot removal and storage cleanup logs [cloudstack]

2023-10-09 Thread via GitHub
DaanHoogland commented on code in PR #8031: URL: https://github.com/apache/cloudstack/pull/8031#discussion_r1351623632 ## server/src/main/java/com/cloud/storage/StorageManagerImpl.java: ## @@ -1369,7 +1384,7 @@ public void cleanupStorage(boolean recurring) {

Re: [PR] Snapshot removal and storage cleanup logs [cloudstack]

2023-10-09 Thread via GitHub
DaanHoogland commented on code in PR #8031: URL: https://github.com/apache/cloudstack/pull/8031#discussion_r1351615410 ## engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/SnapshotServiceImpl.java: ## @@ -418,15 +418,13 @@ public boolean deleteSnapshot

Re: [PR] Quota tariff events [cloudstack]

2023-10-09 Thread via GitHub
vishesh92 commented on code in PR #8030: URL: https://github.com/apache/cloudstack/pull/8030#discussion_r1351622203 ## plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaTariffCreateCmd.java: ## @@ -70,6 +71,7 @@ public class QuotaTariffCreateCmd extends

Re: [PR] Snapshot removal and storage cleanup logs [cloudstack]

2023-10-09 Thread via GitHub
DaanHoogland commented on code in PR #8031: URL: https://github.com/apache/cloudstack/pull/8031#discussion_r1351619558 ## server/src/main/java/com/cloud/storage/StorageManagerImpl.java: ## @@ -1343,7 +1358,7 @@ public void cleanupStorage(boolean recurring) {

Re: [PR] Snapshot removal and storage cleanup logs [cloudstack]

2023-10-09 Thread via GitHub
DaanHoogland commented on code in PR #8031: URL: https://github.com/apache/cloudstack/pull/8031#discussion_r1351616477 ## server/src/main/java/com/cloud/storage/StorageManagerImpl.java: ## @@ -1289,37 +1289,52 @@ public void cleanupStorage(boolean recurring) {

Re: [PR] Snapshot removal and storage cleanup logs [cloudstack]

2023-10-09 Thread via GitHub
DaanHoogland commented on code in PR #8031: URL: https://github.com/apache/cloudstack/pull/8031#discussion_r1351619558 ## server/src/main/java/com/cloud/storage/StorageManagerImpl.java: ## @@ -1343,7 +1358,7 @@ public void cleanupStorage(boolean recurring) {

Re: [PR] Snapshot removal and storage cleanup logs [cloudstack]

2023-10-09 Thread via GitHub
DaanHoogland commented on code in PR #8031: URL: https://github.com/apache/cloudstack/pull/8031#discussion_r1351618298 ## server/src/main/java/com/cloud/storage/StorageManagerImpl.java: ## @@ -1289,37 +1289,52 @@ public void cleanupStorage(boolean recurring) {

Re: [PR] Snapshot removal and storage cleanup logs [cloudstack]

2023-10-09 Thread via GitHub
DaanHoogland commented on code in PR #8031: URL: https://github.com/apache/cloudstack/pull/8031#discussion_r1351616477 ## server/src/main/java/com/cloud/storage/StorageManagerImpl.java: ## @@ -1289,37 +1289,52 @@ public void cleanupStorage(boolean recurring) {

Re: [PR] Snapshot removal and storage cleanup logs [cloudstack]

2023-10-09 Thread via GitHub
DaanHoogland commented on code in PR #8031: URL: https://github.com/apache/cloudstack/pull/8031#discussion_r1351615410 ## engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/SnapshotServiceImpl.java: ## @@ -418,15 +418,13 @@ public boolean deleteSnapshot

Re: [PR] Snapshot removal and storage cleanup logs [cloudstack]

2023-10-09 Thread via GitHub
DaanHoogland commented on code in PR #8031: URL: https://github.com/apache/cloudstack/pull/8031#discussion_r1351614400 ## engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/SnapshotServiceImpl.java: ## @@ -373,7 +373,7 @@ protected Void deleteSnapshotC

Re: [PR] Update requirements file and fix minimum pre-commit version [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7901: URL: https://github.com/apache/cloudstack/pull/7901#issuecomment-1754492151 @DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

[cloudstack] branch main updated (66e5d41a15f -> e0ab2a4bd4a)

2023-10-09 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 66e5d41a15f ui: Fix sorter across different components (#8046) add e0ab2a4bd4a Enable four more `flake8` rules (#

[cloudstack] branch main updated: pre-commit: add hook `check-merge-conflict` (#7883)

2023-10-09 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 7e998f92283 pre-commit: add hook `check-merge-conf

Re: [PR] pre-commit: add hook `check-merge-conflict` [cloudstack]

2023-10-09 Thread via GitHub
DaanHoogland merged PR #7883: URL: https://github.com/apache/cloudstack/pull/7883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

Re: [PR] Enable four more `flake8` rules [cloudstack]

2023-10-09 Thread via GitHub
DaanHoogland merged PR #7811: URL: https://github.com/apache/cloudstack/pull/7811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

Re: [PR] Update requirements file and fix minimum pre-commit version [cloudstack]

2023-10-09 Thread via GitHub
DaanHoogland commented on PR #7901: URL: https://github.com/apache/cloudstack/pull/7901#issuecomment-1754490263 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Quota tariff events [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #8030: URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1754490214 @DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] Quota tariff events [cloudstack]

2023-10-09 Thread via GitHub
DaanHoogland commented on PR #8030: URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1754489266 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Quota tariff events [cloudstack]

2023-10-09 Thread via GitHub
DaanHoogland commented on code in PR #8030: URL: https://github.com/apache/cloudstack/pull/8030#discussion_r1351608713 ## plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaTariffCreateCmd.java: ## @@ -70,6 +71,7 @@ public class QuotaTariffCreateCmd exte

Re: [PR] Fix templates and ISOs listing pagination [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7974: URL: https://github.com/apache/cloudstack/pull/7974#issuecomment-1754482493 @DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

Re: [PR] Fix templates and ISOs listing pagination [cloudstack]

2023-10-09 Thread via GitHub
DaanHoogland commented on PR #7974: URL: https://github.com/apache/cloudstack/pull/7974#issuecomment-1754481733 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] api,server,ui: snapshot copy, multi-zone replica [cloudstack]

2023-10-09 Thread via GitHub
shwstppr commented on PR #7873: URL: https://github.com/apache/cloudstack/pull/7873#issuecomment-1754452768 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] api,server,ui: snapshot copy, multi-zone replica [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7873: URL: https://github.com/apache/cloudstack/pull/7873#issuecomment-1754457260 @shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]

2023-10-09 Thread via GitHub
github-actions[bot] commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1754445108 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

Re: [PR] misc: fix spelling [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7549: URL: https://github.com/apache/cloudstack/pull/7549#issuecomment-1754431342 [LL]Trillian test result (tid-6800) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43127 seconds Marvin logs: https://github.com

Re: [PR] UI: Fix sorter across different components [cloudstack]

2023-10-09 Thread via GitHub
rohityadavcloud commented on PR #8046: URL: https://github.com/apache/cloudstack/pull/8046#issuecomment-175443 Tested a few views - VM, volumes, ip address and templates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[cloudstack] branch main updated: ui: Fix sorter across different components (#8046)

2023-10-09 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 66e5d41a15f ui: Fix sorter across different compo

Re: [PR] UI: Fix sorter across different components [cloudstack]

2023-10-09 Thread via GitHub
rohityadavcloud merged PR #8046: URL: https://github.com/apache/cloudstack/pull/8046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] [Draft] KVM Ingestion - Import Instance [cloudstack]

2023-10-09 Thread via GitHub
kiranchavala commented on PR #7976: URL: https://github.com/apache/cloudstack/pull/7976#issuecomment-1754421084 @kishankavala can you fix the packaging issue, getting the following exception ``` 21:05:08 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compile

Re: [I] KVM volume snapshots are not full snapshots anymore [cloudstack]

2023-10-09 Thread via GitHub
rohityadavcloud commented on issue #8034: URL: https://github.com/apache/cloudstack/issues/8034#issuecomment-1754420344 Excellent, thanks @GutoVeronezi @weizhouapache @shwstppr @andrijapanicsb for moving this forward. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1754419616 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7290 -- This is an auto

Re: [I] [Enhancement]change the return type from null to empty object in [FakeDhcpSnooper.java] [cloudstack]

2023-10-09 Thread via GitHub
weizhouapache closed issue #7646: [Enhancement]change the return type from null to empty object in [FakeDhcpSnooper.java] URL: https://github.com/apache/cloudstack/issues/7646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[cloudstack] branch main updated (c3aeba1f4a4 -> b58ffec4cd2)

2023-10-09 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from c3aeba1f4a4 Merge remote-tracking branch 'origin/4.18' add b58ffec4cd2 [cleanup] Deleted file FakeDhcpSnooper.

Re: [PR] [cleanup] Deleted file FakeDhcpSnooper.java and DhcpSnooper.java [cloudstack]

2023-10-09 Thread via GitHub
weizhouapache merged PR #7672: URL: https://github.com/apache/cloudstack/pull/7672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@c

Re: [PR] misc: fix spelling [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7549: URL: https://github.com/apache/cloudstack/pull/7549#issuecomment-1754368883 [LL]Trillian test result (tid-6802) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39966 seconds Marvin logs: https://github.com/

Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1754357109 @shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]

2023-10-09 Thread via GitHub
shwstppr commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1754356594 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Add option to define password during password reset [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #6863: URL: https://github.com/apache/cloudstack/pull/6863#issuecomment-1754355921 [SF] Trillian test result (tid-7890) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46544 seconds Marvin logs: https://github.com

Re: [PR] Use UserVmDao for listVirtualMachines API to increase performance [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #8012: URL: https://github.com/apache/cloudstack/pull/8012#issuecomment-1754355280 @shwstppr a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respo

Re: [PR] Use UserVmDao for listVirtualMachines API to increase performance [cloudstack]

2023-10-09 Thread via GitHub
shwstppr commented on PR #8012: URL: https://github.com/apache/cloudstack/pull/8012#issuecomment-1754354877 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Update pom.xml reflections version [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #8019: URL: https://github.com/apache/cloudstack/pull/8019#issuecomment-1754167160 [LL]Trillian test result (tid-6797) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 52420 seconds Marvin logs: https://github.com

Re: [PR] [HEALTH] 4.19/main Health Check, please don't merge this! [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1754163425 [LL]Trillian test result (tid-6794) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 55467 seconds Marvin logs: https://github.com

Re: [PR] [cleanup] Deleted file FakeDhcpSnooper.java and DhcpSnooper.java [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7672: URL: https://github.com/apache/cloudstack/pull/7672#issuecomment-1754156755 [SF] Trillian test result (tid-7880) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 51895 seconds Marvin logs: https://github.com

Re: [PR] New Feature: Import VMware VMs into KVM [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7881: URL: https://github.com/apache/cloudstack/pull/7881#issuecomment-1754156147 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7287 -- This is an auto

Re: [PR] Update pom.xml reflections version [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #8019: URL: https://github.com/apache/cloudstack/pull/8019#issuecomment-1754150973 [LL]Trillian test result (tid-6798) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 50709 seconds Marvin logs: https://github.com

Re: [PR] New Feature: Import VMware VMs into KVM [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7881: URL: https://github.com/apache/cloudstack/pull/7881#issuecomment-1754104494 @nvazquez a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] New Feature: Import VMware VMs into KVM [cloudstack]

2023-10-09 Thread via GitHub
nvazquez commented on PR #7881: URL: https://github.com/apache/cloudstack/pull/7881#issuecomment-1754103673 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [cleanup] Deleted file FakeDhcpSnooper.java and DhcpSnooper.java [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7672: URL: https://github.com/apache/cloudstack/pull/7672#issuecomment-1754088525 [SF] Trillian test result (tid-7878) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47978 seconds Marvin logs: https://github.co

Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1754079472 [LL]Trillian test result (tid-6792) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 55443 seconds Marvin logs: https://github.com

Re: [PR] Update pom.xml reflections version [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #8019: URL: https://github.com/apache/cloudstack/pull/8019#issuecomment-1754064784 [LL]Trillian test result (tid-6799) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45711 seconds Marvin logs: https://github.com/

Re: [PR] Global ACL for VPCs [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7150: URL: https://github.com/apache/cloudstack/pull/7150#issuecomment-1754053003 [SF] Trillian test result (tid-7881) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44998 seconds Marvin logs: https://github.com

Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1754049508 [SF] Trillian test result (tid-7882) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44539 seconds Marvin logs: https://github.com

Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1754031554 [LL]Trillian test result (tid-6791) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 51836 seconds Marvin logs: https://github.com

Re: [PR] Do not list Quota API's to accounts with Quota disabled [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7599: URL: https://github.com/apache/cloudstack/pull/7599#issuecomment-1753970732 [SF] Trillian test result (tid-7877) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41501 seconds Marvin logs: https://github.com

Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1753941295 [LL]Trillian test result (tid-6793) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47985 seconds Marvin logs: https://github.com/

Re: [PR] Use UserVmDao for listVirtualMachines API to increase performance [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #8012: URL: https://github.com/apache/cloudstack/pull/8012#issuecomment-1753937584 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7286 -- This is an auto

Re: [PR] Snapshot removal and storage cleanup logs [cloudstack]

2023-10-09 Thread via GitHub
GutoVeronezi commented on code in PR #8031: URL: https://github.com/apache/cloudstack/pull/8031#discussion_r1350790682 ## engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/SnapshotServiceImpl.java: ## @@ -364,7 +364,7 @@ protected Void deleteSnapshotC

Re: [PR] Use UserVmDao for listVirtualMachines API to increase performance [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #8012: URL: https://github.com/apache/cloudstack/pull/8012#issuecomment-1753857827 @mlsorensen a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Use UserVmDao for listVirtualMachines API to increase performance [cloudstack]

2023-10-09 Thread via GitHub
mlsorensen commented on PR #8012: URL: https://github.com/apache/cloudstack/pull/8012#issuecomment-1753853469 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] api,server,ui: snapshot copy, multi-zone replica [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7873: URL: https://github.com/apache/cloudstack/pull/7873#issuecomment-1753777894 @shwstppr a [LL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an

Re: [PR] api,server,ui: snapshot copy, multi-zone replica [cloudstack]

2023-10-09 Thread via GitHub
shwstppr commented on PR #7873: URL: https://github.com/apache/cloudstack/pull/7873#issuecomment-1753774140 @blueorangutan LLtest matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] misc: fix spelling [cloudstack]

2023-10-09 Thread via GitHub
vishesh92 commented on PR #7549: URL: https://github.com/apache/cloudstack/pull/7549#issuecomment-1753759452 Changes in schema shouldn't be done for versions which have been released. This can cause issues in direct migration from an old version to the latest version. To fix values in datab

Re: [PR] Snapshot removal and storage cleanup logs [cloudstack]

2023-10-09 Thread via GitHub
vishesh92 commented on code in PR #8031: URL: https://github.com/apache/cloudstack/pull/8031#discussion_r1350738026 ## engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/SnapshotServiceImpl.java: ## @@ -364,7 +364,7 @@ protected Void deleteSnapshotCall

Re: [PR] Use UserVmDao for listVirtualMachines API to increase performance [cloudstack]

2023-10-09 Thread via GitHub
mlsorensen commented on PR #8012: URL: https://github.com/apache/cloudstack/pull/8012#issuecomment-1753662154 @DaanHoogland I'll check on the autoscale list, that was one of the few I wasn't easily able to test locally, but I'll see what I can do. -- This is an automated message from the

Re: [PR] misc: fix spelling [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7549: URL: https://github.com/apache/cloudstack/pull/7549#issuecomment-1753613404 [LL] Trillian Build Failed (tid-6801) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] UI: Fix sorter across different components [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #8046: URL: https://github.com/apache/cloudstack/pull/8046#issuecomment-1753608692 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8046 (QA-JID-197) -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] WIP - Storage mgmt [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7949: URL: https://github.com/apache/cloudstack/pull/7949#issuecomment-1753592587 [SF] Trillian test result (tid-7876) Environment: kvm-centos7 (x1), Advanced Networking with Mgmt server 7 Total time taken: 39692 seconds Marvin logs: https://github.com

Re: [PR] Quota tariff events [cloudstack]

2023-10-09 Thread via GitHub
vishesh92 commented on code in PR #8030: URL: https://github.com/apache/cloudstack/pull/8030#discussion_r1350725760 ## plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaTariffCreateCmd.java: ## @@ -70,6 +71,7 @@ public class QuotaTariffCreateCmd extends

Re: [PR] UI: Fix sorter across different components [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #8046: URL: https://github.com/apache/cloudstack/pull/8046#issuecomment-1753570666 @vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] UI: Fix sorter across different components [cloudstack]

2023-10-09 Thread via GitHub
vishesh92 commented on PR #8046: URL: https://github.com/apache/cloudstack/pull/8046#issuecomment-1753568804 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] .github: run Sonar Check only on PRs from apache/cloudstack branches [cloudstack]

2023-10-09 Thread via GitHub
weizhouapache commented on code in PR #8058: URL: https://github.com/apache/cloudstack/pull/8058#discussion_r1350715573 ## .github/workflows/sonar-check.yml: ## @@ -28,7 +28,7 @@ concurrency: jobs: build: -if: github.repository == 'apache/cloudstack' +if: github.re

Re: [PR] .github: run Sonar Check only on PRs from apache/cloudstack branches [cloudstack]

2023-10-09 Thread via GitHub
weizhouapache commented on code in PR #8058: URL: https://github.com/apache/cloudstack/pull/8058#discussion_r1350715573 ## .github/workflows/sonar-check.yml: ## @@ -28,7 +28,7 @@ concurrency: jobs: build: -if: github.repository == 'apache/cloudstack' +if: github.re

Re: [PR] .github: run Sonar Check only on PRs from apache/cloudstack branches [cloudstack]

2023-10-09 Thread via GitHub
weizhouapache commented on code in PR #8058: URL: https://github.com/apache/cloudstack/pull/8058#discussion_r1350715573 ## .github/workflows/sonar-check.yml: ## @@ -28,7 +28,7 @@ concurrency: jobs: build: -if: github.repository == 'apache/cloudstack' +if: github.re

Re: [PR] Local variable accessed as a class variable [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #344: URL: https://github.com/apache/cloudstack/pull/344#issuecomment-1753498611 @shwstppr a [LL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an a

Re: [PR] Fix templates and ISOs listing pagination [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7974: URL: https://github.com/apache/cloudstack/pull/7974#issuecomment-1753491578 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7285 -- This is an auto

Re: [PR] Fix allignment on layout on right panel [cloudstack]

2023-10-09 Thread via GitHub
codecov[bot] commented on PR #8060: URL: https://github.com/apache/cloudstack/pull/8060#issuecomment-1753464654 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8060?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

[PR] Fix allignment on layout on right panel [cloudstack]

2023-10-09 Thread via GitHub
harikrishna-patnala opened a new pull request, #8060: URL: https://github.com/apache/cloudstack/pull/8060 ### Description This is a followup for the PR https://github.com/apache/cloudstack/pull/7434, here we are making some more improvements from ![image](https://github.co

Re: [PR] New Feature: Import VMware VMs into KVM [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7881: URL: https://github.com/apache/cloudstack/pull/7881#issuecomment-1753441367 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7284 -- This is an auto

Re: [PR] Fix templates and ISOs listing pagination [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7974: URL: https://github.com/apache/cloudstack/pull/7974#issuecomment-1753427402 @DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] Fix templates and ISOs listing pagination [cloudstack]

2023-10-09 Thread via GitHub
DaanHoogland commented on PR #7974: URL: https://github.com/apache/cloudstack/pull/7974#issuecomment-1753426741 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] .github: run Sonar Check only on PRs from apache/cloudstack branches [cloudstack]

2023-10-09 Thread via GitHub
DaanHoogland commented on code in PR #8058: URL: https://github.com/apache/cloudstack/pull/8058#discussion_r1350602269 ## .github/workflows/sonar-check.yml: ## @@ -28,7 +28,7 @@ concurrency: jobs: build: -if: github.repository == 'apache/cloudstack' +if: github.rep

Re: [PR] Fix templates and ISOs listing pagination [cloudstack]

2023-10-09 Thread via GitHub
winterhazel commented on PR #7974: URL: https://github.com/apache/cloudstack/pull/7974#issuecomment-1753401538 > @winterhazel , did you get some 3rd party testing? @DaanHoogland yes, some users have tested these changes; I will ask them to report the results here. -- This is an aut

Re: [PR] .github: run Sonar Check only on PRs from apache/cloudstack branches [cloudstack]

2023-10-09 Thread via GitHub
weizhouapache commented on code in PR #8058: URL: https://github.com/apache/cloudstack/pull/8058#discussion_r1350593087 ## .github/workflows/sonar-check.yml: ## @@ -28,7 +28,7 @@ concurrency: jobs: build: -if: github.repository == 'apache/cloudstack' +if: github.re

Re: [PR] .github: run Sonar Check only on PRs from apache/cloudstack branches [cloudstack]

2023-10-09 Thread via GitHub
weizhouapache commented on code in PR #8058: URL: https://github.com/apache/cloudstack/pull/8058#discussion_r1350591077 ## .github/workflows/sonar-check.yml: ## @@ -28,7 +28,7 @@ concurrency: jobs: build: -if: github.repository == 'apache/cloudstack' +if: github.re

Re: [PR] Fix templates and ISOs listing pagination [cloudstack]

2023-10-09 Thread via GitHub
hsato03 commented on PR #7974: URL: https://github.com/apache/cloudstack/pull/7974#issuecomment-1753389064 Code LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [Draft] KVM Ingestion - Import Instance [cloudstack]

2023-10-09 Thread via GitHub
DaanHoogland closed pull request #7976: [Draft] KVM Ingestion - Import Instance URL: https://github.com/apache/cloudstack/pull/7976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Format quota email currency values [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7605: URL: https://github.com/apache/cloudstack/pull/7605#issuecomment-1753379268 @DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

Re: [PR] Format quota email currency values [cloudstack]

2023-10-09 Thread via GitHub
DaanHoogland commented on PR #7605: URL: https://github.com/apache/cloudstack/pull/7605#issuecomment-1753378574 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] misc: fix spelling [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7549: URL: https://github.com/apache/cloudstack/pull/7549#issuecomment-1753376966 @DaanHoogland a [LL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This i

Re: [PR] misc: fix spelling [cloudstack]

2023-10-09 Thread via GitHub
DaanHoogland commented on PR #7549: URL: https://github.com/apache/cloudstack/pull/7549#issuecomment-1753376636 @blueorangutan LLtest matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] misc: fix spelling [cloudstack]

2023-10-09 Thread via GitHub
DaanHoogland commented on PR #7549: URL: https://github.com/apache/cloudstack/pull/7549#issuecomment-1753376054 As there are fixes in DB sql code I'll run regression tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] New Feature: Import VMware VMs into KVM [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7881: URL: https://github.com/apache/cloudstack/pull/7881#issuecomment-1753374667 @nvazquez a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] .github: run Sonar Check only on PRs from apache/cloudstack branches [cloudstack]

2023-10-09 Thread via GitHub
DaanHoogland commented on code in PR #8058: URL: https://github.com/apache/cloudstack/pull/8058#discussion_r1350574888 ## .github/workflows/sonar-check.yml: ## @@ -28,7 +28,7 @@ concurrency: jobs: build: -if: github.repository == 'apache/cloudstack' +if: github.rep

Re: [PR] New Feature: Import VMware VMs into KVM [cloudstack]

2023-10-09 Thread via GitHub
nvazquez commented on PR #7881: URL: https://github.com/apache/cloudstack/pull/7881#issuecomment-1753373651 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [Draft] KVM Ingestion - Import Instance [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7976: URL: https://github.com/apache/cloudstack/pull/7976#issuecomment-1753317420 Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-

Re: [PR] Polish UI [cloudstack]

2023-10-09 Thread via GitHub
blueorangutan commented on PR #7855: URL: https://github.com/apache/cloudstack/pull/7855#issuecomment-1753317419 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7282 -- This is an auto

Re: [PR] [NSX] Refactor API wrapper operations [cloudstack]

2023-10-09 Thread via GitHub
codecov[bot] commented on PR #8059: URL: https://github.com/apache/cloudstack/pull/8059#issuecomment-1753315782 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8059?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

  1   2   3   >