Re: [PR] ui: refactor global createmenu [cloudstack]

2024-05-29 Thread via GitHub
blueorangutan commented on PR #9139: URL: https://github.com/apache/cloudstack/pull/9139#issuecomment-2138813018 UI build failed: :heavy_multiplication_x: (SL-JID-359) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] ui; fix admin dashboard vue warnings [cloudstack]

2024-05-29 Thread via GitHub
blueorangutan commented on PR #9140: URL: https://github.com/apache/cloudstack/pull/9140#issuecomment-2138812861 UI build failed: :heavy_multiplication_x: (SL-JID-360) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] feature: webhooks [cloudstack]

2024-05-29 Thread via GitHub
blueorangutan commented on PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2138810600 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] feature: webhooks [cloudstack]

2024-05-29 Thread via GitHub
shwstppr commented on PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2138807579 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] ui; fix admin dashboard vue warnings [cloudstack]

2024-05-29 Thread via GitHub
blueorangutan commented on PR #9140: URL: https://github.com/apache/cloudstack/pull/9140#issuecomment-2138806546 @shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] ui: refactor global createmenu [cloudstack]

2024-05-29 Thread via GitHub
blueorangutan commented on PR #9139: URL: https://github.com/apache/cloudstack/pull/9139#issuecomment-2138806508 @shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] ui: refactor global createmenu [cloudstack]

2024-05-29 Thread via GitHub
shwstppr commented on PR #9139: URL: https://github.com/apache/cloudstack/pull/9139#issuecomment-2138804896 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] ui; fix admin dashboard vue warnings [cloudstack]

2024-05-29 Thread via GitHub
shwstppr commented on PR #9140: URL: https://github.com/apache/cloudstack/pull/9140#issuecomment-2138804556 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] ACS 4.19 | No Auth Failure Message Displayed when login Password is wrong [cloudstack]

2024-05-29 Thread via GitHub
DaanHoogland closed issue #8662: ACS 4.19 | No Auth Failure Message Displayed when login Password is wrong URL: https://github.com/apache/cloudstack/issues/8662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [I] ACS 4.19 | No Auth Failure Message Displayed when login Password is wrong [cloudstack]

2024-05-29 Thread via GitHub
DaanHoogland commented on issue #8662: URL: https://github.com/apache/cloudstack/issues/8662#issuecomment-2138802336 Fixed by #8671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

(cloudstack) branch 4.19 updated: Fixup response code on incorrect credentials (#8671)

2024-05-29 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.19 by this push: new 87b55af1979 Fixup response code on incorrect crede

Re: [PR] Fixup response code on incorrect credentials [cloudstack]

2024-05-29 Thread via GitHub
DaanHoogland merged PR #8671: URL: https://github.com/apache/cloudstack/pull/8671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

Re: [I] Support for Autoscale, using VNF in L2 Networks. [cloudstack]

2024-05-29 Thread via GitHub
btzq commented on issue #9144: URL: https://github.com/apache/cloudstack/issues/9144#issuecomment-2138743627 Hi @weizhouapache , Allowing VNF to be the LB Provider would be great, but come to think of it, i think it will pose a challenge because Cloudstack will need to recognise the

Re: [PR] log messages [cloudstack]

2024-05-29 Thread via GitHub
winterhazel commented on code in PR #9093: URL: https://github.com/apache/cloudstack/pull/9093#discussion_r1619817293 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterResourceModifierActionWorker.java: ## @@ -26

Re: [I] Add limit configuration for number of projects per domain/account and add UI function for configuring limits [cloudstack]

2024-05-29 Thread via GitHub
my-code-AL commented on issue #9127: URL: https://github.com/apache/cloudstack/issues/9127#issuecomment-2138356522 I'll look into this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix columns in VM details tabs [cloudstack]

2024-05-29 Thread via GitHub
codecov[bot] commented on PR #9147: URL: https://github.com/apache/cloudstack/pull/9147#issuecomment-2138308798 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9147?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] api,server: encryptformat in volume response [cloudstack]

2024-05-29 Thread via GitHub
blueorangutan commented on PR #9106: URL: https://github.com/apache/cloudstack/pull/9106#issuecomment-2138301192 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9736 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[PR] Fix columns in VM details tabs [cloudstack]

2024-05-29 Thread via GitHub
hsato03 opened a new pull request, #9147: URL: https://github.com/apache/cloudstack/pull/9147 ### Description When accessing the `Backups` or `VM snapshots` tabs through the VM details, there are some columns that show no data (created column for example). This PR aims to fix this

Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]

2024-05-29 Thread via GitHub
blueorangutan commented on PR #8893: URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2138280118 @shwstppr a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an

Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]

2024-05-29 Thread via GitHub
shwstppr commented on PR #8893: URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2138277857 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]

2024-05-29 Thread via GitHub
blueorangutan commented on PR #8893: URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2138260332 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9734 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] api,server: encryptformat in volume response [cloudstack]

2024-05-29 Thread via GitHub
weizhouapache commented on code in PR #9106: URL: https://github.com/apache/cloudstack/pull/9106#discussion_r1619435774 ## engine/schema/src/main/resources/META-INF/db/views/cloud.volume_view.sql: ## @@ -39,6 +39,8 @@ SELECT `volumes`.`path` AS `path`, `volumes`.`chain

Re: [PR] api,server: encryptformat in volume response [cloudstack]

2024-05-29 Thread via GitHub
blueorangutan commented on PR #9106: URL: https://github.com/apache/cloudstack/pull/9106#issuecomment-2138206169 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

Re: [PR] api,server: encryptformat in volume response [cloudstack]

2024-05-29 Thread via GitHub
weizhouapache commented on PR #9106: URL: https://github.com/apache/cloudstack/pull/9106#issuecomment-2138205327 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] api,server: encryptformat in volume response [cloudstack]

2024-05-29 Thread via GitHub
weizhouapache commented on code in PR #9106: URL: https://github.com/apache/cloudstack/pull/9106#discussion_r1619433817 ## server/src/main/java/com/cloud/api/query/vo/VolumeJoinVO.java: ## @@ -275,6 +275,12 @@ public class VolumeJoinVO extends BaseViewWithTagInformationVO imple

Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]

2024-05-29 Thread via GitHub
weizhouapache commented on PR #8893: URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2138202865 > code looks good, but let's wait untill we are sure 4.19.1 is out. Can we say 4.19.1 will be released before 4.20 now? :-D -- This is an automated message from the Ap

Re: [PR] api,server: encryptformat in volume response [cloudstack]

2024-05-29 Thread via GitHub
shwstppr commented on code in PR #9106: URL: https://github.com/apache/cloudstack/pull/9106#discussion_r1619416941 ## server/src/main/java/com/cloud/api/query/vo/VolumeJoinVO.java: ## @@ -275,6 +275,12 @@ public class VolumeJoinVO extends BaseViewWithTagInformationVO implements

Re: [PR] api,server: encryptformat in volume response [cloudstack]

2024-05-29 Thread via GitHub
shwstppr commented on code in PR #9106: URL: https://github.com/apache/cloudstack/pull/9106#discussion_r1619415377 ## server/src/main/java/com/cloud/api/query/vo/VolumeJoinVO.java: ## @@ -610,6 +616,14 @@ public void setExternalUuid(String externalUuid) { this.externalU

Re: [PR] api,server: encryptformat in volume response [cloudstack]

2024-05-29 Thread via GitHub
shwstppr commented on code in PR #9106: URL: https://github.com/apache/cloudstack/pull/9106#discussion_r1619414742 ## server/src/main/java/com/cloud/api/query/vo/VolumeJoinVO.java: ## @@ -275,6 +275,12 @@ public class VolumeJoinVO extends BaseViewWithTagInformationVO implements

Re: [PR] [Quota] Add API to list preset variables [cloudstack]

2024-05-29 Thread via GitHub
blueorangutan commented on PR #8372: URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2138172862 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9733 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] feature: webhooks [cloudstack]

2024-05-29 Thread via GitHub
shwstppr commented on PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2138150833 Test failing with exceptions, ``` 2024-05-28T13:43:38,730 WARN [c.c.u.AccountManagerImpl] (API-Job-Executor-31:[ctx-26228571, job-39, ctx-aa487b81]) (logid:bf162f6e) Failed to

Re: [PR] Add logs to VMware instance configuration process [cloudstack]

2024-05-29 Thread via GitHub
blueorangutan commented on PR #9080: URL: https://github.com/apache/cloudstack/pull/9080#issuecomment-2138149905 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9732 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]

2024-05-29 Thread via GitHub
blueorangutan commented on PR #8893: URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2138149008 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]

2024-05-29 Thread via GitHub
shwstppr commented on PR #8893: URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2138146972 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] api,server: encryptformat in volume response [cloudstack]

2024-05-29 Thread via GitHub
JoaoJandre commented on code in PR #9106: URL: https://github.com/apache/cloudstack/pull/9106#discussion_r1619390969 ## server/src/main/java/com/cloud/api/query/vo/VolumeJoinVO.java: ## @@ -275,6 +275,12 @@ public class VolumeJoinVO extends BaseViewWithTagInformationVO implemen

Re: [PR] Add configuration to limit the number of rows deleted from vm_stats [cloudstack]

2024-05-29 Thread via GitHub
blueorangutan commented on PR #8740: URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2138139939 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To re

Re: [PR] Add configuration to limit the number of rows deleted from vm_stats [cloudstack]

2024-05-29 Thread via GitHub
weizhouapache commented on PR #8740: URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2138137511 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] KVM Incremental Snapshots/Backups [cloudstack]

2024-05-29 Thread via GitHub
weizhouapache commented on issue #8907: URL: https://github.com/apache/cloudstack/issues/8907#issuecomment-2138136441 > > Ideally, incremental backups, or a base snapshot and a number of snapshot deltas, become abstract concepts in ACS, and drivers for primary storage can implement the oper

Re: [PR] Add unit tests for null cpu for null parameters for set allocated cpu [cloudstack]

2024-05-29 Thread via GitHub
codecov[bot] commented on PR #9137: URL: https://github.com/apache/cloudstack/pull/9137#issuecomment-2138133385 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9137?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] Add configuration to limit the number of rows deleted from vm_stats [cloudstack]

2024-05-29 Thread via GitHub
JoaoJandre commented on PR #8740: URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2138125745 @sureshanaparti @DaanHoogland could we run the CI here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Add unit tests for null cpu for null parameters for set allocated cpu [cloudstack]

2024-05-29 Thread via GitHub
JoaoJandre commented on code in PR #9137: URL: https://github.com/apache/cloudstack/pull/9137#discussion_r1619376523 ## plugins/metrics/src/test/java/org/apache/cloudstack/response/HostMetricsResponseTest.java: ## @@ -56,4 +56,15 @@ public void testSetCpuAllocatedWithValidCpu()

Re: [I] Support for Autoscale, using VNF in L2 Networks. [cloudstack]

2024-05-29 Thread via GitHub
weizhouapache commented on issue #9144: URL: https://github.com/apache/cloudstack/issues/9144#issuecomment-2138107570 Currently the autoscale feature has dependency on loadbalancing service. For now it only works with isolated networks or vpc with lb. Do you want VNF to be working as the

[PR] Differentiate between instalation ISO and attached ISO [cloudstack]

2024-05-29 Thread via GitHub
GaOrtiga opened a new pull request, #9146: URL: https://github.com/apache/cloudstack/pull/9146 ### Description When a VM has been created using an ISO, its infocard will label the ISO as `Template`. Additionally, any ISO attached to it will be labeled as `ISO`. This behaviour may cau

Re: [PR] [Quota] Add API to list preset variables [cloudstack]

2024-05-29 Thread via GitHub
blueorangutan commented on PR #8372: URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2138053546 @BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] [Quota] Add API to list preset variables [cloudstack]

2024-05-29 Thread via GitHub
BryanMLima commented on PR #8372: URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2138051406 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Add logs to VMware instance configuration process [cloudstack]

2024-05-29 Thread via GitHub
blueorangutan commented on PR #9080: URL: https://github.com/apache/cloudstack/pull/9080#issuecomment-2138027251 @winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Add logs to VMware instance configuration process [cloudstack]

2024-05-29 Thread via GitHub
winterhazel commented on PR #9080: URL: https://github.com/apache/cloudstack/pull/9080#issuecomment-2138024736 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add logs to VMware instance configuration process [cloudstack]

2024-05-29 Thread via GitHub
hsato03 commented on code in PR #9080: URL: https://github.com/apache/cloudstack/pull/9080#discussion_r1619302137 ## vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java: ## @@ -1182,6 +1182,7 @@ public boolean setVncConfigInfo(boolean enableVnc, String

Re: [PR] allow users to add description to private gateway and static routes [cloudstack]

2024-05-29 Thread via GitHub
charlesweng commented on PR #9135: URL: https://github.com/apache/cloudstack/pull/9135#issuecomment-2137882691 closing, someone has already started working on this feature -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] allow users to add description to private gateway and static routes [cloudstack]

2024-05-29 Thread via GitHub
charlesweng closed pull request #9135: allow users to add description to private gateway and static routes URL: https://github.com/apache/cloudstack/pull/9135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] KVM Incremental Snapshots/Backups [cloudstack]

2024-05-29 Thread via GitHub
JoaoJandre commented on issue #8907: URL: https://github.com/apache/cloudstack/issues/8907#issuecomment-2137693813 > Ideally, incremental backups, or a base snapshot and a number of snapshot deltas, become abstract concepts in ACS, and drivers for primary storage can implement the operation

Re: [PR] Add configuration to limit the number of rows deleted from vm_stats [cloudstack]

2024-05-29 Thread via GitHub
blueorangutan commented on PR #8740: URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2137587186 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9730 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[I] Autoscale Load Balancing Rule looses VMs during a node failure. [cloudstack]

2024-05-29 Thread via GitHub
btzq opened a new issue, #9145: URL: https://github.com/apache/cloudstack/issues/9145 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ Autoscaling, Load Balancer ~~~ # CLOUDSTACK VERSION ~~~ 4.19.0 ~~~ # CONFIGUR

[I] Support for Autoscale, using VNF in L2 Networks. [cloudstack]

2024-05-29 Thread via GitHub
btzq opened a new issue, #9144: URL: https://github.com/apache/cloudstack/issues/9144 # ISSUE TYPE * Enhancement Request # COMPONENT NAME ~~~ L2 Networks, Autoscaling ~~~ # CLOUDSTACK VERSION ~~~ 4.19.0 ~~~ # C

Re: [PR] pre-commit: add hook `check-yaml` [cloudstack]

2024-05-29 Thread via GitHub
jbampton commented on code in PR #9133: URL: https://github.com/apache/cloudstack/pull/9133#discussion_r1618968734 ## .pre-commit-config.yaml: ## @@ -34,7 +34,8 @@ repos: - id: check-merge-conflict - id: check-symlinks - id: check-vcs-permalinks - #- id

Re: [I] KVM Incremental Snapshots/Backups [cloudstack]

2024-05-29 Thread via GitHub
Philipp-Reisner commented on issue #8907: URL: https://github.com/apache/cloudstack/issues/8907#issuecomment-2137520548 Ideally, incremental backups, or a base snapshot and a number of snapshot deltas, become abstract concepts in ACS, and drivers for primary storage can implement the operat

Re: [PR] pre-commit: add hook `check-yaml` [cloudstack]

2024-05-29 Thread via GitHub
jbampton commented on code in PR #9133: URL: https://github.com/apache/cloudstack/pull/9133#discussion_r1618959074 ## plugins/integrations/kubernetes-service/src/main/resources/conf/k8s-node.yml: ## @@ -21,8 +21,8 @@ users: - name: cloud sudo: ALL=(ALL) NOPASSWD:ALL

Re: [PR] linstor: make getDevicePath more robust [cloudstack]

2024-05-29 Thread via GitHub
JoaoJandre commented on code in PR #9143: URL: https://github.com/apache/cloudstack/pull/9143#discussion_r1618917914 ## plugins/storage/volume/linstor/src/main/java/org/apache/cloudstack/storage/datastore/util/LinstorUtil.java: ## @@ -109,4 +110,36 @@ public static boolean isRes

Re: [PR] Add configuration to limit the number of rows deleted from vm_stats [cloudstack]

2024-05-29 Thread via GitHub
blueorangutan commented on PR #8740: URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2137430831 @JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Add configuration to limit the number of rows deleted from vm_stats [cloudstack]

2024-05-29 Thread via GitHub
JoaoJandre commented on PR #8740: URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2137426806 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [I] Allow Users To Change Guest VM 'Hardware Information' [cloudstack]

2024-05-29 Thread via GitHub
weizhouapache commented on issue #9142: URL: https://github.com/apache/cloudstack/issues/9142#issuecomment-2137375495 I think this is a valid improvement. related to #8912 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] feature: webhooks [cloudstack]

2024-05-29 Thread via GitHub
blueorangutan commented on PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2137351729 [SF] Trillian test result (tid-10310) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 83625 seconds Marvin logs: https://github.co

Re: [PR] linstor: make getDevicePath more robust [cloudstack]

2024-05-29 Thread via GitHub
codecov[bot] commented on PR #9143: URL: https://github.com/apache/cloudstack/pull/9143#issuecomment-2137278162 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9143?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] linstor: make getDevicePath more robust [cloudstack]

2024-05-29 Thread via GitHub
rp- opened a new pull request, #9143: URL: https://github.com/apache/cloudstack/pull/9143 ### Description Before we only asked the first resource for the device path, if those resource was down or broken, we wouldn't get a device path at all. Now we go through all resource and use th

Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]

2024-05-29 Thread via GitHub
rp- commented on PR #8889: URL: https://github.com/apache/cloudstack/pull/8889#issuecomment-2137181390 > > I'm a very bad reviewer and glanced through all changes, but I'm not familiar with a lot of that code and can't really comment if anything of that could break something. > > @rp

Re: [PR] kvm: consider provisioning type for local data volumes [cloudstack]

2024-05-29 Thread via GitHub
blueorangutan commented on PR #9141: URL: https://github.com/apache/cloudstack/pull/9141#issuecomment-2137173979 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9728 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] feature: webhooks [cloudstack]

2024-05-29 Thread via GitHub
shwstppr closed pull request #8674: feature: webhooks URL: https://github.com/apache/cloudstack/pull/8674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]

2024-05-29 Thread via GitHub
shwstppr opened a new pull request, #8602: URL: https://github.com/apache/cloudstack/pull/8602 ### Description This PR... ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionalit

Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]

2024-05-29 Thread via GitHub
shwstppr closed pull request #8602: [HEALTH] 4.20/main Health Check, please don't merge this! URL: https://github.com/apache/cloudstack/pull/8602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[I] Allow Users To Change Guest VM 'Hardware Information' [cloudstack]

2024-05-29 Thread via GitHub
btzq opened a new issue, #9142: URL: https://github.com/apache/cloudstack/issues/9142 # ISSUE TYPE * Improvement Request # COMPONENT NAME ~~~ LibvirtVMDef.java ~~~ # CLOUDSTACK VERSION ~~~ 4.19.0 ~~~ # CONFIGUR

Re: [PR] kvm: consider provisioning type for local data volumes [cloudstack]

2024-05-29 Thread via GitHub
codecov[bot] commented on PR #9141: URL: https://github.com/apache/cloudstack/pull/9141#issuecomment-2137069958 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9141?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] kvm: consider provisioning type for local data volumes [cloudstack]

2024-05-29 Thread via GitHub
blueorangutan commented on PR #9141: URL: https://github.com/apache/cloudstack/pull/9141#issuecomment-2137058649 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] kvm: consider provisioning type for local data volumes [cloudstack]

2024-05-29 Thread via GitHub
shwstppr commented on PR #9141: URL: https://github.com/apache/cloudstack/pull/9141#issuecomment-2137056495 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[PR] kvm: consider provisioning type for local data volumes [cloudstack]

2024-05-29 Thread via GitHub
shwstppr opened a new pull request, #9141: URL: https://github.com/apache/cloudstack/pull/9141 ### Description Fixes #8644 ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking cha

Re: [PR] ui; fix admin dashboard vue warnings [cloudstack]

2024-05-29 Thread via GitHub
codecov[bot] commented on PR #9140: URL: https://github.com/apache/cloudstack/pull/9140#issuecomment-2136914376 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9140?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] ui; fix admin dashboard vue warnings [cloudstack]

2024-05-29 Thread via GitHub
shwstppr opened a new pull request, #9140: URL: https://github.com/apache/cloudstack/pull/9140 ### Description Fixes warnings on admin dashboard in console. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) -

Re: [PR] ui: refactor global createmenu [cloudstack]

2024-05-29 Thread via GitHub
codecov[bot] commented on PR #9139: URL: https://github.com/apache/cloudstack/pull/9139#issuecomment-2136872858 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9139?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] feature: webhooks [cloudstack]

2024-05-29 Thread via GitHub
shwstppr opened a new pull request, #8674: URL: https://github.com/apache/cloudstack/pull/8674 ### Description Feature spec: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Webhooks Webhooks allow external services to be notified when certain events happen. To impl

Re: [PR] feature: webhooks [cloudstack]

2024-05-29 Thread via GitHub
shwstppr closed pull request #8674: feature: webhooks URL: https://github.com/apache/cloudstack/pull/8674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[PR] ui: refactor global createmenu [cloudstack]

2024-05-29 Thread via GitHub
shwstppr opened a new pull request, #9139: URL: https://github.com/apache/cloudstack/pull/9139 ### Description Refactors global create menu code to make it visible only when any menu is accessible. ### Types of changes - [ ] Breaking change (fix or feature that would cau

Re: [PR] pre-commit: add hook `check-yaml` [cloudstack]

2024-05-29 Thread via GitHub
DaanHoogland commented on code in PR #9133: URL: https://github.com/apache/cloudstack/pull/9133#discussion_r1618449412 ## .pre-commit-config.yaml: ## @@ -34,7 +34,8 @@ repos: - id: check-merge-conflict - id: check-symlinks - id: check-vcs-permalinks - #

Re: [PR] linstor: ui show Server and resource-group fields with custom protocol [cloudstack]

2024-05-29 Thread via GitHub
codecov[bot] commented on PR #9138: URL: https://github.com/apache/cloudstack/pull/9138#issuecomment-2136794396 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9138?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] linstor: ui show Server and resource-group fields with custom protocol [cloudstack]

2024-05-29 Thread via GitHub
rp- opened a new pull request, #9138: URL: https://github.com/apache/cloudstack/pull/9138 ### Description Fixes Linstor related fields not showing in add primary storage, while using custom protocol. Fixes: #8550 ### Types of changes - [ ] Breakin

[PR] [Quota] Add API to list preset variables [cloudstack]

2024-05-29 Thread via GitHub
BryanMLima opened a new pull request, #8372: URL: https://github.com/apache/cloudstack/pull/8372 ### Description This PR extends the functionality introduced in PR #5909, allowing users to list the preset variables via API, facilitating the creation of the activation rules while crea

Re: [PR] [Quota] Add API to list preset variables [cloudstack]

2024-05-29 Thread via GitHub
DaanHoogland closed pull request #8372: [Quota] Add API to list preset variables URL: https://github.com/apache/cloudstack/pull/8372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Build: support JRE17 for building and sonar check [cloudstack]

2024-05-29 Thread via GitHub
weizhouapache commented on PR #8609: URL: https://github.com/apache/cloudstack/pull/8609#issuecomment-2136694547 > @rohityadavcloud @DaanHoogland some recent update > > * Update all github actions to use JDK 17 (build, simulator, codecov, sonar check) > * Support packaging usin