| Skipped | 1.12 | test_deploy_vgpu_enabled_vm.py
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about
the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
for monitoring if we have reached the IOPS limit on a storage cluster.
cc: @mike-tutkowski
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go
ase `range[0]` is not a number and the
method returns -1
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service,
anPart: vlanAuthority.split(",")) {
+if (vlanPart == null || vlanPart.isEmpty()) {
Review comment:
what about `StringUtils.isBlank` here?
This is an automated message from the Apache Git Service.
To respond to the
` here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apac
1);
+final List vlans2 = expandVlanUri(vlanRange2);
+if (vlans1 == null || vlans2 == null) {
Review comment:
if one of them is null, the result is `true`? This means that they overlap?
----
This is an automated message from the
helps to reduce the number of IFs inside of IFs
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
ve one if inception
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastr
that I am against the code the way it is; I only wanted to call
attention to a point that can help us to reduce the barrier for newcomers. The
more readable and understandable a code is at first sight, the easier it is for
newcomers to start working with it.
P.S. sorry for the lo
to the failures.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure
OrEmpty(groupId)) {
+return null;
+}
+LOG.debug("Trying to find Cloudian group with id=" + groupId);
+try {
+ final HttpResponse response =
get(String.format("/group?groupId=%s", groupId));
+checkResponseOK(response);
+
///
+
+public boolean addGroup(final CloudianGroup group) {
Review comment:
Runtime exceptions are suitably thrown by checkResponseTimeOut and other
methods. The boolean value may be used to ascertain whether the operation was
successful or not. Throwing and catching exceptions will ultimately be similar
pattern.
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
rhtyd closed pull request #2286: CLOUDSTACK-9993: Have basic constraint in CA
certificate
URL: https://github.com/apache/cloudstack/pull/2286
This is an automated message from the Apache Git Service.
To respond
message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
R is ready, I'll squash
them, and maintain the rebase until the merge.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
F
rhtyd closed pull request #2287: CLOUDSTACK-9998: Prometheus Exporter for
CloudStack
URL: https://github.com/apache/cloudstack/pull/2287
This is an automated message from the Apache Git Service.
To respond to the message
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
'
+}]
+});
+}
+},
+
+forgedTransmits: {
+label: 'label.forged.trasmits',
Review comment:
same typo
This is an automated message from the Apache Git
--------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
}
+
+private abstract class Item {
+String name;
+
+public Item(final String nm) {
+name = nm;
+}
+
+public abstract String toMetricsString();
+}
+
+class ItemVM extends Item {
Review comment:
What approach should we take?
Review comment:
I kept this method to follow the hierarical metrics output at host level in
a zone; splitting may make redundant loops.
----
This is an automated message from the Apache Git Service.
To respond to the message, please
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
and others
@blueorangutan package
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service
tests
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
planations.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
DaanHoogland closed pull request #2246: CLOUDSTACK-10046 checksum validation
for any java supported Digests-type
URL: https://github.com/apache/cloudstack/pull/2246
This is an automated message from the Apache Git Service
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
()
It will start failing on lower java versions
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about
SUCCESSFUL===
Hypervisor = 0ba599dd-6e4a-4b60-9b08-98e53481f24c
Host state is Up
===final results are now copied to: /tmp//MarvinLogs/test_host_TERH92===
This is an automated message from the Apache Git Service.
To respond
](https://github.com/apache/cloudstack/files/1374815/runinfo.txt)
Attached marvin test result
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
of DB. So, replaced it with ConfigKey
based approach
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git
ill passing `deviceNumber` to be used as key
when plugging in a dvswitch `nic` device, I removed the `setKey(30)` as
`setKey` is again called, its usage is redundant and unnecessary.
This is an automated message from the Apache
csi_vm.py
test_deploy_vgpu_enabled_vm | Skipped | 1.19 | test_deploy_vgpu_enabled_vm.py
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
reduce our test scopes, I chose to keep it that
way. IMO it's not a problem as long as the key is unique, being
negative/positive is not a problem.
This is an automated message from the Apache Git Service.
To respond to the messa
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
t_deploy_vgpu_enabled_vm | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support | Skipped | 0.06 | test_deploy_vgpu_enabled_vm.py
This is an automated message from the Apache Git Service.
To respond to the message, plea
from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
csi_vm.py
test_deploy_vgpu_enabled_vm | Skipped | 1.19 | test_deploy_vgpu_enabled_vm.py
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific
).
It seems a problem has been introduced into master.
I can e-mail the list.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific
nabled_vm.py
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
ulator.py
test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py
This is an automated message from the Apache Git Service.
To respond to th
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
_vm.py
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
on your
cloud production environment with caution.
[1] https://github.com/Autonomiccs/autonomiccs-platform
[2] https://github.com/Autonomiccs/cloud-traces
This is an automated message from the Apache Git Service.
To respond
on your
cloud production environment with caution.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about
Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this
)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
accepting values bigger than
10. This PR changes the validation method to accept any number >= 6. We also
change other inconsistencies in error messages presented to users. in near by
validations
This is an automated message from t
DaanHoogland closed pull request #2074: CLOUDSTACK-9899 Url validation disabling
URL: https://github.com/apache/cloudstack/pull/2074
This is an automated message from the Apache Git Service.
To respond to the message
DaanHoogland closed pull request #2061: CLOUDSTACK-8308 automation test for
Delta Snapshot
URL: https://github.com/apache/cloudstack/pull/2061
This is an automated message from the Apache Git Service.
To respond
the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
che Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
| 0.03 | test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
we can throw it here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
not found), it means that something
else further down the deployment process will break, right? If this is the
case, I think we could stop the processing here and throw a runtime exception.
This is an automated message from the Apache Git
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards
DaanHoogland commented on issue #2290: WIP: add track id to async api calls
URL: https://github.com/apache/cloudstack/pull/2290#issuecomment-335484114
@blueorangutan package
This is an automated message from the Apache Git
CloudianGroup group) {
Review comment:
What about throwing a runtime exception (a custom one) if it is not possible
to add this `group` object?
It feels more natural for a method to throw an exception if it fails than to
return a Boolean indicating its status.
The same applies for the
nse);
+if (response.getStatusLine().getStatusCode() ==
HttpStatus.SC_NO_CONTENT ||
Review comment:
what about putting the boolean condition
`response.getStatusLine().getStatusCode() == HttpStatus.SC_NO_CONTENT ||
response.getEntity() == null || response.getEntity().getCon
time I am not able to review or work much with you guys ;)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards
Do you understand why we are using negative values there?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For que
lue as IDs.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.
);
+}
+
+private abstract class Item {
+String name;
+
+public Item(final String nm) {
+name = nm;
+}
+
+public abstract String toMetricsString();
+}
+
+class ItemVM extends Item {
Review comment:
a lot of doublures in field
d) {
Review comment:
I would love to see this method split. It doesn't fit in my mind. Guess it
doesn't differ for the functionality.
----
This is an automated message from the Apache Git Service.
To respond to the message, please
Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git
rhtyd closed pull request #2225: [master] Smoketest health checkrun
URL: https://github.com/apache/cloudstack/pull/2225
This is an automated message from the Apache Git Service.
To respond to the message, please log
201 - 300 of 5898 matches
Mail list logo
