[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4004: Fixed null pointer and deployment issue on Xenserver with L2 Guest network with configDrive

Thu, 21 May 2020 12:42:54 -0700 


DaanHoogland commented on a change in pull request #4004:
URL: https://github.com/apache/cloudstack/pull/4004#discussion_r428866018



##########
File path: 
server/src/main/java/com/cloud/network/element/ConfigDriveNetworkElement.java
##########
@@ -478,7 +476,7 @@ private boolean deleteConfigDriveIso(final VirtualMachine 
vm) throws ResourceUna
         return true;
     }
 
-    private void addConfigDriveDisk(final VirtualMachineProfile profile, final 
DataStore dataStore) throws ResourceUnavailableException {
+    public static void addConfigDriveDisk(final VirtualMachineProfile profile, 
final DataStore dataStore) throws ResourceUnavailableException {

Review comment:
       can you explain? I don't see it being used anywhere




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to