[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4553: Fix for mapping guest OS type read from OVF to existing guest OS in C…

2020-12-22 Thread GitBox
DaanHoogland commented on a change in pull request #4553: URL: https://github.com/apache/cloudstack/pull/4553#discussion_r547292985 ## File path: engine/storage/src/main/java/org/apache/cloudstack/storage/image/deployasis/DeployAsIsHelperImpl.java ## @@ -174,8 +174,25 @@ priva

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4553: Fix for mapping guest OS type read from OVF to existing guest OS in C…

2020-12-21 Thread GitBox
DaanHoogland commented on a change in pull request #4553: URL: https://github.com/apache/cloudstack/pull/4553#discussion_r546661690 ## File path: utils/src/test/java/com/cloud/utils/StringUtilsTest.java ## @@ -258,4 +258,34 @@ public void testToCSVList() { String outpu

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4553: Fix for mapping guest OS type read from OVF to existing guest OS in C…

2020-12-21 Thread GitBox
DaanHoogland commented on a change in pull request #4553: URL: https://github.com/apache/cloudstack/pull/4553#discussion_r546565799 ## File path: utils/src/main/java/com/cloud/utils/StringUtils.java ## @@ -313,4 +313,42 @@ public static String mapToString(final Map map) {