[GitHub] [cloudstack] DaanHoogland commented on issue #3969: Snapshot deletion issues

2020-04-11 Thread GitBox
DaanHoogland commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-612362608 those were spurious failures obviously, @andrijapanicsb as they passed after applying insanity. If you manual verification checks out we should merge an

[GitHub] [cloudstack] DaanHoogland commented on issue #3969: Snapshot deletion issues

2020-04-09 Thread GitBox
DaanHoogland commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-611679538 @Slair1 : ``` $ git branch --contains c94ee1454d3ecdf1bf371fd18c8e3ec0631d3092 4.11 4.12 4.13 ... ``` ---

[GitHub] [cloudstack] DaanHoogland commented on issue #3969: Snapshot deletion issues

2020-04-07 Thread GitBox
DaanHoogland commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-610262406 @blueorangutan test matrix This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] DaanHoogland commented on issue #3969: Snapshot deletion issues

2020-04-07 Thread GitBox
DaanHoogland commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-610223673 @blueorangutan package This is an automated message from the Apache Git Service. To res

[GitHub] [cloudstack] DaanHoogland commented on issue #3969: Snapshot deletion issues

2020-04-07 Thread GitBox
DaanHoogland commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-610223450 @GabrielBrascher @andrijapanicsb (@harikrishna-patnala ) that last commit seems to be a state never tested. I don't think the code allows or should allo

[GitHub] [cloudstack] DaanHoogland commented on issue #3969: Snapshot deletion issues

2020-04-06 Thread GitBox
DaanHoogland commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-60593 @blueorangutan package This is an automated message from the Apache Git Service. To res

[GitHub] [cloudstack] DaanHoogland commented on issue #3969: Snapshot deletion issues

2020-04-06 Thread GitBox
DaanHoogland commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-60763 yes should be !=, tnx (it's late) This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] DaanHoogland commented on issue #3969: Snapshot deletion issues

2020-04-06 Thread GitBox
DaanHoogland commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-609963113 @blueorangutan package This is an automated message from the Apache Git Service. To res

[GitHub] [cloudstack] DaanHoogland commented on issue #3969: Snapshot deletion issues

2020-04-06 Thread GitBox
DaanHoogland commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-609730934 @blueorangutan test This is an automated message from the Apache Git Service. To respon

[GitHub] [cloudstack] DaanHoogland commented on issue #3969: Snapshot deletion issues

2020-04-06 Thread GitBox
DaanHoogland commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-609721773 @blueorangutan package This is an automated message from the Apache Git Service. To res

[GitHub] [cloudstack] DaanHoogland commented on issue #3969: Snapshot deletion issues

2020-03-18 Thread GitBox
DaanHoogland commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-600489931 @blueorangutan test matrix This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] DaanHoogland commented on issue #3969: Snapshot deletion issues

2020-03-17 Thread GitBox
DaanHoogland commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-600174457 @blueorangutan package This is an automated message from the Apache Git Service. To res

[GitHub] [cloudstack] DaanHoogland commented on issue #3969: Snapshot deletion issues

2020-03-16 Thread GitBox
DaanHoogland commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-599630656 @blueorangutan package This is an automated message from the Apache Git Service. To res

[GitHub] [cloudstack] DaanHoogland commented on issue #3969: Snapshot deletion issues

2020-03-16 Thread GitBox
DaanHoogland commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-599576442 @blueorangutan package This is an automated message from the Apache Git Service. To res

[GitHub] [cloudstack] DaanHoogland commented on issue #3969: Snapshot deletion issues

2020-03-16 Thread GitBox
DaanHoogland commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-599556425 using KVM/NFS, I tested this scenario: 1. created VM with data disk 2. both disks snapshotted 3. both deleted 4. both marked deleted in t

[GitHub] [cloudstack] DaanHoogland commented on issue #3969: Snapshot deletion issues

2020-03-16 Thread GitBox
DaanHoogland commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-599542351 @blueorangutan package This is an automated message from the Apache Git Service. To res