[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-03-18 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-600847619 @blueorangutan package This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-03-23 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-602768635 Not good (still testing a few more scenarios and will update this comment once done): ## XENSERVER (7.1): ### snapshot.backup.to.seconda

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-03-30 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-606064729 So - yes, when using KVM+NFS and snapshot.backup.to.secondary=false - there is all kind of mess with snapshots happening - both in 4.11.3 and in maste

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-03-30 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-606101797 I proposed that we continue/merge this PR as it is (I want to confirm a few more things with testing, specifically that VMware is still not affected)

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-03-30 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-606129284 @blueorangutan test matrix This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-01 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-607219803 @blueorangutan package This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-01 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-607319803 when NOT backing up the snap to secondary - the snap fails to be deleteddamn it 😢 2020-04-01 15:29:22,117 DEBUG [c.c.a.ApiServlet] (qtp50

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-01 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-607322344 I've made other extensive tests and everything works fine when snapshot.backup.to.secondary=TRUE - including GC on the snapshot_store_ref table.

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-04 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-609044924 @blueorangutan test This is an automated message from the Apache Git Service. To resp

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-06 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-609950065 Latest testing of the deletion stuff reports below (previously I have tested normal operations works fine - convert to this to that, revert (KV

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-06 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-610018095 Tested the latest commit - to confirm proper logging: ## snapshot.backup.to.secondary=TRUE ### Normal case - 2 rows present, for both IMAGE/P

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-06 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-610019986 not gonna run ANY test or package rebuild after the last commit - a single word was changed in the comment/logging (from "backup" to "secondary") ---

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-07 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-610296032 (will wait for test matrix to finish) This is an automated message from the Apache Gi

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-07 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-610295953 @GabrielBrascher @DaanHoogland I've tested deleting the snaps while SSVM was destroyed - indeed the delete action is "successful" but the file is left

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-08 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-610827367 XS test that needs investigation: 2020-04-07 16:45:40,456 - CRITICAL - EXCEPTION: test_03_list_snapshots: ['Traceback (most recent call last):\

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-08 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-611252468 @blueorangutan test centos7 vmware-67u3 This is an automated message from the Apache

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-09 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-611587549 @blueorangutan package This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-09 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-611681037 So it does @Slair1 ... This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-09 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-611688138 Ape, do your thing! @blueorangutan test matrix This is an automated message from the

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-09 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-611703714 @Slair1 I can't, I'm off as from 10min ago (late night, time for beer) - perhaps @DaanHoogland can confirm once more tomorrow ---

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-09 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-611704299 Is this for volume or VM snapshots @Slair1 ? - as volume snapshots are NOT possible for KVM while the VM is running (someone thought that's interestin

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-10 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-612005865 @blueorangutan test centos7 xenserver-71 This is an automated message from the Apache

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-10 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-612006447 @blueorangutan test This is an automated message from the Apache Git Service. To resp

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-13 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-613054117 I don't see it myself, despite @DaanHoogland confirming the commit being present in 4.13 branch... Some regression by someone? -

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-13 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-613055232 but you can test 4.13.1 RC1 and see if VMs are suspended as expected - perhaps some parts of the code were refractored or so...

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-13 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-613081297 Agree, it's gone/messed up (trying to understand what happened with some of my colleagues who are good with git) - some code refactoring happened betw

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-13 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-613085691 @Slair1 do you mind creating a PR for MASTER (not 4.13 - we already have RC1 for vote today) to add back those few lines... it's incredible - the glob

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-13 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-613090734 @Slair1 - the bug you shared (RHEL bug), was marked as WON'T FIX - and was raised against qemu-kvm-0.12.1.2-2.355.el6_4.1.x86_64 Can you please

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-14 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-613612963 Clear, I did a bit of reading myself. Say, what about corruption when creating snapshots? - in recent qemu releases (2.10) qemu-img actually opens qc

[GitHub] [cloudstack] andrijapanicsb commented on issue #3969: Snapshot deletion issues

2020-04-14 Thread GitBox
andrijapanicsb commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-613655243 tested, confirmed the issue with latest centos7 host (centos5.5 ext3 guest - simulated high IO load while deleting the snap and broke the VM) R