[GitHub] [cloudstack] harikrishna-patnala commented on issue #3969: Snapshot deletion issues

2020-04-03 Thread GitBox
harikrishna-patnala commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-608490677 Have seen couple of issues when handling deletesnapshot for snapshots backed up only in primary storage and snapshots backed up in secondary stor

[GitHub] [cloudstack] harikrishna-patnala commented on issue #3969: Snapshot deletion issues

2020-04-03 Thread GitBox
harikrishna-patnala commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-608618008 > @harikrishna-patnala thanks for sharing that commit. Can you please share a branch with that commit? > > The access issue is due to the

[GitHub] [cloudstack] harikrishna-patnala commented on issue #3969: Snapshot deletion issues

2020-04-06 Thread GitBox
harikrishna-patnala commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-609734614 Code changes on the last commit from @DaanHoogland looks good to me. This is an

[GitHub] [cloudstack] harikrishna-patnala commented on issue #3969: Snapshot deletion issues

2020-04-07 Thread GitBox
harikrishna-patnala commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-610234553 > @GabrielBrascher @andrijapanicsb (@harikrishna-patnala ) that last commit seems to be a state never tested. I don't think the code allows or sh

[GitHub] [cloudstack] harikrishna-patnala commented on issue #3969: Snapshot deletion issues

2020-04-07 Thread GitBox
harikrishna-patnala commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-610311500 Based on the last testing that I have done and @andrijapanicsb's test results this is in good shape now. LGTM ---