[GitHub] [cloudstack] ravening commented on pull request #4259: Reserve memory for host

2022-04-25 Thread GitBox
ravening commented on PR #4259: URL: https://github.com/apache/cloudstack/pull/4259#issuecomment-1108497351 > Sorry dhslove - my bad, the bot is picking wrong PR author, it was meant for @ravening @rohityadavcloud fixed it -- This is an automated message from the Apache Git Service

[GitHub] [cloudstack] ravening commented on pull request #4259: Reserve memory for host

2022-04-11 Thread GitBox
ravening commented on PR #4259: URL: https://github.com/apache/cloudstack/pull/4259#issuecomment-1095105948 @nvazquez @DaanHoogland @weizhouapache please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [cloudstack] ravening commented on pull request #4259: Reserve memory for host

2021-09-29 Thread GitBox
ravening commented on pull request #4259: URL: https://github.com/apache/cloudstack/pull/4259#issuecomment-930017408 > @ravening did you look at the other code? is it aligned with yours? conflicts are a sometimes sign that one of the functionalities should go in another module. @Daa

[GitHub] [cloudstack] ravening commented on pull request #4259: Reserve memory for host

2021-09-29 Thread GitBox
ravening commented on pull request #4259: URL: https://github.com/apache/cloudstack/pull/4259#issuecomment-930017408 > @ravening did you look at the other code? is it aligned with yours? conflicts are a sometimes sign that one of the functionalities should go in another module. @Daa

[GitHub] [cloudstack] ravening commented on pull request #4259: Reserve memory for host

2021-09-21 Thread GitBox
ravening commented on pull request #4259: URL: https://github.com/apache/cloudstack/pull/4259#issuecomment-923770784 > again a conflict @ravening :( > again a conflict @ravening :( @DaanHoogland i will wait for few more days before resolving conflicts... i have resolve

[GitHub] [cloudstack] ravening commented on pull request #4259: Reserve memory for host

2021-09-15 Thread GitBox
ravening commented on pull request #4259: URL: https://github.com/apache/cloudstack/pull/4259#issuecomment-919904946 @weizhouapache @nvazquez reorganized the imports -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack] ravening commented on pull request #4259: Reserve memory for host

2021-09-14 Thread GitBox
ravening commented on pull request #4259: URL: https://github.com/apache/cloudstack/pull/4259#issuecomment-918884859 @rhtyd @sureshanaparti done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cloudstack] ravening commented on pull request #4259: Reserve memory for host

2021-01-26 Thread GitBox
ravening commented on pull request #4259: URL: https://github.com/apache/cloudstack/pull/4259#issuecomment-767481784 > @ravening Conflicts here too. Moving to 4.16.0.0 milestone based on base branch please update if needed @shwstppr resolved the conflicts --

[GitHub] [cloudstack] ravening commented on pull request #4259: Reserve memory for host

2020-09-29 Thread GitBox
ravening commented on pull request #4259: URL: https://github.com/apache/cloudstack/pull/4259#issuecomment-700512488 > @ravening if you read again, I said the setting `host.reserved.mem.mb` exists in `agent.properties` and read by the KVM agent (you're right the `LibvirtComputingResource`)

[GitHub] [cloudstack] ravening commented on pull request #4259: Reserve memory for host

2020-09-23 Thread GitBox
ravening commented on pull request #4259: URL: https://github.com/apache/cloudstack/pull/4259#issuecomment-697190678 > host.reserved.mem.mb @rhtyd I just checked the code and the global setting does not exist. The value `host.reserved.mem.mb` is only checked in `plugins/hypervisors/

[GitHub] [cloudstack] ravening commented on pull request #4259: Reserve memory for host

2020-08-27 Thread GitBox
ravening commented on pull request #4259: URL: https://github.com/apache/cloudstack/pull/4259#issuecomment-681842735 > @ravening is this ready? can you please fix the conflict updated pr This is an automated message fr