rhtyd commented on a change in pull request #4557:
URL: https://github.com/apache/cloudstack/pull/4557#discussion_r547312866
##########
File path:
vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java
##########
@@ -1073,6 +1073,10 @@ public static VMwareDVSPvlanConfigSpec
createDVPortPvlanConfigSpec(int vlanId, i
}
public static VmwareDistributedVirtualSwitchVlanSpec
createDVPortVlanSpec(Integer vlanId, String vlanRange) {
+ if (vlanId != null && vlanId == 4095){
+ vlanId = null;
+ vlanRange = "0-4094";
+ }
Review comment:
@DaanHoogland Yes the 4095 vlan ID is used a magic no. to create a
trunked port group; this already exists for other hypervisors like kvm -
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Enable+vlan+4095+%27tag+passthrough%27+for+KVM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
