[GitHub] [cloudstack] rhtyd commented on issue #3870: systemvm: list systemvm does not return agent state and version

2020-02-06 Thread GitBox
rhtyd commented on issue #3870: systemvm: list systemvm does not return agent state and version URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583259389 @blueorangutan package This is an automated message fr

[GitHub] [cloudstack] rhtyd commented on issue #3870: systemvm: list systemvm does not return agent state and version

2020-02-06 Thread GitBox
rhtyd commented on issue #3870: systemvm: list systemvm does not return agent state and version URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583266003 @blueorangutan test This is an automated message from

[GitHub] [cloudstack] rhtyd commented on issue #3870: systemvm: list systemvm does not return agent state and version

2020-02-06 Thread GitBox
rhtyd commented on issue #3870: systemvm: list systemvm does not return agent state and version URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583266312 @shwstppr @Pearl1594 please review as well. This is an

[GitHub] [cloudstack] rhtyd commented on issue #3870: systemvm: list systemvm does not return agent state and version

2020-02-07 Thread GitBox
rhtyd commented on issue #3870: systemvm: list systemvm does not return agent state and version URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583287665 @DaanHoogland the technical preview targets 4.14, without this fix the implementation in Primate would be complicated.

[GitHub] [cloudstack] rhtyd commented on issue #3870: systemvm: list systemvm does not return agent state and version

2020-02-07 Thread GitBox
rhtyd commented on issue #3870: systemvm: list systemvm does not return agent state and version URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583289113 That's not very critical, but let me check if it's a quick one. I originally wanted to limit the scope just to apis, wr

[GitHub] [cloudstack] rhtyd commented on issue #3870: systemvm: list systemvm does not return agent state and version

2020-02-07 Thread GitBox
rhtyd commented on issue #3870: systemvm: list systemvm does not return agent state and version URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583318262 @shwstppr thanks, fixed the `since` in params response keys. @weizhouapache I've fixed the UI as well. Can you review

[GitHub] [cloudstack] rhtyd commented on issue #3870: systemvm: list systemvm does not return agent state and version

2020-02-07 Thread GitBox
rhtyd commented on issue #3870: systemvm: list systemvm does not return agent state and version URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583318536 Thanks @DaanHoogland will merge after smoketests and some UI confirmation (cc @weizhouapache) @blueorangutan package

[GitHub] [cloudstack] rhtyd commented on issue #3870: systemvm: list systemvm does not return agent state and version

2020-02-07 Thread GitBox
rhtyd commented on issue #3870: systemvm: list systemvm does not return agent state and version URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583358422 @weizhouapache cc @DaanHoogland I used the same logic as here: https://github.com/apache/cloudstack/blob/master/server/