[GitHub] [cloudstack] rhtyd commented on pull request #4004: Fixed null pointer and deployment issue on Xenserver with L2 Guest network with configDrive

2020-06-22 Thread GitBox
rhtyd commented on pull request #4004: URL: https://github.com/apache/cloudstack/pull/4004#issuecomment-647945923 Discussed with @Pearl1594, the operations for config drive are only consumed on the default nics; in case of multiple nics there won't be any regressions.

[GitHub] [cloudstack] rhtyd commented on pull request #4004: Fixed null pointer and deployment issue on Xenserver with L2 Guest network with configDrive

2020-06-15 Thread GitBox
rhtyd commented on pull request #4004: URL: https://github.com/apache/cloudstack/pull/4004#issuecomment-644527926 @borisstoyanov per your testing is this ready to be merged, or needs further testing, the case of multiple nics per Daan's comment? ---

[GitHub] [cloudstack] rhtyd commented on pull request #4004: Fixed null pointer and deployment issue on Xenserver with L2 Guest network with configDrive

2020-06-15 Thread GitBox
rhtyd commented on pull request #4004: URL: https://github.com/apache/cloudstack/pull/4004#issuecomment-643959743 @Spaceman1984 cc @nvazquez please advise, if you've tested then we can merge this This is an automated message

[GitHub] [cloudstack] rhtyd commented on pull request #4004: Fixed null pointer and deployment issue on Xenserver with L2 Guest network with configDrive

2020-06-13 Thread GitBox
rhtyd commented on pull request #4004: URL: https://github.com/apache/cloudstack/pull/4004#issuecomment-643686052 @blueorangutan test centos7 xenserver-71 This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] rhtyd commented on pull request #4004: Fixed null pointer and deployment issue on Xenserver with L2 Guest network with configDrive

2020-06-12 Thread GitBox
rhtyd commented on pull request #4004: URL: https://github.com/apache/cloudstack/pull/4004#issuecomment-643532132 @blueorangutan test centos7 xenserver-71 This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] rhtyd commented on pull request #4004: Fixed null pointer and deployment issue on Xenserver with L2 Guest network with configDrive

2020-06-11 Thread GitBox
rhtyd commented on pull request #4004: URL: https://github.com/apache/cloudstack/pull/4004#issuecomment-643063124 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [cloudstack] rhtyd commented on pull request #4004: Fixed null pointer and deployment issue on Xenserver with L2 Guest network with configDrive

2020-06-03 Thread GitBox
rhtyd commented on pull request #4004: URL: https://github.com/apache/cloudstack/pull/4004#issuecomment-638564451 @DaanHoogland can you review this? Thanks (I'm not following this) This is an automated message from the Apache