[GitHub] GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:"

2018-05-09 Thread GitBox
GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:" URL: https://github.com/apache/cloudstack/issues/2540#issuecomment-387850759 Yes @rhtyd, I will take a look to fix it.

[GitHub] GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:"

2018-05-10 Thread GitBox
GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:" URL: https://github.com/apache/cloudstack/issues/2540#issuecomment-388131599 @covalle1428, removing the conditional as @mdesaive showed is an emergency fix

[GitHub] GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:"

2018-05-11 Thread GitBox
GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:" URL: https://github.com/apache/cloudstack/issues/2540#issuecomment-388445385 @covalle1428 if you intend to do an urgent fix, you can follow a few steps.

[GitHub] GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:"

2018-05-15 Thread GitBox
GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:" URL: https://github.com/apache/cloudstack/issues/2540#issuecomment-389201257 I would like to avoid the solution that just removes the conditional. What do

[GitHub] GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:"

2018-05-16 Thread GitBox
GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:" URL: https://github.com/apache/cloudstack/issues/2540#issuecomment-389522200 @DaanHoogland I agree with you. Let's keep your approach (`getNextAvailableMac

[GitHub] GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:"

2018-05-17 Thread GitBox
GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:" URL: https://github.com/apache/cloudstack/issues/2540#issuecomment-389959183 Created PR [#2653](https://github.com/apache/cloudstack/pull/2653) to address

[GitHub] GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:"

2018-05-17 Thread GitBox
GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:" URL: https://github.com/apache/cloudstack/issues/2540#issuecomment-389959183 Created PR [#2653](https://github.com/apache/cloudstack/pull/2653) to address