[GitHub] rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356

2018-04-17 Thread GitBox
rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r182091684 ## File path: server/src/main/java/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java ## @@ -740,14

[GitHub] rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356

2018-04-16 Thread GitBox
rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r181790641 ## File path: engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDaoImpl.java ## @@ -126,8 +126,10

[GitHub] rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356

2018-04-16 Thread GitBox
rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r181789714 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java ##

[GitHub] rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356

2018-04-16 Thread GitBox
rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r181783355 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java ##

[GitHub] rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356

2018-04-16 Thread GitBox
rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r181777342 ## File path: engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDaoImpl.java ## @@ -126,8 +126,10

[GitHub] rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356

2018-04-16 Thread GitBox
rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r181776039 ## File path: engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDaoImpl.java ## @@ -126,8 +126,10

[GitHub] rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356

2018-04-16 Thread GitBox
rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r181775760 ## File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java ##

[GitHub] rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356

2018-04-16 Thread GitBox
rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r181747454 ## File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java ##

[GitHub] rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356

2018-04-16 Thread GitBox
rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r181748734 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ## @@ -2139,14

[GitHub] rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356

2018-04-16 Thread GitBox
rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r181748253 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java ##

[GitHub] rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356

2018-04-16 Thread GitBox
rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r181748304 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java ##

[GitHub] rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356

2018-04-16 Thread GitBox
rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r181748782 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ## @@ -2139,14

[GitHub] rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356

2018-04-16 Thread GitBox
rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r181748841 ## File path: server/src/main/java/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java ## @@ -740,14

[GitHub] rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356

2018-04-16 Thread GitBox
rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r181748053 ## File path: plugins/deployment-planners/implicit-dedication/src/main/java/com/cloud/deploy/ImplicitDedicationPlanner.java

[GitHub] rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356

2018-04-16 Thread GitBox
rafaelweingartner commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r181747775 ## File path: engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDaoImpl.java ## @@ -126,8 +126,10