[GitHub] rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor…

2018-08-13 Thread GitBox
rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor… URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-412713958 > As far as I know, if you migrate a volume from one primary storage to another, there should never

[GitHub] rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor…

2018-08-13 Thread GitBox
rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor… URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-412675884 Hello Mike, I am not able to reproduce the problem you described. I do think though that the code ca

[GitHub] rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor…

2018-08-11 Thread GitBox
rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor… URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-412284787 Ok, so what this means is that the author when creating the PR used the `snapshotSrv.deleteSnapshot`

[GitHub] rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor…

2018-08-11 Thread GitBox
rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor… URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-412283529 Thanks for your details @mike-tutkowski. Can you help me understand where the problem is? Is

[GitHub] rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor…

2018-08-09 Thread GitBox
rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor… URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-411917970 You are right. That code seems to be the other way around. I mean, we should clean when there is a f

[GitHub] rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor…

2018-08-09 Thread GitBox
rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor… URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-411901840 @mike-tutkowski are you sure this problem is caused by this PR? I mean, can you check the code he

[GitHub] rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor?

2018-01-03 Thread GitBox
rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor? URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-355092544 @rhtyd I tested this fix in my dev environment and it solved the described problem. I think this

[GitHub] rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor?

2017-12-25 Thread GitBox
rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor? URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-353858935 @yvsubhash you are right... My problem is not related to this one here. The snapshots in XenServer i

[GitHub] rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor?

2017-12-19 Thread GitBox
rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor? URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-352927548 I have the same doubt as @syed here. > Why is it expected that latest snapshot be present on t

[GitHub] rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor?

2017-12-19 Thread GitBox
rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor? URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-352927548 I have the same doubt as @syed here. > Why is it expected that latest snapshot be present on t