[GitHub] rafaelweingartner commented on issue #2283: CLOUDSTACK-10105: Maven standard

2017-11-22 Thread GitBox
rafaelweingartner commented on issue #2283: CLOUDSTACK-10105: Maven standard URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-346314723 @marcaurele from me you have an LGTM This is an automated message from the

[GitHub] rafaelweingartner commented on issue #2283: CLOUDSTACK-10105: Maven standard

2017-11-30 Thread GitBox
rafaelweingartner commented on issue #2283: CLOUDSTACK-10105: Maven standard URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-348332862 @rhtyd, @marcaurele, and @khos2ow I have been thinking about this PR and #2343, which focus on changing ACS code base to use current standa

[GitHub] rafaelweingartner commented on issue #2283: CLOUDSTACK-10105: Maven standard

2018-01-16 Thread GitBox
rafaelweingartner commented on issue #2283: CLOUDSTACK-10105: Maven standard URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-357927214 @marcaurele I believe it might be a good idea to ask others to look into this one before we start merging again... ---

[GitHub] rafaelweingartner commented on issue #2283: CLOUDSTACK-10105: Maven standard

2018-01-16 Thread GitBox
rafaelweingartner commented on issue #2283: CLOUDSTACK-10105: Maven standard URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-357979560 me too... This is an automated message from the Apache Git Service. To res

[GitHub] rafaelweingartner commented on issue #2283: CLOUDSTACK-10105: Maven standard

2018-01-17 Thread GitBox
rafaelweingartner commented on issue #2283: CLOUDSTACK-10105: Maven standard URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-358245330 @marcaurele please do the honors and merge this one P.S. you are going to generate conflicts in my PRs :( --

[GitHub] rafaelweingartner commented on issue #2283: CLOUDSTACK-10105: Maven standard

2018-01-19 Thread GitBox
rafaelweingartner commented on issue #2283: CLOUDSTACK-10105: Maven standard URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-358947492 @marcaurele any plan to execute this merge? This is an automated message f

[GitHub] rafaelweingartner commented on issue #2283: CLOUDSTACK-10105: Maven standard

2018-01-19 Thread GitBox
rafaelweingartner commented on issue #2283: CLOUDSTACK-10105: Maven standard URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-358948196 I saw it. My question was actually "considering that the tests finished successfully", will this be merged today? Or maybe we have somethin

[GitHub] rafaelweingartner commented on issue #2283: CLOUDSTACK-10105: Maven standard

2018-01-19 Thread GitBox
rafaelweingartner commented on issue #2283: CLOUDSTACK-10105: Maven standard URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-359110019 @rhtyd what are these "merge 4.11" that are appearing in our commit history? --

[GitHub] rafaelweingartner commented on issue #2283: CLOUDSTACK-10105: Maven standard

2018-01-19 Thread GitBox
rafaelweingartner commented on issue #2283: CLOUDSTACK-10105: Maven standard URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-359111435 hmm... Are you doing via Github the merge forward? I was under the impression that our merge forward script would provide a bit of detai

[GitHub] rafaelweingartner commented on issue #2283: CLOUDSTACK-10105: Maven standard

2018-01-19 Thread GitBox
rafaelweingartner commented on issue #2283: CLOUDSTACK-10105: Maven standard URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-359115827 Normally, whenever merging forward I use `https://github.com/apache/cloudstack/blob/master/tools/git/git-fwd-merge`. This script creates c