[GitHub] rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command

rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-366800251 Since everything is ok, I will merge this one. Let's see if I still know how to do it :) ---

[GitHub] rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command

rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-366798899 @mike-tutkowski thanks! I am getting used to look directly to the "reviweres" section on Github and c

[GitHub] rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command

rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-366796206 reviewers (@DaanHoogland, @mike-tutkowski, @rhtyd ) what is your positions here? It seems that the tests

[GitHub] rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command

rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-359613929 @rhtyd I noticed that you changed the base branch for this PR, from master to 4.11. Do you want me to op

[GitHub] rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command

rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-357555819 Hmm..I am inclined to follow Daan's opinion on this one. It is a bug for sure, but it is a very specific

[GitHub] rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command

rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-357195152 @rhtyd the build issues were already fixed. You started your packing with my first commit here, and ther

[GitHub] rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command

rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-357004830 @mike-tutkowski Welcome! I should thank you for the help ;) Travis is failing, but I have not y

[GitHub] rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command

rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-356922299 Ah ok. Thanks for the feedback. I will leave the PR open, so we can work on it after 4.11 --

[GitHub] rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command

rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-356919058 Hmm, that is a good question. This affects only XenServers and the case that is broken is the followi

[GitHub] rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command

rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-356916761 @DaanHoogland, @rhtyd, and @mike-tutkowski can you review these changes? I believe that the problem de