[GitHub] rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283

2018-01-23 Thread GitBox
rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359748015 Sure, do you wait before merging? This is an automated message from

[GitHub] rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283

2018-01-23 Thread GitBox
rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359746549 @rhtyd, @DaanHoogland is this one ready to be merge? Or is the error that is presented here is something that I should take a look at?

[GitHub] rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283

2018-01-22 Thread GitBox
rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359489817 just to make it clear here. @marcaurele is not going to open a PR to this branch. His changes will be introduced in a specific PR to

[GitHub] rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283

2018-01-22 Thread GitBox
rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359419386 Sure, no problem. Is there something else missing? This is an

[GitHub] rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283

2018-01-22 Thread GitBox
rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359391244 What can I tell you then? Can you open the class

[GitHub] rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283

2018-01-22 Thread GitBox
rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359391244 What can I tell you then? Can you open the class

[GitHub] rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283

2018-01-22 Thread GitBox
rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359385351 @DaanHoogland, I have tested running these in two different systems: System one: Apache Maven 3.3.9

[GitHub] rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283

2018-01-22 Thread GitBox
rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359382791 @marcaurele I was surprised as well. Not just the compilation that passed, but the tests that were executed. And it was not just about