[GitHub] rafaelweingartner commented on issue #2428: CLOUDSTACK-10253: JSON response for SuccessResponse as boolean instead of string

2018-02-22 Thread GitBox
rafaelweingartner commented on issue #2428: CLOUDSTACK-10253: JSON response for SuccessResponse as boolean instead of string URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-367852746 @marcaurele there are some tests using an assert with a string `'true'`, and not a Boolean

[GitHub] rafaelweingartner commented on issue #2428: CLOUDSTACK-10253: JSON response for SuccessResponse as boolean instead of string

2018-04-27 Thread GitBox
rafaelweingartner commented on issue #2428: CLOUDSTACK-10253: JSON response for SuccessResponse as boolean instead of string URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-384975704 @marcaurele do we need to execute Marvin tests again? I was under the impression that te

[GitHub] rafaelweingartner commented on issue #2428: CLOUDSTACK-10253: JSON response for SuccessResponse as boolean instead of string

2018-04-27 Thread GitBox
rafaelweingartner commented on issue #2428: CLOUDSTACK-10253: JSON response for SuccessResponse as boolean instead of string URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-384979936 Only the ShapeBlue guys have access to that system. I think testes were not even started.

[GitHub] rafaelweingartner commented on issue #2428: CLOUDSTACK-10253: JSON response for SuccessResponse as boolean instead of string

2018-04-27 Thread GitBox
rafaelweingartner commented on issue #2428: CLOUDSTACK-10253: JSON response for SuccessResponse as boolean instead of string URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-384984395 You can try to rebase. However, this test seems to be one of those "unit tests" that peopl

[GitHub] rafaelweingartner commented on issue #2428: CLOUDSTACK-10253: JSON response for SuccessResponse as boolean instead of string

2018-04-27 Thread GitBox
rafaelweingartner commented on issue #2428: CLOUDSTACK-10253: JSON response for SuccessResponse as boolean instead of string URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-385104976 I think so. Let's see if Jenkins goes green. -

[GitHub] rafaelweingartner commented on issue #2428: CLOUDSTACK-10253: JSON response for SuccessResponse as boolean instead of string

2018-04-27 Thread GitBox
rafaelweingartner commented on issue #2428: CLOUDSTACK-10253: JSON response for SuccessResponse as boolean instead of string URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-385104976 I think so. Let's see if Jenkins goes green first. ---

[GitHub] rafaelweingartner commented on issue #2428: CLOUDSTACK-10253: JSON response for SuccessResponse as boolean instead of string

2018-04-27 Thread GitBox
rafaelweingartner commented on issue #2428: CLOUDSTACK-10253: JSON response for SuccessResponse as boolean instead of string URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-385119892 forcing Jeninks... This i