[GitHub] rafaelweingartner commented on issue #2437: [CLOUDSTACK-10257]Create template/volume does not allow to specify HVM requirements

2018-03-01 Thread GitBox
rafaelweingartner commented on issue #2437: [CLOUDSTACK-10257]Create template/volume does not allow to specify HVM requirements URL: https://github.com/apache/cloudstack/pull/2437#issuecomment-369631095 Thanks @khos2ow. @DaanHoogland are you ok with changes introduced here?

[GitHub] rafaelweingartner commented on issue #2437: [CLOUDSTACK-10257]Create template/volume does not allow to specify HVM requirements

2018-03-01 Thread GitBox
rafaelweingartner commented on issue #2437: [CLOUDSTACK-10257]Create template/volume does not allow to specify HVM requirements URL: https://github.com/apache/cloudstack/pull/2437#issuecomment-369631095 Thanks @khos2ow. @DaanHoogland are you ok here?

[GitHub] rafaelweingartner commented on issue #2437: [CLOUDSTACK-10257]Create template/volume does not allow to specify HVM requirements

2018-02-28 Thread GitBox
rafaelweingartner commented on issue #2437: [CLOUDSTACK-10257]Create template/volume does not allow to specify HVM requirements URL: https://github.com/apache/cloudstack/pull/2437#issuecomment-369397722 @khos2ow would you mind reviewing this one? ---

[GitHub] rafaelweingartner commented on issue #2437: [CLOUDSTACK-10257]Create template/volume does not allow to specify HVM requirements

2018-01-30 Thread GitBox
rafaelweingartner commented on issue #2437: [CLOUDSTACK-10257]Create template/volume does not allow to specify HVM requirements URL: https://github.com/apache/cloudstack/pull/2437#issuecomment-361674898 This PR will create add the HVM option as illustrated in the following image. The optio

[GitHub] rafaelweingartner commented on issue #2437: [CLOUDSTACK-10257]Create template/volume does not allow to specify HVM requirements

2018-01-30 Thread GitBox
rafaelweingartner commented on issue #2437: [CLOUDSTACK-10257]Create template/volume does not allow to specify HVM requirements URL: https://github.com/apache/cloudstack/pull/2437#issuecomment-361674067 It is not as much refactoring as it is extracting duplicated code to a common method.