[GitHub] rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-03-16 Thread GitBox
rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-373656370 I think we can go forward with this PR. I notice a Flyway DB PR, but that is not all. We need a protocol to

[GitHub] rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-03-15 Thread GitBox
rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-373380723 I believe so, but we still need to find a better way technical and protocol to better manage data model changes in the

[GitHub] rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-03-07 Thread GitBox
rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-371132517 @ernjvr I would go with this one. It does not mean that I like this type of solution. It is a palliative one, and we

[GitHub] rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-02-22 Thread GitBox
rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-367838510 Folks, what are the thoughts here? use this ad-hoc approach? Work a bit harder to a more comprehensive solution using a

[GitHub] rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-02-15 Thread GitBox
rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-366023509 After this script is merged, we will have to make sure that everyone creating new scripts to alter tables must use the so

[GitHub] rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-02-15 Thread GitBox
rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-366023509 After this script is merger, we will have to enforce that everyone creating scripts to alter tables to use the so called