rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view
network ACL rules listing
URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-367846443
Two LGTMs, and as it is only a change in JavaScript there is no need for the
integration tests. I will merge this
rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view
network ACL rules listing
URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-366658774
Thanks for your review @nvazquez !
I have made the changes you suggested.
rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view
network ACL rules listing
URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-366570188
How do we proceed with this one? Will reviewers feedback be enough? No code
was changed in the server side.
rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view
network ACL rules listing
URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-365949680
Yes, it is a screen shot. I just put it there to show people how the page
will look like..
rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view
network ACL rules listing
URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-365949680
Yes, it is a screen shot. I just put it there to show people how the page
will become.
rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view
network ACL rules listing
URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-365949680
Yes, it is a screen shot. I just put there it to show people how the page
will become.
rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view
network ACL rules listing
URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-365949680
Yes, it is a screen shot. I just put it to show people how the page will
become.
