rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-332765820
Alright based on test results and LGTMs presented on this PR, I'll merge
this. If we hit regressions or error reports, we might
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-332748420
@wido can you comment on the potential NPE issue, see the code/comment?
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-332723588
Ignoring test failures on centos6, LGTM. @borisstoyanov @wido @kiwiflyer
what do you think, should we merge this PR?
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-332135336
@blueorangutan test
This is an automated message from the Apache
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-332088139
@blueorangutan test centos7 kvm-centos6
This is an automated
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-332078251
Comparing a recent smoketest result against centos6-kvm I don't see an issue
with failing tests, they are failing on the baseline
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-331349646
@wido I think Trillian may be using CentOS 6.8 for buildilng kvm hosts,
@borisstoyanov @PaulAngus can you comment?
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-330815965
@borisstoyanov can you check failures related to libvirt tests on
kvm/centos6, however those failures are not seen in kvm/centos7?
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-330501194
@blueorangutan test centos7 kvm-centos6
This is an automated
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-330486375
@wido I can run another round of testing, for comparison I'm using the #2225
test results as baseline for comparison
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329949835
@wido can you check/verify the failing libvirt tests?
This is an
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329464938
@wido @GabrielBrascher sure, I've already kicked a final test run with
Trillian and centos6 boxes; I can merge as soon as the
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329437377
@blueorangutan test centos7 kvm-centos6
This is an automated
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329430475
@blueorangutan package
This is an automated message from the
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329381439
test LGTM. @wido there is one outstanding comment, please @GabrielBrascher
's comment.
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329116972
@blueorangutan test
This is an automated message from the Apache
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329059763
@wido LGTM, I'll kick a final round of testing. Any more reviewers may
review the PR -- @nvazquez @DaanHoogland @karuturi
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-317282869
@blueorangutan test
This is an automated message from the Apache
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM
Instance
URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-317261013
@blueorangutan package
This is an automated message from the
19 matches
Mail list logo
