rhtyd commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN
customer gateway configs for same gateway IP
URL: https://github.com/apache/cloudstack/pull/2267#issuecomment-350777084
Merged based on prod test recommendation and regression test results.
--
rhtyd commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN
customer gateway configs for same gateway IP
URL: https://github.com/apache/cloudstack/pull/2267#issuecomment-343201716
@blueorangutan package
This
rhtyd commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN
customer gateway configs for same gateway IP
URL: https://github.com/apache/cloudstack/pull/2267#issuecomment-341960768
LGTM, not sure any side-effects on this change. Others may help review -
@DaanHoogland @marc
rhtyd commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN
customer gateway configs for same gateway IP
URL: https://github.com/apache/cloudstack/pull/2267#issuecomment-336123383
@resmo is that a regression of sorts, we holding this PR?
-
rhtyd commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN
customer gateway configs for same gateway IP
URL: https://github.com/apache/cloudstack/pull/2267#issuecomment-331055575
Thanks @resmo, test LGTM, additional code review is requested after which
this can be merged
rhtyd commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN
customer gateway configs for same gateway IP
URL: https://github.com/apache/cloudstack/pull/2267#issuecomment-330815830
Additional code review requested and please also see Travis failures.
-
rhtyd commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN
customer gateway configs for same gateway IP
URL: https://github.com/apache/cloudstack/pull/2267#issuecomment-330487314
@blueorangutan package
Thi
