[GitHub] rhtyd commented on issue #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMware

rhtyd commented on issue #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMware URL: https://github.com/apache/cloudstack/pull/2340#issuecomment-422342539 Test LGTM, but I think the code could be further refactored. I'm unable to find time to do that @nitin-maharana but please see parts of the

[GitHub] rhtyd commented on issue #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMware

rhtyd commented on issue #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMware URL: https://github.com/apache/cloudstack/pull/2340#issuecomment-419420575 @blueorangutan test centos7 vmware-65 This is an automated message from th

[GitHub] rhtyd commented on issue #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMware

rhtyd commented on issue #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMware URL: https://github.com/apache/cloudstack/pull/2340#issuecomment-419412763 @blueorangutan package This is an automated message from the Apache Git Se

[GitHub] rhtyd commented on issue #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMware

rhtyd commented on issue #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMware URL: https://github.com/apache/cloudstack/pull/2340#issuecomment-412791998 @nitin-maharana can you rebase against latest master, thanks. This

[GitHub] rhtyd commented on issue #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMware

rhtyd commented on issue #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMware URL: https://github.com/apache/cloudstack/pull/2340#issuecomment-411304525 @nitin-maharana can you rebase against latest master, thanks. This is an a

[GitHub] rhtyd commented on issue #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMware

rhtyd commented on issue #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMware URL: https://github.com/apache/cloudstack/pull/2340#issuecomment-353930286 @nitin-maharana I've left some remarks and I feel the code may be further refactored, thanks.

[GitHub] rhtyd commented on issue #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMware

rhtyd commented on issue #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMware URL: https://github.com/apache/cloudstack/pull/2340#issuecomment-353080606 Re-review requested. @blueorangutan package This is an automated messag

[GitHub] rhtyd commented on issue #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMWare

rhtyd commented on issue #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMWare URL: https://github.com/apache/cloudstack/pull/2340#issuecomment-352662115 @nitin-maharana can you address outstanding comments, then I can initiate testing for your PR. ---

[GitHub] rhtyd commented on issue #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMWare

rhtyd commented on issue #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMWare URL: https://github.com/apache/cloudstack/pull/2340#issuecomment-352662115 @nitin-maharana can you address outstanding comments, then I can initiate testing for you. ---