[GitHub] rhtyd commented on issue #2381: CLOUDSTACK-10117 Account ldap binding

2018-01-06 Thread GitBox
rhtyd commented on issue #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#issuecomment-355761762 Test LGTM, the one failure is env related. Merging this based on two code review lgtms and test results. --

[GitHub] rhtyd commented on issue #2381: CLOUDSTACK-10117 Account ldap binding

2018-01-05 Thread GitBox
rhtyd commented on issue #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#issuecomment-355537464 @blueorangutan test This is an automated message from the Apache Git Service. To

[GitHub] rhtyd commented on issue #2381: CLOUDSTACK-10117 Account ldap binding

2018-01-04 Thread GitBox
rhtyd commented on issue #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#issuecomment-355228042 @DaanHoogland looks like we've new conflicts, please fix them This is an automate

[GitHub] rhtyd commented on issue #2381: CLOUDSTACK-10117 Account ldap binding

2018-01-03 Thread GitBox
rhtyd commented on issue #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#issuecomment-355213223 Tests LGTM - `Smoke tests completed. 66 look OK, 0 have error(s)` Additional review requested - @nvazquez @borisstoyanov @rafaelweingartner @wi