rhtyd opened a new pull request #2979: vr: defer was broken in VR because of json name change URL: https://github.com/apache/cloudstack/pull/2979 After upgrade from CS 4.10 to CS 4.11, multiple VRs did not start through. It did not properly defer the finalize config in update_config.py. Apparently, the json files are now called differently: where it used to be vm_dhcp_entry.json it now has a uuid added, for example vm_metadata.json.4d727b6e-2b48-49df-81c3-b8532f3d6745. The if statement that checks if the finalize can be safely deferred therefore no longer matches. This PR contains a fix so finalize is defered again. Rohit: I made a boo-boo by force pushing and trying to rebash on @RPDiep 's repo/branch. Submitting his commit on his behalf against 4.11 branch. Sorry @RPDiep /cc @wido. ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
