BryanMLima commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2167950272
> @BryanMLima shouldn't we need to run smoketests on the PR, or do we think
they were covered by GHA/simulator smoketests?
@rohityadavcloud, the smoke tests were already run
rohityadavcloud commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2167357934
@BryanMLima shouldn't we need to run smoketests on the PR, or do we think
they were covered by GHA/simulator smoketests?
--
This is an automated message from the Apache Git
BryanMLima merged PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
BryanMLima commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2166648210
Merging this one based on reviews and manual tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
blueorangutan commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2163750397
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
blueorangutan commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2163630337
@BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
BryanMLima commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2163628305
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
BryanMLima closed pull request #8372: [Quota] Add API to list preset variables
URL: https://github.com/apache/cloudstack/pull/8372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
blueorangutan commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2138172862
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
blueorangutan commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2138053546
@BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
BryanMLima commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2138051406
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
BryanMLima opened a new pull request, #8372:
URL: https://github.com/apache/cloudstack/pull/8372
### Description
This PR extends the functionality introduced in PR #5909, allowing users to
list the preset variables via API, facilitating the creation of the activation
rules while
DaanHoogland closed pull request #8372: [Quota] Add API to list preset variables
URL: https://github.com/apache/cloudstack/pull/8372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
BryanMLima commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2135199283
@bernardodemarco, thanks for testing it.
> @BryanMLima will you apply @bernardodemarco 's sugestion [#8372
DaanHoogland commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2134508800
@BryanMLima will you apply @bernardodemarco 's sugestion
https://github.com/apache/cloudstack/pull/8372#discussion_r1616409198 , or can
we merge as is?
Also, @BryanMLima
bernardodemarco commented on code in PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#discussion_r1616409198
##
framework/quota/src/main/java/org/apache/cloudstack/quota/activationrule/presetvariables/Value.java:
##
@@ -23,25 +23,75 @@
import
blueorangutan commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2067146592
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
blueorangutan commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2067028881
@BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
BryanMLima commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2067027893
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
github-actions[bot] commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2003895988
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache
blueorangutan commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-1971709919
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
blueorangutan commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-1971612590
@BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
BryanMLima commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-1971610519
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
blueorangutan commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-1936849088
[SF] Trillian test result (tid-9148)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41759 seconds
Marvin logs:
blueorangutan commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-1936189551
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7)
has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To
DaanHoogland commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-1936187112
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
blueorangutan commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-1934291387
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
blueorangutan commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-1934160148
@BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
BryanMLima commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-1934159524
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
github-actions[bot] commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-1934110503
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache
blueorangutan commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-1906612149
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
blueorangutan commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-1906487901
@BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
BryanMLima commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-1906485099
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
BryanMLima commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-1906484675
> clgtm, and lots of test. Just a thought; an integration test seems
appropriate for such a profoundly user facing feature, would you say
@BryanMLima ?
@DaanHoogland, got
blueorangutan commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-1869170367
[SF] Trillian test result (tid-8680)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42187 seconds
Marvin logs:
blueorangutan commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-1868966158
@sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt +
kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
sureshanaparti commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-1868965628
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
blueorangutan commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-1868944790
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
blueorangutan commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-1868920251
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It
will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep
you posted as I make
sureshanaparti commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-1868919826
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
sureshanaparti commented on code in PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#discussion_r1431434349
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/response/QuotaPresetVariablesItemResponse.java:
##
@@ -0,0 +1,47 @@
+//Licensed to the
codecov[bot] commented on PR #8372:
URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-1860832271
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8372?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
All
BryanMLima opened a new pull request, #8372:
URL: https://github.com/apache/cloudstack/pull/8372
### Description
This PR extends the functionality introduced in PR #5909, allowing users to
list the preset variables via API, facilitating the creation of the activation
rules while
43 matches
Mail list logo
