Re: [PR] Allow listing of inactive offerings [cloudstack]

2024-04-04 Thread via GitHub
DaanHoogland commented on PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#issuecomment-2036962708 for the error message issue see #8882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Allow listing of inactive offerings [cloudstack]

2024-04-04 Thread via GitHub
DaanHoogland merged PR #8821: URL: https://github.com/apache/cloudstack/pull/8821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

Re: [PR] Allow listing of inactive offerings [cloudstack]

2024-03-30 Thread via GitHub
vishesh92 commented on code in PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#discussion_r1545318677 ## ui/src/config/section/offering.js: ## @@ -89,15 +90,33 @@ export default { dataView: true, popup: true, component: shallowRef(defineA

Re: [PR] Allow listing of inactive offerings [cloudstack]

2024-03-29 Thread via GitHub
DaanHoogland commented on code in PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#discussion_r1544650804 ## ui/src/config/section/offering.js: ## @@ -89,15 +90,33 @@ export default { dataView: true, popup: true, component: shallowRef(defi

Re: [PR] Allow listing of inactive offerings [cloudstack]

2024-03-28 Thread via GitHub
sureshanaparti commented on PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#issuecomment-2024632032 > > @vishesh92 Please add the view changes in upgrade path, Rest changes LGTM. > > The current listing behavior (with 'Active' state) is maintained in API / UI ? > > V

Re: [PR] Allow listing of inactive offerings [cloudstack]

2024-03-28 Thread via GitHub
DaanHoogland commented on PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#issuecomment-2024627668 > @vishesh92 Please add the view changes in upgrade path, Rest changes LGTM. > > The current listing behavior (with 'Active' state) is maintained in API / UI ? Views

Re: [PR] Allow listing of inactive offerings [cloudstack]

2024-03-25 Thread via GitHub
sureshanaparti commented on code in PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#discussion_r1537564155 ## engine/schema/src/main/resources/META-INF/db/views/cloud.disk_offering_view.sql: ## @@ -76,7 +76,5 @@ FROM LEFT JOIN `cloud`.`disk_offering_d

Re: [PR] Allow listing of inactive offerings [cloudstack]

2024-03-25 Thread via GitHub
sureshanaparti commented on code in PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#discussion_r1537563463 ## engine/schema/src/main/resources/META-INF/db/views/cloud.service_offering_view.sql: ## @@ -108,7 +109,5 @@ FROM LEFT JOIN `cloud`.`service_of

Re: [PR] Allow listing of inactive offerings [cloudstack]

2024-03-22 Thread via GitHub
blueorangutan commented on PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#issuecomment-2016312457 [SF] Trillian test result (tid-9561) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45672 seconds Marvin logs: https://github.com

Re: [PR] Allow listing of inactive offerings [cloudstack]

2024-03-22 Thread via GitHub
blueorangutan commented on PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#issuecomment-2015090613 @vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To resp

Re: [PR] Allow listing of inactive offerings [cloudstack]

2024-03-22 Thread via GitHub
vishesh92 commented on PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#issuecomment-2015089550 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Allow listing of inactive offerings [cloudstack]

2024-03-22 Thread via GitHub
blueorangutan commented on PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#issuecomment-2015045488 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9007 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Allow listing of inactive offerings [cloudstack]

2024-03-22 Thread via GitHub
codecov[bot] commented on PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#issuecomment-2014930265 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8821?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] Allow listing of inactive offerings [cloudstack]

2024-03-22 Thread via GitHub
blueorangutan commented on PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#issuecomment-2014922676 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Allow listing of inactive offerings [cloudstack]

2024-03-22 Thread via GitHub
vishesh92 commented on PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#issuecomment-2014920600 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[PR] Allow listing of inactive offerings [cloudstack]

2024-03-22 Thread via GitHub
vishesh92 opened a new pull request, #8821: URL: https://github.com/apache/cloudstack/pull/8821 ### Description This PR fixes https://github.com/apache/cloudstack/issues/8817 by allowing listing of Inactive offering ids to the user.